[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847773#comment-16847773 ] David Carlton commented on AVRO-1723: - [~zolyfarkas] thanks! > Add support for forward declarations

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847769#comment-16847769 ] Zoltan Farkas commented on AVRO-1723: - [~davidcarltonsumo] should be part of 1.9.0, I see the changes

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847668#comment-16847668 ] David Carlton commented on AVRO-1723: - Is this included in Avro 1.9.0?  It's not showing up in the

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017676#comment-16017676 ] ASF subversion and git services commented on AVRO-1723: --- Commit

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017675#comment-16017675 ] ASF subversion and git services commented on AVRO-1723: --- Commit

Re: [jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

Thiru, when you get a chance can you look at the last version of the PR? thank you —Z > On May 14, 2017, at 7:50 PM, Zoltan Farkas (JIRA) wrote: > > >[ >

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009886#comment-16009886 ] Zoltan Farkas commented on AVRO-1723: - [~thiru_mg] I have updated the PR to redo the guava code and

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009655#comment-16009655 ] Thiruvalluvan M. G. commented on AVRO-1723: --- Hi [~zolyfarkas] I had one problem and couldn't come

Re: [jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

Thiruvalluvan, anything else we need to do before merging this in? let me know thank you —Z > On May 10, 2017, at 2:45 PM, Zoltan Farkas > wrote: > > Anything else left to do? > > let me know > > thank you > > —Z > >> On Apr 30, 2017, at 11:16 PM,

Re: [jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

Anything else left to do? let me know thank you —Z > On Apr 30, 2017, at 11:16 PM, Thiruvalluvan M. G. (JIRA) > wrote: > > >[ >

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997230#comment-15997230 ] Zoltan Farkas commented on AVRO-1723: - Let me know if I need to do anything else. > Add support for

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990923#comment-15990923 ] Zoltan Farkas commented on AVRO-1723: - Looks good! thank you! > Add support for forward declarations

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990573#comment-15990573 ] Thiruvalluvan M. G. commented on AVRO-1723: --- [~zolyfarkas] Great. I just added a test for forward

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990376#comment-15990376 ] Zoltan Farkas commented on AVRO-1723: - [~thiru_mg] Thanks for review. your cleanup + fixes looks good.

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990340#comment-15990340 ] Thiruvalluvan M. G. commented on AVRO-1723: --- [~zolyfarkas] I reviewed your work. It looks great.

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983499#comment-15983499 ] Zoltan Farkas commented on AVRO-1723: - Can somebody review the pull request? thank you > Add support

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854413#comment-15854413 ] Zoltan Farkas commented on AVRO-1723: - "cloning" a field will not work in certain situations when

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234067#comment-15234067 ] Zoltan Farkas commented on AVRO-1723: - Ryan, I have updated the pull request based on your comments.

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199930#comment-15199930 ] Zoltan Farkas commented on AVRO-1723: - Ryan, here is a pull request based on the latest HEAD on master:

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199925#comment-15199925 ] ASF GitHub Bot commented on AVRO-1723: -- GitHub user zolyfarkas opened a pull request:

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195529#comment-15195529 ] Ryan Blue commented on AVRO-1723: - [~zolyfarkas], now that AVRO-1667 is in, could you rebase this on

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018137#comment-15018137 ] Zoltan Farkas commented on AVRO-1723: - Attached a patch > Add support for forward declarations in avro

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012259#comment-15012259 ] Zoltan Farkas commented on AVRO-1723: - Doug, finally I have created a feature branch with this based on

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971761#comment-14971761 ] Zoltan Farkas commented on AVRO-1723: - The creative re-use of the null SCHEMA instead of the

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971803#comment-14971803 ] Doug Cutting commented on AVRO-1723: Perhaps use a record schema instead? E.g. something like:

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971824#comment-14971824 ] Zoltan Farkas commented on AVRO-1723: - Thanks, that is pretty much what I ended up doing, Will test

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790846#comment-14790846 ] Doug Cutting commented on AVRO-1723: Can you please provide a patch or pull request with all and only

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791276#comment-14791276 ] Zoltan Farkas commented on AVRO-1723: - Doug, will gather the changes into a patch should be able to

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742065#comment-14742065 ] Zoltan Farkas commented on AVRO-1723: - Makes sense, here is the change:

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739879#comment-14739879 ] Zoltan Farkas commented on AVRO-1723: - Unfortunately UnresolvedSchema I had to declare it in the

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739902#comment-14739902 ] Doug Cutting commented on AVRO-1723: Adding a public subclass of Schema in org.apache.avro that's not

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739710#comment-14739710 ] Doug Cutting commented on AVRO-1723: Any reason UnresolvedSchema and SchemaResolver need to be public

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739460#comment-14739460 ] Zoltan Farkas commented on AVRO-1723: - There is no change to the IDL. It just does not matter anymore

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739467#comment-14739467 ] Zoltan Farkas commented on AVRO-1723: - To be a bit more precise, There is a change in the IDL spec: