[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346370#comment-15346370
]
Yibing Shi commented on AVRO-1847:
--
[~busbey] and [~rdblue], thank you for your help on this!
> IDL
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345261#comment-15345261
]
ASF subversion and git services commented on AVRO-1847:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345259#comment-15345259
]
Ryan Blue commented on AVRO-1847:
-
Thanks, sorry about missing your note before. This looks good to me.
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345256#comment-15345256
]
Sean Busbey commented on AVRO-1847:
---
I pushed this to master. Once AVRO-1867 lands I'll push it to
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345255#comment-15345255
]
ASF subversion and git services commented on AVRO-1847:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340249#comment-15340249
]
Sean Busbey commented on AVRO-1847:
---
great catch [~Yibing]!
anything else you'd like to see [~rdblue]?
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337885#comment-15337885
]
Yibing Shi commented on AVRO-1847:
--
Thank you very much for your help, [~busbey]!
[~rdblue], please let me
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337884#comment-15337884
]
Yibing Shi commented on AVRO-1847:
--
Yes, I did add the test for UUID. It always use CharSequence as type.
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336194#comment-15336194
]
Sean Busbey commented on AVRO-1847:
---
I'm good with v7. [~rdblue] (or whomever else) please let me know if
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336103#comment-15336103
]
Sean Busbey commented on AVRO-1847:
---
{quote}
And as Sean Busbey said, I have added below test cases in
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333987#comment-15333987
]
Sean Busbey commented on AVRO-1847:
---
sorry, missed this one:
{quote}
I will correct the help messages
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333984#comment-15333984
]
Sean Busbey commented on AVRO-1847:
---
{code}
+ /**
+ * Convert the underlying representation of a
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332090#comment-15332090
]
Ryan Blue commented on AVRO-1847:
-
I'm not suggesting we change it to private, but leave it as-is. I'm
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331759#comment-15331759
]
Yibing Shi commented on AVRO-1847:
--
Method {{GenericDatumWriter.convert}} is a protected method from the
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331268#comment-15331268
]
Yibing Shi commented on AVRO-1847:
--
# I will add javadoc to those public functions
# I will change the
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330700#comment-15330700
]
Ryan Blue commented on AVRO-1847:
-
I think this logic should just apply the conversions if they are
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329708#comment-15329708
]
Ryan Blue commented on AVRO-1847:
-
I think there should also be a test for this to make sure logical types
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329647#comment-15329647
]
Sean Busbey commented on AVRO-1847:
---
{code}
+ public static Object convertToLogicalType(Object datum,
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329515#comment-15329515
]
Yibing Shi commented on AVRO-1847:
--
Oops! Have corrected it.
> IDL compiler uses ByteBuffer for decimal
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329521#comment-15329521
]
Yibing Shi commented on AVRO-1847:
--
As mentioned above, I don't think we need a separate flag for
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329522#comment-15329522
]
Yibing Shi commented on AVRO-1847:
--
Same as above
> IDL compiler uses ByteBuffer for decimal type even if
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329511#comment-15329511
]
Yibing Shi commented on AVRO-1847:
--
I didn't think of childrens of this class may need to check its return
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329501#comment-15329501
]
Yibing Shi commented on AVRO-1847:
--
Since we always try to use Joda or Java classes for date/time types, I
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329495#comment-15329495
]
Yibing Shi commented on AVRO-1847:
--
I have removed the passthrough behaviour in convert to/from methods.
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329494#comment-15329494
]
Yibing Shi commented on AVRO-1847:
--
The {{conver}} method is newly added by this patch. It didn't exist in
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328665#comment-15328665
]
Yibing Shi commented on AVRO-1847:
--
Agree. Will do that.
> IDL compiler uses ByteBuffer for decimal type
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328006#comment-15328006
]
Ryan Blue commented on AVRO-1847:
-
I think you're right. In that case, we could have a common method that
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327939#comment-15327939
]
Sean Busbey commented on AVRO-1847:
---
I dunno. the change is equally visible to anyone extending
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327928#comment-15327928
]
Ryan Blue commented on AVRO-1847:
-
I don't think that there was a chance of a ClassCastException prior to
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327914#comment-15327914
]
Sean Busbey commented on AVRO-1847:
---
it occurs to me that changing this to match the convertToLogicalType
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327910#comment-15327910
]
Ryan Blue commented on AVRO-1847:
-
Sounds fine to me.
> IDL compiler uses ByteBuffer for decimal type even
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327904#comment-15327904
]
Sean Busbey commented on AVRO-1847:
---
this would address my concerns for backwards compatibility, so long
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327903#comment-15327903
]
Sean Busbey commented on AVRO-1847:
---
I can see that, but then we just move the check for a non-null
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327808#comment-15327808
]
Ryan Blue commented on AVRO-1847:
-
Agreed. The default behavior is to use the date/time logical types if
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327802#comment-15327802
]
Ryan Blue commented on AVRO-1847:
-
On the write path, the object's class is part of the conversion lookup.
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327771#comment-15327771
]
Sean Busbey commented on AVRO-1847:
---
{code}
diff --git
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327769#comment-15327769
]
Sean Busbey commented on AVRO-1847:
---
{code}
diff --git
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327762#comment-15327762
]
Sean Busbey commented on AVRO-1847:
---
{code}
diff --git
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327760#comment-15327760
]
Sean Busbey commented on AVRO-1847:
---
{code}
public String conversionInstance(Schema schema) {
+
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327757#comment-15327757
]
Sean Busbey commented on AVRO-1847:
---
{code}
-Conversion conversion = SPECIFIC
-
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327717#comment-15327717
]
Sean Busbey commented on AVRO-1847:
---
{code}
diff --git
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327644#comment-15327644
]
Sean Busbey commented on AVRO-1847:
---
{code}
+
+ public static Object convertToRawType(Schema schema,
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327642#comment-15327642
]
Sean Busbey commented on AVRO-1847:
---
{code}
+ public static Object convertToLogicalType(Object datum,
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311336#comment-15311336
]
Yibing Shi commented on AVRO-1847:
--
Understood! Thanks for the response!
> IDL compiler uses ByteBuffer
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310618#comment-15310618
]
Ryan Blue commented on AVRO-1847:
-
Sorry, I haven't had time for an in-depth review of this lately. It is
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309321#comment-15309321
]
Yibing Shi commented on AVRO-1847:
--
[~rdblue], could you please help have a look at the new patch?
> IDL
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290055#comment-15290055
]
Yibing Shi commented on AVRO-1847:
--
Hi [~rdblue], thanks for the guide! I will modify the patch and submit
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289414#comment-15289414
]
Ryan Blue commented on AVRO-1847:
-
Thanks for working on this, [~Yibing]. For specific, we have to do a bit
48 matches
Mail list logo
