Re: Licensing problem (LGPL in codebase!!)

Committed. On Fri, Dec 22, 2017 at 1:27 PM, Niels Basjes wrote: > Hi all, > > Because this is tricky I decided to first let you guys review everything > before actually committing. > https://github.com/apache/avro/pull/271 > > This is the following set of commits: > AVRO-2118 >

Re: Licensing problem (LGPL in codebase!!)

I think so. It'd be better for someone who hasn't seen the current file to do the code cleanup. But I don't think that's a blocker. On Wed, Dec 20, 2017 at 4:45 PM, Niels Basjes wrote: > Hi all, > > It has been about 1 week now. > Zoltan has put up a pull request correcting the

Re: Licensing problem (LGPL in codebase!!)

Hi all, It has been about 1 week now. Zoltan has put up a pull request correcting the copyright issue very quickly last week. Unfortunately I haven't seen any response from Thiruvalluvan M G < th...@startsmartlabs.com> yet. Since his changes were very simple (basic code cleanup) I propose we do

Re: Licensing problem (LGPL in codebase!!)

As part of the release we do run the rat plugin. So it is a highly unlikely this would have been run through a release. However, changing it now is a great addition since the release manager has to go through the whole license check for all of the files. Also, as Sean mentioned anyone who has made

Re: Licensing problem (LGPL in codebase!!)

Hi all, After we hear back from Thiru I would like Zoltan to fix these 4 files. lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitorAction.java lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java

Re: Licensing problem (LGPL in codebase!!)

Hi all, I had a closer look at the code base. Most important: 1) I have found these files only in the master branch. 2) I checked both release 1.8.2 and 1.7.7 and in these files are NOT present in any of those releases. ( So we're ok on this part. I have found exactly 2 files with this problem:

Re: Licensing problem (LGPL in codebase!!)

In addition to Zoltan we'll need to confirm anyone else who has modified the files. On Dec 13, 2017 11:46, "Sean Busbey" wrote: > Have these files made it into a release? > > On Dec 13, 2017 10:18, "Niels Basjes" wrote: > >> Zoltan, >> >> Because the

Re: Licensing problem (LGPL in codebase!!)

Have these files made it into a release? On Dec 13, 2017 10:18, "Niels Basjes" wrote: > Zoltan, > > Because the copyright notice now says you own it I guess the best way to > approach this is is when you put up a pull request with all those files > files having a new license

Re: Licensing problem (LGPL in codebase!!)

Zoltan, Because the copyright notice now says you own it I guess the best way to approach this is is when you put up a pull request with all those files files having a new license header. That way it is clear that you made the license switch. I think this should be a separate jira to document

Re: Licensing problem (LGPL in codebase!!)

Hi Niels, the license is a mistake made by me. Those files were based from my work on spf4j-avro which is currently dual licensed with LGPL and Apache . We should just replace the license headers with the appropriate Apache header. Let me know if you need me to do anything. Thank you --z >

Re: Licensing problem (LGPL in codebase!!)

+1 On Wed, Dec 13, 2017 at 4:05 PM, Nandor Kollar wrote: > I've one question regarding this: why do we execute Rat plugin *only* in > rat profile, is there any specific reason? Should include this into test > phase, so Maven test would fail, thus we can avoid similar

Re: Licensing problem (LGPL in codebase!!)

I've one question regarding this: why do we execute Rat plugin *only* in rat profile, is there any specific reason? Should include this into test phase, so Maven test would fail, thus we can avoid similar problems? On Wed, Dec 13, 2017 at 2:14 PM, Niels Basjes wrote: > Hi all,

Licensing problem (LGPL in codebase!!)

Hi all, I was going through the codebase and I found that several files are not Apache licensed. https://github.com/apache/avro/tree/master/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema Some of these files do not have a copyright block (fixable), yet some have this: /* *