Re: [DISCUSS] Use Confluence wiki for non-user-facing stuff

2018-07-13 Thread Mikhail Gryzykhin
Hello everyone it's Mikhail and I'm here to revive this long-sleeping thread. I have summarized discussion above into a design/proposal document . The initial proposal is what I consider the best approach, so it is

Re: Permissions for confluence

2018-07-13 Thread Mikhail Gryzykhin
I suggest to close this thread for now. With that being said, I'll do following: 1. I'll prepare documentation in .md format and stash it in temporary folder in code branch to make it available. 2. I'll revive original thread. --Mikhail Have feedback ? On Fri, Jul

Proof-of-concept Beam PR dashboard (based off of Spark's PR dashboard) to improve discoverability

2018-07-13 Thread Holden Karau
Took me waaay longer than planed, and the regexes and components could use some work, but I've got a quick Beam PR dashboard up at https://boos-demo-projects-are-rad.appspot.com/. The code is a fork of the Spark one, and its at https://github.com/holdenk/spark-pr-dashboard/tree/support-beam in the

Re: [PROPOSAL] Prepare Beam 2.6.0 release

2018-07-13 Thread Ahmet Altay
Update: https://issues.apache.org/jira/browse/BEAM-4784 is not a release blocker, details in the JIRA issue. On Fri, Jul 13, 2018 at 11:12 AM, Thomas Weise wrote: > Can one of our Python experts please take a look at > https://issues.apache.org/jira/browse/BEAM-4784 and advise if this should >

Re: CODEOWNERS for apache/beam repo

2018-07-13 Thread Udi Meiri
Mention bot looks cool, as it tries to guess the reviewer using blame. I've written a quick and dirty script that uses only CODEOWNERS. Its output looks like: $ python suggest_reviewers.py --pr 5940 INFO:root:Selected reviewer @lukecwik for:

Re: Permissions for confluence

2018-07-13 Thread Anton Kedin
I may be mistaken, but there was no final conclusion reached, so probably guidance from PMC will be needed where specifically to put things. I personally think that this kind of documentation is a right thing to put under cwiki/contributors. >From the last thread I think Kenn, Jean-Baptiste

Re: Permissions for confluence

2018-07-13 Thread Kai Jiang
Same question. I think only committers have permission to edit page. Also, looking forward to working on some pages. On Fri, Jul 13, 2018, 16:28 Mikhail Gryzykhin wrote: > Hi everyone, > > I believe that last month we decided to keep developers documentation on > Apache confluence wiki

Permissions for confluence

2018-07-13 Thread Mikhail Gryzykhin
Hi everyone, I believe that last month we decided to keep developers documentation on Apache confluence wiki (https://cwiki.apache.org/confluence/display/BEAM). I have some documentation regarding spinning up Jenkins via Docker. Can you help me with following: 1) Is confluence a correct place

Re: Live coding & reviewing adventures

2018-07-13 Thread Holden Karau
Thats a great idea! I did something like that earlier focused on the Go SDK only (see - https://www.youtube.com/watch?v=g0Iq4np-WVk & https://www.youtube.com/watch?v=P4jIfhPTKQo ), and I'll try and do some more general ones later on as we get more stuff working on the portability framework with

Re: Live coding & reviewing adventures

2018-07-13 Thread Ankur Goenka
Thanks Holden for doing this. Looking forward to attend the live session. Suggestion: It will super useful to do a live session for beam setup for users and another for contributors. On Fri, Jul 13, 2018 at 12:33 PM Innocent Djiofack wrote: > Thanks I think this will be super useful. I will

Re: Live coding & reviewing adventures

2018-07-13 Thread Innocent Djiofack
Thanks I think this will be super useful. I will tune in. On Fri, Jul 13, 2018 at 2:54 PM Holden Karau wrote: > Hi folks! I've been doing some live coding in my other projects and I > figured I'd do some with Apache Beam as well. > > Today @ 3pm pacific I'm going be doing some impromptu

Live coding & reviewing adventures

2018-07-13 Thread Holden Karau
Hi folks! I've been doing some live coding in my other projects and I figured I'd do some with Apache Beam as well. Today @ 3pm pacific I'm going be doing some impromptu exploration better review tooling possibilities (looking at forking spark-pr-dashboard for other projects like beam and setting

Re: CODEOWNERS for apache/beam repo

2018-07-13 Thread Holden Karau
I'm looking at something similar in the Spark project, and while it's now archived by FB it seems like something like https://github.com/facebookarchive/mention-bot might do what we want. I'm going to spin up a version on my K8 cluster and see if I can ask infra to add a webhook and if it works

Re: [PROPOSAL] Prepare Beam 2.6.0 release

2018-07-13 Thread Thomas Weise
Can one of our Python experts please take a look at https://issues.apache.org/jira/browse/BEAM-4784 and advise if this should be addressed for the release? Thanks, Thomas On Fri, Jul 13, 2018 at 11:02 AM Ahmet Altay wrote: > > > On Fri, Jul 13, 2018 at 10:48 AM, Pablo Estrada > wrote: > >>

Re: Automatically create JIRA tickets for failing post-commit tests

2018-07-13 Thread Ahmet Altay
This proposal looks good to me. On Fri, Jul 13, 2018 at 10:49 AM, Jason Kuster wrote: > I like the idea of auto-creating bugs. I think that if we do this we > should make sure to set a time period after which we will evaluate whether > it has succeeded, i.e. whether bugs filed as a result of

Re: [PROPOSAL] Prepare Beam 2.6.0 release

2018-07-13 Thread Ahmet Altay
On Fri, Jul 13, 2018 at 10:48 AM, Pablo Estrada wrote: > Hi all, > I've triaged most issues marked for 2.6.0 release. I've localized two that > need a decision / attention: > > - https://issues.apache.org/jira/browse/BEAM-4417 - Bigquery IO Numeric > Datatype Support. Cham is not available to

Re: CODEOWNERS for apache/beam repo

2018-07-13 Thread Eugene Kirpichov
Sounds reasonable for now, thanks! It's unfortunate that Github's CODEOWNERS feature appears to be effectively unusable for Beam but I'd hope that Github might pay attention and fix things if we submit feedback, with us being one of the most active Apache projects - did anyone do this yet /

Re: Automatically create JIRA tickets for failing post-commit tests

2018-07-13 Thread Jason Kuster
I like the idea of auto-creating bugs. I think that if we do this we should make sure to set a time period after which we will evaluate whether it has succeeded, i.e. whether bugs filed as a result of this have been triaged, owned, fixed, and closed. On Fri, Jul 13, 2018 at 10:20 AM Mikhail

Re: [PROPOSAL] Prepare Beam 2.6.0 release

2018-07-13 Thread Pablo Estrada
Hi all, I've triaged most issues marked for 2.6.0 release. I've localized two that need a decision / attention: - https://issues.apache.org/jira/browse/BEAM-4417 - Bigquery IO Numeric Datatype Support. Cham is not available to fix this at the moment, but this is a critical issue. Is anyone able

Re: CODEOWNERS for apache/beam repo

2018-07-13 Thread Udi Meiri
While I like the idea of having a CODEOWNERS file, the Github implementation is lacking: 1. Reviewers are automatically assigned at each push. 2. Reviewer assignment can be excessive (e.g. 5 reviewers in Eugene's PR 5940). 3. Non-committers aren't assigned as reviewers. 4. Non-committers can't

Re: Automatically create JIRA tickets for failing post-commit tests

2018-07-13 Thread Mikhail Gryzykhin
Can we get some PMC opinions on this? According to https://www.apache.org/dev/infra-contact#request-checklist, it is highly recommended to have your opinions when filing a request. --Mikhail Have feedback ? On Wed, Jul 11, 2018 at 6:01 PM Anton Kedin wrote: > I

Re: CODEOWNERS for apache/beam repo

2018-07-13 Thread Udi Meiri
Hi Etienne, Yes you could be as precise as you want. The paths I listed are just suggestions. :) On Fri, Jul 13, 2018 at 1:12 AM Jean-Baptiste Onofré wrote: > Hi, > > I think it's already do-able just providing the expected path. > > It's a good idea especially for the core. > > Regards > JB

Re: [ANNOUNCEMENT] Nexmark included to the CI

2018-07-13 Thread Łukasz Gajowy
@Etienne: Nice to see the graphs! :) @Ismael: Good idea, there's no document yet. I think we could create a small google doc with instructions on how to do this. pt., 13 lip 2018 o 10:46 Etienne Chauchot napisał(a): > Hi, > > @Andrew, this is because I did not find a way to set 2 scales on the

Re: [ANNOUNCEMENT] Nexmark included to the CI

2018-07-13 Thread Etienne Chauchot
Hi, @Andrew, this is because I did not find a way to set 2 scales on the Y axis on the perfkit graphs. Indeed numResults varies from 1 to 100 000 and runtimeSec is usually bellow 10s. Etienne Le jeudi 12 juillet 2018 à 12:04 -0700, Andrew Pilloud a écrit : > This is great, should make

Re: CODEOWNERS for apache/beam repo

2018-07-13 Thread Jean-Baptiste Onofré
Hi, I think it's already do-able just providing the expected path. It's a good idea especially for the core. Regards JB On 13/07/2018 09:51, Etienne Chauchot wrote: > Hi Udi, > > I also have a question, related to what Eugene asked : I see that the > code paths are the ones of the modules.

Re: [ANNOUNCEMENT] Nexmark included to the CI

2018-07-13 Thread Etienne Chauchot
Hi Pablo, yes they run at each commit on master (post-commit jenkins script) Etienne Le jeudi 12 juillet 2018 à 11:40 -0700, Pablo Estrada a écrit : > This is really cool Etienne : ) thanks for working on this.Our of curiosity, > do you know how often the tests run on > each runner? > > Best >

Re: CODEOWNERS for apache/beam repo

2018-07-13 Thread Etienne Chauchot
Hi Udi, I also have a question, related to what Eugene asked : I see that the code paths are the ones of the modules. Can we be more precise than that to assign reviewers ? As an example, I added myself to runner/core because I wanted to take a look at the PRs related to runner/core/metrics but