Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-21 Thread Kenneth Knowles
Nicely done! On Mon, May 20, 2019 at 4:06 PM Daniel Oliveira wrote: > Pablo has merged the PR in and assigned a tag to the commit to make the > ULR code easy to find in the future (java-ulr-removal > ). The Java ULR is > officially removed! >

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-20 Thread Daniel Oliveira
Pablo has merged the PR in and assigned a tag to the commit to make the ULR code easy to find in the future (java-ulr-removal ). The Java ULR is officially removed! On Fri, May 17, 2019 at 4:59 PM Daniel Oliveira wrote: > It's been 72 hours a

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-17 Thread Daniel Oliveira
It's been 72 hours and this vote has passed. There are 10 approving votes, 5 of which are binding: * Lukasz Cwik * Ahmet Altay * Pablo Estrada * Robert Bradshaw * Maximilian Michels There are no disapproving votes. With that decided, I'll get someone to merge the change on Monday (I'm hesitant t

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-15 Thread Michael Luckey
+1 On Wed, May 15, 2019 at 2:17 PM Alex Van Boxel wrote: > +1 > > (best commits are the once that remove code :-) > _/ > _/ Alex Van Boxel > > > On Wed, May 15, 2019 at 2:04 PM Manu Zhang > wrote: > >> +1 >> >> On Wed, May 15, 2019 at 7:57 PM Maximilian Michels >> wrote: >> >>> +1 >>> >>> On

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-15 Thread Alex Van Boxel
+1 (best commits are the once that remove code :-) _/ _/ Alex Van Boxel On Wed, May 15, 2019 at 2:04 PM Manu Zhang wrote: > +1 > > On Wed, May 15, 2019 at 7:57 PM Maximilian Michels wrote: > >> +1 >> >> On 15.05.19 13:19, Robert Bradshaw wrote: >> > +1 for removing the code given the current

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-15 Thread Manu Zhang
+1 On Wed, May 15, 2019 at 7:57 PM Maximilian Michels wrote: > +1 > > On 15.05.19 13:19, Robert Bradshaw wrote: > > +1 for removing the code given the current state of things. > > > > On Wed, May 15, 2019 at 12:32 AM Ruoyun Huang wrote: > >> > >> +1 > >> > >> From: Daniel Oliveira > >> Date: T

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-15 Thread Maximilian Michels
+1 On 15.05.19 13:19, Robert Bradshaw wrote: +1 for removing the code given the current state of things. On Wed, May 15, 2019 at 12:32 AM Ruoyun Huang wrote: +1 From: Daniel Oliveira Date: Tue, May 14, 2019 at 2:19 PM To: dev Hello everyone, I'm calling for a vote on removing the deprec

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-15 Thread Robert Bradshaw
+1 for removing the code given the current state of things. On Wed, May 15, 2019 at 12:32 AM Ruoyun Huang wrote: > > +1 > > From: Daniel Oliveira > Date: Tue, May 14, 2019 at 2:19 PM > To: dev > >> Hello everyone, >> >> I'm calling for a vote on removing the deprecated Java Reference Runner >>

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-14 Thread Ruoyun Huang
+1 *From: *Daniel Oliveira *Date: *Tue, May 14, 2019 at 2:19 PM *To: *dev Hello everyone, > > I'm calling for a vote on removing the deprecated Java Reference Runner > code. The PR for the change has already been tested and reviewed: > https://github.com/apache/beam/pull/8380 > > [ ] +1, Approve

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-14 Thread Andrew Pilloud
+1 for deleting code. *From: *Ahmet Altay *Date: *Tue, May 14, 2019 at 2:22 PM *To: *dev +1 > > *From: *Lukasz Cwik > *Date: *Tue, May 14, 2019 at 2:20 PM > *To: *dev > > +1 >> >> *From: *Daniel Oliveira >> *Date: *Tue, May 14, 2019 at 2:19 PM >> *To: *dev >> >> Hello everyone, >>> >>> I'm cal

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-14 Thread Pablo Estrada
+1 *From: *Lukasz Cwik *Date: *Tue, May 14, 2019 at 2:20 PM *To: *dev +1 > > *From: *Daniel Oliveira > *Date: *Tue, May 14, 2019 at 2:19 PM > *To: *dev > > Hello everyone, >> >> I'm calling for a vote on removing the deprecated Java Reference Runner >> code. The PR for the change has already be

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-14 Thread Ahmet Altay
+1 *From: *Lukasz Cwik *Date: *Tue, May 14, 2019 at 2:20 PM *To: *dev +1 > > *From: *Daniel Oliveira > *Date: *Tue, May 14, 2019 at 2:19 PM > *To: *dev > > Hello everyone, >> >> I'm calling for a vote on removing the deprecated Java Reference Runner >> code. The PR for the change has already be

Re: [VOTE] Remove deprecated Java Reference Runner code from repository.

2019-05-14 Thread Lukasz Cwik
+1 *From: *Daniel Oliveira *Date: *Tue, May 14, 2019 at 2:19 PM *To: *dev Hello everyone, > > I'm calling for a vote on removing the deprecated Java Reference Runner > code. The PR for the change has already been tested and reviewed: > https://github.com/apache/beam/pull/8380 > > [ ] +1, Approve