[GitHub] brooklyn-server issue #908: Added a DashboardAggregator

2017-12-06 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/908 test failure fixed, only thing left to decide is whether this is the correct place or not ---

[GitHub] brooklyn-server pull request #908: Added a DashboardAggregator

2017-12-05 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/908 Added a DashboardAggregator Added a DashboardAggregator. This aggregator will pull together dashboard sensors from it's children and merge them together. This however, does

Re: Brooklyn REST API - omitting fields in JSON objects

2017-11-08 Thread Graeme Miller
Hello, I agree with Thomas here. This seems like an API breaking change, and should be reserved for V2 if it at all. I lean towards reverting. Regards, Graeme On 8 November 2017 at 10:01, Thomas Bouron wrote: > Hi all. > > I'm not a fan of excluding fields

[GitHub] brooklyn-server pull request #884: Add brooklyn-cli as a feature to karaf

2017-11-07 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/884 Add brooklyn-cli as a feature to karaf https://github.com/apache/brooklyn-server/pull/882 added brooklyn-cli to a catalog.bom. This causes brooklyn to fail to start, as karaf can't

[GitHub] brooklyn-library pull request #139: Update visitors-creation-script.sql

2017-11-06 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-library/pull/139 Update visitors-creation-script.sql Need all privileges for three tier app You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-library pull request #136: Fix Library Feature File

2017-11-01 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-library/pull/136 Fix Library Feature File **Issue** When building Brooklyn karaf, brooklyn-library-catalog is not included in the system folder. This means that on startup Karaf goes to a remote

[GitHub] brooklyn-server pull request #869: Reverted code for selecting subnet hostna...

2017-10-27 Thread Graeme-Miller
Github user Graeme-Miller closed the pull request at: https://github.com/apache/brooklyn-server/pull/869 ---

[GitHub] brooklyn-server issue #869: Reverted code for selecting subnet hostname for ...

2017-10-27 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/869 Spoke to @aledsage and we have agreed reverting #849 is the way to go. I have created #871 to do this ---

[GitHub] brooklyn-server pull request #871: Revert "Retrieve the right AWS metadata f...

2017-10-27 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/871 Revert "Retrieve the right AWS metadata for private hostname" This reverts commit 8877368aa4c04e21eecd167538f878c4e0681900. Please see discussion on this

[GitHub] brooklyn-server issue #869: Reverted code for selecting subnet hostname for ...

2017-10-26 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/869 @aledsage did a quick investigation and it looks like you are right. In AMP 4.8, our main.uri (which is highlighted in the UI) would be based off of the host.subnet.hostname so

[GitHub] brooklyn-server pull request #869: Reverted code for selecting subnet hostna...

2017-10-25 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/869 Reverted code for selecting subnet hostname for non aws clouds A change was made to how Brooklyn retrieves the subnet hostname in https://github.com/apache/brooklyn-server/pull/849

[GitHub] brooklyn-server issue #869: Reverted code for selecting subnet hostname for ...

2017-10-25 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/869 @tbouron and @andreaturli it would be good to get your opinion on this. ---

Re: [PROPOSAL] Delete "classic-mode" (always use Karaf)

2017-10-09 Thread Graeme Miller
+1 On 9 October 2017 at 12:56, Thomas Bouron wrote: > +1 > > On Mon, 9 Oct 2017 at 12:39 Geoff Macartney > wrote: > > > +1 > > > > On Mon, 9 Oct 2017 at 12:38 Duncan Godwin com> > > wrote: > > > > >

[GitHub] brooklyn-server pull request #848: Fix for NPE in BasicBrooklynCatalog

2017-09-29 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/848 Fix for NPE in BasicBrooklynCatalog When adding a catalog item, through an exception if there is no brooklyn.catalog in the YAML You can merge this pull request into a Git

[GitHub] brooklyn-server pull request #845: Fix BasicBrooklynCatalog create Spec

2017-09-25 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/845 Fix BasicBrooklynCatalog create Spec If the BasicBrooklynCatalog fails to load a catalog item, it will now fall back to the type registry. You can merge this pull request into a Git

[GitHub] brooklyn-server pull request #832: Add ManagementNodeStateListener support

2017-09-20 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/832#discussion_r139903337 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/ManagementNodeStateListenerManager.java --- @@ -0,0 +1,175

[GitHub] brooklyn-server pull request #832: Add ManagementNodeStateListener support

2017-09-19 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/832#discussion_r139721438 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/ManagementNodeStateListenerManager.java --- @@ -0,0 +1,175

[GitHub] brooklyn-client pull request #54: Fixed setting config. Added setting sensor...

2017-09-14 Thread Graeme-Miller
Github user Graeme-Miller closed the pull request at: https://github.com/apache/brooklyn-client/pull/54 ---

[GitHub] brooklyn-library pull request #127: Update visitors-creation-script.sql

2017-09-14 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-library/pull/127 Update visitors-creation-script.sql An issue was created by #812. That PR removed the password needed to create the user brooklyn'@'localhost You can merge this pull

[GitHub] brooklyn-server issue #823: Fix creation script

2017-09-14 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/823 I have tested this on a MySQLNode and it works ---

[GitHub] brooklyn-server pull request #823: Fix creation script

2017-09-14 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/823 Fix creation script An issue was created by https://github.com/apache/brooklyn-server/pull/812. That PR removed the password needed to create the user brooklyn'@'localhost

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

2017-09-14 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138817948 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

2017-09-13 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138651745 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

2017-09-13 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642145 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

2017-09-13 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642446 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

2017-09-13 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642216 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

2017-09-13 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642085 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

2017-09-13 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138638872 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag

Re: REST API: Policy endpoint addition

2017-09-11 Thread Graeme Miller
PR Created: https://github.com/apache/brooklyn-server/pull/813 On 8 September 2017 at 12:08, Graeme Miller <gra...@cloudsoft.io> wrote: > Geoff, agree we should be adding it to adjunct, that'll be looked at as > part of a stage 2 (Alex is going to pick this up). Not sure about the te

[GitHub] brooklyn-server pull request #813: Added highlights to policy endpoint

2017-09-11 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/813 Added highlights to policy endpoint Policies now return highlights from the REST API. Highlights are a map of ids -> (description, time, task id). They are used to expose m

Re: REST API: Policy endpoint addition

2017-09-08 Thread Graeme Miller
t;"taskId": 1345 >> }, >> ... >>} >> }] >> >> or maybe even better, something like this: >> [{ >> ... >>"highlights": [ >> { >>"name": "Last Confirmation", >>

REST API: Policy endpoint addition

2017-09-07 Thread Graeme Miller
12345689, "taskId": 1345 }, ... } }] Please shout if you have any problems with this, otherwise I'll submit a PR shortly with this change. Regards, Graeme Miller

[jira] [Created] (BROOKLYN-531) k8s DockerContainer location public ip

2017-09-05 Thread Graeme Miller (JIRA)
Graeme Miller created BROOKLYN-531: -- Summary: k8s DockerContainer location public ip Key: BROOKLYN-531 URL: https://issues.apache.org/jira/browse/BROOKLYN-531 Project: Brooklyn Issue Type

[jira] [Created] (BROOKLYN-530) InitScript for Windows machine doesn't run when USER_METADATA_STRING or USER_METADATA_MAP are defined

2017-09-05 Thread Graeme Miller (JIRA)
Graeme Miller created BROOKLYN-530: -- Summary: InitScript for Windows machine doesn't run when USER_METADATA_STRING or USER_METADATA_MAP are defined Key: BROOKLYN-530 URL: https://issues.apache.org/jira/browse

[jira] [Created] (BROOKLYN-529) Windows location keyPair issue

2017-09-05 Thread Graeme Miller (JIRA)
Graeme Miller created BROOKLYN-529: -- Summary: Windows location keyPair issue Key: BROOKLYN-529 URL: https://issues.apache.org/jira/browse/BROOKLYN-529 Project: Brooklyn Issue Type: Bug

[GitHub] brooklyn-server issue #796: Disabled AUTO_WRAP_CATALOG_YAML_AS_BUNDLE

2017-08-21 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/796 no longer required --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #798: Fix template forward reference

2017-08-18 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/798 I have tested locally and can confirm that this fixes the issue that I saw. This PR adds a test for that issue, but thought it was best to double check. This code looks good

[GitHub] brooklyn-server pull request #796: Disabled AUTO_WRAP_CATALOG_YAML_AS_BUNDLE

2017-08-14 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/796 Disabled AUTO_WRAP_CATALOG_YAML_AS_BUNDLE You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-server

[GitHub] brooklyn-docs issue #205: use ~~~ rather than ```

2017-08-07 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-docs/pull/205 @m4rkmckenna updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-docs pull request #205: use ~~~ rather than ```

2017-08-07 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/205 use ~~~ rather than ``` This keeps this page in line with other pages. Also it was causing issues in a downstream project. You can merge this pull request into a Git repository

[GitHub] brooklyn-server pull request #770: Add null checks to Azure default network

2017-07-20 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/770 Add null checks to Azure default network You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-server

[GitHub] brooklyn-server pull request #755: Added endpoint test boms

2017-07-05 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/755 Added endpoint test boms You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-server add_endpoint_test_boms

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-07-04 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/745 @neykov I have rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #747: BROOKLYN-520: better error if type missin...

2017-06-28 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/747#discussion_r124574322 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-06-27 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/745 @neykov that's a good point about the default networking functionality being different in 2.0.1. I'd still recommend merging this PR as it is useful for downstream projects that use

[GitHub] brooklyn-server pull request #745: Azure ARM default network fixes from PR s...

2017-06-26 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/745 Azure ARM default network fixes from PR suggestions Important Note: Azure ARM doesn't currently work with the master of Brooklyn. Currently, after a Azure ARM VM is created, JClouds

[GitHub] brooklyn-server issue #742: DefaultAzureArmNetworkCreator improvements

2017-06-22 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/742 lgtm thanks @aledsage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-docs pull request #200: Fixed advanced example by shipping blueprin...

2017-06-22 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/200 Fixed advanced example by shipping blueprints in repo You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-docs

[GitHub] brooklyn-server pull request #742: DefaultAzureArmNetworkCreator improvement...

2017-06-22 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/742#discussion_r123482786 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreatorTest.java

[GitHub] brooklyn-server pull request #742: DefaultAzureArmNetworkCreator improvement...

2017-06-22 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/742#discussion_r123482551 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreatorTest.java

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

2017-06-21 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123230837 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java

[jira] [Commented] (BROOKLYN-519) Persisting yaml blueprint with $brooklyn:entitySpec stores all configs

2017-06-21 Thread Graeme Miller (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057288#comment-16057288 ] Graeme Miller commented on BROOKLYN-519: You mentioned 0.10.0 of brooklyn. Have you confirmed

[GitHub] brooklyn-server issue #739: A default network is now created when deploying ...

2017-06-21 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/739 The failure was due to my test class having an un-approve licence. I have updated the class and pushed- this should force a retest --- If your project is set up for it, you can reply

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

2017-06-20 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/739 A default network is now created when deploying to Azure ARM In an upcoming release of JClouds, support for Azure ARM will be added. The JClouds code for Azure ARM will place each

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-06-19 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-client/pull/42 Just want to chime in with a different opinion. I think we should merge as is, and not implement the functionality to allow users to switch between multiple hosts. For me

[GitHub] brooklyn-client issue #54: Fixed setting config. Added setting sensors

2017-06-14 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-client/pull/54 Actually, maybe all that is needed is some clarity about how to use this in the help documentation and some better error information. I was fixing this because of this Jira

[GitHub] brooklyn-client pull request #54: Fixed setting config. Added setting sensor...

2017-06-12 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-client/pull/54 Fixed setting config. Added setting sensors You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-client

Re: Is the deploy user available via the API?

2017-06-09 Thread Graeme Miller
If it is the Brooklyn user you're talking about, it should not be difficult to add. Just amend this line to include the user. You can get the

[jira] [Commented] (BROOKLYN-469) CLI: Panic when login attempted with malformed URL

2017-06-07 Thread Graeme Miller (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040832#comment-16040832 ] Graeme Miller commented on BROOKLYN-469: [~sjcorbett] I just tested this and got the following

Re: [VOTE] Accept contribution of Brooklyn Container Service

2017-05-31 Thread Graeme Miller
+1 On 31 May 2017 at 12:43, Geoff Macartney wrote: > +1 binding > > On Wed, 31 May 2017 at 12:19 Andrew Kennedy < > andrew.kenn...@cloudsoftcorp.com> wrote: > > > +1 Binding > > > > This is a really useful addition to Brooklyn. It will allow users to > target

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-05-25 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/42#discussion_r118496514 --- Diff: cli/io/config.go --- @@ -70,3 +98,111 @@ func (config *Config) Read() { dec := json.NewDecoder(fileToRead) dec.Decode

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-05-25 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/42#discussion_r118458597 --- Diff: cli/io/config.go --- @@ -70,3 +98,111 @@ func (config *Config) Read() { dec := json.NewDecoder(fileToRead) dec.Decode

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-05-25 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/42#discussion_r118458240 --- Diff: cli/br/brooklyn.go --- @@ -30,27 +30,14 @@ import ( "path/filepath" ) -func getNetworkCredentials

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-05-25 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/42#discussion_r118455814 --- Diff: cli/commands/login.go --- @@ -53,6 +58,30 @@ func (cmd *Login) Metadata() command_metadata.CommandMetadata

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-05-25 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/42#discussion_r118458766 --- Diff: cli/br/brooklyn.go --- @@ -30,27 +30,14 @@ import ( "path/filepath" ) -func getNetworkCredentials

[GitHub] brooklyn-client pull request #52: Delete requrest now only fail is an unsucc...

2017-05-23 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-client/pull/52 Delete requrest now only fail is an unsuccessful code is returned You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller

[GitHub] brooklyn-docs pull request #186: Add todo

2017-05-23 Thread Graeme-Miller
Github user Graeme-Miller closed the pull request at: https://github.com/apache/brooklyn-docs/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[jira] [Commented] (BROOKLYN-472) YAML anchors cause failure when adding YAML blueprint to catalog

2017-05-23 Thread Graeme Miller (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020957#comment-16020957 ] Graeme Miller commented on BROOKLYN-472: [~Nakomis] could you confirm that this is because

[GitHub] brooklyn-docs pull request #189: Split catalog

2017-05-22 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/189 Split catalog You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-docs split_catalog Alternatively you can

[GitHub] brooklyn-docs pull request #186: Add todo

2017-05-19 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/186 Add todo You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-docs addTodo Alternatively you can review

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-19 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r117458781 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity

Code Contribution: Container Service

2017-05-10 Thread Graeme Miller
are in favour of this, we can provide more deatails about the code and put it to a vote. Regards, Graeme Miller [1] https://docs.cloudsoft.io/ccs/locations/index.html

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/180 Update bundle upload You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-docs updateBundleUpload Alternatively

[GitHub] brooklyn-server issue #605: Add series of meta effectors for composite opera...

2017-05-05 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/605 @grkvlt this PR is rather large, and missing tests. I suggest it is closed for now and we work out a way to break this down. Some ideas for how to break it down

Re: Faster PR reviews

2017-05-04 Thread Graeme Miller
iple thousands of lines added is in my opinion getting too big to review- and you're not the only one to create a PR like that! Regards, Graeme Miller [1] In the interests of transparency, full data set here: https://docs.google.com/spreadsheets/d/1zDXyhs9AOW1s3f 0Zhd3oZlAW4nKdn7hLPd-118zwPhw

[GitHub] brooklyn-server issue #645: Persist OSGi bundles

2017-04-28 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/645 I have briefly reviewed the code and I am in the process of testing it. If you guys are happy to merge go ahead- I'll keep on with testing just in case --- If your project is set

[jira] [Commented] (BROOKLYN-449) Intermittent NoClassDefFoundError deploying a redis blueprint

2017-04-20 Thread Graeme Miller (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976569#comment-15976569 ] Graeme Miller commented on BROOKLYN-449: There is an image here: cloudsoft.tv:6000/amp-groovy

[jira] [Updated] (BROOKLYN-449) Intermittent NoClassDefFoundError deploying a redis blueprint

2017-04-20 Thread Graeme Miller (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Graeme Miller updated BROOKLYN-449: --- Attachment: karaf output also attached a collection of karaf commands from a running issue

[jira] [Updated] (BROOKLYN-449) Intermittent NoClassDefFoundError deploying a redis blueprint

2017-04-20 Thread Graeme Miller (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Graeme Miller updated BROOKLYN-449: --- Attachment: karaf.log amp.info.log amp.debug.log log files

Re: Next release candidate

2017-04-18 Thread Graeme Miller
Hi Richard, Duncan Grant, should this PR be merged in as it fixes node.js requirements: https://github.com/apache/brooklyn-library/pull/98 Also, there are two fixes here for rebind: https://github.com/apache/brooklyn-server/pull/633 https://github.com/apache/brooklyn-server/pull/634 Regards,

[GitHub] brooklyn-server pull request #636: Enable older Java versions

2017-04-17 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/636#discussion_r111724361 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java --- @@ -621,6 +621,7 @@ private static Object getFlag(Map

[GitHub] brooklyn-server issue #634: BROOKLYN-474: rebind to policy with private cons...

2017-04-13 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/634 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #623: BundleMaker copy fix

2017-04-07 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/623 @drigodwin no, it doesn't. If we were creating a zip from scratch we would do what I have done here, and create a zip entry with only the name. The zip code would then figure out

[GitHub] brooklyn-server issue #623: BundleMaker copy fix

2017-04-07 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/623 Can you provide steps to re-produce @m4rkmckenna quickest way to replicate is to use the brooklyn cli from here: https://github.com/apache/brooklyn-client/pull/44. Using that CLI

[GitHub] brooklyn-server pull request #623: BundleMaker copy fix

2017-04-07 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/623 BundleMaker copy fix When cloning a zip, we were using the ZipEntry from the input zip. This causes issues, as the info in the input ZipEntry is not necessarily correct

[GitHub] brooklyn-client pull request #44: Added the ability to upload a zip via the ...

2017-04-07 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-client/pull/44 Added the ability to upload a zip via the CLI @geomacy would you please review? You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-server pull request #616: Fixed BlobStoreContextFactoryImpl. It can...

2017-03-31 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/616 Fixed BlobStoreContextFactoryImpl. It can now have dsl in its config You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme

[GitHub] brooklyn-server issue #594: Revert "add original failing test from @sjcorbet...

2017-03-15 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/594 Ok, so the circular dependency is: * dependency has been added between brooklyn-rest-server and brooklyn-software-nosql * brooklyn-rest-server is a part of brooklyn-server

[GitHub] brooklyn-server pull request #594: Revert "add original failing test from @s...

2017-03-14 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/594 Revert "add original failing test from @sjcorbett" This reverts commit d7cbaeed46d7fedf8e49df015baa812352060f45. That commit added a dependency on brooklyn-soft

[GitHub] brooklyn-server issue #592: Fix publication of EC2 host address in DefaultCo...

2017-03-13 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/592 Tested locally, works as expected: ![screen shot 2017-03-13 at 17 24 51](https://cloud.githubusercontent.com/assets/3742990/23866871/1a04afc0-0812-11e7-90bb-755c3667f3b1.png

[jira] [Created] (BROOKLYN-447) waitForSshable deprecated without replacement

2017-03-06 Thread Graeme Miller (JIRA)
Graeme Miller created BROOKLYN-447: -- Summary: waitForSshable deprecated without replacement Key: BROOKLYN-447 URL: https://issues.apache.org/jira/browse/BROOKLYN-447 Project: Brooklyn Issue

[GitHub] brooklyn-server pull request #554: Ensured the \n character is escaped when ...

2017-02-16 Thread Graeme-Miller
Github user Graeme-Miller closed the pull request at: https://github.com/apache/brooklyn-server/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #554: Ensured the \n character is escaped when escapin...

2017-02-09 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/554 @aledsage has pointed out a way to get around the problem I am having, so I no longer need this PR. However, I think it might still be useful @neykov, the use case here

[GitHub] brooklyn-server pull request #554: Ensured the \n character is escaped when ...

2017-02-09 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/554 Ensured the \n character is escaped when escaping a string for bash You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme

[GitHub] brooklyn-docs pull request #147: Added knwon issues section to azure arm

2017-01-27 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/147 Added knwon issues section to azure arm You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-docs

[GitHub] brooklyn-docs pull request #142: Added docs for useMachinePublicAddressAsPri...

2017-01-25 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-docs/pull/142 Added docs for useMachinePublicAddressAsPrivateAddress You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-docs

[GitHub] brooklyn-client issue #38: Exclude cli/.glide/* (cache) from rat + git

2017-01-23 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-client/pull/38 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-client pull request #38: Exclude cli/.glide/* (cache) from rat + gi...

2017-01-23 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/38#discussion_r97389393 --- Diff: cli/pom.xml --- @@ -101,6 +101,7 @@ vendor

[GitHub] brooklyn-docs pull request #140: Add Azure Classic and ARM docs

2017-01-19 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/140#discussion_r96904988 --- Diff: guide/ops/locations/_azure-ARM.md --- @@ -0,0 +1,92 @@ +--- +section: Azure Compute ARM +section_type: inline

[GitHub] brooklyn-docs pull request #140: Add Azure Classic and ARM docs

2017-01-19 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/140#discussion_r96874537 --- Diff: guide/ops/locations/_azure-classic.md --- @@ -0,0 +1,235 @@ +--- +section: Azure Compute Classic +section_type: inline

  1   2   >