Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/592
Tested locally, works as expected:
 rely on the ability of nodes
to communicate via the subnet IP.
This functionality is useful in a situation where a cloud you
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/468
Added functionality to overwrite private ip/hostname as public ip/hostname
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/339
I have tested this with vanilla/karaf brooklyn and karaf AMP.
I have tested deploying a blueprint and using the Swagger API.
---
If your project is set up for it, you can reply to
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/339
We have decided to proceed with updating the dependency.
We have also added a commit recommended by Svet in the predecessor to this
PR:
https://github.com/neykov/brooklyn-server
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/345
Fixed compilation issue in LocalUsageManagerTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/brooklyn-server
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/342#discussion_r80075760
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/LocalUsageManagerTest.java
---
@@ -16,67 +16,77 @@
* specific
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/342#discussion_r80075903
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalUsageManager.java
---
@@ -173,20 +180,23 @@
public
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-client/pull/27
Are we sure all the '.version' tags are in brooklyn-server?
For instance, I don't think resteasy is?
---
If your project is set up for it, you can reply to this emai
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-client/pull/28
Test failures are because brooklyn-client relies on brooklyn-rest-api which
pulls in an older verision of jackson.
All tests pass locally when
https://github.com/apache
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/317
replacing with:
https://github.com/apache/brooklyn-client/pull/28
https://github.com/apache/brooklyn-server/pull/339
---
If your project is set up for it, you can reply to
Github user Graeme-Miller closed the pull request at:
https://github.com/apache/brooklyn-server/pull/317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-client/pull/28
Updated resteasy version
This is successor to [this
PR](https://github.com/apache/brooklyn-server/pull/317).
After the rest client was moved to brooklyn-client in [this
PR](https
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/339
Updated jackson version
This is successor to [this
PR](https://github.com/apache/brooklyn-server/pull/317).
After the rest client was moved to brooklyn-client in [this
PR](https
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-docs/pull/109
Various fixes. Mainly changing relative links to absolute links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/317
I have just tested the swagger page works as expected with this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-docs/pull/105
Ok, I have tested with the fixes and it looks good. I have removed the
production-installation changes, as they are not required in the downstream
project any more and I have fixed the
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-docs/pull/105
I am going to make the changes suggested by Duncan to the branch- do not
merge yet as I will be testing these changes (I need them pushed so that
amp-docs can build correctly)
---
If
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-docs/pull/105
Various fixes. Mainly changing relative links to absolute links
Changed some relative links to absolute links.
I have run a link checker on the docs with and without these
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/317
Changed jackson version to 2.7.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/brooklyn-server
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/311
lgtm @aledsage can you take a look and merge please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-dist/pull/42
successfully tested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/303
successfully tested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-docs/pull/100
Updated the maven archetype doc
The doc will now more explicitly show adding the JAR to Brooklyn
You can merge this pull request into a Git repository by running:
$ git pull https
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-library/pull/51
LGTM, but I agree with Aled that testing would be beneficial. Andrew did
you investigate further how to do this?
---
If your project is set up for it, you can reply to this email and
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/247
lgtm, but can you re-run the test, it failed with OutOfMemory exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/220#discussion_r68921829
--- Diff:
core/src/test/java/org/apache/brooklyn/enricher/stock/PercentageEnricherTest.java
---
@@ -0,0 +1,275 @@
+/*
+ * Licensed to
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/220
Added a percentage enricher
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/brooklyn-server
add_percent_enricher
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/204#discussion_r67863025
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -709,9
Hello,
Target resolution is relative, and you can currently test multiple levels
down with the test framework, but only for groups. Have a look at the
following YAML. I have a group of groups of software processes. I have a
test which will loop over the first group, and run the configured entity
s
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/204#discussion_r67338633
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
---
@@ -85,15 +81,20 @@
* It
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/192#discussion_r66616715
--- Diff:
core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java
---
@@ -0,0 +1,407 @@
+/*
+ * Licensed
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/192
Couple of comments then LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/192#discussion_r66592324
--- Diff:
core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java
---
@@ -0,0 +1,407 @@
+/*
+ * Licensed
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/192#discussion_r66591368
--- Diff:
core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java
---
@@ -0,0 +1,407 @@
+/*
+ * Licensed
+1
On 7 June 2016 at 10:40, Svetoslav Neykov <
svetoslav.ney...@cloudsoftcorp.com> wrote:
> +1
>
> Also agree having an environment will simplify writing the tests.
>
> Svet.
>
>
> > On 7.06.2016 г., at 12:37, Aled Sage wrote:
> >
> > Hi all,
> >
> > I suggest we rename the entity SimpleShellCom
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/181
@duncangrant @Graeme-Miller how does this interact with #171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/181
Added a default PortForwardManager
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/brooklyn-server
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/166
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/brooklyn-server/pull/130#issuecomment-215469272
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/brooklyn-server/pull/128#issuecomment-215378175
Looks good to me, nothing wrong witht he additions as they are following
the pattern already set down by the ComputeServiceImageChooser.
However
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/128#discussion_r61403861
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java
---
@@ -292,27 +325,63 @@ public int
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/brooklyn-server/pull/114#issuecomment-210039244
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1161#issuecomment-172894171
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Graeme Miller created BROOKLYN-216:
--
Summary: Unreliable test:
org.apache.brooklyn.AssemblyTest.checkBrooklynCoreFeature
Key: BROOKLYN-216
URL: https://issues.apache.org/jira/browse/BROOKLYN-216
Github user Graeme-Miller closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user Graeme-Miller reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1154
Updated JClouds to 1.9.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/incubator-brooklyn
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1154#issuecomment-172511608
@andreaturli yeah looks like we sometimes get a failure in
org.apache.brooklyn.AssemblyTest.checkBrooklynCoreFeature.
What's the pro
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1154
Updated JClouds to 1.9.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/incubator-brooklyn
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1148#issuecomment-172004804
Looks good, are there any tests we can add for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1146
Moved new QA classes to correct location
Due to an issue with [this
PR](https://github.com/apache/incubator-brooklyn/pull/1115) some files were
added to the wrong location. This
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1141
Fixed issue with exceptions in Rest Client
Calling getEntity on BuiltResponsePreservingError would propagate a
previously caught and ignored exception. Because of this the output
gt;>
>> best
>> alex
>>
>>
>> ps. geoff, i get your point, but just so you know brooklyn goes to great
>> lengths to lock systems down and block the "open defaults" attack vector:
>> the default config for cloud machines is to disable the clou
Hello,
Just before the new year, I discovered an interesting feature of Brooklyn.
If an Entity has config with a name ending in "port" that can be coerced to
a PortRange then Brooklyn will automatically open that port range in the
firewall.
So, for example, if you have the following in YAML for a
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1124#discussion_r48825730
--- Diff:
brooklyn-server/core/src/main/java/org/apache/brooklyn/core/entity/AbstractApplication.java
---
@@ -220,13 +221,34 @@ public
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1124#discussion_r48825224
--- Diff:
brooklyn-server/core/src/main/java/org/apache/brooklyn/core/entity/AbstractApplication.java
---
@@ -220,13 +221,34 @@ public
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1124#discussion_r48825140
--- Diff:
brooklyn-server/core/src/main/java/org/apache/brooklyn/core/entity/AbstractApplication.java
---
@@ -220,13 +221,34 @@ public
> ApplicationMain
> > class which extends Brooklyn Main class start multiple applications.
> > The locations, environment etc all other settings are specified in java
> > classes already for my services. Just want to be able to run multiple
> > services from Main class.
>
t; to launch. I was looking for some way to set multiple apps.
>
> The Yaml file option you mentioned must also have to do something on
> similar lines, can I do something similar is my own AppMain which extends
> Brooklyn's Main Class.
>
> Thanks,
> Abhi
>
> On
Hi Abhishek,
The Brooklyn launch command allows you to specify an application with the
'-a' option. However, it only allows you to specify one application.
This specified application can be either a Java Class or a YAML file. One
solution to this would be to write a small YAML file that defines a
[
https://issues.apache.org/jira/browse/BROOKLYN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069487#comment-15069487
]
Graeme Miller commented on BROOKLYN-208:
Thanks Sam. Before Mikes change,
Graeme Miller created BROOKLYN-208:
--
Summary: Config resolution on shutdown
Key: BROOKLYN-208
URL: https://issues.apache.org/jira/browse/BROOKLYN-208
Project: Brooklyn
Issue Type: Bug
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-166632121
@ahgittin docs updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-166375883
@ahgittin didn't have time to do docs today, but will look at getting them
done tomorrow.
Is it worth merging this in now before the repo
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1115
Various QA changes
Added LoopOverGroupMembersTestCase. Removed some targeting functionality
from BaseTest and added it to a new Interface called TargetabeTestComponent
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1101#issuecomment-164736878
@sjcorbett thanks Sam, have added some tests now.
Also, I amended removePermissionsFromLocation so that is is synchronized on
the class, to keep
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1107#issuecomment-164489421
@johnmccabe thanks for looking into this. I have just added two comments.
---
If your project is set up for it, you can reply to this email and have
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1107#discussion_r47521109
--- Diff: docs/guide/yaml/example_yaml/brooklyn-elk-catalog.bom ---
@@ -9,27 +9,28 @@ brooklyn.catalog:
name: ELK Stack
Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1107#discussion_r47520858
--- Diff: docs/guide/yaml/advanced-example.md ---
@@ -74,10 +77,10 @@ customize.command: |
$brooklyn:config("elasticsearch.tcp
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1101
Ported some Clocker changes back to brooklyn.
It is now possible to remove security groups permissions
You can merge this pull request into a Git repository by running
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1091#issuecomment-162544360
@johnmccabe yup, there you go:
```YAML
services:
- type: org.apache.brooklyn.test.framework.InfrastructureDeploymentTestCase
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1091
QA Updates for Clocker
TestCase no longer extends BaseTest, but rather extends Entity directly.
Added check in TestCaseImpl to ensure that only non-started children are
Hi Mike,
Two other suggestions to consider:
- Would it be possible within Brooklyn to keep track of all of the
attributeWhenReady
calls for an Entity and then interrupt them at shutdown? This would mean
the user does not have to be aware of how shutdown works.
- You could also put an
101 - 192 of 192 matches
Mail list logo
