Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/480
thanks @aledsage -- have done most of them. a few more will require more
thought from me, marked them so i can find them easily.
---
If your project is set up for it, you can reply to
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101878724
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -352,33 +357,51 @@ public T get() {
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101878631
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/InterruptingImmediateSupplier.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101878497
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101878445
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101878328
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101878072
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
@@ -91,6 +96,62 @@ public void
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101877907
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -539,8 +550,9 @@ protected
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101877735
--- Diff:
api/src/main/java/org/apache/brooklyn/api/mgmt/ExecutionContext.java ---
@@ -64,4 +65,6 @@
boolean isShutdown();
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/561#discussion_r101876867
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java
---
@@ -111,7 +115,7 @@ public long
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Applied @neykov 's comments. If all tests pass then good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Aled Sage created BROOKLYN-440:
--
Summary: More efficient thread usage for ssh execution
Key: BROOKLYN-440
URL: https://issues.apache.org/jira/browse/BROOKLYN-440
Project: Brooklyn
Issue Type:
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101853047
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/InterruptingImmediateSupplier.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101790138
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
@@ -91,6 +96,62 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101864959
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101855532
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/InterruptingImmediateSupplier.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101836841
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
@@ -91,6 +96,62 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101851346
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
---
@@ -753,7 +753,10 @@ protected void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101847631
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractConfigurationSupportInternal.java
---
@@ -146,7 +146,6 @@ public T call() {
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101836610
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
@@ -91,6 +96,62 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101868849
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/exceptions/Exceptions.java
---
@@ -263,8 +264,41 @@ public static Throwable
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101868262
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101849614
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101782727
--- Diff:
api/src/main/java/org/apache/brooklyn/api/mgmt/ExecutionContext.java ---
@@ -64,4 +65,6 @@
boolean isShutdown();
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101789828
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -539,8 +550,9 @@ protected
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101862310
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -352,33 +357,51 @@ public T get() {
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/564#discussion_r101862606
--- Diff:
software/winrm/src/main/java/org/apache/brooklyn/core/sensor/windows/WinRmCommandSensor.java
---
@@ -0,0 +1,167 @@
+/*
+ *
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/564
Winrm CmdFeed
Please, review commits one by one to have better differences view.
PR can be considered as WIP however I think it is in good shape.
The PR moves SshFeed to
> Can't each Brooklyn node check what cloud it
> is on as it starts and then either create the management-private-
> or join it?
Should be technically possible. I believe (most) clouds provide a way to
self-inspect from the machine and at least get a machine ID - should be
straightforward to
30 matches
Mail list logo
