[GitHub] brooklyn-server issue #835: Tasks subsystem improvements - adjuncts, names, ...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/835 good comments, and straightforward, all addressed ---

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r143085630 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -797,6 +800,7 @@ public

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r143085114 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -402,10 +415,21 @@ public void setDisplayName(String

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r143084360 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/NonDeploymentManagementContext.java --- @@ -254,7 +250,19 @@ public

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r143084497 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindManagerImpl.java --- @@ -490,15 +490,7 @@ public ChangeListener

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r143084004 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java --- @@ -112,12 +115,21 @@ public ConfigConstraints(T

[GitHub] brooklyn-server pull request #856: [WIP] clean up startup logging around cat...

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/856 [WIP] clean up startup logging around catalog just looking at logs and tidying up stuff that is wrong or misleading have done one so far but i think there are others. best hold

Re: Issue running Brooklyn in Vagrant

Hi all, Sorry for the spam -- I'm just getting used to the plain text mailing list. If you prefer HTML formatting, I've uploaded my message here: https://gist.github.com/b-long/9156a3696d9c30c14a092fe4b0a01381 Thanks, b-long On Thu, Oct 5, 2017 at 3:12 PM, Brian Long

Re: [ANNOUNCE] New committer: Thomas Bouron

Very well deserved, congratulations Thomas !! On Thu, 5 Oct 2017 at 10:23 Richard Downer wrote: > Welcome aboard Thomas :-) and thank you for the contributions - both to the > code and the community - that you have made so far! > > Richard. > > > On 5 October 2017 at 09:42,

Re: Issue running Brooklyn in Vagrant

Hi Thomas, Sorry for my delayed response and thanks for your all of your work. Vagrant related I see that the brooklyn-dist PR that you referenced [0] was indeed merged and I agree it appears that it would fix the symlink issue I’ve observed. However, when I download the Vagrant tar archive, I’m

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r142992671 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindCatalogEntityTest.java --- @@ -1,153 +0,0 @@ -/* - * Licensed to

[jira] [Updated] (BROOKLYN-542) Can't use a Freemarker template hashes in a blueprint

[ https://issues.apache.org/jira/browse/BROOKLYN-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Turli updated BROOKLYN-542: -- Summary: Can't use a Freemarker template hashes in a blueprint (was: Can't use a Freemarker

[GitHub] brooklyn-server issue #835: Tasks subsystem improvements - adjuncts, names, ...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/835 thanks @aledsage - great comments, will adress then merge this and #836 ---

[jira] [Commented] (BROOKLYN-542) Can't use a Freemarker template hashes in YAML

[ https://issues.apache.org/jira/browse/BROOKLYN-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193090#comment-16193090 ] ASF GitHub Bot commented on BROOKLYN-542: - GitHub user andreaturli opened a pull request:

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142982817 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManagerTest.java --- @@ -170,4 +181,84 @@ public void run()

[GitHub] brooklyn-server pull request #855: [BROOKLYN-542] add test for freemarker bu...

GitHub user andreaturli opened a pull request: https://github.com/apache/brooklyn-server/pull/855 [BROOKLYN-542] add test for freemarker builtins hashes You can merge this pull request into a Git repository by running: $ git pull https://github.com/andreaturli/brooklyn-server

[jira] [Created] (BROOKLYN-542) Can't use a Freemarker template hashes in YAML

Andrea Turli created BROOKLYN-542: - Summary: Can't use a Freemarker template hashes in YAML Key: BROOKLYN-542 URL: https://issues.apache.org/jira/browse/BROOKLYN-542 Project: Brooklyn Issue

[GitHub] brooklyn-server pull request #836: REST call to get activities on an adjunct

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/836#discussion_r142982015 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -234,4 +236,21 @@ public Response setConfig(

[GitHub] brooklyn-server issue #836: REST call to get activities on an adjunct

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/836 @aledsage the one thing i find with merges is that it's a bit difficult to see changes made to resolve conflicts as part of the merge commit. i always forget the exact command but manage

[GitHub] brooklyn-server pull request #853: [WIP] deprecate Task as values in config ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/853#discussion_r142931102 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/EffectorTasks.java --- @@ -57,9 +58,14 @@ private static final Logger log

[GitHub] brooklyn-server pull request #853: [WIP] deprecate Task as values in config ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/853#discussion_r142933380 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -242,16 +244,40 @@ public synchronized T

[GitHub] brooklyn-server pull request #853: [WIP] deprecate Task as values in config ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/853#discussion_r142933756 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -242,16 +244,40 @@ public synchronized T

[GitHub] brooklyn-server pull request #836: REST call to get activities on an adjunct

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/836#discussion_r142926959 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -234,4 +236,21 @@ public Response setConfig(

Re: Apache Brooklyn 1.0 release

Hi all, Improving our authentication is a good feature to have, but I don't think it's a blocker to a 1.0 release. I'd love to see this feature, but I don't think we need to hold back 1.0 for it (better to think such a feature through properly than to try and rush it into the next release.)

Re: [PROPOSAL] Split Brooklyn website and documentation

Thank you for the research you have done Thomas. I've had similar thoughts myself. The original goal of our web+docs was to integrate them in such a way that we had a versioned user guide that integrated perfectly with the main website. At the time, Markdown tools were relatively immature, with

[GitHub] brooklyn-server issue #836: REST call to get activities on an adjunct

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/836 By the way, I don't entirely trust merge commits inside a pull request. It has seemed to me previously that `/files` in github has not shown me all the code changes because some are

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142920565 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -797,6 +800,7 @@ public

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142919316 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -402,10 +415,21 @@ public void setDisplayName(String

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142922808 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManagerTest.java --- @@ -170,4 +181,84 @@ public void run()

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142912731 --- Diff: api/src/main/java/org/apache/brooklyn/api/mgmt/ExecutionContext.java --- @@ -52,12 +52,22 @@ */ Task submit(Map

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142923334 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManagerTest.java --- @@ -170,4 +181,84 @@ public void run()

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142921455 --- Diff: core/src/test/java/org/apache/brooklyn/core/entity/EntityAssertsTest.java --- @@ -85,12 +83,7 @@ public void

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142912453 --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java --- @@ -139,9 +139,18 @@ private void checkPath(Collection path) {

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142913075 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java --- @@ -112,12 +115,21 @@ public ConfigConstraints(T

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142917944 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/NonDeploymentManagementContext.java --- @@ -254,7 +250,19 @@ public

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/835#discussion_r142918395 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindManagerImpl.java --- @@ -490,15 +490,7 @@ public ChangeListener

Re: Apache Brooklyn 1.0 release

Hi all, I approach this question as "what is essential for a 1.0 release", versus nice-to-have. I think pretty much every feature/change is nice-to-have and can be developed incrementally - if it's ready in time for a 1.0 then great, otherwise it will go in 1.x or 2.x. I personally have

[PROPOSAL] Split Brooklyn website and documentation

Hi all. It's been a couple of weeks that I started to look at how to improve and simplify the Brookyln website[1]. As I said on the Brooklyn 1.0 thread[2], I think we need to sort this out before releasing 1.0. I have looked for a framework / library to handle both the website and documentation

Re: Apache Brooklyn 1.0 release

+1 to stronger authN FYI I've quickly tried readthedocs -- see https://readthedocs.org/projects/brooklyn-docs/ and it is nice and free, maybe we should consider it for the website. It is an hosted service well integrated with github which offers full text seatrch out of the box. Many others ASF

[GitHub] brooklyn-server pull request #854: add adjunct endpoint to karaf config

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/854 ---

Re: Apache Brooklyn 1.0 release

I would agree with Geoff on the auth. I think it would be nice to move to JWT for 1.0. I would also point out the Brooklyn website. I'm the one to blame on this, I redesigned the home page but not the rest (mostly due to the currently complexity of it) I'll send a proposal on this today. Best.

Re: Apache Brooklyn logo

Richard +1 There is another option ... maybe there is a friendly graphic designer in the community that could help out. M On 4 Oct 2017 19:12, "Duncan Johnston Watt" < duncan.johnstonw...@cloudsoftcorp.com> wrote: My two cents is that it is well established and so do nothing is best option.

[GitHub] brooklyn-server issue #854: add adjunct endpoint to karaf config

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/854 Built and tested locally without issue (compare to Jenkins). The endpoints are now displayed in karaf mode 🎉 Will merge once Jenkins is happy ---

[GitHub] brooklyn-server issue #854: add adjunct endpoint to karaf config

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/854 retest this please ---

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/821 @ahgittin I'll review #854 now. Although, there is another point that is missing from this PR: Swagger still don't show the deprecation warning for the entity policy endpoints. For

Re: [ANNOUNCE] New committer: Thomas Bouron

Welcome aboard Thomas :-) and thank you for the contributions - both to the code and the community - that you have made so far! Richard. On 5 October 2017 at 09:42, Geoff Macartney wrote: > The Apache Brooklyn PMC (Project Management Committee) has invited > Thomas Bouron

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/821 @tbouron totally forgot about your point karaf is missing this; have fixed that in #854 if you could take a quick look ---

[GitHub] brooklyn-server pull request #854: add adjunct endpoint to karaf config

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/854 add adjunct endpoint to karaf config enable endpoint done for #821 for karaf You can merge this pull request into a Git repository by running: $ git pull

[ANNOUNCE] New committer: Thomas Bouron

The Apache Brooklyn PMC (Project Management Committee) has invited Thomas Bouron to become a committer, and we are delighted that he has accepted. Thomas is an experienced contributor to Brooklyn, and brings in some specialised skills that will be very valuable for the project. Please join me in