[GitHub] [brooklyn-ui] tbouron commented on issue #127: Allow bigger zoom in, for large screen mainly

2019-03-12 Thread GitBox
tbouron commented on issue #127: Allow bigger zoom in, for large screen mainly URL: https://github.com/apache/brooklyn-ui/pull/127#issuecomment-472130406 @ahgittin Good idea, but the function looks more like `log`, i.e for: - < 2k => `1` - 2k => `1` - 4k => `1.3` - 8k => `1.6`

[GitHub] [brooklyn-server] geomacy opened a new pull request #1050: Move testErrorsCaughtByApiAndRestApiWorks to its own class

2019-03-12 Thread GitBox
geomacy opened a new pull request #1050: Move testErrorsCaughtByApiAndRestApiWorks to its own class URL: https://github.com/apache/brooklyn-server/pull/1050 See https://issues.apache.org/jira/browse/BROOKLYN-611 (from [this comment](https://github.com/apache/brooklyn-server/pull/1049#issue

[GitHub] [brooklyn-server] kemitix opened a new pull request #1051: Bump karaf.version from 4.2.2 to 4.2.3

2019-03-14 Thread GitBox
kemitix opened a new pull request #1051: Bump karaf.version from 4.2.2 to 4.2.3 URL: https://github.com/apache/brooklyn-server/pull/1051 Bumps `karaf.version` from 4.2.2 to 4.2.3. Updates `karaf` from 4.2.2 to 4.2.3 Updates `org.apache.karaf.system.core` from 4.2.2 to 4.2.3

[GitHub] [brooklyn-server] kemitix opened a new pull request #1053: Bump jcommander from 1.27 to 1.72

2019-03-14 Thread GitBox
kemitix opened a new pull request #1053: Bump jcommander from 1.27 to 1.72 URL: https://github.com/apache/brooklyn-server/pull/1053 Bumps [jcommander](https://github.com/cbeust/jcommander) from 1.27 to 1.72. - [Release notes](https://github.com/cbeust/jcommander/releases) - [Changelog]

[GitHub] [brooklyn-server] kemitix opened a new pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.6-01

2019-03-14 Thread GitBox
kemitix opened a new pull request #1052: Bump groovy-eclipse-batch from 2.4.3-01 to 2.5.6-01 URL: https://github.com/apache/brooklyn-server/pull/1052 Bumps [groovy-eclipse-batch](https://github.com/groovy/groovy-eclipse) from 2.4.3-01 to 2.5.6-01. - [Release notes](https://github.com/gr

[GitHub] [brooklyn-server] kemitix opened a new pull request #1054: Bump jaxb-api from 2.3.0 to 2.3.1

2019-03-14 Thread GitBox
kemitix opened a new pull request #1054: Bump jaxb-api from 2.3.0 to 2.3.1 URL: https://github.com/apache/brooklyn-server/pull/1054 Bumps [jaxb-api](https://github.com/javaee/jaxb-spec) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/javaee/jaxb-spec/releases) - [Commits](htt

[GitHub] [brooklyn-server] kemitix opened a new pull request #1055: Bump javax.servlet-api from 3.1.0 to 4.0.1

2019-03-14 Thread GitBox
kemitix opened a new pull request #1055: Bump javax.servlet-api from 3.1.0 to 4.0.1 URL: https://github.com/apache/brooklyn-server/pull/1055 Bumps [javax.servlet-api](https://github.com/javaee/servlet-spec) from 3.1.0 to 4.0.1. - [Release notes](https://github.com/javaee/servlet-spec/re

[GitHub] [brooklyn-ui] asfgit merged pull request #127: Allow bigger zoom in, for large screen mainly

2019-03-18 Thread GitBox
asfgit merged pull request #127: Allow bigger zoom in, for large screen mainly URL: https://github.com/apache/brooklyn-ui/pull/127 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [brooklyn-ui] ahgittin commented on issue #127: Allow bigger zoom in, for large screen mainly

2019-03-18 Thread GitBox
ahgittin commented on issue #127: Allow bigger zoom in, for large screen mainly URL: https://github.com/apache/brooklyn-ui/pull/127#issuecomment-473830859 +1 to an apposite use of logarithms! Needs to be `Math.log` not plain `log` but otherwise great, amended and merged. -

[GitHub] [brooklyn-server] kemitix opened a new pull request #1056: SECURITY Bump jackson-databind to 2.9.8

2019-03-18 Thread GitBox
kemitix opened a new pull request #1056: SECURITY Bump jackson-databind to 2.9.8 URL: https://github.com/apache/brooklyn-server/pull/1056 * [SECURITY] Bump `jackson-databind` from 2.9.7 to 2.9.8 Due to transitive dependencies involving `jackson-databind` the following upgrades were a

[GitHub] [brooklyn-server] ahgittin commented on issue #1056: SECURITY Bump jackson-databind to 2.9.8

2019-03-18 Thread GitBox
ahgittin commented on issue #1056: SECURITY Bump jackson-databind to 2.9.8 URL: https://github.com/apache/brooklyn-server/pull/1056#issuecomment-473986337 alternatively we could do excludes in `jetty`, `cxf`, and `winrm4j` -- we've been hit with big changes though admittedly in minor bumps

[GitHub] [brooklyn-server] asfgit merged pull request #1056: SECURITY Bump jackson-databind to 2.9.8

2019-03-18 Thread GitBox
asfgit merged pull request #1056: SECURITY Bump jackson-databind to 2.9.8 URL: https://github.com/apache/brooklyn-server/pull/1056 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [brooklyn-server] ahgittin opened a new pull request #1057: minor changes to make working w AWS profiles easier

2019-03-18 Thread GitBox
ahgittin opened a new pull request #1057: minor changes to make working w AWS profiles easier URL: https://github.com/apache/brooklyn-server/pull/1057 * tune logging so `[profile xxx]` in `~/.aws/config` doesn't cause lots of WARNs * better description of the role/profile config key --

[GitHub] [brooklyn-docs] geomacy opened a new pull request #280: wip: Add text to comply to Apache naming guidelines

2019-03-19 Thread GitBox
geomacy opened a new pull request #280: wip: Add text to comply to Apache naming guidelines URL: https://github.com/apache/brooklyn-docs/pull/280 See http://www.apache.org/foundation/marks/pmcs.html#naming In particular this part: Every product homepage and any overview downlo

[GitHub] [brooklyn-server] tbouron opened a new pull request #1058: Add Flaky retry analyser to more tests

2019-03-20 Thread GitBox
tbouron opened a new pull request #1058: Add Flaky retry analyser to more tests URL: https://github.com/apache/brooklyn-server/pull/1058 This follows #1049 and add the `FlakyRetryAnalyser` to more tests, based on the latest failure from Jenkins (see: https://lists.apache.org/list.html?dev@

[GitHub] [brooklyn-server] tbouron merged pull request #1050: Move testErrorsCaughtByApiAndRestApiWorks to its own class

2019-03-20 Thread GitBox
tbouron merged pull request #1050: Move testErrorsCaughtByApiAndRestApiWorks to its own class URL: https://github.com/apache/brooklyn-server/pull/1050 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [brooklyn-server] tbouron merged pull request #1057: minor changes to make working w AWS profiles easier

2019-03-20 Thread GitBox
tbouron merged pull request #1057: minor changes to make working w AWS profiles easier URL: https://github.com/apache/brooklyn-server/pull/1057 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [brooklyn-dist] duncangrant merged pull request #141: Make the build of rpm, deb and docker optional by default

2019-03-20 Thread GitBox
duncangrant merged pull request #141: Make the build of rpm, deb and docker optional by default URL: https://github.com/apache/brooklyn-dist/pull/141 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [brooklyn-library] asfgit commented on issue #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many t…

2019-03-20 Thread GitBox
asfgit commented on issue #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many t… URL: https://github.com/apache/brooklyn-library/pull/171#issuecomment-475001162 Can one of the admins verify this patch? T

[GitHub] [brooklyn-library] asfgit commented on issue #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many t…

2019-03-20 Thread GitBox
asfgit commented on issue #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many t… URL: https://github.com/apache/brooklyn-library/pull/171#issuecomment-475001165 Can one of the admins verify this patch? T

[GitHub] [brooklyn-library] houshengbo opened a new pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many t…

2019-03-20 Thread GitBox
houshengbo opened a new pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many t… URL: https://github.com/apache/brooklyn-library/pull/171 …hanks This is an automated message from the Apache Gi

[GitHub] [brooklyn-library] houshengbo closed pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many thanks

2019-03-20 Thread GitBox
houshengbo closed pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many thanks URL: https://github.com/apache/brooklyn-library/pull/171 This is an automated message from the Apache Git Servic

[GitHub] [brooklyn-dist] geomacy commented on issue #141: Make the build of rpm, deb and docker optional by default

2019-03-20 Thread GitBox
geomacy commented on issue #141: Make the build of rpm, deb and docker optional by default URL: https://github.com/apache/brooklyn-dist/pull/141#issuecomment-475059029 oops sorry @tbouron I overlooked the review request. Thanks for merging @duncangrant ---

[GitHub] [brooklyn-docs] geomacy commented on issue #280: wip: Add text to comply to Apache naming guidelines

2019-03-21 Thread GitBox
geomacy commented on issue #280: wip: Add text to comply to Apache naming guidelines URL: https://github.com/apache/brooklyn-docs/pull/280#issuecomment-475433478 I've made some adjustments and moved the description down as suggested by @rdowner. On my box now the front page looks like

[GitHub] [brooklyn-server] jcabrerizo opened a new pull request #1059: Adds SERVER_STATUS entitlement for read-only role

2019-03-22 Thread GitBox
jcabrerizo opened a new pull request #1059: Adds SERVER_STATUS entitlement for read-only role URL: https://github.com/apache/brooklyn-server/pull/1059 The UI calls to `extended` end point and that need being entitled for SERVER_STATUS entitlement. The read-only role hadn't this and that m

[GitHub] [brooklyn-server] tbouron merged pull request #1059: Adds SERVER_STATUS entitlement for read-only role

2019-03-22 Thread GitBox
tbouron merged pull request #1059: Adds SERVER_STATUS entitlement for read-only role URL: https://github.com/apache/brooklyn-server/pull/1059 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [brooklyn-ui] jcabrerizo opened a new pull request #128: Solver error showing entitlements messages

2019-03-25 Thread GitBox
jcabrerizo opened a new pull request #128: Solver error showing entitlements messages URL: https://github.com/apache/brooklyn-ui/pull/128 The error message from the exception thrown when the user has been not entitled to one action is wrapped on an object and was not showed properlly in s

[GitHub] [brooklyn-ui] tbouron merged pull request #128: Solver error showing entitlements messages

2019-03-25 Thread GitBox
tbouron merged pull request #128: Solver error showing entitlements messages URL: https://github.com/apache/brooklyn-ui/pull/128 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [brooklyn-server] aledsage opened a new pull request #1060: BROOKLYN-613: failing rebind test for AutoScalerPolicy config using DSL

2019-03-25 Thread GitBox
aledsage opened a new pull request #1060: BROOKLYN-613: failing rebind test for AutoScalerPolicy config using DSL URL: https://github.com/apache/brooklyn-server/pull/1060 This has a failing test to demonstrate https://issues.apache.org/jira/browse/BROOKLYN-613 (with the unit test marked a

[GitHub] [brooklyn-library] houshengbo closed pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many thanks

2019-03-25 Thread GitBox
houshengbo closed pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many thanks URL: https://github.com/apache/brooklyn-library/pull/171 This is an automated message from the Apache Git Servic

[GitHub] [brooklyn-library] houshengbo opened a new pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many thanks

2019-03-25 Thread GitBox
houshengbo opened a new pull request #171: DO NOT MERGE: Just verify how the pipeline job work in Apache, many thanks URL: https://github.com/apache/brooklyn-library/pull/171 This is an automated message from the Apache Git

[GitHub] [brooklyn-server] kemitix commented on issue #1051: Bump karaf.version from 4.2.2 to 4.2.3

2019-03-25 Thread GitBox
kemitix commented on issue #1051: Bump karaf.version from 4.2.2 to 4.2.3 URL: https://github.com/apache/brooklyn-server/pull/1051#issuecomment-476274745 Sourced from The GitHub Security Advisory Database. > Moderate severity vulnerability that affects org.apache.karaf:karaf and org.a

[GitHub] [brooklyn-server] aledsage commented on issue #1051: [SECURITY] Bump karaf.version from 4.2.2 to 4.2.3

2019-03-25 Thread GitBox
aledsage commented on issue #1051: [SECURITY] Bump karaf.version from 4.2.2 to 4.2.3 URL: https://github.com/apache/brooklyn-server/pull/1051#issuecomment-476310968 The change looks reasonable, but it’s still scary the knock-on consequences of a version bump like this (e.g. what else has b

[GitHub] [brooklyn-server] kemitix commented on issue #1051: [SECURITY] Bump karaf.version from 4.2.2 to 4.2.3

2019-03-25 Thread GitBox
kemitix commented on issue #1051: [SECURITY] Bump karaf.version from 4.2.2 to 4.2.3 URL: https://github.com/apache/brooklyn-server/pull/1051#issuecomment-476392021 @aledsage Needs a little more work. Testing had been pretty basic with just brooklyn-server. I'm seeing a maven enforcer error

[GitHub] [brooklyn-ui] ahgittin opened a new pull request #129: UI for defining parameters

2019-03-26 Thread GitBox
ahgittin opened a new pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129 has a field-based mode and JSON mode builds on #118 , makes it mergeable ideally flaws in the PR can be tracked here but addressed in follow-on PRs unless cr

[GitHub] [brooklyn-ui] ahgittin commented on issue #118: [WIP] Parameter UI additions

2019-03-26 Thread GitBox
ahgittin commented on issue #118: [WIP] Parameter UI additions URL: https://github.com/apache/brooklyn-ui/pull/118#issuecomment-476723168 Superseded by #129 This is an automated message from the Apache Git Service. To respond

[GitHub] [brooklyn-docs] geomacy commented on issue #280: Add text to comply with Apache naming guidelines

2019-03-27 Thread GitBox
geomacy commented on issue #280: Add text to comply with Apache naming guidelines URL: https://github.com/apache/brooklyn-docs/pull/280#issuecomment-477065009 hi @rdowner @tbouron could I ask for another review, what do you think of the look now? --

[GitHub] [brooklyn-docs] tbouron commented on issue #280: Add text to comply with Apache naming guidelines

2019-03-27 Thread GitBox
tbouron commented on issue #280: Add text to comply with Apache naming guidelines URL: https://github.com/apache/brooklyn-docs/pull/280#issuecomment-477116689 I'm also happy with this @geomacy ! This is an automated message f

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-03-27 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477125795 i've addressed 1,2,4, and applied a similar toolbar cleanup to configuration (also use labels a la palette instead of checkboxes for the filters). 3 is m

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-03-27 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477229926 did some testing and it all works (6 is happy), except a default value of `''` is being set for things so `required` has no effect. i've fixed that

[GitHub] [brooklyn-ui] jcabrerizo commented on issue #129: UI for defining parameters

2019-03-28 Thread GitBox
jcabrerizo commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477572837 Great job you both! I'd like add some ideas: 1. When we add an efector to an application, it shows an small icon on the top right. Have something

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-03-28 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477576730 all good suggestions @jcabrerizo , TY. your 2 and 4 are easy, i'll do that in this PR. not sure about 1, it might make the display noisy. but we s

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-03-28 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477586017 @jcabrerizo both updated; went with a subset of common parameter types, with note in code and ability to write others good to merge in your opinion?

[GitHub] [brooklyn-ui] jcabrerizo commented on issue #129: UI for defining parameters

2019-03-28 Thread GitBox
jcabrerizo commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477606422 Yes, looks good to me now except for one weird thing: you can not use `name` as key name. Makes sense? -

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-03-28 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477614540 that's weird, `name` seems to make it blow up. i'll look at that. This is an automated me

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-03-28 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477630964 took me far too long to find, but i've got it now @jcabrerizo . can you look at last commit and then we can merge! --

[GitHub] [brooklyn-ui] jcabrerizo commented on issue #129: UI for defining parameters

2019-03-28 Thread GitBox
jcabrerizo commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477646547 Perfect now 👍 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [brooklyn-docs] geomacy merged pull request #280: Add text to comply with Apache naming guidelines

2019-03-28 Thread GitBox
geomacy merged pull request #280: Add text to comply with Apache naming guidelines URL: https://github.com/apache/brooklyn-docs/pull/280 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [brooklyn-docs] geomacy commented on issue #280: Add text to comply with Apache naming guidelines

2019-03-28 Thread GitBox
geomacy commented on issue #280: Add text to comply with Apache naming guidelines URL: https://github.com/apache/brooklyn-docs/pull/280#issuecomment-477729552 Thanks @rdowner @tbouron, I've merged this now and will have a look at pushing it to the website. Haven't done this before, we'll s

[GitHub] [brooklyn-ui] tbouron merged pull request #125: Fix errors around locations in composer

2019-03-29 Thread GitBox
tbouron merged pull request #125: Fix errors around locations in composer URL: https://github.com/apache/brooklyn-ui/pull/125 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [brooklyn-ui] tbouron merged pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit

2019-03-29 Thread GitBox
tbouron merged pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit URL: https://github.com/apache/brooklyn-ui/pull/124 This is an automated message from the Apache Git Service. To respon

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270354008 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -888,13 +1037,151

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353960 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -888,13 +1037,151

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353811 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -788,11 +938,11 @@

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353328 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -503,7 +593,7 @@ e

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353437 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -548,24 +638,65 @@

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353242 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -449,13 +527,25 @@

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353614 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -601,36 +738,37 @@

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270354038 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -888,13 +1037,151

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353756 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -654,48 +792,61 @@

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353374 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -548,24 +638,65 @@

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353652 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -639,9 +777,9 @@ e

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #129: UI for defining parameters

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353351 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -548,24 +638,65 @@

[GitHub] [brooklyn-server] jcabrerizo opened a new pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
jcabrerizo opened a new pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061 Added new more granulated entitlements applied on rest resources This is an automated message

[GitHub] [brooklyn-ui] jcabrerizo opened a new pull request #130: Fix entitlement messages

2019-03-29 Thread GitBox
jcabrerizo opened a new pull request #130: Fix entitlement messages URL: https://github.com/apache/brooklyn-ui/pull/130 Now shows the messages from the entitlement control system This is an automated message from the Apache Gi

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #130: Fix entitlement messages

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #130: Fix entitlement messages URL: https://github.com/apache/brooklyn-ui/pull/130#discussion_r270405032 ## File path: ui-modules/app-inspector/app/views/main/inspect/summary/summary.controller.js ## @@ -188,7 +188,11 @@ export

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270409222 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/PolicyConfigResource.java

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270409599 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/PolicyResource.java ## @@

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270408624 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/EntityResource.java ## @@

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270407461 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java #

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270408234 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java ## @@

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270409680 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/PolicyResource.java ## @@

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270408903 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/LocationResource.java ##

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270409445 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/PolicyConfigResource.java

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1061: Granularity entitlement control

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r270407919 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java #

[GitHub] [brooklyn-ui] jcabrerizo commented on a change in pull request #130: Fix entitlement messages

2019-03-29 Thread GitBox
jcabrerizo commented on a change in pull request #130: Fix entitlement messages URL: https://github.com/apache/brooklyn-ui/pull/130#discussion_r270416036 ## File path: ui-modules/app-inspector/app/views/main/inspect/summary/summary.controller.js ## @@ -188,7 +188,11 @@ exp

[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #130: Fix entitlement messages

2019-03-29 Thread GitBox
tbouron commented on a change in pull request #130: Fix entitlement messages URL: https://github.com/apache/brooklyn-ui/pull/130#discussion_r270418848 ## File path: ui-modules/app-inspector/app/views/main/inspect/summary/summary.controller.js ## @@ -188,7 +188,11 @@ export

[GitHub] [brooklyn-ui] jcabrerizo commented on a change in pull request #130: Fix entitlement messages

2019-03-29 Thread GitBox
jcabrerizo commented on a change in pull request #130: Fix entitlement messages URL: https://github.com/apache/brooklyn-ui/pull/130#discussion_r270449717 ## File path: ui-modules/app-inspector/app/views/main/inspect/summary/summary.controller.js ## @@ -188,7 +188,11 @@ exp

[GitHub] [brooklyn-ui] tbouron merged pull request #130: Fix entitlement messages

2019-03-29 Thread GitBox
tbouron merged pull request #130: Fix entitlement messages URL: https://github.com/apache/brooklyn-ui/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [brooklyn-server] jcabrerizo commented on issue #1061: Granularity entitlement control

2019-03-29 Thread GitBox
jcabrerizo commented on issue #1061: Granularity entitlement control URL: https://github.com/apache/brooklyn-server/pull/1061#issuecomment-478052574 Messages changed. Thanks for the feedback This is an automated message from

[GitHub] [brooklyn-server] bd2019us opened a new pull request #1062: [SECURITY] change Executors.newCachedThreadPool() to newFixedThreadPool(int)

2019-03-31 Thread GitBox
bd2019us opened a new pull request #1062: [SECURITY] change Executors.newCachedThreadPool() to newFixedThreadPool(int) URL: https://github.com/apache/brooklyn-server/pull/1062 Since the size of 'sockets' can be large, cached thread pool has a high risk in running out of memory and causes t

[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #129: UI for defining parameters

2019-04-01 Thread GitBox
ahgittin commented on a change in pull request #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270942802 ## File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js ## @@ -449,13 +527,25 @

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-04-01 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-478653794 great points @tbouron > `==` vs `===` and `!=` vs `!==` ... you are 100% correct we should use the latter. i revert to bad other language h

[GitHub] [brooklyn-ui] ahgittin commented on issue #129: UI for defining parameters

2019-04-01 Thread GitBox
ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-478654065 (all comments addressed and pushed @tbouron ) This is an automated message from the Apache

[GitHub] [brooklyn-ui] tbouron commented on issue #129: UI for defining parameters

2019-04-02 Thread GitBox
tbouron commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-478991360 >yeah, i buy that. i don't see an easy way to do it with validation for the case where duplicate keys are set in yaml. (we already did it if you tried to s

[GitHub] [brooklyn-ui] tbouron closed pull request #118: [WIP] Parameter UI additions

2019-04-03 Thread GitBox
tbouron closed pull request #118: [WIP] Parameter UI additions URL: https://github.com/apache/brooklyn-ui/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [brooklyn-ui] tbouron commented on issue #118: [WIP] Parameter UI additions

2019-04-03 Thread GitBox
tbouron commented on issue #118: [WIP] Parameter UI additions URL: https://github.com/apache/brooklyn-ui/pull/118#issuecomment-479432992 As @ahgittin, this one is superseded by #129 so closing it But thanks @grkvlt for starting it 👍 --

[GitHub] [brooklyn-docs] geomacy opened a new pull request #281: Update download index and verify files to match published website

2019-04-07 Thread GitBox
geomacy opened a new pull request #281: Update download index and verify files to match published website URL: https://github.com/apache/brooklyn-docs/pull/281 This is a follow up to https://github.com/apache/brooklyn-docs/pull/280 Add text to comply with Apache naming guidelines #280

[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #281: Update download index and verify files to match published website

2019-04-08 Thread GitBox
tbouron commented on a change in pull request #281: Update download index and verify files to match published website URL: https://github.com/apache/brooklyn-docs/pull/281#discussion_r272926850 ## File path: download/index.md ## @@ -66,8 +146,8 @@ A pre-built package that

[GitHub] [brooklyn-docs] tbouron opened a new pull request #282: Update dev build instructions

2019-04-08 Thread GitBox
tbouron opened a new pull request #282: Update dev build instructions URL: https://github.com/apache/brooklyn-docs/pull/282 Update required version + build instructions to match the latest changes in Brooklyn This is an autom

[GitHub] [brooklyn-docs] duncangrant merged pull request #282: Update dev build instructions

2019-04-08 Thread GitBox
duncangrant merged pull request #282: Update dev build instructions URL: https://github.com/apache/brooklyn-docs/pull/282 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [brooklyn-docs] duncangrant commented on issue #282: Update dev build instructions

2019-04-08 Thread GitBox
duncangrant commented on issue #282: Update dev build instructions URL: https://github.com/apache/brooklyn-docs/pull/282#issuecomment-480890387 Thanks @tbouron and @kemitix - I'll merge This is an automated message from the Ap

[GitHub] [brooklyn-docs] geomacy commented on a change in pull request #281: Update download index and verify files to match published website

2019-04-08 Thread GitBox
geomacy commented on a change in pull request #281: Update download index and verify files to match published website URL: https://github.com/apache/brooklyn-docs/pull/281#discussion_r273220353 ## File path: download/index.md ## @@ -66,8 +146,8 @@ A pre-built package that

[GitHub] [brooklyn-docs] geomacy commented on a change in pull request #281: Update download index and verify files to match published website

2019-04-08 Thread GitBox
geomacy commented on a change in pull request #281: Update download index and verify files to match published website URL: https://github.com/apache/brooklyn-docs/pull/281#discussion_r273220758 ## File path: download/index.md ## @@ -66,8 +146,8 @@ A pre-built package that

[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #281: Update download index and verify files to match published website

2019-04-09 Thread GitBox
tbouron commented on a change in pull request #281: Update download index and verify files to match published website URL: https://github.com/apache/brooklyn-docs/pull/281#discussion_r273369180 ## File path: download/index.md ## @@ -66,8 +146,8 @@ A pre-built package that

[GitHub] [brooklyn-docs] tbouron merged pull request #281: Update download index and verify files to match published website

2019-04-09 Thread GitBox
tbouron merged pull request #281: Update download index and verify files to match published website URL: https://github.com/apache/brooklyn-docs/pull/281 This is an automated message from the Apache Git Service. To respond t

[GitHub] [brooklyn-server] tbouron opened a new pull request #1063: Add support for finally block in TestCase entity

2019-04-09 Thread GitBox
tbouron opened a new pull request #1063: Add support for finally block in TestCase entity URL: https://github.com/apache/brooklyn-server/pull/1063 This adds a new config key called `on.finally.spec` where one can configure it to execute a new entity. regardless of the state of the test. Th

[GitHub] [brooklyn-docs] tbouron opened a new pull request #283: Update documentation to match new parameters for TestCase entity

2019-04-09 Thread GitBox
tbouron opened a new pull request #283: Update documentation to match new parameters for TestCase entity URL: https://github.com/apache/brooklyn-docs/pull/283 This requires https://github.com/apache/brooklyn-server/pull/1063

[GitHub] [brooklyn-docs] duncangrant merged pull request #283: Update documentation to match new parameters for TestCase entity

2019-04-09 Thread GitBox
duncangrant merged pull request #283: Update documentation to match new parameters for TestCase entity URL: https://github.com/apache/brooklyn-docs/pull/283 This is an automated message from the Apache Git Service. To respon

[GitHub] [brooklyn-server] duncangrant merged pull request #1063: Add support for finally block in TestCase entity

2019-04-09 Thread GitBox
duncangrant merged pull request #1063: Add support for finally block in TestCase entity URL: https://github.com/apache/brooklyn-server/pull/1063 This is an automated message from the Apache Git Service. To respond to the mes

<    1   2   3   4   5   6   7   8   9   10   >