[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-10-02 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r142124445 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/BrooklynRestResourceUtils.java --- @@ -130,6 +143,36 @@ public Policy

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-10-02 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r142122967 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-10-02 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r142122148 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityInternal.java --- @@ -189,7 +189,7 @@ void remove(AttributeSensor

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

2017-10-02 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/821#discussion_r142122006 --- Diff: api/src/main/java/org/apache/brooklyn/api/sensor/Feed.java --- @@ -43,7 +43,7 @@ /** * True if everything has

[GitHub] brooklyn-server issue #846: Delete unneeded catalog code

2017-10-01 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/846 retest this please ---

[GitHub] brooklyn-server issue #847: Catalog init refactor

2017-10-01 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/847 retest this please ---

[GitHub] brooklyn-server issue #816: Tasks code improvements - prep for better presen...

2017-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/816 For `executionContext.getImmediately()` if given an unsubmitted task, I think it is probably better to throw an `ImmediateUnsupportedException` rather than break the task

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141918771 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java --- @@ -906,18 +908,14 @@ public void setSubmitTimeUtc(long val

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141917699 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141917156 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141596090 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java --- @@ -256,6 +246,17 @@ public synchronized void

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141578971 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141606551 --- Diff: core/src/test/java/org/apache/brooklyn/util/core/task/BasicTasksFutureTest.java --- @@ -174,29 +175,53 @@ public T call

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141560042 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141579426 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141585797 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -110,48 +248,53 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140607423 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -66,23 +75,37 @@ final Set tags = new

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140607801 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141594847 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141576522 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141586350 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -253,8 +261,13 @@ protected boolean

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140608998 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java --- @@ -269,6 +274,21 @@ public Boolean call() throws Exception

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141592263 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -706,19 +719,23 @@ public void run

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141596718 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java --- @@ -327,11 +328,10 @@ public synchronized boolean cancel

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141587409 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java --- @@ -448,36 +470,46 @@ public Object call

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141603195 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -434,7 +434,11 @@ protected boolean

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141573429 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -100,6 +123,121 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r141605052 --- Diff: core/src/test/java/org/apache/brooklyn/core/effector/EffectorSayHiTest.java --- @@ -99,6 +99,23 @@ public void testInvokeEffectors1

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140609179 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java --- @@ -183,29 +183,40 @@ public T get

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

2017-09-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/826 retest this please ---

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

2017-09-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/826 Jenkins failed for reasons related to build environment, rather than this PR: ``` GitHub pull request #826 of commit d113c7f856c1c3a9855d1fb71c5188234fba3561, no merge conflicts

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

2017-09-27 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/129 retest this please ---

[GitHub] brooklyn-server pull request #847: Catalog init refactor

2017-09-27 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/847 Catalog init refactor Builds on code tidy/deletions in https://github.com/apache/brooklyn-server/pull/846. Please review/merge that first, and then I'll rebase this. Only the final

[GitHub] brooklyn-server pull request #846: Delete unneeded catalog code

2017-09-26 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/846 Delete unneeded catalog code You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server delete-unneeded-catalog-code

[GitHub] brooklyn-server issue #843: limit reset/persistence to legacy items

2017-09-26 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/843 Thanks @ahgittin - confirmed this fixes it for me in Karaf. Merging now. ---

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140767366 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140804115 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140767511 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-docs pull request #212: Add update instructions for RPM/DEB and bin...

2017-09-25 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/212#discussion_r140802173 --- Diff: guide/ops/upgrade.md --- @@ -0,0 +1,356 @@ +--- +title: Upgrade +layout: website-normal +--- + +This guide provides

[GitHub] brooklyn-server pull request #816: Tasks code improvements - prep for better...

2017-09-22 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/816#discussion_r140606634 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ScheduledTask.java --- @@ -117,6 +121,44 @@ public ScheduledTask(Map flags

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-22 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140600450 --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypePredicates.java --- @@ -194,27 +219,42 @@ public boolean apply

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-22 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140603081 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java --- @@ -153,6 +153,9 @@ public Response createFromUpload

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-22 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140602227 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -60,6 +60,7 @@ import org.slf4j.Logger

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-22 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140605795 --- Diff: rest/rest-resources/src/test/java/org/apache/brooklyn/rest/resources/BundleAndTypeResourcesTest.java --- @@ -0,0 +1,1098

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-22 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140604372 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EnricherConfigSummary.java --- @@ -20,60 +20,24 @@ import

[GitHub] brooklyn-server pull request #844: Fix machine customizers

2017-09-22 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/844 Fix machine customizers Previously, DSL values passed to the location/machine customizers would not be resolved. Also includes a couple of other tiny changes (see individual

[GitHub] brooklyn-server issue #843: limit reset/persistence to legacy items

2017-09-22 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/843 Note this fixes https://issues.apache.org/jira/browse/BROOKLYN-539 ---

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140315673 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/TypeApi.java --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140310844 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140311355 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140307032 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/TypeTransformer.java --- @@ -0,0 +1,194

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140307822 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/BundleApi.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140305502 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/TypeTransformer.java --- @@ -0,0 +1,194

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140309656 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/BundleApi.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140309889 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/TypeDetail.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140315527 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/TypeApi.java --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140315307 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140311803 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140313345 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #841: BROOKLYN-538: add failing test

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/841 BROOKLYN-538: add failing test Adds a test that demonstrates https://issues.apache.org/jira/browse/BROOKLYN-538 I'm going to mark issue as "won't fix" for the followi

[GitHub] brooklyn-server issue #840: Fix catalog YAML

2017-09-21 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/840 Thanks for spotting and fixing! Merging now. ---

[GitHub] brooklyn-server pull request #839: BROOKLYN-537: fix NPE listing catalog ite...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/839 BROOKLYN-537: fix NPE listing catalog items Fixes https://issues.apache.org/jira/browse/BROOKLYN-537 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-client pull request #60: Fix tests tearDown (to always stop managem...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-client/pull/60 Fix tests tearDown (to always stop management context) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-client tests

[GitHub] brooklyn-server pull request #838: Fix tests tearDown (to always stop manage...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/838 Fix tests tearDown (to always stop management context) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server

[GitHub] brooklyn-library pull request #131: Fix tests tearDown (to always stop manag...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-library/pull/131 Fix tests tearDown (to always stop management context) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-library

[GitHub] brooklyn-server issue #837: [IMPORTANT] Fix FunctionSensor’s rebind

2017-09-21 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/837 Merging this now to fix the build (and because it's very low risk). But if someone can review it later that would be good! ---

[GitHub] brooklyn-server pull request #837: Fix FunctionSensor’s rebind

2017-09-20 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/837 Fix FunctionSensor’s rebind It was trying to serialise the TypeCoercions function. We don’t need that - it coerces automatically. This is important: the brooklyn master

[GitHub] brooklyn-server issue #810: REST API for bundles, types, and subtypes

2017-09-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/810 For template versus application, we can defer that (as long as we're not making pain for ourselves in this api; I don't think we are). Good to separate things into more PRs. UIs that want

[GitHub] brooklyn-server issue #810: REST API for bundles, types, and subtypes

2017-09-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/810 TL;DR: I propose we split this PR into two. The `/bundles` part we can merge pretty quickly. However, the `/types` and `/subtypes` is too controversial - it probably deserves a `/v2

[GitHub] brooklyn-server issue #832: Add ManagementNodeStateListener support

2017-09-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/832 jenkins build failed with: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) on project brooklyn-core: Failed

[GitHub] brooklyn-server issue #832: Add ManagementNodeStateListener support

2017-09-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/832 retest this please ---

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

2017-09-20 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/833#discussion_r139937923 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/AbstractScheduledEffectorPolicy.java --- @@ -101,15 +102,15

[GitHub] brooklyn-docs issue #214: Document `sshMonitoring.enabled`

2017-09-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-docs/pull/214 Thanks @drigodwin - comments incorporated and squashed into one commit. Merging now. ---

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

2017-09-19 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/833 Fix PeriodicEffectorPolicy The `PeriodicEffectorPolicy` rebind test(s) were failing non-deterministically in the jenkins master build, and same for me locally. This PR makes

[GitHub] brooklyn-server pull request #832: Add ManagementNodeStateListener support

2017-09-19 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/832#discussion_r139803014 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/ManagementNodeStateListenerManager.java --- @@ -0,0 +1,175

[GitHub] brooklyn-server issue #832: Add ManagementNodeStateListener support

2017-09-19 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/832 retest this please ---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

2017-09-19 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/129 retest this please ---

[GitHub] brooklyn-server issue #824: Config for VanillaSoftwareProcess disabling ssh ...

2017-09-19 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/824 Thanks @drigodwin - I'll merge this, and will update the brooklyn docs. ---

[GitHub] brooklyn-server pull request #825: fix non-det failure in scaling down test

2017-09-19 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/825#discussion_r139718436 --- Diff: policy/src/test/java/org/apache/brooklyn/policy/autoscaling/AutoScalerPolicyPoolSizeTest.java --- @@ -101,10 +103,18 @@ public void

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

2017-09-19 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/129 jenkins failed with the error: ``` java.io.IOException: remote file operation failed: /home/jenkins/jenkins-slave/workspace/brooklyn-library-pull-requests

[GitHub] brooklyn-server pull request #832: Add ManagementNodeStateListener support

2017-09-19 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/832 Add ManagementNodeStateListener support You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server add

[GitHub] brooklyn-library issue #128: Add icons to catalog.bom files

2017-09-19 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/128 retest this please ---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

2017-09-19 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/129 @tbouron changes made; ready for review + (hopefully!) merge. @tbouron For why we have ansible, chef and salt in different modules (versus databases in one module), we don't have

[GitHub] brooklyn-library issue #128: Add icons to catalog.bom files

2017-09-19 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/128 @tbouron yes, the rest endpoint `/children` also includes the `iconUrl` (for both the `pr-128-top-level` and `pr-128-inside-item`). I deployed the app shown below: ``` services

[GitHub] brooklyn-library pull request #129: Move chef from brooklyn-software-base to...

2017-09-19 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/129#discussion_r139619615 --- Diff: software/cm/chef/src/main/resources/catalog.bom --- @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] brooklyn-server pull request #829: [WIP] BROOKLYN-535: restarter policy when...

2017-09-18 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/829 [WIP] BROOKLYN-535: restarter policy when entity stopping See https://issues.apache.org/jira/browse/BROOKLYN-534 You can merge this pull request into a Git repository by running

[GitHub] brooklyn-server pull request #828: BROOKLYN-533: adds maxConcurrentMachineDe...

2017-09-18 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/828 BROOKLYN-533: adds maxConcurrentMachineDeletions Workaround for BROOKLYN-533: `maxConcurrentMachineDeletions` will ensure that at most this many machine deletions are done at one time

[GitHub] brooklyn-library issue #128: Add icons to catalog.bom files

2017-09-18 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/128 Thanks @tbouron. I think the icon url needs to be at the top-level to be known about by the catalog, and that should be sufficient for it to be known by the entity instances. I

[GitHub] brooklyn-server pull request #826: Move chef from brooklyn-software-base to ...

2017-09-16 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/826 Move chef from brooklyn-software-base to own module in brooklyn-library See https://github.com/apache/brooklyn-library/pull/129 for where this code is being moved to. You can merge

[GitHub] brooklyn-library pull request #129: Move chef from brooklyn-software-base to...

2017-09-16 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-library/pull/129 Move chef from brooklyn-software-base to own module This contains no code changes. It just moves files to the new locations, and moves snippets of some files (e.g. catalog.bom

[GitHub] brooklyn-library pull request #128: Add icons to catalog.bom files

2017-09-16 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-library/pull/128 Add icons to catalog.bom files I've deliberately only focused on the .bom files in each module. I've not touched `karaf/catalog/src/main/resources/library-catalog-classes.bom`. At some

[GitHub] brooklyn-server pull request #824: Config for VanillaSoftwareProcess disabli...

2017-09-15 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/824#discussion_r139185879 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessImpl.java --- @@ -18,20 +18,40

[GitHub] brooklyn-server issue #819: Improve config key descriptions

2017-09-15 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/819 @ahgittin @tbouron @drigodwin thanks for comments - incorporated in an additional commit. Is it ok to merge (with icons being separate from this PR)? ---

[GitHub] brooklyn-server pull request #824: Config for VanillaSoftwareProcess disabli...

2017-09-15 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/824 Config for VanillaSoftwareProcess disabling ssh polling See individual commits for more details. The `FunctionSensor` I primarily added to make it easier to write my

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

2017-09-13 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138607380 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

2017-09-13 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138607947 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

2017-09-13 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138606936 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

2017-09-13 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138607171 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

2017-09-13 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138608438 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed

[GitHub] brooklyn-server issue #812: use external config in examples

2017-09-13 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/812 @m4rkmckenna there is a "file-based exteranl config supplier" you can use for dev (`PropertiesFileExternalConfigSupplier`), and then switch to Vault or whatever when yo

<    1   2   3   4   5   6   7   8   9   10   >