[GitHub] brooklyn-server issue #971: DSL for $brooklyn:location()

2018-09-04 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/971 LGTM apart from a minor comment on the test. I agree it would be nice to be able to tell whether DSL simply hasn't resolved yet or whether it's permanently failed to resolve, but I'm happy

[GitHub] brooklyn-server pull request #971: DSL for $brooklyn:location()

2018-09-04 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/971#discussion_r214940310 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java --- @@ -467,6 +467,30 @@ public void

[GitHub] brooklyn-docs issue #260: Use the official AWS CLI instead of s3cmd

2018-06-21 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/260 LGTM ---

[GitHub] brooklyn-docs issue #258: Fix copy-state usage for brooklyn-karaf

2018-06-21 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/258 One minor comment, other than that LGTM ---

[GitHub] brooklyn-docs pull request #258: Fix copy-state usage for brooklyn-karaf

2018-06-21 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/258#discussion_r197133399 --- Diff: guide/ops/persistence/index.md --- @@ -246,16 +246,16 @@ The state can be downloaded periodically from the object store, archived and bac

[GitHub] brooklyn-server issue #972: BROOKLYN-594: fix REST api /v1/server/ha/persist...

2018-06-21 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/972 Tested; LGTM ---

[GitHub] brooklyn-server issue #971: DSL for $brooklyn:location()

2018-06-21 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/971 Looks good, nothing to add to @geomacy's comments ---

[GitHub] brooklyn-server issue #970: MultiLocation yaml tests

2018-06-21 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/970 Tested, LGTM ---

[GitHub] brooklyn-docs pull request #253: Document Azure ad app password reset

2018-05-23 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-docs/pull/253 Document Azure ad app password reset Provides the command used to change the Azure active directory application password used for API access You can merge this pull request into a Git

[GitHub] brooklyn-server issue #957: SshCommandSensor.testDslWithSshSensor: convert t...

2018-04-20 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/957 LGTM ---

[GitHub] brooklyn-server issue #953: Defers reading of config in SshCommandSensor

2018-04-17 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/953 PR comments addressed ---

[GitHub] brooklyn-server pull request #954: Changes access of `StringPredicates` clas...

2018-04-17 Thread nakomis
Github user nakomis closed the pull request at: https://github.com/apache/brooklyn-server/pull/954 ---

[GitHub] brooklyn-server pull request #956: SSH Sensor value-on-error

2018-04-16 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/956 SSH Sensor value-on-error Adds `value.on.error` config key to SshCommandSensor to allow a value to be specified for use when an exception occurs when executing the ssh command You

[GitHub] brooklyn-server pull request #954: Changes access of `StringPredicates` clas...

2018-04-12 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/954 Changes access of `StringPredicates` classes This allows them to be used in YAML, via $brooklyn:object You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-server pull request #953: Defers reading of config in SshCommandSen...

2018-04-11 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/953 Defers reading of config in SshCommandSensor This allows DSL to be used in the command, env and execution dir as a management context will then be available You can merge this pull

[GitHub] brooklyn-docs pull request #249: Updates ulimit docs for Centos 7

2018-03-23 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-docs/pull/249 Updates ulimit docs for Centos 7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-docs ulimit-docs-update Alternatively

[GitHub] brooklyn-server issue #916: DynamicCluster's max size applies to all calls t...

2018-01-03 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/916 @aledsage regarding resizing up to `maxSize`, I'd favour @sjcorbett's approach of throwing the `InsufficientCapacityException` and leaving it up to the consumer to re-try. Requesting a new

[GitHub] brooklyn-server pull request #916: DynamicCluster's max size applies to all ...

2017-12-12 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/916#discussion_r156406908 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java --- @@ -799,6 +795,12 @@ protected Entity replaceMember

[GitHub] brooklyn-server pull request #916: DynamicCluster's max size applies to all ...

2017-12-12 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/916#discussion_r156407339 --- Diff: core/src/test/java/org/apache/brooklyn/entity/group/DynamicClusterTest.java --- @@ -1398,14 +1398,18 @@ public void

[GitHub] brooklyn-server pull request #858: Fixes broken ClassLoaderFromStackOfBrookl...

2017-10-09 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/858 Fixes broken ClassLoaderFromStackOfBrooklynClassLoadingContextTest.testLoadClassFromBundle test Updates test jars to fix broken

[GitHub] brooklyn-server issue #800: AutoScalerPolicy to resize to limits on expunge

2017-08-23 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/800 PR comment addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #803: Adds cluster.max.size to dynamic cluster

2017-08-22 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/803 PR comments addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server pull request #803: Adds cluster.max.size to dynamic cluster

2017-08-22 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/803 Adds cluster.max.size to dynamic cluster Adds cluster.max.size to dynamic cluster, and prevents the cluster from being manually increased beyond that size You can merge this pull request

[GitHub] brooklyn-server issue #800: AutoScalerPolicy to resize to limits on expunge

2017-08-18 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/800 Should now be good to go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #800: AutoScalerPolicy to resize to limits on expunge

2017-08-18 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/800 On second thoughts, these tests seem a little fragile and may have non-deterministic failures. Please DO NOT MERGE (yet) --- If your project is set up for it, you can reply to this email

[GitHub] brooklyn-server pull request #800: AutoScalerPolicy to resize to limits on e...

2017-08-17 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/800 AutoScalerPolicy to resize to limits on expunge Currently, if a user resizes a cluster with an `AutoScalerPolicy` such that the pool size is now outside the min and max pool size

[GitHub] brooklyn-server pull request #700: Adds getLastConstructorProps to Recording...

2017-05-25 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/700 Adds getLastConstructorProps to RecordingWinRmTool Adds `getLastConstructorProps()` to `RecordingWinRmTool`, in line with `RecordingSshTool` You can merge this pull request into a Git

[GitHub] brooklyn-docs pull request #164: Adds documentation for bundling catalog res...

2017-05-19 Thread nakomis
Github user nakomis closed the pull request at: https://github.com/apache/brooklyn-docs/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-docs issue #164: Adds documentation for bundling catalog resources ...

2017-05-19 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/164 Closing in favour of #180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #677: Adds EBS Location Customizers

2017-05-18 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/677 @neykov Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #677: Adds EBS Location Customizers

2017-05-18 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/677 @drigodwin description an example added @sjcorbett the classes sit adjacent to existing cloud-specific classes such as `SoftLayerSameVlanLocationCustomizer

[GitHub] brooklyn-server pull request #680: Adds JcloudsLocationCustomizer hook to al...

2017-05-15 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/680#discussion_r116485510 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsSshMachineLocationStubbedTest.java --- @@ -118,4 +123,17

[GitHub] brooklyn-server issue #680: Adds JcloudsLocationCustomizer hook to allow nod...

2017-05-15 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/680 @bostko If declared in the YAML, then the property must be known *before* the machine is provisioned. The hook allows for a customizer to configure the ssh / winrm config tool with runtime

[GitHub] brooklyn-server pull request #680: Adds JcloudsLocationCustomizer hook to al...

2017-05-15 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/680 Adds JcloudsLocationCustomizer hook to allow node / config configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis

[GitHub] brooklyn-server pull request #677: Adds EBS Location Customizers

2017-05-10 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/677 Adds EBS Location Customizers You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-server ebs-volume-customizer

[GitHub] brooklyn-docs pull request #181: Adds instructions for configuring brooklyn ...

2017-05-10 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-docs/pull/181 Adds instructions for configuring brooklyn to use the system proxy You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-docs

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698327 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115697990 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115699050 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698765 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698151 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115698963 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115697711 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs pull request #180: Update bundle upload

2017-05-10 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/180#discussion_r115697661 --- Diff: guide/blueprints/catalog/index.md --- @@ -375,153 +375,120 @@ the latest non-snapshot version will be loaded when an entity is instantiated

[GitHub] brooklyn-docs issue #172: Java config docs: default-value should be immutabl...

2017-04-19 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/172 I think it would be worth changing the wording to make it clearer that you're not talking about the user *setting* the default to a new value, but instead modifying the underlying object, i.e

[GitHub] brooklyn-server issue #625: Updates BasicExternalConfigSupplierRegistry to u...

2017-04-11 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/625 Tests added at https://github.com/apache/brooklyn-dist/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-dist pull request #89: Adds tests for OSGI loading of external conf...

2017-04-11 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-dist/pull/89 Adds tests for OSGI loading of external config providers You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-dist osgi

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

2017-04-11 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110842541 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BasicExternalConfigSupplierRegistry.java --- @@ -103,12 +103,13 @@ private

[GitHub] brooklyn-docs issue #164: Adds documentation for bundling catalog resources ...

2017-04-11 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/164 DO NOT MERGE. zip uploading is currently WIP feature --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

2017-04-10 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/625 Updates BasicExternalConfigSupplierRegistry to use ClassLoaderUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn

[GitHub] brooklyn-docs pull request #164: Adds documentation for bundling catalog res...

2017-04-07 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-docs/pull/164 Adds documentation for bundling catalog resources in a zip file You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-docs

[GitHub] brooklyn-docs pull request #158: Minor fix to Azure ARM docs

2017-03-30 Thread nakomis
Github user nakomis closed the pull request at: https://github.com/apache/brooklyn-docs/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-docs pull request #158: Minor fix to Azure ARM docs

2017-03-29 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-docs/pull/158 Minor fix to Azure ARM docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-docs fix/azure-arm-docs Alternatively you

[GitHub] brooklyn-server issue #564: Winrm CmdFeed

2017-03-03 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/564 @neykov It looks like @bostko has addressed the bulk of the issues. Are you happy to merge this now? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] brooklyn-docs issue #151: BROOKLYN-433: docs for yaml config key constraints

2017-02-28 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/151 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server pull request #144: Allows for multiple deserialization class...

2017-02-07 Thread nakomis
Github user nakomis closed the pull request at: https://github.com/apache/brooklyn-server/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #144: Allows for multiple deserialization class rename...

2017-02-07 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/144 Not needed for classic, so #492 should suffice, closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server pull request #276: Effector for opening inbound ports in sec...

2016-08-17 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/276#discussion_r75093209 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java --- @@ -0,0 +1,88

[GitHub] brooklyn-server pull request #276: (For Review) Effector for opening inbound...

2016-08-17 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/276#discussion_r75093029 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java --- @@ -0,0 +1,88

[GitHub] brooklyn-ui issue #30: BROOKLYN-323: Improve logout script

2016-08-04 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-ui/pull/30 Tested alongside https://github.com/apache/brooklyn-server/pull/288 and this resolves the issue on Windows 10 on both IE and Edge. Behaviour on Chrome on OS X remains unchanged LGTM

[GitHub] brooklyn-server issue #288: BROOKLYN-323: Simplify Logout api

2016-08-04 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/288 Tested alongside https://github.com/apache/brooklyn-ui/pull/30 and this resolves the issue on Windows 10 on both IE and Edge. Behaviour on Chrome on OS X remains unchanged LGTM

[GitHub] brooklyn-server pull request #276: (For Review) Effector for opening inbound...

2016-07-28 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/276#discussion_r72585644 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java --- @@ -39,4 +43,22 @@ public static InetAddress

[GitHub] brooklyn-server issue #270: [REVIEW ONLY] State transformations: support del...

2016-07-22 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/270 Tested catalog deletions will YAML similar to following: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server issue #267: Fix for BROOKLYN-314

2016-07-19 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/267 Looks good, and pretty straightforward. Could you add a test for the rebind issue described in BROOKLYN-314 --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server issue #227: Fixes BrooklynFeatureEnablement setting defaults

2016-07-01 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/227 One comment unrelated to this PR. Other than that, code looks good. Is there an documentation that explains the explicit precedence? --- If your project is set up for it, you can reply

[GitHub] brooklyn-server issue #157: Windows helper script for using Invoke-Command -...

2016-06-27 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/157 Great, thanks @bostko There are now a couple of outstanding issues ([BROOKLYN-306](https://issues.apache.org/jira/browse/BROOKLYN-306) and [BROOKLYN-308](https://issues.apache.org

[GitHub] brooklyn-server issue #157: Windows helper script for using Invoke-Command -...

2016-06-23 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/157 The install scripts are run in the INSTALLDIR, and not the RUNDIR (the launch script is run in RUNDIR), which would be a good pattern to keep. As it will require a change

[GitHub] brooklyn-docs issue #78: Adds details of setting up a HA master-slave pair

2016-06-23 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/78 PR comments addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-docs pull request #78: Adds details of setting up a HA master-slave...

2016-06-20 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-docs/pull/78 Adds details of setting up a HA master-slave pair You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-docs ha-supplemental

[GitHub] brooklyn-server issue #194: Prevents premature resolving of external config

2016-06-16 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/194 PR comments addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server pull request #194: Prevents premature resolving of external ...

2016-06-16 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/194#discussion_r67360931 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2422,7 +2437,7 @@ protected

[GitHub] brooklyn-server issue #194: Prevents premature resolving of external config

2016-06-10 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/194 This is in addition to the changes in https://github.com/apache/brooklyn-server/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-server pull request #194: Prevents premature resolving of external ...

2016-06-10 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/194 Prevents premature resolving of external config If external config is resolved too early, it can lead to resolved values being persisted (security flaw). Also, changes to the external

[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/193#discussion_r66481067 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java --- @@ -0,0 +1,153

[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/193#discussion_r66480706 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java --- @@ -0,0 +1,153

[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/193#discussion_r66480033 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java --- @@ -0,0 +1,153

[GitHub] brooklyn-server issue #157: Windows helper script for using Invoke-Command -...

2016-06-09 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/157 @bostko Ideally, *all* of the scripts and config file should be copied some path relative to `C:\brooklyn-managed-processes\install`. If they're copied to the temp folder, there's always

[GitHub] brooklyn-server issue #191: Add AbstractTransformer.ALLOW_CYCLIC_PUBLISHING

2016-06-09 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/191 One comment, but other than that, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #150: Ability to perform installation on a Windows Blu...

2016-06-08 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/150 The latest changes looks sensible. Is there any (external) documentation saying what exceptions we may see during `rebootAndWait`, or are the exceptions used (`WebServiceException

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-08 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66244197 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java --- @@ -321,12 +332,21

[GitHub] brooklyn-server issue #150: Ability to perform installation on a Windows Blu...

2016-06-08 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/150 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #150: Ability to perform installation on a Windows Blu...

2016-06-06 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/150 A couple of minor comments, but other than that, LGTM. We should probably refactor the away the `winrm.computerName` config key, and instead set the `hostname` sensor correctly during

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-06 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r65900734 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,28 @@ public

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-06 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r65900017 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java --- @@ -321,12 +332,22

[GitHub] brooklyn-server pull request: Ability to suppress install command failures o...

2016-05-31 Thread nakomis
Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/150 @bostko I've been trying to reproduce the issue manually, by provisioning a windows VM, installing ADDS remotely using pywinrm with `-NoRebootOnCompletion`, then reconnecting

[GitHub] brooklyn-server pull request: Windows helper script for using Invoke-Command...

2016-05-31 Thread nakomis
Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/157 This looks sensible, but it would be nice to tidy it up as follows: - Rename `brooklyn-invoke-command-credssp.ps1` to `invoke-command-credssp.ps1` - Rename `custom-enable

[GitHub] brooklyn-server pull request: Merge Map values in config

2016-05-23 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/151#discussion_r64203567 --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java --- @@ -345,7 +346,7 @@ protected void

[GitHub] brooklyn-server pull request: Merge Map values in config

2016-05-23 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/151#discussion_r64203063 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EmptySoftwareProcessYamlTest.java --- @@ -60,6 +62,31 @@ public void

[GitHub] brooklyn-server pull request: Merge Map values in config

2016-05-23 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/151#discussion_r64197677 --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java --- @@ -345,7 +346,7 @@ protected void

[GitHub] brooklyn-server pull request: Merge Map values in config

2016-05-23 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/151#discussion_r64197284 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EmptySoftwareProcessYamlTest.java --- @@ -60,6 +62,31 @@ public void

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

2016-05-19 Thread nakomis
Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/145#issuecomment-220266139 A future improvement would be for `AbstractSoftwareProcessWinRmDriver.rebootAndWait` to set a sensor to indicate that the machine is rebooting, which could

[GitHub] brooklyn-server pull request: Allows for multiple deserialization ...

2016-05-18 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/144 Allows for multiple deserialization class renames files You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-server

[GitHub] brooklyn-server pull request: Adds class renames for downstream Cl...

2016-05-18 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/143 Adds class renames for downstream Clocker project You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-server clocker

[GitHub] brooklyn-server pull request: Configurable removal strategies

2016-05-09 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r62474640 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/FirstFromRemovalStrategy.java --- @@ -0,0 +1,53 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request: Configurable removal strategies

2016-04-12 Thread nakomis
Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/112#issuecomment-208879479 Hadn't twigged that I wouldn't need to change the config key. Much nice without all the deprecation. Have close https://github.com/apache/brooklyn-library/pull

[GitHub] brooklyn-library pull request: Adds configurable removal strategie...

2016-04-12 Thread nakomis
Github user nakomis closed the pull request at: https://github.com/apache/brooklyn-library/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server pull request: Configurable removal strategies

2016-04-12 Thread nakomis
Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/112#issuecomment-208827153 Depended on by https://github.com/apache/brooklyn-library/pull/31 to be merged at the same time --- If your project is set up for it, you can reply

[GitHub] brooklyn-library pull request: Adds configurable removal strategie...

2016-04-12 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-library/pull/31 Adds configurable removal strategies, deprecates old removal strategy Depends on https://github.com/apache/brooklyn-server/pull/112 to be merged at the same time You can merge this pull

[GitHub] brooklyn-server pull request: Configurable removal strategies

2016-04-12 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/112 Configurable removal strategies You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-server configurable-removal

[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...

2016-02-19 Thread nakomis
Github user nakomis commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-186160816 /bump @sjcorbett @grkvlt @aledsage Any input on @ahgittin's comments? --- If your project is set up for it, you can reply to this email and have your

  1   2   >