Re: [ANNOUNCE] New committer: Jiajun Xie

2023-02-22 Thread Julian Hyde
Thanks for introducing yourself, and thank you for the excellent contributions you have made to Calcite’s community and code! Julian > On Feb 15, 2023, at 5:35 PM, Jiajun Xie wrote: > > Thanks for the warm welcome to everyone! > > A few words about myself: > > I'm 23 years old and I often

Re: scope of rex expressions

2023-02-22 Thread Julian Hyde
I suspect that the problem is this. Validation is mostly read-only but not entirely. When you validate the AST for ’select foo from t’ the validator mutates it as if the user had written ’select t.foo from t’. This makes SqlToRelConverter’s job easier/possible. You are providing the AST for

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-22 Thread Julian Hyde
t; >>> >> https://github.com/apache/calcite/commit/96b05ee12f936ed057265072ff6a2de8ea0a249e >>>> >>>> is not present in the main branch. It might have been caused by doing a >>>> cherry-pick instead of merging back to main. >>>>

Re: [Question] What is the best way to allow for subclassing and using a custom SqlValidator?

2023-02-21 Thread Julian Hyde
The strategy of subclassing CalcitePrepareImpl is definitely right. You can’t change the createSqlValidator method (at line 721) because, as well as being private, it is static. Instead, you should probably subclass CalcitePreparingStatement and override its createSqlValidator method (at line

Re: RECURSIVE keyword not supported?

2023-02-21 Thread Julian Hyde
A classic problem of open source development. Should we accept a contribution for recursive queries even though it doesn't have SQL support? And if we choose to accept it without SQL support, do we show the equivalent SQL in our documentation? I agree that the documentation is a bit misleading.

Re: Rat failures in CI

2023-02-19 Thread Julian Hyde
passed > too. > > It seems that the failure is ephemeral, and we do not have to modify > `.ratignore` to get rid of it, at least it is not urgent. > > [1] https://github.com/apache/calcite/pull/3055 > [2] https://github.com/apache/calcite/pull/3053 > [3] https://github.com/apache/calc

Re: Avatica 'userAgent' connection property

2023-02-19 Thread Julian Hyde
a=b > > See https://issues.apache.org/jira/browse/CALCITE-4121 > > On Sat, Feb 18, 2023 at 4:32 AM Julian Hyde wrote: > >> TJ has logged a case [1] proposing to add a "userAgent" connection >> property to Avatica. (It would be inherited by all drivers, e.g. >

Re: Rat failures in CI

2023-02-17 Thread Julian Hyde
its/71b9b747c51fc4f108759455923e2e474357e547 > [6] > https://github.com/apache/calcite/pull/3074/commits/5149bc88870ebc59d04d0410689f596b41c7035f > > > Julian Hyde 于2023年2月18日周六 11:39写道: > >> CI tests have been falling recently (e.g. [1]) with the following error: >&

Rat failures in CI

2023-02-17 Thread Julian Hyde
CI tests have been falling recently (e.g. [1]) with the following error: > Task :rat FAILED :rat failure marker Files with unapproved licenses: - /home/runner/work/calcite/calcite/C:/Users/runneradmin/.gradle-cache-action/gradle-generated-jars-contents.json -

Avatica 'userAgent' connection property

2023-02-17 Thread Julian Hyde
TJ has logged a case [1] proposing to add a "userAgent" connection property to Avatica. (It would be inherited by all drivers, e.g. Calcite, that use Avatica.) The intent is that userAgent would indicate the client program. Do we need additional properties for client process ID? I know these are

Re: DDL and BABEL at the same time

2023-02-15 Thread Julian Hyde
You can compose your own parser. (Babel, Server, Core parsers use the same template with different inclusions via FMPP.) On Wed, Feb 15, 2023 at 3:58 PM Mihai Budiu wrote: > > Hello, > > I am trying to parse a DDL statement such as CREATE VIEW V AS SELECT > DATE_PART(YEAR, T) FROM TABLE. > If I

Re: 1.33.0: Possible regression in rewriting COALESCE expression.

2023-02-15 Thread Julian Hyde
I have managed to reproduce it, and have a fix. Can you assign the case to me, please? On Wed, Feb 15, 2023 at 9:22 AM Ruben Q L wrote: > Hello Max, > > Thanks for reporting this. At first glance it seems a regression, could > you please create a Jira ticket (and link it to CALCITE-5424)? > >

Re: RexExecutorImpl and RexSubQuery

2023-02-15 Thread Julian Hyde
to prevent the reducer > from attempting to reduce the subquery. Does this sound problematic and > would it be the correct fix for this? If so, I can prepare a PR and submit > it upstream. > > --Jonathan Sternberg > > On Mon, Feb 13, 2023 at 6:52 PM Julian Hyde wrote: &

[jira] [Created] (CALCITE-5529) Improve dialect tests

2023-02-14 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5529: Summary: Improve dialect tests Key: CALCITE-5529 URL: https://issues.apache.org/jira/browse/CALCITE-5529 Project: Calcite Issue Type: Bug

Re: RexExecutorImpl and RexSubQuery

2023-02-13 Thread Julian Hyde
We need to decide whether a RexSubQuery can appear inside a RexProgram. If yes, then RegisterInputShuttle should be extended to handle it, register it, and then it will become a RexLocalRef. If no, you will need to apply a rule to expand all RexSubQuery instances before the phase where you

Re: withExpand behavior with ANY/ALL subqueries

2023-02-10 Thread Julian Hyde
> It can be a notable change though for those using SqlToRelConverter as it > is so we have to at least put it in a prominent place in the release notes. > > Best, > Stamatis > > > On Fri, Feb 10, 2023 at 10:32 PM Julian Hyde wrote: > > > You should definitely log a bu

Re: withExpand behavior with ANY/ALL subqueries

2023-02-10 Thread Julian Hyde
You should definitely log a bug for this. Please do so. We would prefer that new features in SqlToRelConverter are developed with expand=false. (Rationale: Keeping subqueries as RexSubQuery expressions allows us to handle them later, via a planner rule, which makes the logic more composable and

[jira] [Created] (CALCITE-5524) JDBC adapter generates LIMIT, OFFSET in wrong order for Presto dialect

2023-02-10 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5524: Summary: JDBC adapter generates LIMIT, OFFSET in wrong order for Presto dialect Key: CALCITE-5524 URL: https://issues.apache.org/jira/browse/CALCITE-5524 Project

Re: Insert data exceeding fixed length column.

2023-02-09 Thread Julian Hyde
I agree that that query should throw when executed. If it doesn’t, you should log a bug. However, that test in SqlToRelConverterTest doesn’t prove that Calcite doesn’t throw at execute time. > On Feb 8, 2023, at 11:20 PM, stanilovsky evgeny > wrote: > > > Hello, seems sql standard

Re: RexProgram expansion and non-deterministic functions

2023-02-09 Thread Julian Hyde
I agree that expandLocalRef and expandList are broken. They should probably throw if expansion creates multiple references to non-deterministic expressions. Let’s be clear what we mean by non-deterministic. “RANDOM" and “NEXT VALUE OF ” are non-deterministic. “CURRENT_TIMESTAMP” is

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-09 Thread Julian Hyde
>> On Wed, Feb 8, 2023 at 11:28 AM Stamatis Zampetakis >>> wrote: >>> >>>> Great work Jess, thanks a lot for being the RM! >>>> >>>> On Wed, Feb 8, 2023 at 12:57 AM Jess Balint wrote: >>>> >>>>> Release is complete a

Re: Why does timestamp diff return a value inconsistent with the time unit?

2023-02-07 Thread Julian Hyde
-01 00:00:00.0 > > This happens because `-` is giving 13 months, which it then adds to 1970-01 > to get 1971-02, but TIMESTAMPDIFF gives 1 (year) which it then adds to > 1970-01 to get 1971-01 > > Thanks! > -Ian > > > > On 2023/02/07 00:33:48 Julian Hy

Re: [DISCUSS] Apache Calcite Meetup March 2023

2023-02-07 Thread Julian Hyde
tis >>> >>> >>> On Fri, Feb 3, 2023 at 5:58 PM Gavin Ray wrote: >>> >>>> Just to follow up on this, maybe the Calcite org could schedule >>>> something for March and advertise it? >>>> >>>> The

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-07 Thread Julian Hyde
When I see you push the web site updates, I’ll update reporter. Julian > On Feb 7, 2023, at 11:33 AM, Jess Balint wrote: > > I thought it would be the svn commit date mentioned above (2023-02-06). > Otherwise today works. I'm working on the site updates. > > On Tue, Feb 7, 202

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-07 Thread Julian Hyde
calcite-1.33.0-rc0 -> calcite-1.33.0 to release > area > > If you are a PMC member of this project, we ask that you log on to: > https://reporter.apache.org/addrelease.html?calcite > and add your release data (version and date) to the database. > > On Tue, Feb 7, 2023

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-07 Thread Julian Hyde
emaining steps >> (announcements etc.). >> >> Best, >> Stamatis >> >> [1] https://dlcdn.apache.org/calcite/apache-calcite-1.33.0/ >> >> >> On Tue, Feb 7, 2023 at 12:36 AM Julian Hyde >> wrote: >> >>> It looks as if

Re: Future of the Spatial Type Extension

2023-02-06 Thread Julian Hyde
. > On Feb 6, 2023, at 5:00 PM, Julian Hyde wrote: > > Similar issues have come up with non-GIS functions. For example, the DATEDIFF > function [1]. Snowflake and MSSQL have ‘DATEDIFF(timeUnit, datetime, > datetime2)’, whereas MySQL has ‘DATEDIFF(date, date2)’. We document which >

Re: Future of the Spatial Type Extension

2023-02-06 Thread Julian Hyde
Similar issues have come up with non-GIS functions. For example, the DATEDIFF function [1]. Snowflake and MSSQL have ‘DATEDIFF(timeUnit, datetime, datetime2)’, whereas MySQL has ‘DATEDIFF(date, date2)’. We document which specification we implement, and potentially we could implement both

Re: Why does timestamp diff return a value inconsistent with the time unit?

2023-02-06 Thread Julian Hyde
I ran the queries through SQLLine and got the expected results, as follows. 0: jdbc:calcite:model=core/src/test/resources> values ((TIMESTAMP '1971-01-01 00:00:00' - TIMESTAMP '1970-01-01 00:00:00') second); +--+ | EXPR$0 | +--+ |

Re: [DISCUSS] Apache Calcite Meetup March 2023

2023-02-06 Thread Julian Hyde
gt;>> Best, >>> Stamatis >>> >>> >>> On Fri, Feb 3, 2023 at 5:58 PM Gavin Ray wrote: >>> >>>> Just to follow up on this, maybe the Calcite org could schedule >> something >>>> for March and advertise it? >>&g

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-06 Thread Julian Hyde
18) >at > com.github.vlsi.gradle.release.PromoteSvnRelease.operations(PromoteSvnRelease.kt:48) >at > com.github.vlsi.gradle.release.SvnmuccTask.mucc(SvnmuccTask.kt:91) > > > > On Thu, Feb 2, 2023 at 4:03 PM Julian Hyde wrote: > >> Because w

Re: Output column names of Calc discarded by VolcanoPlanner in Calcite 2.22+

2023-02-03 Thread Julian Hyde
Thanks for citing CALCITE-1584. That pretty much is our position. Beam should not rely on field names, or base equality on field names. (Otherwise the planner will start to choke on cruft.) If you need to know where a field came from, use provenance tools like RelMdColumnOrigins. That said,

Re: [VOTE] Release Apache Calcite 1.33.0 (release candidate 0)

2023-02-03 Thread Julian Hyde
+1 (binding) Downloaded, checked NOTICE, README, LICENSE, README.md, howto.md; compared with git contents; checked headers (using rat); compiled and ran tests using OpenJDK 18 and Gradle 7.4.2 on Ubuntu Linux 5.9.0-29 x86_64. I had some comments on the PR with the release notes but they can be

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-02 Thread Julian Hyde
ocking commits? > > > On Thu, Feb 2, 2023 at 1:29 PM Jess Balint wrote: > > > Sorry for delay! I'll get the release notes PR up in a few hours. > > > > On Thu, Feb 2, 2023 at 1:28 PM Julian Hyde wrote: > > > >> Jess, > >> > >> How

Re: [DISCUSS] Towards Calcite 1.33.0

2023-02-02 Thread Julian Hyde
Jess, How long until the RC is ready for a vote? Main branch has been closed for over a week and it's hurting. Julian On 2023/01/27 23:01:16 Julian Hyde wrote: > The particular failure I was referring to was this one: > > > Task :druid:javadoc > Picked up _JAVA_OPTIONS:

[jira] [Created] (CALCITE-5508) Add constructor functions for DATE, TIME, TIMESTAMP, DATETIME

2023-01-30 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5508: Summary: Add constructor functions for DATE, TIME, TIMESTAMP, DATETIME Key: CALCITE-5508 URL: https://issues.apache.org/jira/browse/CALCITE-5508 Project: Calcite

Re: several JavaCC warnings "Choice conflict involving two expansions"

2023-01-27 Thread Julian Hyde
Good catch. Yes, we want to stay on top of these kinds of warnings. (See broken windows theory [1].) Probably introduced by https://issues.apache.org/jira/browse/CALCITE-5450. Probably missing one or two LOOKAHEAD directives in the parser. Can you log a JIRA case please. Julian [1]

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Julian Hyde
case you’ve asked for and a rather trivial fix. > https://github.com/apache/calcite/pull/3050 > > Thanks, > Moritz > > On 27.01.23, 10:00, "Moritz Mack" wrote: > > Thanks a lot, Julian. > I’ll look into that the next few days. > > /Moritz > > On 25

Re: array literal in spark dialect

2023-01-27 Thread Julian Hyde
Thanks Guillaume. We'd love a fix. I saw you logged https://issues.apache.org/jira/browse/CALCITE-5504 so let's continue the conversation there. On Fri, Jan 27, 2023 at 3:05 PM Guillaume Masse wrote: > > Array literals are unparsed incorrectly for the spark dialect. > > They should be in the

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-27 Thread Julian Hyde
09, Jess Balint wrote: > > > Thanks, will get the release notes PR up shortly. > > > > On Thu, Jan 26, 2023 at 7:29 PM Julian Hyde wrote: > > > > > I have merged a fix for CALCITE-5489. Thanks to Tanner and TJ for their > > > help. > > >

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Julian Hyde
I have merged a fix for CALCITE-5489. Thanks to Tanner and TJ for their help. There is one failure in the build, but I'm pretty sure it is intermittent and is related to CI infrastructure, not our code. Jess, Go ahead and make that RC. Julian On Thu, Jan 26, 2023 at 10:50 AM Julian Hyde

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Julian Hyde
‘…’, ’TIMESTAMP ‘…’, quarter). > On Jan 26, 2023, at 9:13 AM, Tanner Clary > wrote: > > Yes I will be putting up a PR with a fix in the next hour or so. Sorry > about the hold up! > > Tanner > > On Thu, Jan 26, 2023 at 8:09 AM Julian Hyde wrote: > >

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Julian Hyde
> >> Great, I'll start the build. Let's hold off on further commits please. >> >>> On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde wrote: >>> >>> I have merged it: >>> >>> >> https://github.com/apache/calcite/commit/20014b6c5b9b

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-25 Thread Julian Hyde
I have merged it: https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f On Wed, Jan 25, 2023 at 2:03 PM Jess Balint wrote: > > I'll merge it and then start the rc build. > > On Wed, Jan 25, 2023, 13:04 Julian Hyde wrote: > > > Oops, I have one m

Re: [DISCUSS] Apache Calcite Meetup March 2023

2023-01-25 Thread Julian Hyde
I'd be up for a meetup. I am giving a talk "Cubing and metrics in SQL, oh my!" at Data Council in Austin on Mar 29, so I could give a shorter talk on the same topic at the meetup, if people are interested. Julian [1] https://www.datacouncil.ai/talks/cubing-and-metrics-in-sql On Tue, Jan 24,

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-25 Thread Julian Hyde
Oops, I have one more PR ready to merge [1]. If the main branch is not yet closed, let me know, Jess. Julian [1] https://issues.apache.org/jira/browse/CALCITE-5283 On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde wrote: > > I agree. I merged some PRs last night (before I saw this email) but I

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-25 Thread Julian Hyde
anding reviews: >> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >> >> Do we have any final requests for PRs to be merged or should I create the >> rc build? >> >>> On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde wrote:

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-25 Thread Julian Hyde
It would seem a reasonable and useful enhancement if CheapestPlanReplacer did some memoization. If it sees the same RelNode twice it should emit the same result. I would be conservative, and memoize based on identity of the RelNodes, not just equality. It would be useful if you could come up

[jira] [Created] (CALCITE-5495) Allow WEEK and QUARTER in INTERVAL literals

2023-01-24 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5495: Summary: Allow WEEK and QUARTER in INTERVAL literals Key: CALCITE-5495 URL: https://issues.apache.org/jira/browse/CALCITE-5495 Project: Calcite Issue Type

[jira] [Created] (CALCITE-5490) Add a 'naiveMeasures' connection property to allow regular aggregate functions (e.g. SUM, MIN) to be used instead of AGGREGATE

2023-01-23 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5490: Summary: Add a 'naiveMeasures' connection property to allow regular aggregate functions (e.g. SUM, MIN) to be used instead of AGGREGATE Key: CALCITE-5490 URL: https

Re: [DISCUSS] Drop unused branches from git repos

2023-01-22 Thread Julian Hyde
+1 There’s probably a tag for each release but let’s make sure before we drop the branch. If any branch just has a ‘prepare for next iteration’ commit following the release tag I’m fine dropping that commit. Julian > On Jan 22, 2023, at 1:05 PM, Francis Chuang wrote: > > +1 for dropping

[ANNOUNCE] Apache Calcite Avatica 1.23.0 Released

2023-01-19 Thread Julian Hyde
! Julian Hyde, on behalf of the Apache Calcite team

[RESULT] [VOTE] Release Apache Calcite Avatica 1.23.0 (release candidate 0)

2023-01-19 Thread Julian Hyde
; > > > > > Gradle 7.4.2 > > > ---- > > > > > > Build time: 2022-03-31 15:25:29 UTC > > > Revision: 540473b8118064efcc264694cbcaa4b677f

Re: [ANNOUNCE] New Calcite PMC chair: Stamatis Zampetakis

2023-01-19 Thread Julian Hyde
As many of you remember, Stamatis has served as Chair before. This is the first time that Calcite has re-elected a previous Chair, and that speaks to Stamatis' excellent qualities. Stamatis' style is very similar to Ruben's style - serving the project by quietly getting things done, defusing

Re: [DISCUSS] CAST DOUBLE to BOOLEAN

2023-01-18 Thread Julian Hyde
I agree, we should not support converting (explicitly or implicitly) any numeric type to BOOLEAN. We made a mistake when we documented the conversions (the table did not match actual or intended behavior) I have just logged https://issues.apache.org/jira/browse/CALCITE-5485 to ensure that the

[jira] [Created] (CALCITE-5485) Make type conversion documentation consistent with behavior and tests

2023-01-18 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5485: Summary: Make type conversion documentation consistent with behavior and tests Key: CALCITE-5485 URL: https://issues.apache.org/jira/browse/CALCITE-5485 Project

[VOTE] Release Apache Calcite Avatica 1.23.0 (release candidate 0)

2023-01-15 Thread Julian Hyde
Hi all, I have created a build for Apache Calcite Avatica 1.23.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/avatica-1.23.0-rc0/site/_docs/history.md The commit to be voted

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-15 Thread Julian Hyde
I have created a jira case to track this release: https://issues.apache.org/jira/browse/CALCITE-5481 Also, I am proposing to make a quick Avatica 1.23 release. If the plans work out, it will be ready for inclusion in Calcite 1.33 from Thursday. Julian On 2023/01/05 20:21:03 Julian Hyde wrote

[DISCUSS] Towards Calcite-Avatica 1.23.0

2023-01-15 Thread Julian Hyde
I'm thinking of making a quick release of Avatica, so that Calcite 1.33 (which is alleged [1] to be happening soon) can be based on Avatica 1.23. (Avatica 1.22 was six months ago, and there have been about 20 bug fixes since then.) The following PRs seem ready to merge: *

[jira] [Created] (CALCITE-5481) Release Calcite 1.33.0

2023-01-15 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5481: Summary: Release Calcite 1.33.0 Key: CALCITE-5481 URL: https://issues.apache.org/jira/browse/CALCITE-5481 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-5480) Release Avatica 1.23.0

2023-01-15 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5480: Summary: Release Avatica 1.23.0 Key: CALCITE-5480 URL: https://issues.apache.org/jira/browse/CALCITE-5480 Project: Calcite Issue Type: Bug

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-12 Thread Julian Hyde
all possible warnings/code smells, but most of them > yes. Some are just fine as-is to me and they can even be considered false > positives. > > Best regards, > Alessandro > > > On Wed 11 Jan 2023, 23:17 Julian Hyde, wrote: > > > The instanceof case was complicated

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-11 Thread Julian Hyde
ematic to do comparisons by relying on the class name. >> >> I encourage others to share their thoughts/remarks as well so that we >> improve as much as possible the developer experience. >> >> Best, >> Stamatis >> >> [1] >> >> https://

Re: Push unparsed SQL select statement into RelBuilder

2023-01-09 Thread Julian Hyde
nt to use the algebra builder to construct SQL queries, but use an > unparsed/unparseable subquery as the root (as just a string). Does that > make sense? > > (obviously this subquery would be in same sql dialect as output of RelToSql) > > On Mon, Jan 9, 2023 at 4:41 PM Julian Hyde wrote

Re: Push unparsed SQL select statement into RelBuilder

2023-01-09 Thread Julian Hyde
What are you trying to achieve? If you want Calcite to understand an unparsed SQL expression then you need a SQL parser. RelBuilder is not a SQL parser. SqlParser is a SQL parser. On Mon, Jan 9, 2023 at 4:37 PM Heiko wrote: > > Say from some legacy system I get some valid select stmt, e.g.

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-09 Thread Julian Hyde
I see two false positives so far: * The message on be7135cf "58.1% Coverage on New Code (is less than 80%)" * The bug on PR 2942 "Use an "instanceof" comparison instead" Has Sonarcube had any true positives yet? Vladimir used to hate when I was skeptical of changes to the build system. But I

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-05 Thread Julian Hyde
right now and will get this in a few hours. >> I removed the fixVersion from >> https://issues.apache.org/jira/browse/CALCITE-5427 (I am working on it) >> since there is no rush to get it in 1.33.0. >> Unfortunately, I don't have time to review other things today. >>

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-04 Thread Julian Hyde
ding: >>>>>>> >>>>>>> >>>>>> >>>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.33.0%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20%22In%20Review%22%2C%20%22In%20

[jira] [Created] (CALCITE-5457) Upgrade Junit from 4 to 5

2022-12-23 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5457: Summary: Upgrade Junit from 4 to 5 Key: CALCITE-5457 URL: https://issues.apache.org/jira/browse/CALCITE-5457 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-5446) Support TIMESTAMP WITH LOCAL TIME ZONE type in JDBC driver

2022-12-19 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5446: Summary: Support TIMESTAMP WITH LOCAL TIME ZONE type in JDBC driver Key: CALCITE-5446 URL: https://issues.apache.org/jira/browse/CALCITE-5446 Project: Calcite

Re: Calcite jars with shaded guava

2022-12-11 Thread Julian Hyde
/pull/2999 and this JIRA: > https://issues.apache.org/jira/browse/CALCITE-5428. > >> On 2022/12/09 20:54:46 Julian Hyde wrote: >> I ran with '-Dguava.version=16.0.1' and it seems to just work. >> >> If you want this to be the new minimum, please create a Jira case an

Re: Calcite jars with shaded guava

2022-12-09 Thread Julian Hyde
k for us. If that doesn't work out, > I think our best remaining idea would be to build our own version of Calcite > that uses a relocated Guava. > > On 2022/12/08 20:49:17 Julian Hyde wrote: > > If it helps, it wouldn’t be impossible for Calcite to move its minimum > > Gu

Re: Calcite jars with shaded guava

2022-12-08 Thread Julian Hyde
want to > update it, so we're looking into options. There's a GitHub issue here with > our thoughts: https://github.com/apache/druid/issues/13532 > > On 2022/03/30 17:55:44 Julian Hyde wrote: >> Wow, I had no idea that anyone was on a version of Guava that old. >

[jira] [Created] (CALCITE-5424) Customize handling of literals based on type system

2022-12-07 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5424: Summary: Customize handling of literals based on type system Key: CALCITE-5424 URL: https://issues.apache.org/jira/browse/CALCITE-5424 Project: Calcite

[jira] [Created] (CALCITE-5423) Implement TIMESTAMP_DIFF function (compatible with BigQuery)

2022-12-07 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5423: Summary: Implement TIMESTAMP_DIFF function (compatible with BigQuery) Key: CALCITE-5423 URL: https://issues.apache.org/jira/browse/CALCITE-5423 Project: Calcite

Re: Proj4j license

2022-12-05 Thread Julian Hyde
Julian Hyde wrote: > > You’re not to blame. I think that the license of Proj4j is deceptive, because > use requires explicit user consent. > > I’m sure the developers of Proj4j have the best of intentions. They are > caught between a rock and a hard place: they want to provide ric

Re: Structuring SubQueries as Functions

2022-12-05 Thread Julian Hyde
inputs of correlated variables are explicitly > called out as children of the RexSubQuery, then the fields would not be > trimmed as well as being shifted correctly. > > I hope this makes it clearer what I am proposing. > > James > > > On Thu, Dec 1, 2022 at 12:01 PM Julian Hyde w

[jira] [Created] (CALCITE-5415) In ByteString, add startsWith and endsWith methods

2022-12-01 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5415: Summary: In ByteString, add startsWith and endsWith methods Key: CALCITE-5415 URL: https://issues.apache.org/jira/browse/CALCITE-5415 Project: Calcite Issue

Re: Structuring SubQueries as Functions

2022-12-01 Thread Julian Hyde
I do agree that a correlated sub-query is a function call. If you write your queries using CROSS APPLY this becomes clear. Decorrelation is very useful. Some execution engines, especially the highly parallel/distributed ones, stopping and restarting subqueries requires a lot of communication.

Re: [DISCUSS] Towards Calcite 1.33.0

2022-11-28 Thread Julian Hyde
3], there are >>> many pending issues that could / should be part of the release. I'd >> propose >>> to make a collective effort to try to clean up our 1.33 backlog and merge >>> the PRs which are in a good state. Shall we give ourselves around four >>> weeks

Re: Proj4j license

2022-11-23 Thread Julian Hyde
I wasn’t aware of this issue > with EPSG until we discussed the draft release of Apache Baremaps. > > I will make a PR to remove it and I will try to find a work around for future > releases. > > Bertil > >> On 23 Nov 2022, at 17:31, Julian Hyde w

Proj4j license

2022-11-23 Thread Julian Hyde
Bertil has logged https://issues.apache.org/jira/browse/CALCITE-5399 describing a licensing issue with the Proj4j library, which we added as a dependency in the last release. Though it describes itself as Apache licensed, it embeds a data set (EPSG) that requires the user to agree to its terms

Re: BigQuery Timestamp_Add Implementation Question

2022-11-21 Thread Julian Hyde
Tanner, I made a comment in the Jira case that I hoped that TIMESTAMP_ADD would map onto the TIMESTAMPADD function (basically just be a synonym for it) as the DATEADD function already does. TIMESTAMPADD already handles custom time frames [1]. Did you try that strategy? It’s a bit confusing

Re: [DISCUSS] State of the project 2022

2022-11-20 Thread Julian Hyde
1]. At that point, the community decided to > > have > > > an annual “state of the project” discussion, and we have arrived to that > > > time of the year. > > > > > > We have had three Calcite releases so far in 2022 [2] (many thanks to > > each > &g

Re: What is the purpose of systemFieldList inside SqlToRelConverter

2022-11-15 Thread Julian Hyde
This came up recently. See my comment in https://issues.apache.org/jira/browse/CALCITE-4362 where I talk about how "isSystemField and getRowTypeSansSystemColumns are not stubs exactly, but vestiges of a previous system”. > On Nov 15, 2022, at 1:37 AM, Dmitry Sysolyatin > wrote: > > Hello! >

Re: Adding implementations of operators for RexExecutor?

2022-11-15 Thread Julian Hyde
Ian, I don’t think anyone has done this before, but making your own executor does seem to be the right path. It’s possible that Schema does not need to be part of the solution. Schema is used for looking up operators by name, but if you already have the operators (because they are referenced

Simple dependency upgrades

2022-11-13 Thread Julian Hyde
I made some comments on https://issues.apache.org/jira/browse/CALCITE-5379 about upgrading dependency libraries in order to fix CVEs. What I said is just my opinion, but it might be construed as policy, so others should chime in if they have opinions. Julian

MEASURE type and AGGREGATE aggregate function

2022-11-09 Thread Julian Hyde
Can I get a review for https://github.com/apache/calcite/pull/2965 / https://issues.apache.org/jira/browse/CALCITE-5105? It's the first change in what is - in my opinion - a major extension to SQL, namely being able to define expressions in queries and views and have those expressions 'expand' in

Re: Missing grgit-gradle library

2022-11-08 Thread Julian Hyde
> Have not tried this personally, but gradle has some documentation [1] > > for overriding a transitive dependency. > > > > [1] > > https://docs.gradle.org/current/userguide/dependency_downgrade_and_exclude.html#sec:enforcing_dependency_version > > > > O

Re: Implementation of ORDER BY WITH FILL [INTERPOLATE]

2022-11-08 Thread Julian Hyde
at 10:00 AM, Julian Hyde wrote: > > I think of this topic in 3 areas: > > 1. how to extend SQL for interpolation; > 2. how to represent interpolation in relational algebra; > 3. how to implement the relational operator. > > Your question was mostly about

Re: [ANNOUNCE] New committer: Dmitry Sysolyatin

2022-11-08 Thread Julian Hyde
Congratulations, Dmitry! Thanks for the great work you’ve already done for the project. Julian > On Nov 8, 2022, at 10:56 AM, Alessandro Solimando > wrote: > > Congrats Dmitry, welcome to Calcite! > > On Tue 8 Nov 2022, 18:44 Ruben Q L, wrote: > >> Apache Calcite's Project Management

Re: Implementation of ORDER BY WITH FILL [INTERPOLATE]

2022-11-08 Thread Julian Hyde
I think of this topic in 3 areas: 1. how to extend SQL for interpolation; 2. how to represent interpolation in relational algebra; 3. how to implement the relational operator. Your question was mostly about 3. I think you could add a ‘fill’ or ‘interpolate’ relational operator that assumes a

Missing grgit-gradle library

2022-11-07 Thread Julian Hyde
We have started to get build errors from Avatica because we depend on version 4.0.1 of libraries grgit-gradle and grgit-core and these no longer exist in Maven Central. The oldest version in Maven Central is 4.1.1. I have logged a bug [1] and tried to make a fix [2] but apparently I don't

[jira] [Created] (CALCITE-5371) Library grgit 4.0.1 has disappeared from Maven Central

2022-11-07 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5371: Summary: Library grgit 4.0.1 has disappeared from Maven Central Key: CALCITE-5371 URL: https://issues.apache.org/jira/browse/CALCITE-5371 Project: Calcite

Re: Passing non-primitive objects between EnumerableConverter and the Queryable

2022-11-07 Thread Julian Hyde
I put info into DataContext? > 2. Is it safe to do the plan context as I have it working now and are > any of these objects safe to re-use between two queries and or threads? > 1. > CalciteSchema, RelDataTypeFactory, CalciteCatalogReader, SqlValidator > 2. I'm th

Re: Passing non-primitive objects between EnumerableConverter and the Queryable

2022-11-07 Thread Julian Hyde
The goal of Enumerable convention is to create a query plan that is Java source code. Along with that goes the idea that the plan can be run by something like a ‘public static void main’ method, where the only parameters are things you could pass from the command-line. We’re not literally that

[jira] [Created] (CALCITE-5369) In Avatica DateTimeUtils, add support for FLOOR and CEIL to ISOYEAR

2022-11-06 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5369: Summary: In Avatica DateTimeUtils, add support for FLOOR and CEIL to ISOYEAR Key: CALCITE-5369 URL: https://issues.apache.org/jira/browse/CALCITE-5369 Project

[jira] [Created] (CALCITE-5368) Automated site build should not bring changes to SQL reference

2022-11-06 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5368: Summary: Automated site build should not bring changes to SQL reference Key: CALCITE-5368 URL: https://issues.apache.org/jira/browse/CALCITE-5368 Project: Calcite

[jira] [Created] (CALCITE-5364) In materialized view substitution, use custom time frames

2022-11-02 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5364: Summary: In materialized view substitution, use custom time frames Key: CALCITE-5364 URL: https://issues.apache.org/jira/browse/CALCITE-5364 Project: Calcite

[jira] [Created] (CALCITE-5363) Move DATEADD, DATEDIFF, DATE_PART from Babel to Core parser

2022-11-02 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5363: Summary: Move DATEADD, DATEDIFF, DATE_PART from Babel to Core parser Key: CALCITE-5363 URL: https://issues.apache.org/jira/browse/CALCITE-5363 Project: Calcite

<    1   2   3   4   5   6   7   8   9   10   >