lint errors, or
>>> upgrades a component, I browse the commit log to see what commit
>>> messages people have used for similar changes.
>>>
>>> Julian
>>>
>>> On Wed, Jan 3, 2024 at 4:11 AM Benchao Li wrote:
>>>>
>>>> Th
Julian Hyde created CALCITE-6187:
Summary: Linter should disallow tags such as '[MINOR]' in commit
messages
Key: CALCITE-6187
URL: https://issues.apache.org/jira/browse/CALCITE-6187
Project: Calcite
have used for similar changes.
>>
>> Julian
>>
>> On Wed, Jan 3, 2024 at 4:11 AM Benchao Li wrote:
>>>
>>> The word [MINOR] is very coarse-grained to me, as Stamatis mentions
>>> above, it may contains small improvements to javadoc, site, test,
&
On Wed, Jan 3, 2024 at 4:11 AM Benchao Li wrote:
> >
> > The word [MINOR] is very coarse-grained to me, as Stamatis mentions
> > above, it may contains small improvements to javadoc, site, test,
> > error message, method/variable name, etc. And it is subjective to the
> > au
nvent your own. If I'm
about to make a commit that fixes a typo, or fixes lint errors, or
upgrades a component, I browse the commit log to see what commit
messages people have used for similar changes.
Julian
On Wed, Jan 3, 2024 at 4:11 AM Benchao Li wrote:
>
> The word [MINOR] is very coar
The word [MINOR] is very coarse-grained to me, as Stamatis mentions
above, it may contains small improvements to javadoc, site, test,
error message, method/variable name, etc. And it is subjective to the
author/committer whether a PR should be minor.
Looking at the git history, I found it useful
The presence of the "minor" keyword in the commit summary is a bit
redundant. I would argue that if the message is precise enough the
person reading it can infer it is minor or not.
Moreover, the minor classification is subjective. Some people consider
minor things that do not change c
t; paint to remove.
>
> Istvan
>
> On Tue, Jan 2, 2024 at 10:50 PM Tanner Clary .invalid>
> wrote:
>
> > I like the [MINOR] prefix because it makes it easy to identify simple
> > commits (via grep or ctrl+f), the same way [CALCITE-1234] makes it easy
> to
&
:
> I like the [MINOR] prefix because it makes it easy to identify simple
> commits (via grep or ctrl+f), the same way [CALCITE-1234] makes it easy to
> find commits related to [CALCITE-1234]. I also like that it maintains the
> "[...]" styling at the beginning of the commi
I like the [MINOR] prefix because it makes it easy to identify simple
commits (via grep or ctrl+f), the same way [CALCITE-1234] makes it easy to
find commits related to [CALCITE-1234]. I also like that it maintains the
"[...]" styling at the beginning of the commit message
ssion, but no standards, and therefore commit messages that
have lower information content, and more work for the release manager
coercing them into a consistent change log.
In Calcite we have not used '[MINOR]' as a prefix to minor commits. If
it is minor, it doesn't need a jira case, and doesn't need a p
Ruben Q L created CALCITE-4244:
--
Summary: Minor improvements in EnumerableBatchNestedLoopJoin cost
computation
Key: CALCITE-4244
URL: https://issues.apache.org/jira/browse/CALCITE-4244
Project: Calcite
Ruben Q L created CALCITE-3853:
--
Summary: Minor improvements in SortJoinCopyRule
Key: CALCITE-3853
URL: https://issues.apache.org/jira/browse/CALCITE-3853
Project: Calcite
Issue Type: Task
Jiatao Tao created CALCITE-3770:
---
Summary: Minor change "EnumerableCalcRel" to "EnumerableCalcRel"
Key: CALCITE-3770
URL: https://issues.apache.org/jira/browse/CALCITE-3770
Francis Chuang created CALCITE-3042:
---
Summary: Fix minor bugs in Avatica-Go docker release script
Key: CALCITE-3042
URL: https://issues.apache.org/jira/browse/CALCITE-3042
Project: Calcite
>>>>>>> Best,
>>>>>>> Jungtaek Lim (HeartSaVioR)
>>>>>>>
>>>>>>> 2016년 9월 30일 (금) 오전 3:13, Julian Hyde <jh...@apache.org>님이 작성:
>>>>>>>
>>>>>>>> +1
>>>>&g
ter branch is in good shape right now. Some good stuff has gone in
>>>>>>> since the release, but it is stable.
>>>>>>>
>>>>>>> I would ask committers to be cautious when committing to master for the
>>>
Jesus Camacho Rodriguez created CALCITE-1420:
Summary: Allow Calcite JDBC Driver minor version to be greater
than 9
Key: CALCITE-1420
URL: https://issues.apache.org/jira/browse/CALCITE-1420
would ask committers to be cautious when committing to master for the
>>>>> next few days. That is, be sure to run the test suite before committing.
>>>>> Run under both JDK 1.7 and 1.8 if practical.
>>>>>
>>>>> Julian
>>>>>
>>&
;>>>
>>>> Julian
>>>>
>>>>
>>>>> On Sep 29, 2016, at 11:00 AM, Jesus Camacho Rodriguez <
>>>> jcamachorodrig...@hortonworks.com> wrote:
>>>>>
>>>>> Hi team,
>>>>>
>>>
that prevent us from upgrading, e.g., CALCITE-1396,
>>> CALCITE-1397.
>>>>
>>>> Thus, I was thinking on starting a new release either tomorrow or
>>> beginning next week (I will be the release manager again).
>>>>
>>>> At first I was thinking about a bug fix release (1.9.1), but I discuss
>>> with Julian, and probably it makes sense to have a minor release 1.10.0
>>> with everything that went into Calcite since our last release.
>>>>
>>>> If you have any comment or you have other fixes that you want in the
>>> release, please let me know.
>>>>
>>>> Thanks,
>>>> Jesús
>>>
>>>
; some issues that prevent us from upgrading, e.g., CALCITE-1396,
>> CALCITE-1397.
>> >
>> > Thus, I was thinking on starting a new release either tomorrow or
>> beginning next week (I will be the release manager again).
>> >
>> > At first I was thinking a
, e.g., CALCITE-1396,
> CALCITE-1397.
> >
> > Thus, I was thinking on starting a new release either tomorrow or
> beginning next week (I will be the release manager again).
> >
> > At first I was thinking about a bug fix release (1.9.1), but I discuss
> with Julia
I was thinking about a bug fix release (1.9.1), but I discuss with
Julian, and probably it makes sense to have a minor release 1.10.0 with
everything that went into Calcite since our last release.
If you have any comment or you have other fixes that you want in the release,
please let me know
24 matches
Mail list logo
