RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Animesh Chaturvedi
Kelven most likely in on a flight to US and may not see this -Original Message- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Tuesday, July 23, 2013 7:36 PM To: Kelven Yang; dev@cloudstack.apache.org Subject: RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere

Re: [Proposal] Routing between guest networks in VLAN isolation method.

2013-07-24 Thread Murali Reddy
On 23/07/13 11:15 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: @David: it just only add a feature for guest network mode. If a VPC has too much tiers, maybe one VPC router is not enough. If scale is a concern with VPC router, perhaps that could be addressed. I believe users can today deploy a

Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23738 --- When I run it locally I see this: ERROR: Test Volumes limit per

Re: Automated Tests: Account Cleanup in test modules

2013-07-24 Thread Sheng Yang
About the patch I committed, in fact it's not moving. It's fixing. Because: 1. The logical reason is, currently in many cases(which I committed the patches) the account is already create per test case rather than per module. And if account is created in setUp() rather than setUpClass(), the clean

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/ --- (Updated July 24, 2013, 6:30 a.m.) Review request for cloudstack and Kishan

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Wei ZHOU
Ilya, Did you upgrade agent and systemvm.iso on host ? 2013/7/24 Musayev, Ilya imusa...@webmd.net Kelven We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-3433. After several hours of testing, even after I redeploy CPVM, I still see more errors in the logs (see below)

Re: Automated Tests: Account Cleanup in test modules

2013-07-24 Thread Prasanna Santhanam
On Tue, Jul 23, 2013 at 11:20:22PM -0700, Sheng Yang wrote: About the patch I committed, in fact it's not moving. It's fixing. Because: 1. The logical reason is, currently in many cases(which I committed the patches) the account is already create per test case rather than per module. And if

RE: New Components on JIRA

2013-07-24 Thread Animesh Chaturvedi
-Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Tuesday, July 23, 2013 9:32 PM To: dev@cloudstack.apache.org Subject: Re: New Components on JIRA On Tue, Jul 23, 2013 at 05:23:03PM +, Ram Ganesh wrote: -Original Message- From: Prasanna

[ACS42] Release Status Update: One week to code freeze

2013-07-24 Thread Animesh Chaturvedi
Folks We are now just 1 week from ACS 4.2 code freeze on 7/29. For the past 2 - 3 week there has been vibrant activity in filing and fixing issues. We have managed to contain open defects to less than 400 but blockers and critical are still in 90+. For the days remaining to code freeze,

Re: Git Push Summary

2013-07-24 Thread Isaac Chiang
Hi all, I've been working on re-factoring the dedication UI code in these days and just finished. I discussed the requirements with Pranav before. The changes are listed as following: 1. zone wizard: (JIRA ticket : https://issues.apache.org/jira/browse/CLOUDSTACK-3700) Add a

Re: Review Request 12886: Fix test case issue test_vm_life_cycle.py:test_09_expunge_vm : CLOUDSTACK-2899

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12886/#review23745 --- I think you should increase the number of expunge.workers in your

RE: Git Push Summary

2013-07-24 Thread Saksham Srivastava
Not there in 4.2? -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: Wednesday, July 24, 2013 3:12 PM To: Pranav Saxena Cc: dev@cloudstack.apache.org Subject: Re: Git Push Summary Hi all, I've been working on re-factoring the dedication UI code in these

Re: Git Push Summary

2013-07-24 Thread Pranav Saxena
Thanks Isaac for making the relevant code changes there. I think you probably committed it only to master . You would need to cherry-pick it up to asf/4.2 as well . Otherwise the changes you have made look good and in accordance with the workflow we discussed . Regards, Pranav On Wed, Jul 24,

RE: [GSOC]cannot add host with the lastest master

2013-07-24 Thread Donal Lafferty
Hi Chiradeep, Before I explore further, can I ask where StartupSecondaryStorageCommand mentioned in the defect https://issues.apache.org/jira/browse/CLOUDSTACK-3377 gets used? DL -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: 24 July 2013 6:01

RE: New Components on JIRA

2013-07-24 Thread Ram Ganesh
-Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: 24 July 2013 10:02 To: dev@cloudstack.apache.org Subject: Re: New Components on JIRA On Tue, Jul 23, 2013 at 05:23:03PM +, Ram Ganesh wrote: -Original Message- From: Prasanna Santhanam

Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/ --- Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

2013-07-24 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 24, 2013, 10:28 a.m.) Review request for cloudstack, Alena

Re: Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23746 --- Review 12896 failed the build test : FAILURE The url of build

Re: [DESIGN] Why is enum a class...

2013-07-24 Thread Daan Hoogland
Thanks Frank and John, I've been strugling with the enums in Networks.java. A discussion on those is needed I think. BroadcastDomainType seems to be a hybrid of a stable and a plugin extendible enum. It breaks my mind and my every change. regards, Daan On Tue, Jul 23, 2013 at 8:37 PM, Frank

Review Board/Jenkins

2013-07-24 Thread Ian Duffy
Hi, I uploaded a patch to review board for a specific branch, ldapplugin. Jenkins attempted to take the patch and apply it to master, resulting in a failed result. https://reviews.apache.org/r/12896/ http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/29/console

[DISCUSS} enums in Networks,.java

2013-07-24 Thread Daan Hoogland
there has been some discussion on the proper use of enums recently. I've been strugling with the enums in Networks.java. A discussion on those is needed I think. BroadcastDomainType seems to be a hybrid of a stable and a plugin extendible enum. It breaks my mind and my every change. There are

Re: Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Ian Duffy
On July 24, 2013, 10:30 a.m., Jenkins Cloudstack.org wrote: Review 12896 failed the build test : FAILURE The url of build cloudstack-master-with-patch #29 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/29/ Jenkins attempted to patch master... patch is for ldapplugin

Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

2013-07-24 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/ --- (Updated July 24, 2013, 10:53 a.m.) Review request for cloudstack, Alena

RE: [GSOC]cannot add host with the lastest master

2013-07-24 Thread Donal Lafferty
I had an offline conversation with Chiradeep to sort this out. Provided the latest SystemVM code is built, there's no difficulty. E.g. using mvn clean install -P developer,systemvm See https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+on+master+branch That said, our

Re: Review Request 12858: CLOUDSTACK-3724: Test case test_vpc_vms_deployment.py failed to find network offering.

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12858/#review23749 --- Commit 2b8f1bde8f8e3c399baf44695c10866798e1fe45 in branch

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23748 --- Commit b8a38ca7bd866db32dba644f8fc1be5d3406e16c in branch

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23751 --- Commit 4a7f5d59d6f77fdeb5623937f4efa2542f891573 in branch

Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23753 --- Commit 605a31eb70e8998b4476ffadf2514c969b83f7d7 in branch

Re: Review Request 12858: CLOUDSTACK-3724: Test case test_vpc_vms_deployment.py failed to find network offering.

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12858/#review23752 --- Commit 74ac8575b09427c7511272bdd6592df092b55112 in branch

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

2013-07-24 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23754 --- Review 12897 PASSED the build test The url of build

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

2013-07-24 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/ --- (Updated July 24, 2013, 11:43 a.m.) Review request for cloudstack, Abhinandan

Review Request 12899: CLOUDSTACK-702: Tests for Multiple IP Ranges

2013-07-24 Thread sanjeev n
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12899/ --- Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.

Re: [DESIGN] Why is enum a class...

2013-07-24 Thread John Burwell
Daan and Frank, First, I think its important to separate when and where an enumeration should be used from how to best employ enums when their use is appropriate. Enums are a finite set of values defined at compile-time. Therefore, they shouldn't employed in situations where extensibility of

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23756 --- Commit 2b9d9cf0360b22a703f27600292f22711f51c62f in branch

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23757 --- Commit 135a2e66c565044b6597e9178c3cf3d544712cca in branch

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23760 --- Ship it! commit d89115b5cff9013c917c8d2e984c596698389cfe - Kishan

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23758 --- Commit 743d35cae4985a8d898da06e5768ae282b32adb2 in branch

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23759 --- Commit d89115b5cff9013c917c8d2e984c596698389cfe in branch

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23761 --- Ship it! commit 743d35cae4985a8d898da06e5768ae282b32adb2 - Kishan

Re: Review Request 12898: CLOUDSTACK-3544: Xen 6.2 hosts are tagged with Xen 6.1.

2013-07-24 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12898/#review23762 --- Review 12898 PASSED the build test The url of build

Re: [DESIGN] Why is enum a class...

2013-07-24 Thread Daan Hoogland
And as an example: the way the net should be isolated or the broadcast should be constructed are typically behavioral issues, whilst the fact that it is being used for storage or private network or routing can be caught in a constant/enum value. right? On Wed, Jul 24, 2013 at 2:37 PM, John

Re: Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23763 --- Ship it! Ship It! - Abhinandan Prateek On July 24, 2013, 10:26

Re: Review Request 12775: Migrate the dozens of ssh calls for KVM VmDataCommand to a single router command

2013-07-24 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12775/#review23764 --- Ship it! So it took me some time to get around reviewing this, but

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Musayev, Ilya
Wei. Yes, I recreated the systemvms by destroying them. I have no agents, if you mean KVM/Xen agents, I'm running vSphere. Regards Ilya -Original Message- From: Wei ZHOU [mailto:ustcweiz...@gmail.com] Sent: Wednesday, July 24, 2013 2:37 AM To: dev@cloudstack.apache.org Subject:

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23765 --- Ship it! Ship It! - Prasanna Santhanam On July 24, 2013, 10:51

Re: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/#review23766 --- I think you forgot to attach the diff here. - Prasanna Santhanam

Re: [rant] stupid test cases

2013-07-24 Thread Prasanna Santhanam
On Tue, Jul 23, 2013 at 06:12:31PM +, Mathias Mullins wrote: Prasanna, If we broke these tests down into smaller test specific test cases, could we automate them into one specific end-to-end test together? I think this is called 'sequencing'. You have a bunch of individual operations

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Wido den Hollander
Hi, I reverted this commit in the 4.1 branch: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a069f31f51d0ef1f255d85ef32d7649a5ec659c1 There has been no discussion about changing this API in the 4.1 series, I even think we can't simply do that for 4.2 either. You

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

2013-07-24 Thread Mathias Mullins
Noah, Did you ever review / report / re-vote this? Thanks, Matt On 6/25/13 11:17 AM, Noah Slater nsla...@apache.org wrote: Thanks for the feedback, Matt. Anyone else got any feedback on this? Might cut a new vote. On 24 June 2013 05:12, Mathias Mullins mathias.mull...@citrix.com wrote:

Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12853/#review23771 --- There is no bug in current Java code, and the java part of this

RE: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Sowmya Krishnan
RB doesn’t accept the patch. Keeps failing. Here's the patch: From 02238e6903d3d399d402886513efd6cd2664696a Mon Sep 17 00:00:00 2001 From: Sowmya Krishnan sowmya.krish...@citrix.com Date: Tue, 23 Jul 2013 22:29:10 +0530 Subject: [PATCH] Add wait while Netscaler recognizes service to be up ---

Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.

2013-07-24 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/ --- (Updated July 24, 2013, 5:12 p.m.) Review request for cloudstack and Prasanna

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Marcus Sorensen
Yes, definitely shouldn't be a 4.1.x change. I don't think we want people to have to go through major pains on a minor point release unless there's some major showstopper bug. 4.2, I don't know. I was always under the impression that going from 4.x to 4.y WAS a major release, per the versioning

RE: [GSOC]cannot add host with the lastest master

2013-07-24 Thread Han,Meng
Thank you all guys! If I am understanding this correctly, using mvn clean install -P developer,systemvm will build the latest management server and systemvm code. This latest management server is using fully qualified class name which requires the latest agent and system vm template to work

Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Sanjay Tripathi
On July 24, 2013, 5:02 p.m., Alena Prokharchyk wrote: There is no bug in current Java code, and the java part of this review ticket shouldn't be checked in. In the method cleanupDomain(), we try to remove every account before checking if accounts marked for cleanup, exist.

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

2013-07-24 Thread Noah Slater
Nope. Sorry. Feel free to run with it. If not, I can see about doing another vote in the next few days. On 24 July 2013 18:02, Mathias Mullins mathias.mull...@citrix.com wrote: Noah, Did you ever review / report / re-vote this? Thanks, Matt On 6/25/13 11:17 AM, Noah Slater

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Alex Huang
You can look at the code yourself and see if it's any different than what we copied. http://grepcode.com/file/repo1.maven.org/maven2/org.kuali.rice/rice-impl/1.0.3.1-BX/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java --Alex -Original Message- From: Amogh

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Alex Huang
It's only two files and they were not that huge if I recall correctly from my quick glance. --Alex -Original Message- From: Alex Huang Sent: Wednesday, July 24, 2013 10:22 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar You can look at

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Koushik Das
For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Amogh Vasekar
Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go

Re: [DISCUSS] Bylaw changes for new committer / new PMC member votes

2013-07-24 Thread Mathias Mullins
So I'm not even a committer yet, but this is an idea on how I think I would want to be voted in. For Committer - 2/3 Lazy This makes sure that at least 2 people basically nominated, and seconded and the votes were 2:1 in favor of the person coming in. For PMC - 3/4 Lazy This is the leadership of

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

2013-07-24 Thread Mathias Mullins
I'm not a committer so I don't want really to take this one on the Bylaws side. :-) Matt On 7/24/13 1:19 PM, Noah Slater nsla...@apache.org wrote: Nope. Sorry. Feel free to run with it. If not, I can see about doing another vote in the next few days. On 24 July 2013 18:02, Mathias Mullins

RE: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Sanjay Tripathi
Can you rebase your branch and try to create a new patch; file that you modified might have got updated. --Sanjay -Original Message- From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com] Sent: Wednesday, July 24, 2013 10:37 PM To: dev@cloudstack.apache.org; Prasanna Santhanam

Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23776 --- Commit 5009d3b82af4fa385490517185d071e1326cffaa in branch

Re: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Prasanna Santhanam
Actually I just applied it. So it's okay. On Wed, Jul 24, 2013 at 05:34:27PM +, Sanjay Tripathi wrote: Can you rebase your branch and try to create a new patch; file that you modified might have got updated. --Sanjay -Original Message- From: Sowmya Krishnan

Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Alena Prokharchyk
The resources of those accounts might not be removed yet. Removing the domain while these resources are still present, will introduce tons of NPEs when we try to access the domain info for them. So removing the domain should be done only after all the accounts are removed. -Alena. From: Sanjay

Re: Review Request 12723: test for Script

2013-07-24 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12723/ --- (Updated July 24, 2013, 5:42 p.m.) Review request for cloudstack and Prasanna

Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command

2013-07-24 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- Review request for cloudstack and Sheng Yang. Bugs: Cloudstack-3753

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Musayev, Ilya
Speaking of system vm upgrades, would you how to force an upgrade without recreating the vm? Thinking worse case would be to mount systemvm.iso and execute one of the init.d scripts, but not certain. We should not have to recreate system vms, in order for them to get new code. -Original

Review Request 12907: WIP: Add LDAP Account addition UI. Feedback and Help wanted.

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12907/ --- Review request for cloudstack, Abhinandan Prateek, Brian Federle, Jessica Wang,

Re: Review Request 12907: WIP: Add LDAP Account addition UI. Feedback and Help wanted.

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12907/ --- (Updated July 24, 2013, 5:52 p.m.) Review request for cloudstack, Abhinandan

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
No it's not. I used to use commons-httpclient-contrib jar, it's separate -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in

RE: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Sanjay Tripathi
Its correct that there is the possibility that resource of these accounts might not be removed; but if we take the same scenario with deleteAccount API, where we always return true as success response irrespective of the resources (except project) are still attached to this account or not. If

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the

RE: DNS Network Domain

2013-07-24 Thread Soheil Eizadi
Thanks, it will have to be part of a bigger change to also change the UI to update the Network when the Zone DNS Domain is updated. -Soheil From: Chiradeep Vittal [chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:56 PM To:

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Chip Childers
Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original

RE: [VOTE] Apache Cloudstack 4.1.1

2013-07-24 Thread Musayev, Ilya
+1, I did QA of 4.1.1 to best of my abilities. -Original Message- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Wednesday, July 24, 2013 1:23 PM To: dev@cloudstack.apache.org Subject: [VOTE] Apache Cloudstack 4.1.1 Hi All, I've created a 4.1.1 release, with the

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Marcus Sorensen
It's going to be different for various things, depending on what is being changed. Is it a conf for a service, that will need to be restarted? Or the cloud-early-config init script itself, requiring a reboot? Internally, we've written a plugin (upgradeRouterScripts routerid=) that copies the

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
Amogh has checked it's Apache 2. I am not sure if any process we need to go through -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 11:24 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib

Re: DNS Network Domain

2013-07-24 Thread Alena Prokharchyk
Soheil, About network domain update. Changing network domain on the zone/account/domain/global level, will affect newly created networks only. It should stay this way. Once the network domain is determined and set for the network (during the network creation), it can be changed just by

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

2013-07-24 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779 --- Ship it! Nice work!

Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

2013-07-24 Thread Rayees Namathponnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12912/ --- Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Chip Childers
We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for. I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-07-24 Thread Daan Hoogland
Ok, I don't like changing this enum. I'd rather throw it out and start over but you are answering the question by sharing your views on school of programming, i think. BroadcastDomainType by its name implies it could be unknown but never undecided. Do you agree? I can comply with any school. Op

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-07-24 Thread Alex Huang
Daan, Agreed. If it's unknown, the variable of that type can just be null which is an accepted practice for saying the business logic hasn't determined the value yet. --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, July 24, 2013 12:41 PM To: Alex Huang Cc:

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command

2013-07-24 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 8:02 p.m.) Review request for cloudstack and Sheng

KVM devs - notice for 4.2+

2013-07-24 Thread Marcus Sorensen
FYI, I just pushed a patch that contains a new router script. Existing routers in existing KVM dev environments will need to be rebooted after you pull this in.

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
Thanks Chip. Let me know once you done so I can get Amogh's patch in -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 12:19 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar We just

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Amogh Vasekar
Hi, The files are currently in : http://bit.ly/18Ae7zH Thanks, Amogh On 7/24/13 1:22 PM, Chip Childers chip.child...@sungard.com wrote: I don't think you need to wait. I actually need the files in the repo to pick up on them anyway for the docs. On Wed, Jul 24, 2013 at 08:13:59PM +,

Re: Automated Tests: Account Cleanup in test modules

2013-07-24 Thread Sheng Yang
On Tue, Jul 23, 2013 at 11:54 PM, Prasanna Santhanam t...@apache.org wrote: On Tue, Jul 23, 2013 at 11:20:22PM -0700, Sheng Yang wrote: About the patch I committed, in fact it's not moving. It's fixing. Because: 1. The logical reason is, currently in many cases(which I committed the

Re: Review Request 12877: Support HTTP to HTTPS redirect for UCS

2013-07-24 Thread Frank Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12877/#review23782 --- Ship it! shipped in both 4.2/master - Frank Zhang On July 23,

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Chip Childers
Right, that's what I thought. Frank, what were you saying you were waiting for? On Wed, Jul 24, 2013 at 08:38:36PM +, Amogh Vasekar wrote: Hi, The files are currently in : http://bit.ly/18Ae7zH Thanks, Amogh On 7/24/13 1:22 PM, Chip Childers chip.child...@sungard.com wrote: I

Re: Review Request 12242: CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12242/#review23783 --- Commit d09a088093568f167921597825110d5517ac535b in branch

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
No. I have checked in the patch -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 1:46 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Right, that's what I thought. Frank, what were

Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone

2013-07-24 Thread Soheil Eizadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/#review23785 --- After thinking about this some more I think a better way to fix

Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone

2013-07-24 Thread Soheil Eizadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/#review23786 --- After thinking about this some more I think a better way to fix

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

2013-07-24 Thread Sheng Yang
On July 24, 2013, 6:50 p.m., Sheng Yang wrote: Nice work! Fixed version pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command

2013-07-24 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 9:57 p.m.) Review request for cloudstack, Alena

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command

2013-07-24 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review23793 --- 1) Bharat, can you please check if your API allows you to set the

  1   2   >