Re: Review Request 12934: Tests for egress firewall rules for advance zone

2013-07-24 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/#review23820 --- test/integration/component/test_egress_fw_rules.py

Re: CallContexts?

2013-07-24 Thread Chiradeep Vittal
I can confirm this serious bug on master. On 7/18/13 1:55 PM, "Prasanna Santhanam" wrote: >On Thu, Jul 18, 2013 at 11:58:30AM +0530, Prasanna Santhanam wrote: >> I see the following repeated lines with API calls on master code >> lately: What's the call context? and what's the role? >> >> 2013-

Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.

2013-07-24 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12759/ --- (Updated July 25, 2013, 6:05 a.m.) Review request for cloudstack, Abhinandan Pr

Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare

2013-07-24 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/ --- Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-3779 Reposito

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

2013-07-24 Thread Bharat Kumar
Thank you Sheng. Bharat. On Jul 25, 2013, at 12:20 AM, Sheng Yang mailto:sh...@yasker.org>> wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ Ship it! Nice work! patches/systemvm/debian/config/root/dnsmasq.sh

Re: Automated Tests: Account Cleanup in test modules

2013-07-24 Thread Prasanna Santhanam
On Wed, Jul 24, 2013 at 01:45:13PM -0700, Sheng Yang wrote: > On Tue, Jul 23, 2013 at 11:54 PM, Prasanna Santhanam wrote: > > > On Tue, Jul 23, 2013 at 11:20:22PM -0700, Sheng Yang wrote: > > > About the patch I committed, in fact it's not moving. It's fixing. > > > Because: > > > 1. The logical

[ACS42] Resolved Defect Closure

2013-07-24 Thread Sudha Ponnaganti
Hi, Below are the resolved defects that need to be verified and closed. I have included reporter name so they can verify the issue they have reported. As we are getting closer to the release, pl confirm that fix is working fine for the issue you have reported. Reporter Total Abh

Re: Review Request 12913: Fix map based APIs in CloudMonkey

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12913/ --- (Updated July 25, 2013, 4:52 a.m.) Review request for cloudstack and Rohit Yada

Re: Review Request 12934: Tests for egress firewall rules for advance zone

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/ --- (Updated July 25, 2013, 4:39 a.m.) Review request for cloudstack, Girish Shilam

Review Request 12934: Tests for egress firewall rules for advance zone

2013-07-24 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/ --- Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Reposit

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

2013-07-24 Thread Bharat Kumar
Hi Alena, The code as of now works with a valn siting having ranges separated by semicolons(it is like this now 2001-2003;2012-2013, I will update it to work with comas. rather than compare each range with the existing one we have used sets to figure out what to add and and what to remove. On

Re: Review Request 12025: CLOUDSTACK-2304 [ZWPS]NPE while migrating volume from one zone wide primary to another

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12025/#review23815 --- Commit 80ac885e22b19dc2f7a0a9ba8b02b0911f32a9f3 in branch refs/heads

Re: Review Request 12025: CLOUDSTACK-2304 [ZWPS]NPE while migrating volume from one zone wide primary to another

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12025/#review23811 --- Commit ca474d0e09f772cb22abf2802a308a2da5351592 in branch refs/heads

[ACS42] BVTs - VMWare advanced zone

2013-07-24 Thread Sudha Ponnaganti
We are lagging behind on pass rates compared to Xen and KVM BVTs. Below are the defects which cause majority of the failures https://issues.apache.org/jira/browse/CLOUDSTACK-3568 https://issues.apache.org/jira/browse/CLOUDSTACK-3168 https://issues.apache.org/jira/browse/CLOUDSTACK-3792 https://iss

Re: Git Push Summary

2013-07-24 Thread Isaac Chiang
Hi, I've cherry-picked these two commits into 4.2 branch. Thanks Isaac On Wed, Jul 24, 2013 at 5:48 PM, Saksham Srivastava < saksham.srivast...@citrix.com> wrote: > Not there in 4.2? > > -Original Message- > From: Isaac Chiang [mailto:isaacchi...@gmail.com] > Sent: Wednesday, July

[ACS42]BVTs - Automated Test results Xen 6.1 Advanced zone

2013-07-24 Thread Sudha Ponnaganti
This week BVT runs for Xen also showed higher pass rates > 95%. As community is fixing issues, hope we can reach 100% soon. Package FailedPassed SkippedTotal 1 0 0 1 :setup integration.smoke.test_affinity_gr

[ACS 42] BVTs - KVM Advanced and Basiz Zone Automnated test results

2013-07-24 Thread Sudha Ponnaganti
Hi, We are at a stage that BVTs are passing at high %age and below are the test results. I have posted results early on but we were at a very low %ages and did not post it even though we are running them on weekly basis on 4.2 code base. But here are the results as these are a little easy to co

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

2013-07-24 Thread Noah Slater
Everyone is free to propose changes to the by-laws. If you want to make a patch and call a vote on it, by all means, go ahead. :) That sot of stuff is a good way to become a committer in the first place. ;) On 24 July 2013 18:34, Mathias Mullins wrote: > I'm not a committer so I don't want rea

Re: Review Request 12928: update midterm review

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12928/ --- (Updated July 24, 2013, 11:14 p.m.) Review request for cloudstack, Abhinandan P

Re: Review Request 12928: update midterm review

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12928/ --- (Updated July 24, 2013, 11:06 p.m.) Review request for cloudstack, Abhinandan P

Review Request 12928: update midterm review

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12928/ --- Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repos

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

2013-07-24 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review23793 --- 1) Bharat, can you please check if your API allows you to set the vn

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

2013-07-24 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 9:57 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

2013-07-24 Thread Sheng Yang
> On July 24, 2013, 6:50 p.m., Sheng Yang wrote: > > Nice work! Fixed version pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779

Re: [DISCUSS] Upgrade path to ACS 4.2 from CCP

2013-07-24 Thread Alena Prokharchyk
The code is committed to master/4.2 branch with commit f1706e2c4bec158670b229b420229732cabc966e. -alena. From: Alena Prokharchyk mailto:alena.prokharc...@citrix.com>> Date: Tuesday, July 23, 2013 11:42 AM To: "dev@cloudstack.apache.org" mailto:dev@cloudstack.a

Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone

2013-07-24 Thread Soheil Eizadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/#review23786 --- After thinking about this some more I think a better way to fix this

Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone

2013-07-24 Thread Soheil Eizadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/#review23785 --- After thinking about this some more I think a better way to fix this

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
No. I have checked in the patch > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Wednesday, July 24, 2013 1:46 PM > To: dev@cloudstack.apache.org > Subject: Re: Inclusion of commons-httpclient-contrib jar > > Right, that's what I thought. Frank, what

Re: Review Request 12242: CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12242/#review23783 --- Commit d09a088093568f167921597825110d5517ac535b in branch refs/heads

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Chip Childers
Right, that's what I thought. Frank, what were you saying you were waiting for? On Wed, Jul 24, 2013 at 08:38:36PM +, Amogh Vasekar wrote: > Hi, > > The files are currently in : http://bit.ly/18Ae7zH > > Thanks, > Amogh > > On 7/24/13 1:22 PM, "Chip Childers" wrote: > > >I don't think yo

Re: Review Request 12877: Support HTTP to HTTPS redirect for UCS

2013-07-24 Thread Frank Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12877/#review23782 --- Ship it! shipped in both 4.2/master - Frank Zhang On July 23, 20

Re: Automated Tests: Account Cleanup in test modules

2013-07-24 Thread Sheng Yang
On Tue, Jul 23, 2013 at 11:54 PM, Prasanna Santhanam wrote: > On Tue, Jul 23, 2013 at 11:20:22PM -0700, Sheng Yang wrote: > > About the patch I committed, in fact it's not moving. It's fixing. > Because: > > 1. The logical reason is, currently in many cases(which I committed the > > patches) the

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Amogh Vasekar
Hi, The files are currently in : http://bit.ly/18Ae7zH Thanks, Amogh On 7/24/13 1:22 PM, "Chip Childers" wrote: >I don't think you need to wait. I actually need the files in the repo >to pick up on them anyway for the docs. > > >On Wed, Jul 24, 2013 at 08:13:59PM +, Frank Zhang wrote: >>

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Chip Childers
I don't think you need to wait. I actually need the files in the repo to pick up on them anyway for the docs. On Wed, Jul 24, 2013 at 08:13:59PM +, Frank Zhang wrote: > Thanks Chip. Let me know once you done so I can get Amogh's patch in > > > -Original Message- > > From: Chip Child

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
Thanks Chip. Let me know once you done so I can get Amogh's patch in > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Wednesday, July 24, 2013 12:19 PM > To: > Subject: Re: Inclusion of commons-httpclient-contrib jar > > We just need to include it in

KVM devs - notice for 4.2+

2013-07-24 Thread Marcus Sorensen
FYI, I just pushed a patch that contains a new router script. Existing routers in existing KVM dev environments will need to be rebooted after you pull this in.

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

2013-07-24 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 8:02 p.m.) Review request for cloudstack and Sheng Yang

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-07-24 Thread Alex Huang
Daan, Agreed. If it's unknown, the variable of that type can just be null which is an accepted practice for saying the business logic hasn't determined the value yet. --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, July 24, 2013 12:41 PM To: Alex Huang Cc: cloudst

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-07-24 Thread Daan Hoogland
Ok, I don't like changing this enum. I'd rather throw it out and start over but you are answering the question by sharing your views on school of programming, i think. BroadcastDomainType by its name implies it could be unknown but never undecided. Do you agree? I can comply with any school. Op 24

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Chip Childers
We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for. I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang wrote: > Amogh ha

Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

2013-07-24 Thread Rayees Namathponnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12912/ --- Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Holland

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

2013-07-24 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779 --- Ship it! Nice work! patches/systemvm/debian/config/root/dnsmasq.s

Re: DNS Network Domain

2013-07-24 Thread Alena Prokharchyk
Soheil, About network domain update. Changing network domain on the zone/account/domain/global level, will affect newly created networks only. It should stay this way. Once the network domain is determined and set for the network (during the network creation), it can be changed just by modifyin

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
Amogh has checked it's Apache 2. I am not sure if any process we need to go through > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Wednesday, July 24, 2013 11:24 AM > To: dev@cloudstack.apache.org > Subject: Re: Inclusion of commons-httpclient-contr

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Marcus Sorensen
It's going to be different for various things, depending on what is being changed. Is it a conf for a service, that will need to be restarted? Or the cloud-early-config init script itself, requiring a reboot? Internally, we've written a plugin (upgradeRouterScripts routerid=) that copies the cloud

RE: [VOTE] Apache Cloudstack 4.1.1

2013-07-24 Thread Musayev, Ilya
+1, I did QA of 4.1.1 to best of my abilities. > -Original Message- > From: Musayev, Ilya [mailto:imusa...@webmd.net] > Sent: Wednesday, July 24, 2013 1:23 PM > To: dev@cloudstack.apache.org > Subject: [VOTE] Apache Cloudstack 4.1.1 > > Hi All, > > I've created a 4.1.1 release, with the

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Chip Childers
Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: > Agree. Amogh actually has done it in cloud-utils > > > -Original Message-

RE: DNS Network Domain

2013-07-24 Thread Soheil Eizadi
Thanks, it will have to be part of a bigger change to also change the UI to update the Network when the Zone DNS Domain is updated. -Soheil From: Chiradeep Vittal [chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:56 PM To: dev@cloudstack.apache.o

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
Agree. Amogh actually has done it in cloud-utils > -Original Message- > From: Koushik Das [mailto:koushik@citrix.com] > Sent: Wednesday, July 24, 2013 10:26 AM > To: dev@cloudstack.apache.org > Subject: RE: Inclusion of commons-httpclient-contrib jar > > For now I think cloud-utils is

RE: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Sanjay Tripathi
Its correct that there is the possibility that resource of these accounts might not be removed; but if we take the same scenario with deleteAccount API, where we always return true as success response irrespective of the resources (except project) are still attached to this account or not. If th

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Frank Zhang
No it's not. I used to use commons-httpclient-contrib jar, it's separate > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Tuesday, July 23, 2013 10:25 PM > To: dev@cloudstack.apache.org > Subject: RE: Inclusion of commons-httpclient-contrib jar > > Isn't thi

Re: Review Request 12907: WIP: Add LDAP Account addition UI. Feedback and Help wanted.

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12907/ --- (Updated July 24, 2013, 5:52 p.m.) Review request for cloudstack, Abhinandan Pr

Review Request 12907: WIP: Add LDAP Account addition UI. Feedback and Help wanted.

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12907/ --- Review request for cloudstack, Abhinandan Prateek, Brian Federle, Jessica Wang,

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Musayev, Ilya
Speaking of system vm upgrades, would you how to force an upgrade without recreating the vm? Thinking worse case would be to mount systemvm.iso and execute one of the init.d scripts, but not certain. We should not have to recreate system vms, in order for them to get new code. > -Original

Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

2013-07-24 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- Review request for cloudstack and Sheng Yang. Bugs: Cloudstack-3753 Repositor

Re: Review Request 12723: test for Script

2013-07-24 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12723/ --- (Updated July 24, 2013, 5:42 p.m.) Review request for cloudstack and Prasanna S

Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Alena Prokharchyk
The resources of those accounts might not be removed yet. Removing the domain while these resources are still present, will introduce tons of NPEs when we try to access the domain info for them. So removing the domain should be done only after all the accounts are removed. -Alena. From: Sanjay

Re: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Prasanna Santhanam
Actually I just applied it. So it's okay. On Wed, Jul 24, 2013 at 05:34:27PM +, Sanjay Tripathi wrote: > Can you rebase your branch and try to create a new patch; file that you > modified might have got updated. > > --Sanjay > > > -Original Message- > > From: Sowmya Krishnan [mailto

Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23776 --- Commit 5009d3b82af4fa385490517185d071e1326cffaa in branch refs/heads

Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23775 --- Commit cd51303f2086fc1fe6d21495c9514ef59450ea0d in branch refs/heads

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

2013-07-24 Thread Mathias Mullins
I'm not a committer so I don't want really to take this one on the Bylaws side. :-) Matt On 7/24/13 1:19 PM, "Noah Slater" wrote: >Nope. Sorry. Feel free to run with it. If not, I can see about doing >another vote in the next few days. > > >On 24 July 2013 18:02, Mathias Mullins wrote: > >>

RE: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Sanjay Tripathi
Can you rebase your branch and try to create a new patch; file that you modified might have got updated. --Sanjay > -Original Message- > From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com] > Sent: Wednesday, July 24, 2013 10:37 PM > To: dev@cloudstack.apache.org; Prasanna Santhanam

Re: [DISCUSS] Bylaw changes for new committer / new PMC member votes

2013-07-24 Thread Mathias Mullins
So I'm not even a committer yet, but this is an idea on how I think I would want to be voted in. For Committer - 2/3 Lazy This makes sure that at least 2 people basically nominated, and seconded and the votes were 2:1 in favor of the person coming in. For PMC - 3/4 Lazy This is the leadership of

Re: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Amogh Vasekar
Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : "Warning: not-yet-commons-ssl-0.3.11 should be considered to be of "Alpha" quality!" I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should g

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Koushik Das
For now I think cloud-utils is the best option. > -Original Message- > From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] > Sent: Wednesday, July 24, 2013 10:48 PM > To: dev@cloudstack.apache.org > Subject: Re: Inclusion of commons-httpclient-contrib jar > > Hi Alex, > > Thanks! I had

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Alex Huang
It's only two files and they were not that huge if I recall correctly from my quick glance. --Alex > -Original Message- > From: Alex Huang > Sent: Wednesday, July 24, 2013 10:22 AM > To: dev@cloudstack.apache.org > Subject: RE: Inclusion of commons-httpclient-contrib jar > > You can loo

[VOTE] Apache Cloudstack 4.1.1

2013-07-24 Thread Musayev, Ilya
Hi All, I've created a 4.1.1 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1 Commit: 8fe3505cba45756a51e9e9ee97cd09bf1e71c79e Source release (checksums and signatures are available

RE: Inclusion of commons-httpclient-contrib jar

2013-07-24 Thread Alex Huang
You can look at the code yourself and see if it's any different than what we copied. http://grepcode.com/file/repo1.maven.org/maven2/org.kuali.rice/rice-impl/1.0.3.1-BX/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java --Alex > -Original Message- > From: Amogh

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

2013-07-24 Thread Noah Slater
Nope. Sorry. Feel free to run with it. If not, I can see about doing another vote in the next few days. On 24 July 2013 18:02, Mathias Mullins wrote: > Noah, > > Did you ever review / report / re-vote this? > > Thanks, > Matt > > > On 6/25/13 11:17 AM, "Noah Slater" wrote: > > >Thanks for the

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-07-24 Thread Alex Huang
Daan, Sorry for the late reply. Now, it kinda goes into code/design philosophy. I'll tell you what mine is. There's one school of thought that code should cover all bases. To me having undecided is in that school because it asks "could it be undecided" and the answer is of course yes becaus

Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Sanjay Tripathi
> On July 24, 2013, 5:02 p.m., Alena Prokharchyk wrote: > > There is no bug in current Java code, and the java part of this review > > ticket shouldn't be checked in. > > > > > > In the method cleanupDomain(), we try to remove every account before > > checking if accounts marked for cleanup,

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Marcus Sorensen
Yes, definitely shouldn't be a 4.1.x change. I don't think we want people to have to go through major pains on a minor point release unless there's some major showstopper bug. 4.2, I don't know. I was always under the impression that going from 4.x to 4.y WAS a major release, per the versioning st

RE: [GSOC]cannot add host with the lastest master

2013-07-24 Thread Han,Meng
Thank you all guys! If I am understanding this correctly, using "mvn clean install -P developer,systemvm" will build the latest management server and systemvm code. This latest management server is using fully qualified class name which requires the latest agent and system vm template to work

Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.

2013-07-24 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/ --- (Updated July 24, 2013, 5:12 p.m.) Review request for cloudstack and Prasanna S

RE: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Sowmya Krishnan
RB doesn’t accept the patch. Keeps failing. Here's the patch: From 02238e6903d3d399d402886513efd6cd2664696a Mon Sep 17 00:00:00 2001 From: Sowmya Krishnan Date: Tue, 23 Jul 2013 22:29:10 +0530 Subject: [PATCH] Add wait while Netscaler recognizes service to be up --- test/integration/component/t

Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.

2013-07-24 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12853/#review23771 --- There is no bug in current Java code, and the java part of this revi

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

2013-07-24 Thread Mathias Mullins
Noah, Did you ever review / report / re-vote this? Thanks, Matt On 6/25/13 11:17 AM, "Noah Slater" wrote: >Thanks for the feedback, Matt. > >Anyone else got any feedback on this? Might cut a new vote. > > >On 24 June 2013 05:12, Mathias Mullins wrote: > >> Noah, >> >> I agree that there ne

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Wido den Hollander
Hi, I reverted this commit in the 4.1 branch: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a069f31f51d0ef1f255d85ef32d7649a5ec659c1 There has been no discussion about changing this API in the 4.1 series, I even think we can't simply do that for 4.2 either. You CAN

Re: [rant] stupid test cases

2013-07-24 Thread Prasanna Santhanam
On Tue, Jul 23, 2013 at 06:12:31PM +, Mathias Mullins wrote: > Prasanna, > > If we broke these tests down into smaller test specific test cases, could > we automate them into one specific end-to-end test together? I think this is called 'sequencing'. You have a bunch of individual operations

Re: Review Request 12874: Fix reboot failures with wait time

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/#review23766 --- I think you forgot to attach the diff here. - Prasanna Santhanam

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

2013-07-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23765 --- Ship it! Ship It! - Prasanna Santhanam On July 24, 2013, 10:51 a

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

2013-07-24 Thread Musayev, Ilya
Wei. Yes, I recreated the systemvms by destroying them. I have no agents, if you mean KVM/Xen agents, I'm running vSphere. Regards Ilya > -Original Message- > From: Wei ZHOU [mailto:ustcweiz...@gmail.com] > Sent: Wednesday, July 24, 2013 2:37 AM > To: dev@cloudstack.apache.org > Subject

Re: Review Request 12775: Migrate the dozens of ssh calls for KVM VmDataCommand to a single router command

2013-07-24 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12775/#review23764 --- Ship it! So it took me some time to get around reviewing this, but

Re: Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23763 --- Ship it! Ship It! - Abhinandan Prateek On July 24, 2013, 10:26 a

Re: [DESIGN] Why is enum a class...

2013-07-24 Thread Daan Hoogland
And as an example: the way the net should be isolated or the broadcast should be constructed are typically behavioral issues, whilst the fact that it is being used for storage or private network or routing can be caught in a constant/enum value. right? On Wed, Jul 24, 2013 at 2:37 PM, John Burwel

Re: Review Request 12898: CLOUDSTACK-3544: Xen 6.2 hosts are tagged with Xen 6.1.

2013-07-24 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12898/#review23762 --- Review 12898 PASSED the build test The url of build cloudstack-maste

Re: UI Query: createForm

2013-07-24 Thread Ian Duffy
Hi Pranav, The "Required: true" in the creates that span required field automatically. The following is the result of its generated html: (Just using account as an example, account isn't required in practice) *Account: But it still allows the f

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23761 --- Ship it! commit 743d35cae4985a8d898da06e5768ae282b32adb2 - Kishan

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23759 --- Commit d89115b5cff9013c917c8d2e984c596698389cfe in branch refs/heads

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23760 --- Ship it! commit d89115b5cff9013c917c8d2e984c596698389cfe - Kishan

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23758 --- Commit 743d35cae4985a8d898da06e5768ae282b32adb2 in branch refs/heads

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23756 --- Commit 2b9d9cf0360b22a703f27600292f22711f51c62f in branch refs/heads

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23757 --- Commit 135a2e66c565044b6597e9178c3cf3d544712cca in branch refs/heads

Re: UI Query: createForm

2013-07-24 Thread Pranav Saxena
Sorry for missing this thread .Seems like the mail was automatically sent to my citrix ID which doesn't exist anymore. Anyways, I gave a quick look at what Ian is trying to do here and realized that he has probably forgotten to add the "required" class in the form structure . Ian , you might want t

Re: [DESIGN] Why is enum a class...

2013-07-24 Thread John Burwell
Daan and Frank, First, I think its important to separate when and where an enumeration should be used from how to best employ enums when their use is appropriate. Enums are a finite set of values defined at compile-time. Therefore, they shouldn't employed in situations where extensibility of

Re: Review Request 12899: CLOUDSTACK-702: Tests for Multiple IP Ranges

2013-07-24 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12899/#review23755 --- Review 12899 PASSED the build test The url of build cloudstack-maste

Re: UI Query: createForm

2013-07-24 Thread Sebastien Goasguen
Parnav, Jessica or Brian, can you help Ian here ? thx On Jul 22, 2013, at 9:51 AM, Ian Duffy wrote: > Hi, > > I'm having an issue with the below gisted snippets. For whatever > reason they do not get validated. Any idea why? > > https://gist.github.com/imduffy15/6053967 > > Thanks, > Ian

Review Request 12898: CLOUDSTACK-3544: Xen 6.2 hosts are tagged with Xen 6.1.

2013-07-24 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12898/ --- Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs: CLOU

RE: [DISCUSS} enums in Networks,.java

2013-07-24 Thread Alex Huang
+1 So are BroadcastScheme, IsolationType, TrafficType. --Alex > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Wednesday, July 24, 2013 3:38 AM > To: dev > Subject: [DISCUSS} enums in Networks,.java > > there has been some discussion on the proper use

Review Request 12899: CLOUDSTACK-702: Tests for Multiple IP Ranges

2013-07-24 Thread sanjeev n
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12899/ --- Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.

  1   2   >