[GitHub] cloudstack pull request: Added missed esp policy

2015-08-03 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/655#issuecomment-127497586 @wilderrodrigues Can you please review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: Added missed esp policy

2015-08-03 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/655 Added missed esp policy esp is added with esp_lifetime instead of esp_policy, corrected it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127484976 Integration test will be tricky as it does http redirections etc, will add unit test --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127482730 New api cmd and other changes. can you add unit/marvin tests please? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127478102 any LGTM please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/653#issuecomment-127472162 Good points...I went ahead and used Math.max (I also replaced the magic number with a private static final...it doesn't need to be user configurable at the ti

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/653#issuecomment-127471522 :+1: with/without the minor change I suggested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/653#discussion_r36155878 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java --- @@ -352,8 +352,8

Re: Build failed in Jenkins: cloudstack-rat-master #6740

2015-08-03 Thread Pierre-Luc Dion
Hi Daan, My fault, I've moved the file, where do I change the path for this error? Le lundi 3 août 2015, Daan Hoogland a écrit : > Pierre-Luc, Any idea about this failure. I got it on a commit of mine but > the license is missing in tools/docker/supervisord.conf > supervisord.conf is in the exc

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

2015-08-03 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36141245 --- Diff: utils/src/com/cloud/utils/AutoCloseableUtil.java --- @@ -0,0 +1,20 @@ +package com.cloud.utils; + +import org.apache.log4j.Log

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

2015-08-03 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36141156 --- Diff: framework/db/src/com/cloud/utils/db/DbUtil.java --- @@ -43,8 +43,10 @@ import org.apache.log4j.Logger; +import static

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/653#issuecomment-127426349 Definitely a valid point. It's something on my radar, but I just wanted to put this "quick fix" in per a customer request. :) On Mon, Aug 3, 2015 a

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

2015-08-03 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/654 Cloudstack 8656: do away with more silently ignoring exceptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/653#issuecomment-127425881 Of course I have something to nag about but LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/653#discussion_r36140697 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java --- @@ -352,8 +35

Re: Build failed in Jenkins: cloudstack-rat-master #6740

2015-08-03 Thread Daan Hoogland
Pierre-Luc, Any idea about this failure. I got it on a commit of mine but the license is missing in tools/docker/supervisord.conf supervisord.conf is in the exclude list (without the path) Can you look at that? On Tue, Aug 4, 2015 at 12:07 AM, Apache Jenkins Server < jenk...@builds.apache.org> wro

Pull request #653

2015-08-03 Thread Mike Tutkowski
Hi, Any chance I can get a couple people to look at #653 and do a LGTM? It is a very trivial change and only applies to the SolidFire storage plug-in. Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/653 Reduce the lowest hypervisor snapshot reserve value from 50% to 10% If the admin specifies a hypervisor snapshot reserve value that is below a particular number, we want to just use that

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127398255 two lgtm and succesful travis, merge gives no conflicts but will do a local build before push anyway --- If your project is set up for it, you can reply to thi

Re: Revisit Process for creating Blocker bugs

2015-08-03 Thread Daan Hoogland
On Mon, Aug 3, 2015 at 10:16 PM, Somesh Naidu wrote: > I would like to add that while the # of users affected is definitely a > major factor when ascertaining severity of an issue, should we not consider > the technical scope and/or use-case of a defect. For example, let's say > there is only one

RE: Revisit Process for creating Blocker bugs

2015-08-03 Thread Somesh Naidu
Daan, Yes, I am. Don't know about others but I was never against discussion on ML. I know there cannot be a process in Apache community that does not involve discussion on ML. I was primarily concerned with the fact that there is no pressure on the community to make an explicit decision. Requi

[GitHub] cloudstack pull request: coverity issues in old upgrade code

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: simulator-4.5-singlerun #257

2015-08-03 Thread jenkins
See -- Started by upstream project "build-4.5-simulator" build number 312 originally caused by: Started by upstream project "build-4.5" build number 504 originally caused by: Started by an

[GitHub] cloudstack pull request: coverity: bring down all high impact issu...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Need Info on configuring cloudstack HA

2015-08-03 Thread Marcus
yes, the HA function is not very hypervisor specific. If the mgmt server thinks that a vm that is marked 'HA' is not running and should be, it will try to start it, with whatever hypervisors are available. No setup needed on KVM. If the KVM agent decides it cannot write to a primary NFS storage, i

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/625#issuecomment-127384025 @wido I am pretty sure acs code has a problem with the new gson version (see https://builds.apache.org/job/cloudstack-pull-requests/872/org.apache.cloudstack$cl

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

2015-08-03 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/652 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/652#issuecomment-127383479 cool, thanks both :) merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/652#issuecomment-127383327 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127383237 Travis fixed in https://github.com/apache/cloudstack/pull/652 Will kick again once PR #652 is merged on 4.5 --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

2015-08-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/652#issuecomment-127383121 Build passes, nice job. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: coverity: bring down all high impact issu...

2015-08-03 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/604#issuecomment-127378331 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: coverity issues in old upgrade code

2015-08-03 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/603#issuecomment-127378233 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

2015-08-03 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/625#issuecomment-127377070 I just don't know why the tests keep failing on this one. They seem to fail on code not touched by this PR at all. Really want to get this in to 4.6. --- If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127376598 @remibergsma I will look at this with @borisroman tomorrow at the office. I want to verify his logic. Code seems good for now. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127375332 @DaanHoogland If it fits, its OK. Usually when people do this, it doesn't fit any more and GitHub will cut it. If the issue id is in the body, you can still sear

Re: [PROPOSAL] Release principles for Apache CloudStack

2015-08-03 Thread Wido den Hollander
Looks good! +1 On 08/03/2015 06:01 PM, Remi Bergsma wrote: > Hi all, > > First of all, thanks for all the feedback! There were two approaches > discussed to handle bug fixing (as you can read in discussion tread [1]) and > we simply went ahead and tried them both. That’s how we figured out the

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

2015-08-03 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/652 travis: don't force M2_HOME, let Travis use the bundled maven3 This PR would test is M2_HOME option overriding is causing for the 4.5 Travis failures You can merge this pull request into a Git

Re: Need Info on configuring cloudstack HA

2015-08-03 Thread Wido den Hollander
On 08/03/2015 05:58 PM, Nux! wrote: > Hello, > > "KVM" itself does not have a built-in HA engine, since it's just the > hypervisor. > > The HA in this case is handled by the Cloudstack management server, it will > make sure your instance is always UP as long as > the service offering has "Off

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127368979 @remibergsma Are you sure you don't want the issue ref on the first line? CLOUDSTACK-8703: Fixed issue when listing directory on S3 It would onl

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127366917 I cannot test the functionality myself right now, although it looks OK. @wido can you verify and give a final LGTM? I'll then merge it. @borisroman my on

Re: Revisit Process for creating Blocker bugs

2015-08-03 Thread Daan Hoogland
kewl, Are you sure btw, the openoffice page does state that blockers first have to be discussed on the mailing list, which was I think the argument to start this thread. On Mon, Aug 3, 2015 at 8:20 PM, Somesh Naidu wrote: > Daan, that sounds perfect to me! > > Regards, > Somesh > > > -Origi

[GitHub] cloudstack pull request: CLOUDSTACK-8640: Revert to AWS SDK 1.3.22

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/647 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: Revisit Process for creating Blocker bugs

2015-08-03 Thread Somesh Naidu
Daan, that sounds perfect to me! Regards, Somesh -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, August 03, 2015 4:59 AM To: dev Subject: Re: Revisit Process for creating Blocker bugs Raja, Somesh, I want to revise my stand on this slightly; If we

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127360713 thanks for the comments Boris LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127359986 I just had a comment on 87ae150. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127357042 @mike-tutkowski sorry didn't notice your reply, I added a view more. Can you have a look? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127350489 @bhaisaab @DaanHoogland had a look at this.. Codehaus shut down only recently, in July. On the site they say: If your configuration is not updated and

Revert AWS SDK to 1.3.22

2015-08-03 Thread Boris Schrijver
Hi all, This PR (https://github.com/apache/cloudstack/pull/647) has two LGTM's so it should be good to merge. Together with this PR (https://github.com/apache/cloudstack/pull/651) it will fix the current issues with the S3 platform. In the coming weeks I will revise the entire S3 implementation

Re: [GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread Mike Tutkowski
Yes On Monday, August 3, 2015, DaanHoogland wrote: > Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/649#issuecomment-127284140 > > @mike-tutkowski are you alright with this now (merge-level allright;)? > > > --- > If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/651#discussion_r36103980 --- Diff: utils/src/com/cloud/utils/S3Utils.java --- @@ -352,10 +352,15 @@ public static File getFile(final ClientOptions clientOptions, final String b

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/651#discussion_r36103914 --- Diff: utils/src/com/cloud/utils/S3Utils.java --- @@ -352,10 +352,15 @@ public static File getFile(final ClientOptions clientOptions, final String b

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127312399 @borisroman @remibergsma the timeout is not related to anything but travis and maybe to the way we use it --- If your project is set up for it, you can reply t

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/651#discussion_r36102819 --- Diff: utils/src/com/cloud/utils/S3Utils.java --- @@ -352,10 +352,15 @@ public static File getFile(final ClientOptions clientOptions, final String

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/651#discussion_r36102628 --- Diff: utils/src/com/cloud/utils/S3Utils.java --- @@ -352,10 +352,15 @@ public static File getFile(final ClientOptions clientOptions, final String

Re: [PROPOSAL] Release principles for Apache CloudStack

2015-08-03 Thread Daan Hoogland
:+1: or such

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127292168 The failing check is a Travis timeout. Seems not related, is it? --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS][PROPOSAL] cleanup repo

2015-08-03 Thread Remi Bergsma
+1 > On 02 Aug 2015, at 15:46, Daan Hoogland wrote: > > As we are changing our review process I want to clean up the > repository at apache getting rid of stale branches. Of course the > release branches of old releases should stay, but a lot of old > branches have been merged at unknown places

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127288807 @bhaisaab I know of no fix. I had a quick look and recognised codehaus in the error, remembering that They shut down. For some reason it seems not to be a probl

ACS 4.6 RC is just around the corner!

2015-08-03 Thread Remi Bergsma
Hi all, The last remaining blocker was just resolved! There are some bugs being worked on that should be ready in the next couple of days. We will create the RC when these issues are resolved: CLOUDSTACK-8688: Default policy for INPUT and FORWARD chain is ACCEPT in VR filter table [1] CLOUDSTA

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/8#issuecomment-127288047 I'll test and merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[PROPOSAL] Release principles for Apache CloudStack

2015-08-03 Thread Remi Bergsma
Hi all, First of all, thanks for all the feedback! There were two approaches discussed to handle bug fixing (as you can read in discussion tread [1]) and we simply went ahead and tried them both. That’s how we figured out the best one (we also described why we choose this approach over the othe

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/8#issuecomment-127288003 LGTM, @ntavares I liked that in this change you're lowering the keys to compare instead of doing a substring search. Can you suggest any API response whi

Improving API reference pages

2015-08-03 Thread Somesh Naidu
{should you be adding [DISCUSS] and/or [PROPOSAL] to the subject?} +1 Definitely required. Improvements in description/function required for both the API call itself and associated parameters. I am willing to help with the content. Regards, Somesh -Original Message- From: Dave Dunawa

Re: Need Info on configuring cloudstack HA

2015-08-03 Thread Nux!
Hello, "KVM" itself does not have a built-in HA engine, since it's just the hypervisor. The HA in this case is handled by the Cloudstack management server, it will make sure your instance is always UP as long as the service offering has "Offer HA". e.g. http://storage4.static.itmages.com/i/15/0

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127285144 @DaanHoogland thanks, looks like it. In that case, did we fix this on master? If so, we can possible port the fix to 4.5/4.4/4.3? --- If your project is set up for

RE: [DISCUSS][PROPOSAL] cleanup repo

2015-08-03 Thread Somesh Naidu
+1 I believe we are saying these branches will no longer have any future releases; that they are technically EOM/EOL. Regards, Somesh From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: Monday, August 03, 2015 10:41 AM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS][PROPOSAL] cleanu

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127284140 @mike-tutkowski are you alright with this now (merge-level allright;)? --- If your project is set up for it, you can reply to this email and have your reply app

Re: Small grammatical point to clarify

2015-08-03 Thread Daan Hoogland
English is changing isn't it ;) we need to cleanup it On Mon, Aug 3, 2015 at 5:15 PM, Mike Tutkowski wrote: > Another common one might be "cleanup" versus "clean up". :) > > The cleanup work has been completed. // used as an adj > > versus > > We need to clean up some branches. // used as a verb

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127281959 @bhaisaab org.codehaus.plexus.classworlds.launcher.Launcher I don't know the details but codehaus has abandonned their opensource repo support. Form their main

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-08-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-127280785 @wilderrodrigues ok. thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-08-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-127275589 I will start on it this week, hopefully! Just keep the PR open, I will get it and create a PR on top of your with the tests. In this way we keep track of eve

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-08-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-127274573 @wilderrodrigues did you take it over? can I close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Re: Small grammatical point to clarify

2015-08-03 Thread Mike Tutkowski
Another common one might be "cleanup" versus "clean up". :) The cleanup work has been completed. // used as an adj versus We need to clean up some branches. // used as a verb On Sat, Aug 1, 2015 at 2:19 PM, Nux! wrote: > Thanks for that. > This pleases my inner grammar nazi. :) > > Lucian > >

Fwd: Need Info on configuring cloudstack HA

2015-08-03 Thread Mike Tutkowski
CCing Marcus since he's one of our resident KVM gurus, but - of course - anyone please chime in. Thanks! -- Forwarded message -- From: Budur Nagaraju Date: Mon, Aug 3, 2015 at 1:44 AM Subject: Need Info on configuring cloudstack HA To: dev-ow...@cloudstack.apache.org HI New t

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/651 CLOUDSTACK-8703: Fixed issue when listing directory on S3. It would only return objectSummaries when the anwser from the S3 System was truncated. You can merge this pull request into a Git r

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-127265742 @DaanHoogland @wilderrodrigues @karuturi @kishankavala @abhinandanprateek - any ideas why Travis is failing on 4.5 (in general), also please help review. --- If yo

Re: [DISCUSS][PROPOSAL] cleanup repo

2015-08-03 Thread Rohit Yadav
+1 I think we can easily cleanup all branches that are 6+ months older. On 03-Aug-2015, at 10:46 am, Rajani Karuturi mailto:raj...@apache.org>> wrote: +1 Agree. We have more than 200 branches. ~Rajani On Mon, Aug 3, 2015 at 4:39 AM, Boris Schrijver mailto:bo...@pcextreme.nl>> wrote: +1 Be

[GitHub] cloudstack pull request:

2015-08-03 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/commit/c5ebb68be4084c2a654c87beb7c41fe4ce059f9d#commitcomment-12493549 Hi again, I see the "this closes" message! Sorry for the noise :) --- If your project is set up for it, you can r

Re: Improving API reference pages

2015-08-03 Thread Dave Dunaway
I would definitely say this is needed. A few calls need to specify "types" of which there is not description or they are poorly worded. If the API doc page could have comments... that would be good too. Let the community add examples or suggestions. However the real deal is to document the attrib

[GitHub] cloudstack pull request:

2015-08-03 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/commit/c5ebb68be4084c2a654c87beb7c41fe4ce059f9d#commitcomment-12493453 Hi there @pritisarap12 This looks like some nice stuff you're adding here. I just miss the PR for this?

Improving descriptions in the API reference pages

2015-08-03 Thread Rajsekhar K
Hi, All, This is part of our effort to improve user experience of Cloudstack API reference pages. Majority of the CloudStack API reference pages do not adequately describe the usage of the parameters associated with them. Many of these parameters contain only a single line description, which does

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

2015-08-03 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/644#issuecomment-127186217 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-03 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/646#discussion_r36072298 --- Diff: test/integration/component/maint/test_escalation_templates.py --- @@ -0,0 +1,394 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-03 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/646#discussion_r36072278 --- Diff: test/integration/component/maint/test_escalation_templates.py --- @@ -0,0 +1,394 @@ +# Licensed to the Apache Software Foundation (ASF) und

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Wilder Rodrigues
HI, VPC routers (used by single and redundant VPCs) already fixed. Now testing shared/isolated routers. PR will be available in a few hours. Cheers, Wilder > On 03 Aug 2015, at 11:47, Wilder Rodrigues > wrote: > > Yep… that bit I know and it was already in the code. > > > What I just foun

[GitHub] cloudstack pull request: Coverity Issue: Null pointer dereferencin...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/629#issuecomment-127183509 h @kansal, please add a ref to the issue in the commit message, thanks --- If your project is set up for it, you can reply to this email and have your reply ap

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Wilder Rodrigues
Yep… that bit I know and it was already in the code. What I just found out was that the DROP was put before there, in a probably first run of the code. What I changed now was to have the DROP added only after the control nic is configured. It should work, but I still need to test it - new RPMs

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/650 APIServlet, AuthCmd, SAML fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cloudstack 4.5-samlfixes Alternatively you can revi

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Sanjeev N
I think we need to allow tcp port 3922 in INPUT chain for the host to ssh to VR. On Mon, Aug 3, 2015 at 3:00 PM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > Hi Sanjeev, > > I added some comments to the issue on Jira, but will share it here as well > since not many people are watchi

Improving API reference pages

2015-08-03 Thread Rajsekhar K
Hi, All, This is part of our effort to improve user experience of Cloudstack/CloudPlatform API reference pages. Majority of the CloudStack/CloudPlatform API reference pages do not adequately describe the usage of the parameters associated with them. Many of these parameters contain only a single

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Wilder Rodrigues
Hi Sanjeev, I added some comments to the issue on Jira, but will share it here as well since not many people are watching the issue: I updated the CsAddress.py file and deployed a KVM datacenter, with new agent/common RPM packages. The router has now INPUT/FORWARD with DROP instead of ACCEPT.

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127174572 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: coverity: bring down all high impact issu...

2015-08-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/604#issuecomment-127173549 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8640: Revert to AWS SDK 1.3.22

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/647#issuecomment-127173031 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/643 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: coverity issues in old upgrade code

2015-08-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/603#issuecomment-127171961 Went through the file, had just one remark which won't cause trouble. I would rather remove the old code other them keeping it commented out. But that's just

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

2015-08-03 Thread ntavares
GitHub user ntavares opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/8 FIX responses /contain/ word "response", but may not exactly match Hi @bhaisaab , commit 242b8e7ed3688ca137b7879da6c3a5774deeda06 introduced a problem.. AFAICS, not all responses have

  1   2   >