Re: Super trivial code change and PR

Sounds good I could always "cache" those kinds of trivial changes and create a single PR for them later, too. On Thu, Aug 6, 2015 at 12:29 AM, Remi Bergsma wrote: > We'll live with it this time I'd say ;-) Thanks for bringing it up! > > Regards, Remi > > > On 06 Aug 2015, at 08:09, Mike Tutkows

Re: Super trivial code change and PR

We'll live with it this time I'd say ;-) Thanks for bringing it up! Regards, Remi > On 06 Aug 2015, at 08:09, Mike Tutkowski wrote: > > Fair enough > > Do you want me to revert this one or are we OK to just live with it? > > On Wed, Aug 5, 2015 at 11:57 PM, Remi Bergsma > wrote: > >> Hi Mi

Re: Super trivial code change and PR

Fair enough Do you want me to revert this one or are we OK to just live with it? On Wed, Aug 5, 2015 at 11:57 PM, Remi Bergsma wrote: > Hi Mike, > > Yes, I want everything to go through a PR. > > Otherwise: > - there are no Travis CI and other tests run > - we need to describe what 'trivial' is

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Super trivial code change and PR

Hi Mike, Yes, I want everything to go through a PR. Otherwise: - there are no Travis CI and other tests run - we need to describe what 'trivial' is and what not - the change is not visible The goal is a stable master at all times and we cannot reach that with direct commits. I do get your p

[DISCUSS][PROPOSAL] Support for standard metadata/userdata URL

Today the metadata / userdata server is retrieved by the guest from http:///latest/meta-data and http:// of DHCP server>/latest/user-data This of course has been inspired by the EC2 standard[1] http://169.254.169.254/latest/ While this works and has been incorporated into cloud-init [2], there ar

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128250790 So, the way we got around the issue of occasionally acquiring the same device ID was to move the retrieve-device-ID logic from the API layer (which can be cal

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128250223 if we dont persist the deviceId at the time of generation, as you said multiple calls around the same time will still get the same id and the attach would fail (whi

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/644#issuecomment-128249920 All the tests success results are given in the PR. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

RE: Revisit Process for creating Blocker bugs

Looks like there are few of us who differ with the current process/restriction. Just to close this thread - there are already guidelines that exist currently and we should continue to adopt or follow those.Let the Release Manager or other people closely involved with a particular release d

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/656#discussion_r36382437 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -242,16 +242,19 @@ public void scheduleRestartForVmsOnHost(final HostVO host

Re: [DISCUSS] 4.5.2 bugfix sprint

On Wed, Aug 5, 2015 at 10:07 PM, Rohit Yadav wrote: > > On 05-Aug-2015, at 11:01 am, Rajani Karuturi wrote: > > Hi Rohit, > Any update on the release timelines for 4.5.2? I think based on the current > upgrade path, we have to do 4.5.2 before 4.6.0. Else upgrade path needs to > changed. > > > I’

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/656#discussion_r36381969 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -242,16 +242,19 @@ public void scheduleRestartForVmsOnHost(final HostVO hos

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128244090 The reason we could pick multiple same device IDs is because the ID is not written to the DB until late in the attach process (after a successful attach on th

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128243816 I don't think there's a race condition anymore (it was fixed by my initial commit (not this code)). The attach code is run in serial for the VM in que

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128242754 Even after e5ffcab0 and this change, race condition is possible right? Let us say the hypervisor takes time to attach and another attach command came in before this

Re: Super trivial code change and PR

Woops...I meant to provide the URL to the diff: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=2c8d179b7abf6da1c99390788c3329f243e172db;hp=abfe33a2441679b0105e2023472614a8648e6fcb On Wed, Aug 5, 2015 at 10:48 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Hi

Super trivial code change and PR

Hi everyone, Hopefully this isn't an issue, but I occasionally have super trivial, but useful changes to SolidFire-only code that I'd like to push without bothering with a PR. For example: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob;f=plugins/storage/volume/solidfire/src/org/

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128234545 @bhaisaab I don't think there's any issue with the hypervisor matrix. What was happening was a NPE was being thrown in one scenario when trying to attach a vo

Re: s2s vpn related iptables are not applied on VR

Hi Remi, Created ticket for this. https://issues.apache.org/jira/browse/CLOUDSTACK-8710 Thanks, Jayapal On 06-Aug-2015, at 1:23 AM, Remi Bergsma wrote: > Hi, > > Could you please create an ACS issue for this, so we can track it? Sounds > like something we need to fix. > > Thanks, > Remi > >

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128231212 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128230517 Yes please move the necessary code to schema-451to452.sql on 4.5 branch; we'll merge the same change on master as well --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128230242 LGTM @mike-tutkowski can this cause any side effect on any hypervisor/storage permutation? --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128227678 @remibergsma Agreed. In this case fix will go into 4.5.2 and 4.6 Updated fixVersion accordingly --- If your project is set up for it, you can reply to

PR 660

Hi everyone, If you have a moment and feel qualified, would you be able to take a look at PR 660? https://github.com/apache/cloudstack/pull/660 It's a one-line fix to close out CLOUDSTACK-8698: https://issues.apache.org/jira/browse/CLOUDSTACK-8698 The problem was that when a volume was being a

Re: Ec2stack not working with current aws cli

BTW I figured out how to force the cli to send v2. It would still be nice to update Ec2Stack though: aws configure set profile..ec2.signature_version v2 Or for your default profile: aws configure set default.ec2.signature_version v2 The above will update your ~/.aws/config file. On Wed,

Ec2stack not working with current aws cli

Hi, I am having trouble with the current aws cli. Ec2stack is expecting AWS signature version 2 but the current aws cli uses v4. Do I file a JIRA in under cloudstack? I did not see an ec2stack component. Here is a wireshark capture: POST / HTTP/1.1 Host: localhost:5000 Accept-Encoding: identit

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/660 CLOUDSTACK-8698: Retrieve a new device ID, if needed This PR addresses https://issues.apache.org/jira/browse/CLOUDSTACK-8698. You can merge this pull request into a Git repository by runn

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/653#issuecomment-128159614 Sorry...I accidentally closed this PR without getting the code properly into upstream (so re-opening it for a bit). --- If your project is set up for it, you

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

GitHub user mike-tutkowski reopened a pull request: https://github.com/apache/cloudstack/pull/653 Reduce the lowest hypervisor snapshot reserve value from 50% to 10% If the admin specifies a hypervisor snapshot reserve value that is below a particular number, we want to just use tha

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user mike-tutkowski closed the pull request at: https://github.com/apache/cloudstack/pull/653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Re: s2s vpn related iptables are not applied on VR

Hi, Could you please create an ACS issue for this, so we can track it? Sounds like something we need to fix. Thanks, Remi > On 05 Aug 2015, at 14:30, Jayapal Reddy Uradi > wrote: > > Hi, > > I haves configured the s2s vpn in vpc network. Observed that the iptables > rules related to s2s vp

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128128323 @kishankavala Released versions will never be changed, only their ongoing release branches, like the '4.5' branch. So, we won't touch 4.5.0 and 4.5.1. What goes

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128126924 @DaanHoogland @karuturi @bhaisaab Yes, let's do 4.5.2 first and then all focus on 4.6.0 --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: CLONE - Restore VM (Re-install VM) with e...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/659#issuecomment-128125258 Thanks! Can you please rewrite the commit message and use the CLOUDSTACK issue ID? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: CLONE - Restore VM (Re-install VM) with e...

GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/659 CLONE - Restore VM (Re-install VM) with enable.storage.migration set to false fails .later fails to start up VM too Author: Prachi Damle Changes: - Try to reuse the s

Re: Jenkins at buildacloud.org

Hi Boris, On 05-Aug-2015, at 2:25 pm, Boris Schrijver mailto:bo...@pcextreme.nl>> wrote: - Sync nightly package builds of master and the 4.5 branch to cloudstack.apt-get.eu - Add a job for packaging the 4.5 branch for Centos 7 That’s good to know. - Fix the Centos

Re: [DISCUSS] 4.5.2 bugfix sprint

On 05-Aug-2015, at 11:01 am, Rajani Karuturi mailto:raj...@apache.org>> wrote: Hi Rohit, Any update on the release timelines for 4.5.2? I think based on the current upgrade path, we have to do 4.5.2 before 4.6.0. Else upgrade path needs to changed. I’ll attempt to start working on a RC next we

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128023315 @DaanHoogland yes, there was a discussion with @remibergsma and @karuturi on slack; I'll start something next week --- If your project is set up for it, you can re

[CLOUDSTACK-8708] Using Google Gson 2.3.1

Hi, While trying to merge PR 625 [0] which is CLOUDSTACK-8677 [1] (Call-Home) a issue came up due to failing tests. This feature requires Gson 2.3.1 and that breaks the test com.cloud.agent.transport.RequestTest in "core". We currently use Gson 1.7.2 which is from September 2011 (!). This happe

s2s vpn related iptables are not applied on VR

Hi, I haves configured the s2s vpn in vpc network. Observed that the iptables rules related to s2s vpn are not configured on the VR. In configure.py there is method 'configure_iptables' which is having rules but these are not getting applied on VR. Can you please look into this. Also can you pl

Facing an error in travis build. Need help.

Hi, Facing the following error in travis build( https://travis-ci.org/apache/cloudstack/builds/74205076 ) .Not able to figure out the reason for it. Help needed.Thanks in advance. /usr/local/maven-3.2.5/bin/mvn: 3: export: -XX:MaxPermSize: bad variable name /usr/local/maven-3.2.5/bin/mv

Change account membership: non-VMs

Hi, I found this: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Change+account+membership For 4.2, changing ownership of VMs was implemented. Was the ability to move around snapshots, templates, ISOs, etc ever added? Jeff

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-127946635 @devdeep the test you added seems fine and passes (the assert messages look like they can be better formulated to describe what went wrong) I do not understa

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r36286725 --- Diff: server/test/com/cloud/template/TemplateManagerImplTest.java --- @@ -18,20 +18,369 @@ package com.cloud.template; -impor

Re: Jenkins at buildacloud.org

Boris, I read that you are asking for karma to configure jobs on jenkins.bac.o. David, these are your machines. Can we give him? Anything we need to adhere to giving access to people on this jenkins installation? On Wed, Aug 5, 2015 at 10:55 AM, Boris Schrijver wrote: > Hi David, dev@, > > Yeste

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/625#issuecomment-127927660 @DaanHoogland You are right. There has been a change between GSON 1.7 and 2.0 which causes a failure of the tests. Looking into this, but my Java Reflecting kno

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/658 Implemented condition that only admin or owner of the template can change its permissions . using updateTemplatePermissions API You can merge this pull request into a Git repository by ru

Jenkins at buildacloud.org

Hi David, dev@, Yesterday I spoke with Daan about jenkins.buildacloud.org, who maintains it and who has ownership. As I would like to add a couple of jobs and automate some things around packaging and syncing against the cloudstack.apt-get.eu repo. To not stress any of the current maintainers I wo

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

Github user ntavares commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/8#issuecomment-127921548 @bhaisaab Sorry for the late reply. You are correct about the suffix, however "'response' not in response" was not working, I suspect it was due to the s

Re: Revisit Process for creating Blocker bugs

Koushik, that would be true if we had our upgrade process in order. On Wed, Aug 5, 2015 at 7:14 AM, Koushik Das wrote: > If there is a group of users in dire need for a specific feature they can > always take the code and use it. No need to wait for an official release. > Official release should

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-127918187 will do but a bit busy today, hang on --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: Added missed esp policy

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/655 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-127916051 @bhaisaab If we do that we do commit ourselves to releasing 4.5.2 before 4.6.0 don't we? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-cloudmonkey/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

MariaDB crash with loading CloudStack database

Hi, I've just spent a few hours debugging why this failed: $ mvn -P developer -pl developer -Ddeploydb After about 30 seconds MariaDB (5.5 and 10.0) would crash: [WARNING] java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-127899688 @karuturi can you move this to 451to452 schema and then merge on both 4.5/master which will fix the issue for both future releases 4.5.2 and 4.6.0? --- If your pro

[GitHub] cloudstack pull request: Only admin or owner of the template can c...

Github user manuiiit closed the pull request at: https://github.com/apache/cloudstack/pull/648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i