GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1234
CLOUDSTACK-9153: When negative credits are added to an account the
When negative credits are added to an account the balance credits can
become negative for that account. This will fix will
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164208189
OK, that makes sense. let's do it. if we need it there is always git
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164205140
Hi @DaanHoogland
In late 2012 it was replaced with cloudmonkey. It's just some code that was
left behind. It's not touched since halfway through 2012.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164204798
LGTM, and I agree with @borisroman the incremental change is better as we
had some initial problems with utils, After NSX and KVM I think we can
accelerate. un
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164204591
I'm hesitant, is really nothing usefull or being used in there? I would
like to know why this became out of use before disgarding it.
---
If your project is s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1226#issuecomment-164204418
LGTM, is it in .gitignore? it should
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164201764
@milamberspace Are we good to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164201602
@ustcweizhou @borisroman we will release both 4.6.2 and 4.7.0 RDs tomorrow
---
If your project is set up for it, you can reply to this email and have your
repl
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1232#issuecomment-164201023
Integration tests ran ok! @wido @remibergsma @wilderrodrigues
@miguelaferreira @DaanHoogland
**Environment**
- 2 KVM host on CentOS 7.1
- 1 Ma
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164200657
LGTM :+1:
**Environment**
- 2 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164199618
@ustcweizhou Thanks! Will see them when they arrive!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1209#discussion_r47437641
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -222,11 +222,20 @@ public String getIpAddress(long networkId, long
instanceId) {
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-164199095
@DaanHoogland @wilderrodrigues
assume there are two routers now routerA (master) and routerB (backup).
if we destroy routerA (master) at first, then rou
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164198697
@DaanHoogland I will add some tests in the file when I have time.
currently I have some other tasks to do (not porting).
---
If your project is set up for i
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1212#discussion_r47437500
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -185,6 +186,8 @@
@Mock
GlobalLoadBalancerRuleDao _gslbRuleDa
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164196808
ran the build:
```
checking for unpackaged file(s): /usr/lib/rpm/check-files
/data/git/cs1/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.2-SNAPSHOT.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1233#issuecomment-164196319
LGTM :+1:
Nice way of not creating duplicate code!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1233#issuecomment-164194791
As discussed, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1233
4.6.2 -> 4.7.0 upgrade does not use any scripts above 4.6.1
test build ongoing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164191853
It is certainly not wanted but as it is in an otherwise working unit test
it is allowed. It does not interfere with the correct working of the system.
---
If
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164191465
LGTM :+1: All pom.xml files haven been correctly changed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164190196
Have discussed the upgrade paths with @DaanHoogland We are implementing
them as we speak.
---
If your project is set up for it, you can reply to this email and
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164189121
Hi @DaanHoogland, well then that's your opinion. Mine is, as a developer I
do not want dead code to be added to the project.
Therefore I stand by my :-1:
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164188525
@borisroman I don't agree with your :-1: The artifact from a port in a test
class that otherwise compiles is worth a -1?
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164187066
@nitin-maharana I don't agree we should allow the user to get a default
name if (s)he doesn't care. I'd say let the name be the uuid-generated one when
empty (
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164186662
Update: this resolved our production problem. It now works fine in
master+this PR.
LGTM :+1:
---
If your project is set up for it, you can reply to t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-164186641
I will look at improving the integration tests but can you do the
improvements to the code as @wilderrodrigues suggested (or comment on them)?
---
If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435856
--- Diff:
server/test/org/apache/cloudstack/networkoffering/MockUsageEventEmitter.java ---
@@ -0,0 +1,134 @@
+package org.apache.cloudstack.netw
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1209#discussion_r47435854
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -222,11 +222,20 @@ public String getIpAddress(long networkId, long
instanceId) {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435795
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -131,54 +127,55 @@ public static void publishUsageEvent(String
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435785
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -38,44 +34,37 @@
import com.cloud.event.dao.UsageEventDao
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1219#issuecomment-164179455
LGTM :+1:
Deployed with Ceph.
 is removed, :-1:
---
If your project is set up for it, you can reply to this e
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164178250
@nitin-maharana @bhaisaab both I and @remibergsma don't work with vmware as
part of our cloudstack installs, can you do testing and preferably write tests
for
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1212#discussion_r47435698
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -185,6 +186,8 @@
@Mock
GlobalLoadBalancerRuleDao _gslbRuleDao
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-164178065
@priyankparihar Could you point me where in VolumeStateListener it is
emitted?
---
If your project is set up for it, you can reply to this email and have your
r
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/859#discussion_r47435639
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -125,6 +125,25 @@ public UsageVO(Long zoneId, Long accountId, Long
domainId, String des
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164177507
Update: Verified the same as above in our pre-production environment (aka
Employee Cloud). Will now deploy to production as it works as expected. When
the integ
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-164177131
@priyankparihar these are nice results but I have no way of verifying the
latter is actually the good result. can you write a test that proves proper
behaviou
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164177113
@milamberspace @remibergsma @DaanHoogland LGTM :+1:
Only did code review.
---
If your project is set up for it, you can reply to this email and have you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164176585
@DaanHoogland Thanks. Deploying to a real cloud as we speak. Will verify
there too.
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164176274
As an operator I want this in :p have only read the feature description in
jira and the diff but lgtm based on that and @remibergsma his test results.
---
If
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164176177
Thanks @DaanHoogland
PR updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1229#issuecomment-164176128
Yes, this config file doesn't use at this place. Can be remove.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164175379
@remibergsma Please try again! I changed a few files today. You probably
didn't notice because I squashed them in the commit from yesterday. (Which you
likely bu
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164174462
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1209#issuecomment-164174368
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164174234
@borisroman I can't get it to run. It builds but after start it errors out
like this:
```
2015-12-12 10:01:33,843 WARN [o.a.c.s.m.c.ResourceApplica
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164174058
LGTM based on these tests (run on KVM):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
co
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164172595
First test results:
keepalived.conf looks as expected:
```
vrrp_instance inside_network {
state EQUAL
interface eth2
virt
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164171363
Jenkins error unrelated to PR change:
```
Build timed out (after 120 minutes). Marking the build as aborted.
```
---
If your project is set up for i
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1232
CLOUDSTACK-9152: Remove unused folder(s)/file(s); utils/bindir
As a developer I want a project without dead or unused code.
Builds ok
```
[INFO]
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164171043
@borisroman what benefits we will have?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164170827
LGTM based on the above tests. Makes no sense to run the same tests again
:-)
---
If your project is set up for it, you can reply to this email and have your
r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1229#issuecomment-164170453
Ping @milamberspace to have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164170412
@bhaisaab nice suggestion! Not sure if it is needed though. The vrrp is
done over the first guest network, so it cannot clash with other router pairs.
Other tie
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169626
@bhaisaab I think an incremental approach is better. I will also create
issue for all other projects and move the each at a time. The
plugin-hypervisor-kvm just
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-164169523
Thanks for the instructions @serg38
I will attempt to reproduce this early this week.
---
If your project is set up for it, you can reply to this
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169497
@miguelaferreira I also think incremental is better. Keeps changed
contained and documented. Else it would be a PR that changes "OVER "
files...
---
If yo
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169391
And btw LGTM! Nice one @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169348
Since no one is making a PR to improve all modules, I would say that
incremental improvement is better than no improvement at all. I have done the
same to t
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164168237
@bhaisaab Good idea to do that indeed. I think many of us want Java 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164167812
Time to move to Java 8, post 4.7 perhaps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164167703
This is codebase wide issue that we're not following the default maven
directory structure for all the maven projects/modules. What is the motivation
behind doing
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1229#issuecomment-164167598
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164167571
LGTM, perhaps we can use VPCID % 255 to get a value that is less than 255
but greater than 0?
@remibergsma @fborn @wilderrodrigues Do you think using a static/f
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-164165606
@DaanHoogland thanks for merging. This is not yet in 4.5 as I'm yet to
merge the 4.5 based PR https://github.com/apache/cloudstack/pull/1131
Will do that on Mon
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164163749
You can read the following from man keepalived.conf:
```
# arbitary unique number 0..255
# used to differentiate multiple instances of vrrpd
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164163586
Thanks for the quick fix @wilderrodrigues.
Bit explanation: redundant routers worked fine in our 4.7 cloud, then all
of a sudden were broken. Root caus
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164163506
It works! Though please tests yourself for more confidence!
@wilderrodrigues @miguelaferreira @remibergsma
**Environment**
- 1 KVM host on CentOS 7.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164163315
It works! Though please tests yourself for more confidence!
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1226#issuecomment-164162389
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
**Integration test s
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164162326
*Environment*
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
*Integration test suit
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-164161973
Hi @dmytro-shevchenko
Thanks for implementing the removal code. Could you squash the commits and
add a descriptive commit message?
---
If your project
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164161230
Ping @remibergsma @DaanHoogland @borisroman
Could you guys test it before the RC? I just fixed, but have to go to a
concert now.
---
If your proj
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1231
CLOUDSTACK-9151 - As a Developer I want the VRID to be set within the
limits of KeepaliveD
This PR fixes a blocker issue!
- Just like with RVRs, use the VRID 51 instead of
GitHub user dmytro-shevchenko opened a pull request:
https://github.com/apache/cloudstack/pull/1230
CLOUDSTACK-8302: Removing snapshots on RBD
Snapshot removing implemented if primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302
You can merge this pull
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1223#issuecomment-164159535
40G sounds like an old fs limit. doesn't make sense nowadays.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164159167
@milamberspace Dutch complemented
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1229
CLOUDSTACK-9150: Remove docs/.tx/config
The config file docs/.tx/config has been replaced with
tools/transifex/.tx/config. It's not maintained or used so it must be removed.
You can merge t
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164157579
Nice one, @borisroman !
LGTM :+1:
Waiting for the test results. :)
---
If your project is set up for it, you can reply to this email and
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1228
Removed cloud-cli folder and contents, as it is not maintained or used
anymore.
Remove legacy code.
You can merge this pull request into a Git repository by running:
$ git pull https:/
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164151105
Nice find @DaanHoogland Can you please fix this @SudharmaJain ? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47431643
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java
---
@@ -0,0 +1,35 @@
+package com.cl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-164150715
code LGTM and @remibergsma his test succeed, as this is in 4.5 I think it
must go in 4.6 as well, however it contains way to little tests and can not be
guaran
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164149214
Go for it, @remibergsma! Changes LGTM :+1:
@DaanHoogland: should we wait for the outcome of your build?
Cheers,
Wilder
---
If your pr
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47431578
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
@@ -236,4 +236,15 @@ public static Str
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164148706
lgtm, doing a test build, now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1211#issuecomment-164148314
LGTM, thanks for testing @remibergsma. I am going to trust on sight and as
this as it is a port from the custom leaseweb code in 4.2.1.
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1227
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1227#issuecomment-164147061
LGTM, this is why we want to be merging code instead of rebasing, no more
commits on master! only merges!
---
If your project is set up for it, you can reply
1 - 100 of 128 matches
Mail list logo
