GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to
underlay) in Nuage VSP plugin
Support for underlay features (Source & Static NAT to underlay) with Nuage
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to
underlay) in Nuage VSP plugin
Support for underlay features (Source & Static NAT to underlay) with Nuage
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1579
CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin
This is first phase of support of Shared Network in cloudstack through
NuageVsp Network Plugin. A shared network is a type
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1579
CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin
This is first phase of support of Shared Network in cloudstack through
NuageVsp Network Plugin. A shared network is a type
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to
underlay) in Nuage VSP plugin
Support for underlay features (Source & Static NAT to underlay) with Nuage
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1585
CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null
In most network plugins, there's a Resource class which will handle the
communication with the actual device
Github user nlivens commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@mike-tutkowski, pinging you because I made changes upon your recent merge
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1585
CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null
In most network plugins, there's a Resource class which will handle the
communication with the actual device / underlaying
Github user nlivens commented on the issue:
https://github.com/apache/cloudstack/pull/756
### ACS CI BVT Run
**Sumarry:**
Build Number 132
Hypervisor xenserver
NetworkType Advanced
Passed=70
Failed=1
Skipped=3
_Link to logs Folder (search
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (PAT & FIP2UL) in Nuage VSP
plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1579
CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin
Test Results are:-
Valiate that ROOT admin is NOT able to deploy a VM for a user in ROOT
domain in a shared network
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1578
CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin
Testrun:-
Verify InternalDns on Isolated Network ... === TestName:
test_01_Isolated_Network_with_zone | Status : SUCCESS
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1577
CLOUDSTACK-9321 : Multiple Internal LB rules (more than one Internal LB
rule with same source IP address) are not getting resolved in the corresponding
InternalLbVm instance's haproxy.cfg file
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1574
@swill, thanks, I appreciate the effort!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1574
@swill, great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1574
Yes, that's what I was thinking, in my development setup (```mvn -pl
:cloud-client-ui jetty:run```) it's working fine as well. But on our real test
setups (```service cloudstack
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1574
@swill, that's what I was afraid of. Are you running ACS as a service, or
just running it like a development setup (through jetty)? Since that makes a
huge difference. And yes, we
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1574#issuecomment-222654633
@rhtyd, thanks for your quick review, handled your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1574#issuecomment-222642902
@rhtyd, @DaanHoogland, @swill, pinging you guys for an update regarding the
Tomcat start up issue. This is related to #1553. I've also updated this in the
mailing
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1574
Make sure that the DB drivers are loaded before creating connections
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221891214
@remibergsma, sounds fair. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221791953
@remibergsma, I understand your concern regarding the wait_until method.
Perhaps we could use the wait_until with a 2s interval and a max wait of 4s?
That's 1
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221222391
@koushik-das, thanks for the review. Yes, all our model objects in the
Nuage VSP library are Serializable :)
---
If your project is set up for it, you can reply
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221212242
@GabrielBrascher, @abhinandanprateek, resolved / commented on your notes
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64350508
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229436
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
---
@@ -0,0 +1,370 @@
+//
+// Licensed to the Apache
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229325
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -270,15 +258,15 @@ public PingCommand
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220986821
Changed db.x.path to db.x.driver as @DaanHoogland suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223798
--- Diff: engine/storage/snapshot/test/resources/db.properties ---
@@ -46,6 +47,8 @@
db.cloud.url.params=prepStmtCacheSize=517=true
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220974849
@DaanHoogland, I've added the piece we were talking about, this can be
found it the logs regarding loading the driver dynamically :
> 2016-05-23 05:42:57,
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64195563
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64191953
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64178488
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220599141
@DaanHoogland, triggering you for review as well, this is only a small code
change
---
If your project is set up for it, you can reply to this email and have your
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220546975
@swill, @rhtyd, @kiwiflyer, triggering you guys because you were part of
this mailing thread.
---
If your project is set up for it, you can reply to this email
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1553
Explicitely load JDBC driver before creating our MySQL connections
Solution to the mailing thread titled "MySQL : No suitable driver found for
jdbc:mysql".
It doesn't ha
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220019415
@remibergsma, @DaanHoogland, @swill, I've added an update to this PR.
We're stepping away from the no-redist model :)
---
If your project is set up for it, you
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-219706255
Great, thanks @swill!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1246#issuecomment-217875751
@SudharmaJain, I've added a few comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503852
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1588,6 +1588,16 @@ protected StringBuilder
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503776
--- Diff: server/src/com/cloud/network/guru/GuestNetworkGuru.java ---
@@ -396,6 +396,16 @@ public NicProfile allocate(final Network network,
NicProfile
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503830
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -755,6 +755,16 @@ protected HypervisorType
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217858039
@DaanHoogland, the file has been renamed to make use of the python naming
standards
---
If your project is set up for it, you can reply to this email and have
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217791958
@DaanHoogland, @alexandrelimassantana, could you review the PR once again
please?
---
If your project is set up for it, you can reply to this email and have your
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216763100
@jburwell, I think that would be a nice solution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216524904
@remibergsma, down from 15 to 2 seconds is pretty big in terms of computing
time. Is there an internal retry in CS might this script give a timeout? I
think
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216513556
According to the explanation of @remibergsma, and the code changes : LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-216511879
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-216476619
Fixed issues with the added multi-zone support to "nuageTestCase.py" and
"test_nuage_vpc_network_multizone" testcase in "test_nuage_vpc_n
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216462358
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-216208745
@rhtyd, rebased against latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216208431
@alexandrelimassantana, you're right, I've splitted up the 3 different test
cases.
---
If your project is set up for it, you can reply to this email and have
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216130431
@cristofolini, @alexandrelimassantana, I've extracted the internal loop
logic to a separate method and I've added a unit test for this behavior. This
logic
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215421778
@DaanHoogland, you already have a UserData test script, do you want us to
add this test to the same script, or create a new one for it?
---
If your project is set
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215336954
@DaanHoogland, @remibergsma, @swill, @jburwell, these are rather small
changes, if any of you could review, that would be great!
---
If your project is set up
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1523
CLOUDSTACK-9365 : updateVirtualMachine with userdata should not errorâ¦
⦠when a VM is attached to multiple networks from which one or more
doesn't support userdata
You can merge this pull
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-209912550
@remibergsma, I've added description :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1494
Master nuage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack master_nuage
Alternatively you can review and apply
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-203794406
@pedro-martins, I do like it, but we didn't change that code, we just
restructured it a bit so I didn't want to touch the original code, I can still
make
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-202859071
@pedro-martins Updated the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168667533
@runseb, I've handled your comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1187#discussion_r46935277
--- Diff:
utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java
---
@@ -106,6 +104,8 @@ private void
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1187
Adapted HypervisorUtilsTest to no longer give false positives
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1187#issuecomment-162797756
@bhaisaab, @remibergsma, this is the ported commit for 4.6 described in
PR#1185
---
If your project is set up for it, you can reply to this email and have your
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162523432
@DaanHoogland, below you can find a possible alternative for this test file.
[HypervisorUtilsTestPatch.txt](https://github.com/apache/cloudstack/files/53965
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1185
Adapted HypervisorUtilsTest to no longer give false positives
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162551073
@bhaisaab, this is the PR for the test adaptation discussed in PR#1142
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162462731
@jburwell, thanks for the review! I've handled your comments. Thanks
@bhaisaab, would be great if we can still get this in 4.7
---
If your project is set up
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162496553
@bhaisaab, we've looked into the code of that test, and the results are
unreliable.
The steps that are done in that test (along with the implementation
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1142
CLOUDSTACK-9095 : Hypervisor changes to support UserData for Nuage VSP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159894668
@DaanHoogland, @remibergsma, can this be merged in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159642930
@rafaelweingartner, implemented the test cases as suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159629890
@rafaelweingartner, I've added a test for those methods
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158381857
@DaanHoogland, how about the following piece of code then? In this case we
are using the getPrefferedCharset()
```java
public static String
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158375131
@DaanHoogland, @fmaximus was right about the encoding. I rewrote that part
so we're always using the same encoding :)
---
If your project is set up for it, you
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158394211
@DaanHoogland
1. getBytesUtf8() and newStringUtf8() would no
longer be used.
2. With this new code, we won't any longer be only dependent on UTF-8
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158026133
@DaanHoogland, this PR contains the fixes for the build-master-slowbuild
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1092
Fix NuageVsp errors for build-master-slowbuild
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack master
Alternatively
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157683273
Awesome! Thanks @jburwell for the thorough review, thanks @remibergsma for
merging it in, thanks to all who helped getting this PR in! Much appreciated
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157371668
Thanks @remibergsma, much appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43090521
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -129,6 +145,18 @@
AgentManager _agentMgr
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091274
--- Diff: plugins/network-elements/nuage-vsp/pom.xml ---
@@ -28,6 +28,13 @@
4.6.0-SNAPSHOT
../../pom.xml
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093202
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093132
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093227
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093875
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +414,17 @@ protected boolean canHandle
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091431
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -67,25 +74,76 @@
import
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091944
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091957
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092995
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093020
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
@@ -51,13 +61,91 @@ public boolean
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092964
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093192
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093221
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network
1 - 100 of 271 matches
Mail list logo
