Build failed in Jenkins: build-master-slowbuild #2963

2016-01-11 Thread jenkins
See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: LTS release or not

2016-01-11 Thread ilya
There are good points for and against LTS. I do have specific use case that LTS solves, but in my opinion the scope of LTS would need to be revised. Why LTS is good idea? If you have environment with thousands of servers, upgrading from 4.5 to 4.7 and beyond would be rather risky. There are

Re: [DISCUSS] Move to Github

2016-01-11 Thread Sebastien Goasguen
> On Jan 10, 2016, at 12:50 PM, Daan Hoogland wrote: > > people, what we are saying by moving to github, completely is that, for > now, we will be moving away from apache. Apache can not take responsibility > for any code that is not under it's control. Daan, thanks

Re: Pull Requests we should include in 4.7.1 / 4.8.0

2016-01-11 Thread Sebastien Goasguen
> On Jan 10, 2016, at 3:54 PM, Ron Wheeler > wrote: > > Are all of the documentation issues fixed? there are no open PR on the docs repos. > > Does the documentation reflect the 4.7.1/4.8 release? > Are there any new issues that need to be created to update

[GitHub] cloudstack-docs pull request: Add Nuage plugin to the list

2016-01-11 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs/pull/15#issuecomment-170473016 @terbolous can you merge and close this ? LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

2016-01-11 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1325#issuecomment-170477896 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] Move to Github

2016-01-11 Thread Wido den Hollander
On 11-01-16 10:56, sebgoa wrote: > > On Jan 11, 2016, at 10:51 AM, Rene Moser wrote: > >> Hi Sebastien >> >> On 01/11/2016 09:53 AM, Sebastien Goasguen wrote: >>> Part 3: >>> >>> >>> To me the main issue for us is that our current privileges on GitHub >>> prevent us

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170508275 Hi @koushik-das Your questions were rhetorical and hence not valid because I did not disagree with you in terms of refactor. I asked you to help

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-01-11 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-170488605 @pedro-martins By java doc are you referring to adding some comments for isRouterDeployed()? Note that this is a private method. If you look at the unit

Build failed in Jenkins: build-master-slowbuild #2958

2016-01-11 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: [DISCUSS] Move to Github

2016-01-11 Thread Rene Moser
On 01/11/2016 10:56 AM, sebgoa wrote: > this is exactly what "moving to github" would mean. > if we agree to do this, we then need to work with infra and the board to make > sure everything is ok in terms of provenance and that it does not "break" our > ASF "commitment" I see. Thanks for

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

2016-01-11 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1325#issuecomment-170458897 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack-docs pull request: Add Nuage plugin to the list

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-11 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170483420 @wilderrodrigues My questions and comments are very valid. If you don't see any value in them too bad. Looks like you don't want to understand the point I am

Re: [DISCUSS] Move to Github

2016-01-11 Thread sebgoa
On Jan 11, 2016, at 10:51 AM, Rene Moser wrote: > Hi Sebastien > > On 01/11/2016 09:53 AM, Sebastien Goasguen wrote: >> Part 3: >> >> >> To me the main issue for us is that our current privileges on GitHub prevent >> us from building more productive CI workflow and

[GitHub] cloudstack-docs pull request: Add Nuage plugin to the list

2016-01-11 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs/pull/15#issuecomment-170481810 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] Move to Github

2016-01-11 Thread Rene Moser
Hi Sebastien On 01/11/2016 09:53 AM, Sebastien Goasguen wrote: > Part 3: > > > To me the main issue for us is that our current privileges on GitHub prevent > us from building more productive CI workflow and makes the life of the RM > more difficult (cannot use labels, cannot use issues,

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-11 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170505131 It's sorted! LGTM ![screen shot 2016-01-11 at 11 45

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-11 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-170825451 @mike-tutkowski : Yes, we decided to make random name as a preferred solution. You can refer the detail conversation on this PR #1273 . Thanks for

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-170804399 Just curious. If this is the expected behavior (mentioned above): It shouldn't create a volume with an empty name. Error should be returned.

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

2016-01-11 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1300#issuecomment-170801305 @kishankavala @koushik-das : Can you please review this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply

Build failed in Jenkins: build-master-slowbuild #2965

2016-01-11 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: LTS release or not

2016-01-11 Thread Daan Hoogland
ok, one last €0,01: any bug should be fixed not on the branch but on the commit it was introduced in and thenn be merged forward. It can then be merged into any branch that contains the offending commit and there is no longer any difference between LTS or anything else. Am I speaking Kardeshian? I

Build failed in Jenkins: build-master-slowbuild #2964

2016-01-11 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-11 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-170782564 @remibergsma status get updated in 'router.check.interval'. Please set that interval to low 30 sec to update the status immediately and try running once. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-11 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-170801193 @remibergsma : Any updates on this. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Build failed in Jenkins: build-master-slowbuild #2962

2016-01-11 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: [DISCUSS] Move to Github

2016-01-11 Thread Daan Hoogland
Ok, nice to see we have in the open what possible problems are. That said and as we are, my experience as RM leads me to say we should move sooner rather then later. explenation of my not always 100% clear communication methods: :+1:!!! On Mon, Jan 11, 2016 at 12:43 PM, Sebastien Goasguen

Build failed in Jenkins: build-master-slowbuild #2959

2016-01-11 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2016-01-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-170541020 One failure. I am yet to investigat if it is related. will try and find time soon.

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-11 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r49317967 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port, private_port,

Re: LTS release or not

2016-01-11 Thread Nux!
Daan, Ok, that sounds good, but at this point it's really up to the people writing actual code. Wido has already voted against it and SBP guys don't seem too keen on it either. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Daan

Summary: -1 LTS

2016-01-11 Thread Rene Moser
LTS by the community is not an option for now: Most of the threads/users/devs had concerns or are skeptical how it can be done in practice. As we recently changed the release process, it seems to "early" to change it again or add new processes to it. I still think CloudStack need some kind of

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170535918 Let's all move on, @koushik-das. If we don't, we will be talking about this for weeks. We have been saying the same thing all the time. I got your points

Re: LTS release or not

2016-01-11 Thread Nux!
I think LTS is a good idea, but I am afraid we'd be spreading ourselves too thin with maintaining that in addition to mainline. The way I see it, one way to have this sorted is by means of commercial offerings from companies such as ShapeBlue. What lifetime are we talking rougly for an LTS

Re: [DISCUSS] Move to Github

2016-01-11 Thread Sebastien Goasguen
> On Jan 11, 2016, at 11:15 AM, Wido den Hollander wrote: > > > > On 11-01-16 10:56, sebgoa wrote: >> >> On Jan 11, 2016, at 10:51 AM, Rene Moser wrote: >> >>> Hi Sebastien >>> >>> On 01/11/2016 09:53 AM, Sebastien Goasguen wrote: Part 3:

Re: LTS release or not

2016-01-11 Thread Daan Hoogland
Any version that is not a year old should be LTS in my view. We must as reviewers take care that fixes are merged on the oldest branch first and then merged forward along the line. To me this was the whole purpose of the changes we did to our release process. Are we abandonning this now to return

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170558660 @DaanHoogland @remibergsma @koushik-das It worked here without the commit mentioned by @koushik-das . ``` [root@cs1 integration]# less

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-11 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170520102 @wilderrodrigues My questions were not in the context of refactor at all. The reason for asking the questions was to highlight the point that for testing

Re: LTS release or not

2016-01-11 Thread Daan Hoogland
On Mon, Jan 11, 2016 at 7:58 AM, Rene Moser wrote: > >> * Fix must be important. > >> > > > > Who defines what 'important' is? > > "must be important" means we do not backport trivial things like typos > in docs and so forth, only important things. And I would say important >

Re: LTS release or not

2016-01-11 Thread Daan Hoogland
My point is that no backporting should have to take place. Wido and SBP should be convinced of the improved way of working and we shouldn't try to patch a less ideal way of working into something acceptable if we already have a good thing. I will start -1 any patch to 4.8 that could also go

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

2016-01-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-170516429 @phillipkent I understand, but looks like it still works without your fix. I was able to update network display test with a * in it: Update

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170542781 I got two failures. egress and an exception VPC_nics_after_destroy. No time to investigate today.

Re: LTS release or not

2016-01-11 Thread Rene Moser
On 01/11/2016 02:28 PM, Nux! wrote: > What lifetime are we talking rougly for an LTS release? 6 months, 12 months? I thought about 18 months. After 12 months we define a new LTS. So users have a 6 months time frame to switch from LTS to LTS.

[GitHub] cloudstack pull request: Quota: findbug fixes

2016-01-11 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1289#discussion_r49316008 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java --- @@ -310,14 +269,12 @@ public String

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-11 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1276#issuecomment-170543474 just ran the test again after adding the validateList method: command: ``` osetests --with-marvin

Re: LTS release or not

2016-01-11 Thread Sebastien Goasguen
> On Jan 11, 2016, at 2:41 PM, Nux! wrote: > > Daan, > > Ok, that sounds good, but at this point it's really up to the people writing > actual code. > Wido has already voted against it and SBP guys don't seem too keen on it > either. > Exactly, we can say we want an LTS,

Re: Let’s discuss database upgrades

2016-01-11 Thread Rafael Weingärtner
Hi John, Thanks for your contributions, sorry the late reply. I completely agree with Wido that the notion of the ACS version (e.g. 4.6.0, 4.6.1, 4.7.0, etc) should be a purely logical concept. It points to particular git hash, a version of the database schema, etc. I also agree that

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: LTS release or not

2016-01-11 Thread Ron Wheeler
There may have to be some rules about patches such as "You may not apply any bug fix to a minor release that will break the upgrade path." So 4.6.0, 4.6.1 and 4.6.2 can all be upgraded to 4.7.0 or the latest 4.7.x If a user absolutely needs a fix that breaks this, then it is their problem to

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2016-01-11 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-170620697 @DaanHoogland the problem seems to be related to something else. It seemed more like a DNS problem to resolve the google.com address --- If your

[GitHub] cloudstack pull request: NicProfileHelperImpl NullpointerException...

2016-01-11 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1328 NicProfileHelperImpl NullpointerException when ipVO is null When a VPC has a private gateway, and one would like to restart the VPC with **cleanup** it would fail. This PR adds a

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2016-01-11 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-170626131 I agree with @rafaelweingartner, since we can check that in last lines. --- If your project is set up for it, you can reply to this email and have your reply

Re: LTS release or not

2016-01-11 Thread Remi Bergsma
Guys, IMHO we should pick 4.7 instead of 4.6 as it has newer features (like the Metrics UI and some more stuff). Apart from that 4.7 has had more bug fixes. These could have been merged to 4.6, but we didn’t always do that. Let’s make sure we keep doing that for 4.7, also when 4.8 is out.

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: LTS release or not

2016-01-11 Thread Rene Moser
Hi Remi On 01/11/2016 04:16 PM, Remi Bergsma wrote: > Maintaining LTS is harder than it seems. For example with upgrading. You can > only upgrade to versions that are released _after_ the specific LTS version. > This due to the way upgrades work. If you release 4.7.7 when we’re on say > 4.10,

Build failed in Jenkins: build-master-slowbuild #2960

2016-01-11 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: LTS release or not

2016-01-11 Thread Daan Hoogland
thanks Remi, I think I we agree. On Mon, Jan 11, 2016 at 4:16 PM, Remi Bergsma wrote: > Guys, > > IMHO we should pick 4.7 instead of 4.6 as it has newer features (like the > Metrics UI and some more stuff). Apart from that 4.7 has had more bug > fixes. These could

Re: Summary: -1 LTS

2016-01-11 Thread Daan Hoogland
(rant alert) I have been stating this in the discuss thread and I don't agree with your conclusion; with our new workflow any release is a LTS as long as we maintain the discipline of allowing only bugfixes on the release they first appeared in (or 4.6 as a start point) If we maintain that

Re: LTS release or not

2016-01-11 Thread Remi Bergsma
Hi René, Yes, except there’s nothing in CloudStack that can handle such a version and I’m unsure if the extra dot works. If you call it 4.5.2-1 it works. You could only give the package a new version and then re-release 4.5.2. Although that probably is not compatible with the Apache release

Build failed in Jenkins: build-master-slowbuild #2961

2016-01-11 Thread jenkins
See Changes: [wrodrigues] CLOUDSTACK-9213 - Formatting the code [wrodrigues] CLOUDSTACK-9213 - Split the ACL rules using comma instead of dash. [aopgenoort] Fix mariadb related listCapacity bug (CLOUDSTACK-8966)

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-01-11 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-170636370 A javadoc is a notation above the method declaration that describes what the method do. javadoc with examples :)

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-11 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1276#issuecomment-170636254 ping @DaanHoogland --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9222 Prevent cloud.log.1 filli...

2016-01-11 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1329 CLOUDSTACK-9222 Prevent cloud.log.1 filling up the disk Delay Compress results in more space usage than needed. Since we have copy truncate we don't need it. You can merge this pull

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-11 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-170667305 Hi Guys ( @bhaisaab, @DaanHoogland, @remibergsma ).Did you get a chance to look at this? I think we can remove this safely. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9222 Prevent cloud.log.1 filli...

2016-01-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1329#issuecomment-170675145 Ping @borisroman @michaelandersen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Pull Requests we should include in 4.7.1 / 4.8.0

2016-01-11 Thread Ron Wheeler
Did anyone change anything that is not documented or that changes existing documentation? Do the people who accept PRs look at documentation as part of the process and create JIRA issues if the docs need changing? Ron On 11/01/2016 4:02 AM, Sebastien Goasguen wrote: On Jan 10, 2016, at