[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140053317 No direct commits to master. all the commits to master should be merges. I earlier reverted and merged a PR. Please check the comments on PR #728 and merge the

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140053426 I am reverting this direct commit. Please reopen the PR and use the git pr script to merge --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390690 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1971,7 +1971,7 @@ protected void

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390674 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1981,7 +1981,7 @@ private void

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390601 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1971,7 +1971,7 @@ protected void

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390959 --- Diff: server/src/com/cloud/storage/upload/UploadListener.java --- @@ -113,7 +113,7 @@ protected void runInContext() { private

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/819 Tagging tests appropriately to pick them for running on basic zone Adding additional tag to the list of tags. You can merge this pull request into a Git repository by running: $ git pull

Re: Wiki edit permissions

Done. ~Rajani On 14-Sep-2015, at 3:58 pm, Suresh Kumar Anaparti wrote: > Hi, > > I wanted to add some design documentation to wiki. Please grant me edit > permissions. My ID: sureshkumar.anaparti. > > Thanks, > Suresh >

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390123 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -3327,7 +3330,7 @@ private Answer

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390917 --- Diff: server/src/com/cloud/storage/LocalStoragePoolListener.java --- @@ -39,7 +39,7 @@ import com.cloud.utils.db.DB; public

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390966 --- Diff: server/src/com/cloud/storage/upload/UploadListener.java --- @@ -270,7 +274,7 @@ public AgentControlAnswer processControlCommand(long

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140071482 Hi Miguel, Fortunately this PR is such that there is essentially no existing test code that needed to be modified. At a high level, this code simply

Wiki edit permissions

Hi, I wanted to add some design documentation to wiki. Please grant me edit permissions. My ID: sureshkumar.anaparti. Thanks, Suresh

Re: Recurring snapshot taking full every time

Looks like the host is not instrumented properly and management server is unable to invoke plugin on the host. Can you force-reconnect the host that is throwing this error ? That should recopy the plugins on to the host. > On 14-Sep-2015, at 3:15 pm, raja sekhar wrote:

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/818 Fixed: Network Update from RVR offering to Standalone offering fails Problem: Moving a RVR network offering to standalone makes the status of VR's as UNKNOWN and Redundant Router marked with

New Defects reported by Coverity Scan for cloudstack

Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 5 new defect(s) introduced to cloudstack found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390723 --- Diff: server/src/com/cloud/network/security/SecurityGroupListener.java --- @@ -81,7 +81,7 @@ public boolean isRecurring() { @Override

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390730 --- Diff: server/src/com/cloud/network/security/SecurityGroupListener.java --- @@ -106,7 +106,7 @@ public boolean processAnswers(long agentId,

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/820 CLOUDSTACK-8840: Systemd service for the Usage Server There already was a uncompleted systemd service file for the Usage Server. This new one replaces sysvinit and the old systemd

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140046870 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/821#issuecomment-140048982 Pending Travis -> LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/821#issuecomment-140059934 comment about the log message, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/821#discussion_r39388787 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java --- @@ -877,8 +877,8 @@ public boolean

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390243 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -4420,11 +4450,13 @@ private void

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140046588 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/821 CLOUDSTACK-8645: Improve logging of RBD functionality in KVM A simple commit which changes a couple of log lines. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390851 --- Diff: server/src/com/cloud/storage/LocalStoragePoolListener.java --- @@ -18,7 +18,7 @@ import javax.inject.Inject; -import

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/817 Cherry-pick PR #795 into 4.5 branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack 4.5 Alternatively you can

Jenkins build is back to normal : build-master-slowbuild #2304

See

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390513 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1589,8 +1589,8 @@ protected StringBuilder

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140056577 FWIW LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140059312 @karuturi Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390303 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java --- @@ -115,7 +115,7 @@

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140080679 Hi Miguel, I can remove those commented-out lines. No problem. Some companies like such lines left in, but others - as you point out - like them

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-140101031 @bvbharatk or @ke4qqq something went wrong with the auto-close (wasn't merged properly) Could either of you close this PR please? Thanks! --- If your project

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140077337 Hi again Mike, Thanks for addressing my questions. Regarding the commented-out code, I see from your answers that the reason for leaving

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140097887 Sure, I'd be happy to get your input on how you see us unit testing this code. In the past, I've mainly restricted my CloudStack testing (automated and

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39394113 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java --- @@ -124,6 +132,22 @@

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140095795 Hi @mike-tutkowski Thanks for being open about removing the commented-out code. IMHO (and not just mine btw) commented-out code poses a serious

[GitHub] cloudstack pull request: CID 1324349: conditionally return -1 or t...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/822 CID 1324349: conditionally return -1 or the dc id for the volume You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/823 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id When calling listServiceOfferings with VM id as parameter. It is returning

Build failed in Jenkins: build-systemvm-master #624

See Changes: [Rajani Karuturi] CLOUDSTACK-8816 Fixed entityUuid missing in some cases is events [Rajani Karuturi] CLOUDSTACK-8816: instance uuid is missing in events for delete account [Rajani Karuturi] CLOUDSTACK-8816:

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39452237 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,214 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39451499 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,214 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469559 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473421 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473393 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39474044 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39474082 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39474118 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469518 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470168 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaCreditsVO.java --- @@ -0,0 +1,117 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470153 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaCreditsVO.java --- @@ -0,0 +1,117 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470144 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaBalanceVO.java --- @@ -0,0 +1,127 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470434 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,136 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470643 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470650 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java --- @@ -0,0 +1,95 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470619 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39471282 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39471234 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39471718 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472260 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472187 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473652 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140277680 4.5 was missing upgrade path, implemented that; please push again to force a travis build --- If your project is set up for it, you can reply to this email and

Re: Build failed in Jenkins: build-systemvm-master #624

Anyone understands why this is failing? ~Rajani On 15-Sep-2015, at 3:23 am, jenk...@cloudstack.org wrote: > See > > Changes: > > [Rajani Karuturi] CLOUDSTACK-8816 Fixed entityUuid missing in some cases is > events > >

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473690 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473707 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user bvbharatk closed the pull request at: https://github.com/apache/cloudstack/pull/784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39474147 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469479 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,82 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469424 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469851 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469805 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469861 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,86 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470029 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,86 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470069 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/UserVmDetailsDaoImpl.java --- @@ -0,0 +1,62 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470928 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaCreditsResponse.java --- @@ -0,0 +1,91 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470951 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470999 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472092 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472075 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472668 --- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java --- @@ -373,6 +381,26 @@ protected void runInContextInternal() { }

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472656 --- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java --- @@ -373,6 +381,26 @@ protected void runInContextInternal() { }

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472643 --- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java --- @@ -373,6 +381,26 @@ protected void runInContextInternal() { }

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39472622 --- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java --- @@ -373,6 +381,26 @@ protected void runInContextInternal() { }

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473180 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473211 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473201 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473261 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39473760 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39474267 --- Diff: usage/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java --- @@ -0,0 +1,239 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39474327 --- Diff: usage/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java --- @@ -0,0 +1,203 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469677 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470599 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateUpdateCmd.java --- @@ -0,0 +1,122 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470564 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39470575 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateListCmd.java --- @@ -0,0 +1,60 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39471028 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39471164 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the

  1   2   >