Re: Introduction

On Fri, Apr 8, 2016 at 6:58 AM, Rashmi Dixit wrote: > Hello! > > I am Rashmi Dixit and have recently joined the CloudPlatform team in > Accelerite. I have worked on a hybrid cloud management solution supporting > hypervisors such as KVM, Xen, VMware, HyperV and

Re: Introduction

Welcome aboard, Rashmi ! 2016-04-08 6:58 GMT+02:00 Rashmi Dixit : > Hello! > > I am Rashmi Dixit and have recently joined the CloudPlatform team in > Accelerite. I have worked on a hybrid cloud management solution supporting > hypervisors such as KVM, Xen, VMware,

Re: Introduction

Welcome aboard! From: Rashmi Dixit Sent: Thursday, April 7, 2016 10:58 PM To: dev@cloudstack.apache.org Subject: Introduction Hello! I am Rashmi Dixit and have recently joined the CloudPlatform team in Accelerite. I have

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

GitHub user Slair1 opened a pull request: https://github.com/apache/cloudstack/pull/1478 CLOUDSTACK-9342: Site to Site VPN PFS not being set correctly Bug in code set PFS to the same value (yes/no) as DPD. file.addeq(" pfs=%s" % CsHelper.bool_to_yn(obj['dpd'])) You can

Introduction

Hello! I am Rashmi Dixit and have recently joined the CloudPlatform team in Accelerite. I have worked on a hybrid cloud management solution supporting hypervisors such as KVM, Xen, VMware, HyperV and public clouds such as EC2. My areas of interest are User Interface, networking. I am really

Build failed in Jenkins: build-master-slowbuild #3527

See -- [...truncated 497 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-framework-managed-context --- [debug] execute contextualize [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-207159853 That is great. Shouldn't you also verify if the sleep method is being used? If we remove that (the sleep), will the code continue to work as it is

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-207159361 @rafaelweingartner now I am using PowerMockito to test the "throwSshExceptionIfSshConnectionIsNull" method without the need to wait for the

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207155639 No problem. Ya it took me a couple pull requests to figure out how they work. Thanks for taking the time to do this for me. :) --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207150675 thanks @swill , it looks much better now, i needed the -f on the git push --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1253#issuecomment-207147802 ### ACS CI BVT Run **Sumarry:** Build Number 161 Hypervisor xenserver NetworkType Advanced Passed=110 Failed=18 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-207146770 @swill just reviewed. @abhinandanprateek I have a few more comments to be addressed on the test cases. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58965582 --- Diff: test/integration/component/test_host_maintenance.py --- @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58965445 --- Diff: tools/marvin/marvin/lib/utils.py --- @@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid, allowedstates): if

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58965346 --- Diff: tools/marvin/marvin/lib/utils.py --- @@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid, allowedstates): if

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58964900 --- Diff: tools/marvin/marvin/lib/utils.py --- @@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid, allowedstates): if

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58964733 --- Diff: tools/marvin/marvin/lib/utils.py --- @@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid, allowedstates): if

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207144084 Once you get your local branch setup correctly with the squashed commit, you should be able to do a `push - f` to replace what is in the PR with what you have

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207141177 @swill thanks, that makes sense. I did it to my branch the first time, but for some reason when i tried to save to here it just created two more commits. i'll try

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-207133913 I agree with you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-207113402 @rafaelweingartner yes, I think this is ready too. I am trying to get two LGTM for every PR, so can someone else from the dev list give me a review? --- If

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-207112861 Yes, I think this one is ready. I am trying to get two LGTM code reviews on every PR, so can one of @DaanHoogland or @pdube give me a LGTM, I have one from

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-207111301 I have gone through the code, it LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58953686 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-207109385 @abhinandanprateek tests have passed, thanks for the updates. Can you do a `push -f` to kick off a Jenkins run so we can try to get this PR all green.

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58952716 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-207107811 ## CI RESULTS ### 84/85 TESTS PASSED The test that failed is a test that commonly fails in my environment and has been

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207101177 No one is allowed to push code to `apache/cloudstack`, you have to push it to your fork where your PR is coming from. Does that make sense? --- If your project is

Re: PRs for 4.9 Release

If you are using bubble, here are a few more 'tweaks'. The 'bubble-blueprint' is missing the following, so you will need to do the following after you run it: $ systemctl stop firewalld $ systemctl disable firewalld Also, if you are using a static IP, you will have to manually add the following

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-207084566 @swill another one that seems to be ready to be merged. What do you think? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-207084266 @swill what about this one? The tests were already executed and everything passed. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-207082450 @remibergsma this looks like a good improvement to processing on the VR. Please look through my feedback on #1465 regarding string and logging performance. They

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207081102 @rafaelweingartner I'll check this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58941182 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58940609 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long

Re: PRs for 4.9 Release

For those interested: Fred and I have some adjustments for Fedora and as Cloudstack we need to remain at java 1.7 for now while the SBP guys are ahead of us at 1.8. On Thu, Apr 7, 2016 at 10:30 PM, Remi Bergsma wrote: > Great to see more and more people use the

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207077724 @swill i seem to get an access denied when pushing my change: C:\slair\Source\Github\cloudstack [pr/1433]> git push origin pr/1433 --force remote: Permission

Re: PRs for 4.9 Release

Great to see more and more people use the bubbles! Setting up: https://github.com/MissionCriticalCloud/bubble-blueprint Using: https://github.com/MissionCriticalCloud/bubble-toolkit Happy testing :-) Regards, Remi > On 07 Apr 2016, at 19:56, Will Stevens wrote: > >

[GitHub] cloudstack pull request: When no zone name is available display a ...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1477 When no zone name is available display a default When a zone name is available, the previous behaviour is still there: ![screen shot 2016-03-30 at 21 00

[GitHub] cloudstack pull request: Fix deleting template from UI

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1476 Fix deleting template from UI It failed because zoneid was zero. Added a check for it and only send it when it makes sense. With zoneid: ![screen shot 2016-03-29 at 21 40

[GitHub] cloudstack pull request: Remove unused images

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1475 Remove unused images We really don't need this, do we? Check your own cloud, it's there... ![screen shot 2016-03-22 at 17 38

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207062648 No worries. :) This should work: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-207058799 @swill all green now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: 47 private gw initial config

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1474 47 private gw initial config When initialising a VPC router we need to know which IP/device corresponds to a private gateway. This is to solve a problem when stop/starting a VPC router

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58931640 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,25 @@ private Volume orchestrateDetachVolumeFromVM(long vmId,

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207057213 @nvazquez there is something wrong with one of your SQLs. > Unable to upgrade the database: Unable to execute upgrade script:

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58927653 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -292,6 +292,9 @@ public ExecutionResult

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58929616 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,25 @@ private Volume orchestrateDetachVolumeFromVM(long

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58927993 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -300,6 +303,8 @@ public ExecutionResult

[GitHub] cloudstack pull request: Make the generated json files unique to p...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1470 Make the generated json files unique to prevent concurrency issues The json files now have UUIDs to prevent them from getting overwritten before they've been executed. Prevents config to

[GitHub] cloudstack pull request: Apply static routes on change to master s...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1472 Apply static routes on change to master state Refactored static routes for private gateways so they also get loaded when the router switches to master state. Otherwise they're lost and

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1465#issuecomment-207054605 it was already started :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1473 Bump ssh retries to prevent false positives of test_loadbalance No more false positives after this change. ``` [root@cs1 integration]# cat

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1469 Bump ssh retries to prevent false positives of test_loadbalance No more false positives after this change. ``` [root@cs1 integration]# cat

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58927692 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java --- @@ -104,13 +109,25 @@ public static

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1471 Lower the time we wait for interfaces to appear Waiting for interfaces is tricky. They might never appear.. for example when we have entries in `/etc/cloudstack/ips.json` that haven't been

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58927425 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java --- @@ -104,13 +109,25 @@ public static

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1465#issuecomment-207051489 @DaanHoogland This can be pointed towards 4.7 so I will close this and open one to 4.7 instead of master. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Apply static routes on change to master s...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1468 Apply static routes on change to master state Refactored static routes for private gateways so they also get loaded when the router switches to master state. Otherwise they're lost and

Re: Masters Thesis on False Alarms in Test Failures

Kevin, what you intent to do sound promising. I think you are on your own in collecting data but by the sound of it you allready have a list of 110 name/question pairs, do you? If not, how do you intent to do the collection of the data you require? On Thu, Apr 7, 2016 at 4:04 PM, Kevin van den

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1467 Lower the time we wait for interfaces to appear after restart Waiting for interfaces is tricky. They might never appear.. for example when we have entries in `/etc/cloudstack/ips.json`

Re: [jira] [Created] (CLOUDSTACK-9341) Cannot upload volume when using Swift as secondary storage

PLD, do we have a github PR for this one already? I thought we had a fix for this locally. On Apr 7, 2016 2:45 PM, "Pierre-Luc Dion (JIRA)" wrote: > Pierre-Luc Dion created CLOUDSTACK-9341: > --- > > Summary: Cannot upload

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1465#issuecomment-207044590 code LGTM running integration suite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58923375 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh --- @@ -91,7 +91,7 @@ do done < $cfg #remove the configuration

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207038085 @swill , i apologize, but this is my first PR. I squashed it in Github Desktop on my local copy and did a push, but it sees like it it just added additional

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1466 CLOUDSTACK-9340: General DB Optimization ## Description In some production environments there were being experimented delays in most of the jobs. A search for DB optimization was taken

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207033442 I applied 1433 and then tried to apply 1409, but 1433 changes prevent the later patch from matching previous lines. One or the other probably needs to be based

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207031562 @mike-tutkowski, @swill I am ok with that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207031227 Thanks for the comments @rafaelweingartner and @ustcweizhou. Since canHandle is part of the infrastructure, we decided this particular PR isn't the

Re: PRs for 4.9 Release

Yes, we'll be testing these on real hardware. From: williamstev...@gmail.com on behalf of Will Stevens Sent: Thursday, April 7, 2016 12:59 PM To: dev@cloudstack.apache.org Subject: Re: PRs for 4.9 Release

Re: PRs for 4.9 Release

Awesome, thanks for the list Simon. Will you be actively testing these against real hardware and posting the results? Feel free to use 'upr comment' [1] if it will help you post back your results. Let me know if you have questions and I will try to get you sorted. [1]

Re: PRs for 4.9 Release

If you want me to verify things in your env, you can send me a tmate and I can have a look. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at 1:54 PM,

Re: PRs for 4.9 Release

yes, makes perfect sense. I skipped 1326 for now, I just tried to build 1436 it fails in the rpm build fase. I am now going to try that ui thing to build confidence in my test environment. On Thu, Apr 7, 2016 at 7:49 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Sure it makes. >

Re: PRs for 4.9 Release

Will et al, These are currently the PRs we're tracking in our merge list: https://github.com/apache/cloudstack/pull/1230 https://github.com/apache/cloudstack/pull/1462 https://github.com/apache/cloudstack/pull/1441 https://github.com/apache/cloudstack/pull/1428

Re: PRs for 4.9 Release

Sure it makes. On Thu, Apr 7, 2016 at 2:47 PM, Will Stevens wrote: > Yes, if the PR is ONLY a test and does not touch any other code then we can > only run that test. I agree with you. > > If any code is changed outside the test, I always run the full suite. Make >

Re: PRs for 4.9 Release

Yes, if the PR is ONLY a test and does not touch any other code then we can only run that test. I agree with you. If any code is changed outside the test, I always run the full suite. Make sense? *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|*

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-207022111 I can't specifically test the VMware functionality, but I can validate that it does not break anything else. I have added this to my queue for CI. --- If your

Re: PRs for 4.9 Release

running a new test in an environment should pass but should not require all other test being re-validated. SO what is the point of running all others? I am not saying we shouldn't regularly run all tests but in this case it adds no value AFAICT. On Thu, Apr 7, 2016 at 7:35 PM, Will Stevens

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-207019005 @swill @rafaelweingartner @jburwell fixed outstanding issues and added more unit tests --- If your project is set up for it, you can reply to this email and have

Re: PRs for 4.9 Release

Yes, I agree we only need to run tests against the branch it was created on. It probably SHOULD be done against all branches it will be merged into, but we need to have things streamlined a bit more for that to be viable IMO. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1465 Fix concurrency issue on virtual router The json files now have UUIDs to prevent them from getting overwritten before they've been executed. Prevents config to be pushed to the wrong

Re: PRs for 4.9 Release

I also had problems with 1459, but I was trying to run 4 CIs in the same bubble, so I thought it may have had something to do with that. I want to run it on its own so I don't have resource contention to make sure the tests are actually failing. *Will STEVENS* Lead Developer *CloudOps* *|

Re: PRs for 4.9 Release

Yes, I want to run tests against the tests. I have found issues in some of the tests not working as expected, so I add the test to the run and run them. I think it is worth it because then we know the test is valid later. I would rather have the author fix the test now if there are problems

Re: PRs for 4.9 Release

IMO, we only need to run the test and check if it works against the branch that it was created upon. On Thu, Apr 7, 2016 at 2:30 PM, Daan Hoogland wrote: > 1326 is just a test. it does not touch production code. Do we run > regression tests against such PRs. seems a

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: PRs for 4.9 Release

1326 is just a test. it does not touch production code. Do we run regression tests against such PRs. seems a waste to me. On Thu, Apr 7, 2016 at 7:27 PM, Daan Hoogland wrote: > > On Thu, Apr 7, 2016 at 7:26 PM, Daan Hoogland > wrote: > >> 1326

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-207014015 @serg38 awesome, thank you. I will get this merged... Yes, good new about Accelerite. I am very hopeful they will be able to add value to the ACS community

Re: PRs for 4.9 Release

On Thu, Apr 7, 2016 at 7:26 PM, Daan Hoogland wrote: > 1326 - master (*pending CI) ​starting​ -- Daan

Re: PRs for 4.9 Release

i just finished redoing 1459 but the first 5 tests failed so i aborted and am looking for a new target On Thu, Apr 7, 2016 at 7:24 PM, Will Stevens wrote: > Thanks Daan. I really wish I had the ability to label PRs because that > would make things SO much easier. > > I

Re: PRs for 4.9 Release

Thanks Daan. I really wish I had the ability to label PRs because that would make things SO much easier. I have these 3 pending CI, all of which need changes the the ' helper_scripts/cloudstack/run_marvin_router_tests.sh' because they are PRs on tests, so we have to explicitly add the test to

Re: PRs for 4.9 Release

Thanks Rafael. I have 1/2 of those on my watch list, so I will review the ones I am not already actively working on. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at

Re: PRs for 4.9 Release

will, Fred Neubauer just helped me finalize my test environment on a fedora laptop. I will be chipping away at the pile as well. hopefully at a rate of one per day. I would like your directions as to which I can pick. of course I can go my own way but double work is a shame. On Thu, Apr 7, 2016

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906935 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfoTest.java --- @@ -0,0 +1,46 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906447 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java --- @@ -39,4 +38,11 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206992288 @serg38 thats is great. So, Do I or you (@Swill) do the honors to execute the merge. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906077 --- Diff: server/test/com/cloud/vm/UserVmManagerTest.java --- @@ -928,4 +928,13 @@ public void testUpdateVmNicIpFailure3() throws Exception {

  1   2   >