[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-210655468 @nvazquez you can create a common super class for those class, and put it into the “cloud-server” project. Additionally, you can remove the

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-210646612 It seems to be in pretty good order. I would like some code reviews and since there are changes to logic outside of the tests, I would like a full CI run against

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-210643703 @KrisSterckx I think so but not sure. @swill can you put this in? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r59934099 --- Diff: tools/marvin/marvin/lib/utils.py --- @@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid, allowedstates): if

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-210619709 @abhinandanprateek Jenkins failed due to no license header in the new test case, test_host_ha.py. Travis failed because it could not find the Marvin egg. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-210618704 @DaanHoogland I rebased against master, and Travis and Jenkins have gone green. Looks like my branch was out of date. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1497#discussion_r59923092 --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java --- @@ -1731,6 +1731,17 @@ Long zoneId = cmd.getZoneId(); Long

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59920010 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59918834 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,215 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-210576373 Thanks all for the review, I've update the commits; please re-review and advise other outstanding issue. Thanks again. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59917981 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1497#discussion_r59917535 --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java --- @@ -1790,6 +1802,10 @@ sc.setParameters("display",

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1497#discussion_r59917122 --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java --- @@ -1731,6 +1731,17 @@ Long zoneId = cmd.getZoneId();

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-210569587 Yes, it is only this proposal. Cool, I'll squash them --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-210567690 Ah ok, so our home made JPA takes care of that ;) That felt a little weird to me, but now I understand why. I would only suggest you squashing your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59915385 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean isClient)

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59915315 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59915248 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean isClient)

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59915144 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-210566503 Hi @rafaelweingartner, yes, I did test them. I provided new parameters in API calls and they retrieved objects as expected. About the implementation, I was

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59914101 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean isClient)

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59913697 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59913436 --- Diff: utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java --- @@ -94,7 +94,7 @@ public void wakeupNotExisting() {

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59913672 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59913051 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean isClient)

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59913073 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59912710 --- Diff: utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java --- @@ -94,7 +94,7 @@ public void wakeupNotExisting()

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59912439 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-210561289 @nvazquez have you tested this change? I noticed that you are using the SearchCriteria, shouldn’t that “idIN” have to be at the POJO and

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59900221 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean isClient)

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59900296 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean isClient)

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59900210 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean isClient)

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59894203 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59892756 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1497 CLOUDSTACK-9351: Add ids parameter to resource listing API calls ## General behaviour A new parameter is added in each method, its type a list of IDs of the entity, it will be mutually

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

Github user sverrirab commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-210485675 I agree that this is not a good approach but it is the current one and it is broken. How about we commit this fix and I submit a new PR to master with a new

RE: [discuss] CloudStack logging

Hi Pierre-Luc, I have a pull request in to fix the rotating of the catalina.out logs - I'll check what it's status is. And yes, being able to view VR, CPVM and SSVM logs from mgmt. server would be awesome. Some of our clients have 1000s of VRs so, some real thought needs to go into it...

Re: [DISCUSS] Request for comments : VPC Inline LoadBalancer (new plugin)

Thanks for this update Ilya, Best regards, Kris On 11 April 2016 at 07:59, ilya wrote: > Kris and Nick > > Noticed an update in the FS: > > >> The VPC Inline LB appliance therefore is a regular System VM, exactly > the same as the Internal LB appliance today.

Re: PRs for 4.9 Release

On Thu, Apr 7, 2016 at 6:15 PM, Will Stevens wrote: > I know this is not how this usually works, but I need to crowd source some > info to be more effective. > > I am slowly getting things rolling for the 4.9 release. My CI is chugging > away and I have a queue of PRs

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-210464551 Hi @DaanHoogland is this PR still in the candidate list of 4.9.0 ? If there is anything that I & the team can facilitate in doing, pls let me know.

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

Hi, The system VMs are just running on local storage. Thanks, Mike > On Apr 15, 2016, at 12:49 AM, Anshul Gangwar > wrote: > > Mike, what type of storage are you using? > > >> On 15-Apr-2016, at 9:49 AM, Tutkowski, Mike >> wrote:

Re: [discuss] CloudStack logging

Something that could be interesting also is to remove VR and systemVMs logs from the cloudstack-management.log and have them into a separate files. I'm still not sure of those logs are traps only when there is problems, if it's the case it make sense to keep them in cloudstack-management.log.

Re: Feature proposal: Resource naming policies

Security group is one such feature as you have mentioned. Vm sync may get impacted if VM internal names are changed. Once all integration/regression tests are run additional things may come up. I think it will be a good idea to have a wiki document describing all resource types that are

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59863002 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59861537 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-210423416 Thanks all, I've fixed most issues. Please see any outstanding issue and let me know if you find any other issue. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59860632 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-210422617 Marvin output with only Local storage: 49b-b201830aec39 VirtualMachine on Hyp 1 = 1d500ef3-ef56-4d11-91d8-c0e37f015236 VirtualMachine on

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-210422584 Marvin test output for NFS PS: hine on Hyp 1 = 228dc462-ceab-4225-8d35-5749cbb593c2 VirtualMachine on Hyp 1 =

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1496 CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost for Local storage - KVM-HA- Fix CheckOnHost for Local storage - Also skip HA on VMs that are using local storage You can merge this

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59860389 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59859824 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59859628 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59859123 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicy.java --- @@ -0,0 +1,36 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59858602 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59858459 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59858432 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59858001 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59857962 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59857842 --- Diff: api/test/org/apache/cloudstack/acl/RuleTest.java --- @@ -0,0 +1,39 @@ +package org.apache.cloudstack.acl; + +import

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59857696 --- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59856830 --- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59856707 --- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59856583 --- Diff: api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java --- @@ -117,6 +123,12 @@ public long getEntityOwnerId() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59856523 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/ListRolePermissionsCmd.java --- @@ -0,0 +1,104 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59855818 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java --- @@ -0,0 +1,104 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59855822 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/DeleteRoleCmd.java --- @@ -0,0 +1,84 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59855472 --- Diff: api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java --- @@ -196,5 +204,8 @@ private void validateParams() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59855085 --- Diff: api/src/org/apache/cloudstack/acl/Rule.java --- @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59854979 --- Diff: api/src/org/apache/cloudstack/acl/Rule.java --- @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59853380 --- Diff: server/src/org/apache/cloudstack/acl/RoleManagerImpl.java --- @@ -0,0 +1,242 @@ +package org.apache.cloudstack.acl; --- End diff --

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59853322 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/CreateRolePermissionCmd.java --- @@ -0,0 +1,121 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59853146 --- Diff: engine/schema/src/com/cloud/user/AccountVO.java --- @@ -83,8 +86,16 @@ public AccountVO(String accountName, long domainId, String

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59852956 --- Diff: api/test/org/apache/cloudstack/acl/RuleTest.java --- @@ -0,0 +1,39 @@ +package org.apache.cloudstack.acl; --- End diff --

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59852709 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/ListRolesCmd.java --- @@ -0,0 +1,118 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59852554 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java --- @@ -0,0 +1,104 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59852381 --- Diff: api/src/org/apache/cloudstack/acl/RoleService.java --- @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Foundation (ASF) under one

Re: [discuss] CloudStack logging

Paul, I think that asking for input is a good approach. Those that have problem with a certain log message or - sequence are the best to say what should be different. Whether we should make hundreds of PRs or one?.. neither. I would say change anything from a big class to a small package, or get

RE: [discuss] CloudStack logging

Great, I'll pick up the issue that Wido has already created https://issues.apache.org/jira/browse/CLOUDSTACK-8645 Does anyone have an suggestions wrt to structure of pull requests? I'm inclinded to ask the community for copies of logs - particularly ones that people have found difficult to read

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

Mike, what type of storage are you using? > On 15-Apr-2016, at 9:49 AM, Tutkowski, Mike wrote: > > I'm not sure, Daan. > > I plan to keep an eye on this behavior for a while when creating new clouds. > > > From: Daan Hoogland