RE: Migrating CloudStack content from download.cloud.com

2016-05-13 Thread Paul Angus
Raja,

I've just picked up on this.

There are a number of URLs which are hardcoded into the CloudStack database for 
the small built-in templates.  These are in just about every copy of CloudStack 
out there.

http://download.cloud.com/templates/builtin/f59f18fb-ae94-4f97-afd2-f84755767aca.vhd.bz2
http://download.cloud.com/releases/2.2.0/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2
http://download.cloud.com/templates/builtin/centos56-x86_64.vhd.bz2
http://download.cloud.com/releases/4.3/centos6_4_64bit.vhd.bz2
http://download.cloud.com/releases/2.2.0/CentOS5.3-x86_64.ova
http://download.cloud.com/templates/builtin/centos-7-x86_64.tar.gz


These will need copying and the CloudStack code updating to the new location.


I don't think that you can deprecate download.cloud.com or it's contents for 
some time, without causing a lot of issues for users.









Hi,



Short Term - all the content has moved to cloudstack.apt-get.eu



Which sections to be modified?



The Install Guide needs to be modified.  Sample links/details are mentioned
below for 4.6 and same needs to be updated for other Released versions of
Cloudstack documentation:

http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.6/management-server/#downloading-vhd-util

Section - Downloading vhd-util¶



What to do modified ?

modify URL from http://download.cloud.com.s3.amazonaws.com/tools/vhd-util to
http://cloudstack.apt-get.eu/tools/vhd-util



@Rajsekhar can you please update the sections ?



Thanks

Raja

Senior Manager, Product Development

Accelerite,

2055, Laurelwood Road,  Santa Clara, CA 95054, USA

Phone: 1-408-216-7010,  www.accelerite.com, @accelerite


Kind regards,

Paul Angus


Regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


Re: [DISCUSS] Moving to Java8

2016-05-13 Thread Ron Wheeler


https://jira.spring.io/browse/SPR-11656
has a pretty good description of spring 3.2.13 support for Java 8

They did add support for Java 8 bytecode.
I am only at 3.2.4 and have no problems but we are pretty explicit about 
wiring and do not use autowiring.


In the end, we will all end up moving off Spring 3 so if it is 
manageable without delaying the release, it may be a good idea to bite 
the bullet and do both at once.


Ron


On 13/05/2016 7:56 PM, Ron Wheeler wrote:


All my code is compiled with Java 8.

I have not had any problem since I moved my stuff to Java 8 with 
Spring 3 but I may just be lucky.


I am not sure how much of a change to code or configurations is 
required to upgrade to Spring 4 so it may not be a big deal to do both 
upgrades in one release.


Ron

On 13/05/2016 5:26 PM, John Burwell wrote:

Ron,

According to Spring's documentation, Spring 3 only supports running 
byte code compiled for 1.7 on a Java8 VM [1].  Spring 4 is the first 
release to support byte code compiled to 1.8 running on a Java8 VM.


Our experience with CloudStack 4.5 and master on Java8 has been that 
it runs, but within 36-48 hangs or abends.  Therefore, the first step 
to getting a stable build on JDK8 is to ensure that all our 
dependencies support it.


Thanks,
-John

[1]: 
https://spring.io/blog/2013/05/21/spring-framework-4-0-m1-3-2-3-available/


Regards,

John Burwell

john.burw...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 13, 2016, at 2:04 PM, Ron Wheeler 
 wrote:
I am not sure what you are using in Spring but I have been using 
Spring 3.x.x with Java 8 for some time.


I can believe that Spring 4 is "better" than Spring 3 but you might 
see if you can separate these two technology upgrades just to keep 
it simple.
There is enough in Java 8 to make a pretty big project if you just 
look at Streams and refactoring interfaces and abstract classes to 
reduce the amount of code.


Just a comment from the cheap seats.

Ron



On 13/05/2016 1:10 PM, Rohit Yadav wrote:
All,


I've started some work [pr] that aims to adapt CloudStack to recent 
changes in the environments and the ecosystem:



- Java8, Spring 4.x

- SystemD

- MariaDB and MySQL

- Reduce distro provided package dependency

- Packaging, CI and testing


These are long term goals but I've identified some concrete goals:


- Migrate to Java8 both for building codebase and running 
CloudStack (mgmt server, usage, agent etc)


- Migrate to Spring 4.x as 3.x is not supported to work with Java7

- Fix CI and packaging to use Java8

- Reduce distro specific package dependency such as Tomcat, since 
we're already using Jetty (maven-jetty-plugin) during development 
we can use embedded Jetty for mgmt server(s) as well


- Update systemvm template to include Java8 JRE

- Update packaging to support systemd (CentOS7+ has some systemd 
support and thanks to Wido's recent PR we would have systemd 
support for debian packages in future too)


- Optimize JVM options for long running mgmt server(s), agent(s) 
and usage server(s) to run on JRE8



I've sent a [pr] to show some initial progress in this regard where 
we've some outstanding issues but we're able to build/run/test with 
Java8 + Spring 4.x and TravisCI has been fixed to use JDK8 as well.



Testing in general would be a huge requirement for this initiative, 
especially testing of all the plugins. Java7 has EOL-ed and Java9 
is around the corner; we've seen good amount of security and memory 
issues with Java7/6 and Tomcat6.x; therefore it seems necessary to 
work on above as we move towards a LTS release in upcoming months.



Request for comments, suggestions and guidance. Thanks.


[pr] https://github.com/apache/cloudstack/pull/1546


Regards.

Regards,

Rohit Yadav

rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102







--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



Re: [DISCUSS] Moving to Java8

2016-05-13 Thread Ron Wheeler


All my code is compiled with Java 8.

I have not had any problem since I moved my stuff to Java 8 with Spring 
3 but I may just be lucky.


I am not sure how much of a change to code or configurations is required 
to upgrade to Spring 4 so it may not be a big deal to do both upgrades 
in one release.


Ron

On 13/05/2016 5:26 PM, John Burwell wrote:

Ron,

According to Spring's documentation, Spring 3 only supports running byte code 
compiled for 1.7 on a Java8 VM [1].  Spring 4 is the first release to support 
byte code compiled to 1.8 running on a Java8 VM.

Our experience with CloudStack 4.5 and master on Java8 has been that it runs, 
but within 36-48 hangs or abends.  Therefore, the first step to getting a 
stable build on JDK8 is to ensure that all our dependencies support it.

Thanks,
-John

[1]: https://spring.io/blog/2013/05/21/spring-framework-4-0-m1-3-2-3-available/

Regards,

John Burwell

john.burw...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 13, 2016, at 2:04 PM, Ron Wheeler  wrote:

I am not sure what you are using in Spring but I have been using Spring 3.x.x 
with Java 8 for some time.

I can believe that Spring 4 is "better" than Spring 3 but you might see if you 
can separate these two technology upgrades just to keep it simple.
There is enough in Java 8 to make a pretty big project if you just look at 
Streams and refactoring interfaces and abstract classes to reduce the amount of 
code.

Just a comment from the cheap seats.

Ron



On 13/05/2016 1:10 PM, Rohit Yadav wrote:
All,


I've started some work [pr] that aims to adapt CloudStack to recent changes in 
the environments and the ecosystem:


- Java8, Spring 4.x

- SystemD

- MariaDB and MySQL

- Reduce distro provided package dependency

- Packaging, CI and testing


These are long term goals but I've identified some concrete goals:


- Migrate to Java8 both for building codebase and running CloudStack (mgmt 
server, usage, agent etc)

- Migrate to Spring 4.x as 3.x is not supported to work with Java7

- Fix CI and packaging to use Java8

- Reduce distro specific package dependency such as Tomcat, since we're already 
using Jetty (maven-jetty-plugin) during development we can use embedded Jetty 
for mgmt server(s) as well

- Update systemvm template to include Java8 JRE

- Update packaging to support systemd (CentOS7+ has some systemd support and 
thanks to Wido's recent PR we would have systemd support for debian packages in 
future too)

- Optimize JVM options for long running mgmt server(s), agent(s) and usage 
server(s) to run on JRE8


I've sent a [pr] to show some initial progress in this regard where we've some 
outstanding issues but we're able to build/run/test with Java8 + Spring 4.x and 
TravisCI has been fixed to use JDK8 as well.


Testing in general would be a huge requirement for this initiative, especially 
testing of all the plugins. Java7 has EOL-ed and Java9 is around the corner; 
we've seen good amount of security and memory issues with Java7/6 and 
Tomcat6.x; therefore it seems necessary to work on above as we move towards a 
LTS release in upcoming months.


Request for comments, suggestions and guidance. Thanks.


[pr] https://github.com/apache/cloudstack/pull/1546


Regards.

Regards,

Rohit Yadav

rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



Re: [DISCUSS] Moving to Java8

2016-05-13 Thread Ron Wheeler

Sorry. You misunderstood my comment.

I was noting that users who want to run ACS which requires Java 8 could 
also run applications that can not run on Java 8 (although I have never 
heard of an application that would not run with the Java 8 JRE) by 
running both jre7 and jre8.


Of course once you convert to Java 8 with the changes (streams and 
consolidation of interfaces and abstract classes) that I suggested in my 
earlier posting, it will require the Java 8 jre.


Ron


On 13/05/2016 5:17 PM, John Burwell wrote:

Ron,

Upon upgrade, we will start using features and runtime classes/methods 
introduced with Java8.  Therefore, it will become mandatory upgrade from Java7 
to Java8 when adopting the release with these changes.

Thanks,
-John

Regards,

John Burwell

john.burw...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 13, 2016, at 4:51 PM, Ron Wheeler  wrote:

It would seem that a major version would be appropriate.

I am not sure why someone could not use both Java 8 and Java 7.

I have Java 3 versions 6, 7, and 8 available on my Windows 7 PC.

I would have thought that Linux would be at least that flexible.
Is it really not possible to run Java 8 on Ubuntu 14.04?

http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/ suggests that 
it can be run on versions as old as 10.04

Ron


On 13/05/2016 4:37 PM, Erik Weber wrote:
It only means that we are dropping support for newer ACS versions.
It most likely won't get into 4.9, which means 14.04 will be supported a
few more weeks/months.

We could mention in the 4.9 RN that for the next release (call it 5.0
because of the change?) will only be supported by $xyz distribution versjons


--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



Re: ACS PRs Status - 2016/05/12

2016-05-13 Thread Will Stevens
That is helpful, but I need to release an official ACS template with the
release and it needs to be built from the RC candidate, so I need to figure
out the process.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Fri, May 13, 2016 at 6:01 PM, John Burwell 
wrote:

> Will,
>
> Rohit has built a new systemvm template that includes strongswan and
> quagga.  He can point you to images, as well as, help with understanding
> the build/release process.
>
> Thanks,
> -John
>
> >
> Regards,
>
> John Burwell
>
> john.burw...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
> On May 13, 2016, at 5:54 PM, Will Stevens  wrote:
> >
> > Ok, thank you John.  I need to sort out the process for testing and
> > releasing a new system VM template.  Another thing to do...
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Fri, May 13, 2016 at 5:34 PM, John Burwell <
> john.burw...@shapeblue.com>
> > wrote:
> >
> >> Will,
> >>
> >> 1371 includes new Marvin test cases to verify the operation of OSPF.
> >> Bobby Stoyanov will be running these tests, as well as, manual rating of
> >> the UI features added to support it.
> >>
> >> Thanks,
> >> -John
> >>
> >> Regards,
> >>
> >> John Burwell
> >>
> >> john.burw...@shapeblue.com
> >> www.shapeblue.com
> >> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> >> @shapeblue
> >> On May 12, 2016, at 5:02 PM, Will Stevens 
> >> wrote:
> >>>
> >>> ACS PRs
> >>>
> >>>  - 1537 - master (ready, pending Jenkins)
> >>>  - 1514 - 4.7 (pending Jenkins)
> >>>  - 1520 - master (ready, pending Jenkins)
> >>>  - 1482 - 4.7 (pending Jenkins & LGTM)
> >>>  - 1403 - master (pending LGTM, run CI again to be sure)
> >>>  - 1532 - master (ready, pending LGTM and Jenkins)
> >>>  - 956 - master (ready, pending Jenkins and verification)
> >>>  - 1516 - master (ready, pending Travis)
> >>>  - 1455 - master (ready, pending LGTM)
> >>>  - 1376 - master (ready, pending 1515 conflict)
> >>>  - 1280 - master (ready, pending LGTM)
> >>>  - 1424 - master (pending LGTM)
> >>>  - 1297 - master (pending verification)
> >>>  - 1464 - master (pending LGTM)
> >>>  - 1410 - 4.7 (ready, pending LGTM)
> >>>  - 1486 - 4.7 (ready, pending LGTM)
> >>>  - 1436 - master (CI posted, needs review)
> >>>  - * 1423 - master + svm (*pending CI)
> >>>  - 1371 - master + svm (figure out how to test)
> >>>  - 872 - master + svm (pending CI)
> >>>  - 866 - master (pending LGTM)
> >>>  - 1523 - master (*pending CI)
> >>>  - 1304 - master (needs work)
> >>>  - 1503 - master (bbl1)
> >>>  - 1513 - 4.8 (bbl2)
> >>>  - 1450 - 4.7 (ready, pending LGTM)
> >>>  - 1331 - 4.7 (cs1)
> >>>  - 1470 - 4.7 (being fixed)
> >>>  - 1471 - 4.7 (pending comments)
> >>>  - 1412 - 4.6 (pending ALL)
> >>>  - 1406 - 4.6 (pending LGTM)
> >>>  - 1378 - 4.6 (pending LGTM)
> >>>  - 1533 - master (pending LGTM)
> >>>  - 1491 - 4.7 (ready, pending LGTM)
> >>>  - 1360 - master (pending LGTM)
> >>>  - 1499 - master (pending ALL)
> >>>  - 883 - master (pending ALL)
> >>>  - 956 - master (needs work)
> >>>  - 846 - master (pending CI)
> >>>  - 1244 - master (needs work)
> >>>  - 1511 - master (bbl4)
> >>>  - 1530 (1351) - master (pending tests)
> >>>  - 1519 - 4.7 (needs work)
> >>>  - 1437 - master (pending HyperV CI)
> >>>  - 985 - master (bbl3)
> >>>  - 1269 - master (pending LGTM)
> >>>  - 669 - master (pending ALL)
> >>>  - 1494 - master (bbl3)
> >>>  - 1417 - master (marvin fails to import)
> >>>  - 1540 - master (pending LGTM and verification)
> >>>
> >>> ​Sorry this update is so late.  I have been pretty buried trying to
> stay
> >> on
> >>> top of everything in preparation for the freeze next week.
> >>>
> >>> If you have some time *PLEASE* help out with some code review.  We
> have​
> >> 18
> >>> PRs that are pending LGTM reviews and most of them are ready to merge
> >>> assuming I get some code review.
> >>>
> >>> I will be freezing master early next week.  I said Monday, but it will
> >>> likely be Tuesday since I expect to have a lot of work trying to get
> the
> >>> last stuff in that has been reviewed.
> >>>
> >>> If there are PRs that you think are ready that you think should be in
> >> 4.9,
> >>> speak now or forever hold your peace.  I am doing my best to keep
> things
> >>> moving and getting the different PRs into a good place...
> >>>
> >>> Right now we are down to *161 PRs* so we have definitely made progress.
> >> I
> >>> think there are another 20 that we could reasonably get in if we do a
> bit
> >>> of a blitz of code review...
> >>>
> >>> Cheers,
> >>>
> >>> Will
> >>>
> >>> PS: I don't know how Remi did this for so long.  I need some sleep...
> :P
> >>
>


Re: ACS PRs Status - 2016/05/12

2016-05-13 Thread John Burwell
Will,

Rohit has built a new systemvm template that includes strongswan and quagga.  
He can point you to images, as well as, help with understanding the 
build/release process.

Thanks,
-John

> 
Regards,

John Burwell

john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 13, 2016, at 5:54 PM, Will Stevens  wrote:
> 
> Ok, thank you John.  I need to sort out the process for testing and
> releasing a new system VM template.  Another thing to do...
> 
> *Will STEVENS*
> Lead Developer
> 
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
> 
> On Fri, May 13, 2016 at 5:34 PM, John Burwell 
> wrote:
> 
>> Will,
>> 
>> 1371 includes new Marvin test cases to verify the operation of OSPF.
>> Bobby Stoyanov will be running these tests, as well as, manual rating of
>> the UI features added to support it.
>> 
>> Thanks,
>> -John
>> 
>> Regards,
>> 
>> John Burwell
>> 
>> john.burw...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
>> @shapeblue
>> On May 12, 2016, at 5:02 PM, Will Stevens 
>> wrote:
>>> 
>>> ACS PRs
>>> 
>>>  - 1537 - master (ready, pending Jenkins)
>>>  - 1514 - 4.7 (pending Jenkins)
>>>  - 1520 - master (ready, pending Jenkins)
>>>  - 1482 - 4.7 (pending Jenkins & LGTM)
>>>  - 1403 - master (pending LGTM, run CI again to be sure)
>>>  - 1532 - master (ready, pending LGTM and Jenkins)
>>>  - 956 - master (ready, pending Jenkins and verification)
>>>  - 1516 - master (ready, pending Travis)
>>>  - 1455 - master (ready, pending LGTM)
>>>  - 1376 - master (ready, pending 1515 conflict)
>>>  - 1280 - master (ready, pending LGTM)
>>>  - 1424 - master (pending LGTM)
>>>  - 1297 - master (pending verification)
>>>  - 1464 - master (pending LGTM)
>>>  - 1410 - 4.7 (ready, pending LGTM)
>>>  - 1486 - 4.7 (ready, pending LGTM)
>>>  - 1436 - master (CI posted, needs review)
>>>  - * 1423 - master + svm (*pending CI)
>>>  - 1371 - master + svm (figure out how to test)
>>>  - 872 - master + svm (pending CI)
>>>  - 866 - master (pending LGTM)
>>>  - 1523 - master (*pending CI)
>>>  - 1304 - master (needs work)
>>>  - 1503 - master (bbl1)
>>>  - 1513 - 4.8 (bbl2)
>>>  - 1450 - 4.7 (ready, pending LGTM)
>>>  - 1331 - 4.7 (cs1)
>>>  - 1470 - 4.7 (being fixed)
>>>  - 1471 - 4.7 (pending comments)
>>>  - 1412 - 4.6 (pending ALL)
>>>  - 1406 - 4.6 (pending LGTM)
>>>  - 1378 - 4.6 (pending LGTM)
>>>  - 1533 - master (pending LGTM)
>>>  - 1491 - 4.7 (ready, pending LGTM)
>>>  - 1360 - master (pending LGTM)
>>>  - 1499 - master (pending ALL)
>>>  - 883 - master (pending ALL)
>>>  - 956 - master (needs work)
>>>  - 846 - master (pending CI)
>>>  - 1244 - master (needs work)
>>>  - 1511 - master (bbl4)
>>>  - 1530 (1351) - master (pending tests)
>>>  - 1519 - 4.7 (needs work)
>>>  - 1437 - master (pending HyperV CI)
>>>  - 985 - master (bbl3)
>>>  - 1269 - master (pending LGTM)
>>>  - 669 - master (pending ALL)
>>>  - 1494 - master (bbl3)
>>>  - 1417 - master (marvin fails to import)
>>>  - 1540 - master (pending LGTM and verification)
>>> 
>>> ​Sorry this update is so late.  I have been pretty buried trying to stay
>> on
>>> top of everything in preparation for the freeze next week.
>>> 
>>> If you have some time *PLEASE* help out with some code review.  We have​
>> 18
>>> PRs that are pending LGTM reviews and most of them are ready to merge
>>> assuming I get some code review.
>>> 
>>> I will be freezing master early next week.  I said Monday, but it will
>>> likely be Tuesday since I expect to have a lot of work trying to get the
>>> last stuff in that has been reviewed.
>>> 
>>> If there are PRs that you think are ready that you think should be in
>> 4.9,
>>> speak now or forever hold your peace.  I am doing my best to keep things
>>> moving and getting the different PRs into a good place...
>>> 
>>> Right now we are down to *161 PRs* so we have definitely made progress.
>> I
>>> think there are another 20 that we could reasonably get in if we do a bit
>>> of a blitz of code review...
>>> 
>>> Cheers,
>>> 
>>> Will
>>> 
>>> PS: I don't know how Remi did this for so long.  I need some sleep...  :P
>> 


[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1212#issuecomment-219169448
  
Ok, what I will do is merge it into 4.6 and forward merge it to 4.7 and 
then run CI on it there.  I also need to verify what is forward merged from 4.6 
because I don't think I have done that yet...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1212#issuecomment-219169003
  
That is fine, I don't mind doing that.  Is that the process here?  This is 
the first time I have handled a 4.6 PR.  Will a 4.6 ever be released, or is 
that just not important and if someone wants one, they can grab master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS PRs Status - 2016/05/12

2016-05-13 Thread Will Stevens
Ok, thank you John.  I need to sort out the process for testing and
releasing a new system VM template.  Another thing to do...

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Fri, May 13, 2016 at 5:34 PM, John Burwell 
wrote:

> Will,
>
> 1371 includes new Marvin test cases to verify the operation of OSPF.
> Bobby Stoyanov will be running these tests, as well as, manual rating of
> the UI features added to support it.
>
> Thanks,
> -John
>
> >
> Regards,
>
> John Burwell
>
> john.burw...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
> On May 12, 2016, at 5:02 PM, Will Stevens 
> wrote:
> >
> > ACS PRs
> >
> >   - 1537 - master (ready, pending Jenkins)
> >   - 1514 - 4.7 (pending Jenkins)
> >   - 1520 - master (ready, pending Jenkins)
> >   - 1482 - 4.7 (pending Jenkins & LGTM)
> >   - 1403 - master (pending LGTM, run CI again to be sure)
> >   - 1532 - master (ready, pending LGTM and Jenkins)
> >   - 956 - master (ready, pending Jenkins and verification)
> >   - 1516 - master (ready, pending Travis)
> >   - 1455 - master (ready, pending LGTM)
> >   - 1376 - master (ready, pending 1515 conflict)
> >   - 1280 - master (ready, pending LGTM)
> >   - 1424 - master (pending LGTM)
> >   - 1297 - master (pending verification)
> >   - 1464 - master (pending LGTM)
> >   - 1410 - 4.7 (ready, pending LGTM)
> >   - 1486 - 4.7 (ready, pending LGTM)
> >   - 1436 - master (CI posted, needs review)
> >   - * 1423 - master + svm (*pending CI)
> >   - 1371 - master + svm (figure out how to test)
> >   - 872 - master + svm (pending CI)
> >   - 866 - master (pending LGTM)
> >   - 1523 - master (*pending CI)
> >   - 1304 - master (needs work)
> >   - 1503 - master (bbl1)
> >   - 1513 - 4.8 (bbl2)
> >   - 1450 - 4.7 (ready, pending LGTM)
> >   - 1331 - 4.7 (cs1)
> >   - 1470 - 4.7 (being fixed)
> >   - 1471 - 4.7 (pending comments)
> >   - 1412 - 4.6 (pending ALL)
> >   - 1406 - 4.6 (pending LGTM)
> >   - 1378 - 4.6 (pending LGTM)
> >   - 1533 - master (pending LGTM)
> >   - 1491 - 4.7 (ready, pending LGTM)
> >   - 1360 - master (pending LGTM)
> >   - 1499 - master (pending ALL)
> >   - 883 - master (pending ALL)
> >   - 956 - master (needs work)
> >   - 846 - master (pending CI)
> >   - 1244 - master (needs work)
> >   - 1511 - master (bbl4)
> >   - 1530 (1351) - master (pending tests)
> >   - 1519 - 4.7 (needs work)
> >   - 1437 - master (pending HyperV CI)
> >   - 985 - master (bbl3)
> >   - 1269 - master (pending LGTM)
> >   - 669 - master (pending ALL)
> >   - 1494 - master (bbl3)
> >   - 1417 - master (marvin fails to import)
> >   - 1540 - master (pending LGTM and verification)
> >
> > ​Sorry this update is so late.  I have been pretty buried trying to stay
> on
> > top of everything in preparation for the freeze next week.
> >
> > If you have some time *PLEASE* help out with some code review.  We have​
> 18
> > PRs that are pending LGTM reviews and most of them are ready to merge
> > assuming I get some code review.
> >
> > I will be freezing master early next week.  I said Monday, but it will
> > likely be Tuesday since I expect to have a lot of work trying to get the
> > last stuff in that has been reviewed.
> >
> > If there are PRs that you think are ready that you think should be in
> 4.9,
> > speak now or forever hold your peace.  I am doing my best to keep things
> > moving and getting the different PRs into a good place...
> >
> > Right now we are down to *161 PRs* so we have definitely made progress.
> I
> > think there are another 20 that we could reasonably get in if we do a bit
> > of a blitz of code review...
> >
> > Cheers,
> >
> > Will
> >
> > PS: I don't know how Remi did this for so long.  I need some sleep...  :P
>


[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-219168754
  
ok, thank you sir.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-219168529
  
@swill I added a small fix for inside the SSVM. During some additional 
manual testing I found that the SSVM is picky in the order in the XML 
definition.

My second commit makes sure it doesn't use the first VirtIO port, but uses 
the proper port.

I tested that fix in production as well, works just fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1371#issuecomment-219168493
  
Please verify why the jobs are failing and re-push this PR to try to get it 
green.  I need to verify the process to test new system templates and how to 
build and distribute new system templates.  I have not tried to find the 
documentation on this, so if someone knows where to find it, I would accept a 
link.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
GitHub user syed reopened a pull request:

https://github.com/apache/cloudstack/pull/1331

Fix Sync of template.properties in Swift

When using Swift as a secondary storage, we create a template.properties 
file which stores the metadata about the template. Currently the data which is 
present in the file is incorrect which leads to templates becoming unavailable 
after they are downloaded. This fix makes sure that the template.properties has 
the correct "path" set so that templates are available. 

I've also done a bit of cleanup and made the code bit more clean. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack swift-restart-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1331


commit f3b8c7e0f2720639f1db77b15e0791ec70537a29
Author: Syed 
Date:   2015-12-14T22:37:28Z

Fix Sync of template.properties in Swift




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-219166142
  
@DaanHoogland  sure ... doesn't hurt



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Moving to Java8

2016-05-13 Thread John Burwell
Ron,

According to Spring's documentation, Spring 3 only supports running byte code 
compiled for 1.7 on a Java8 VM [1].  Spring 4 is the first release to support 
byte code compiled to 1.8 running on a Java8 VM.  

Our experience with CloudStack 4.5 and master on Java8 has been that it runs, 
but within 36-48 hangs or abends.  Therefore, the first step to getting a 
stable build on JDK8 is to ensure that all our dependencies support it.

Thanks,
-John

[1]: https://spring.io/blog/2013/05/21/spring-framework-4-0-m1-3-2-3-available/

> 
Regards,

John Burwell

john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 13, 2016, at 2:04 PM, Ron Wheeler  wrote:
> 
> I am not sure what you are using in Spring but I have been using Spring 3.x.x 
> with Java 8 for some time.
> 
> I can believe that Spring 4 is "better" than Spring 3 but you might see if 
> you can separate these two technology upgrades just to keep it simple.
> There is enough in Java 8 to make a pretty big project if you just look at 
> Streams and refactoring interfaces and abstract classes to reduce the amount 
> of code.
> 
> Just a comment from the cheap seats.
> 
> Ron
> 
> 
>> On 13/05/2016 1:10 PM, Rohit Yadav wrote:
>> All,
>> 
>> 
>> I've started some work [pr] that aims to adapt CloudStack to recent changes 
>> in the environments and the ecosystem:
>> 
>> 
>> - Java8, Spring 4.x
>> 
>> - SystemD
>> 
>> - MariaDB and MySQL
>> 
>> - Reduce distro provided package dependency
>> 
>> - Packaging, CI and testing
>> 
>> 
>> These are long term goals but I've identified some concrete goals:
>> 
>> 
>> - Migrate to Java8 both for building codebase and running CloudStack (mgmt 
>> server, usage, agent etc)
>> 
>> - Migrate to Spring 4.x as 3.x is not supported to work with Java7
>> 
>> - Fix CI and packaging to use Java8
>> 
>> - Reduce distro specific package dependency such as Tomcat, since we're 
>> already using Jetty (maven-jetty-plugin) during development we can use 
>> embedded Jetty for mgmt server(s) as well
>> 
>> - Update systemvm template to include Java8 JRE
>> 
>> - Update packaging to support systemd (CentOS7+ has some systemd support and 
>> thanks to Wido's recent PR we would have systemd support for debian packages 
>> in future too)
>> 
>> - Optimize JVM options for long running mgmt server(s), agent(s) and usage 
>> server(s) to run on JRE8
>> 
>> 
>> I've sent a [pr] to show some initial progress in this regard where we've 
>> some outstanding issues but we're able to build/run/test with Java8 + Spring 
>> 4.x and TravisCI has been fixed to use JDK8 as well.
>> 
>> 
>> Testing in general would be a huge requirement for this initiative, 
>> especially testing of all the plugins. Java7 has EOL-ed and Java9 is around 
>> the corner; we've seen good amount of security and memory issues with 
>> Java7/6 and Tomcat6.x; therefore it seems necessary to work on above as we 
>> move towards a LTS release in upcoming months.
>> 
>> 
>> Request for comments, suggestions and guidance. Thanks.
>> 
>> 
>> [pr] https://github.com/apache/cloudstack/pull/1546
>> 
>> 
>> Regards.
>> 
>> Regards,
>> 
>> Rohit Yadav
>> 
>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
> 
> 
> -- 
> Ron Wheeler
> President
> Artifact Software Inc
> email: rwhee...@artifact-software.com
> skype: ronaldmwheeler
> phone: 866-970-2435, ext 102
> 


[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-219162095
  
@swill I got the file from jenkins and it points to 
`utils/testsmallfileinactive` ... I have no idea where this file came from


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Moving to Java8

2016-05-13 Thread Wido den Hollander

> Op 13 mei 2016 om 22:51 schreef John Burwell :
> 
> 
> All,
> 
> Java8 is targeted for post 4.9.  Oracle provides an official PPA for Java6, 
> Java7, Java8, and Java9 [1] that supports Ubuntu 14.04.  It is important to 
> bear in mind that Java7 was EOL’ed on April 2015 [2].  In my opinion, the 
> recent history of Java vulnerabilities dictates that we cannot allow a 
> particular distribution’s failure to update their to supported JDK place our 
> user community at risk.
> 

I agree with you. Drop Java 7 post 4.9. In the packaging we can then also drop 
14.04, less code to maintain.

Wido

> Thanks,
> -John
> 
> [1]: https://launchpad.net/~webupd8team/+archive/ubuntu/java
> [2]: http://www.oracle.com/technetwork/java/eol-135779.html
> 
> > 
> Regards,
> 
> John Burwell
> 
> john.burw...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
> On May 13, 2016, at 4:37 PM, Erik Weber  wrote:
> > 
> > It only means that we are dropping support for newer ACS versions.
> > It most likely won't get into 4.9, which means 14.04 will be supported a
> > few more weeks/months.
> > 
> > We could mention in the 4.9 RN that for the next release (call it 5.0
> > because of the change?) will only be supported by $xyz distribution versjons
> > 
> > -- 
> > Erik
> > 
> > On Fri, May 13, 2016 at 9:10 PM, Wido den Hollander  wrote:
> > 
> >> I am in favor of Java 8, but it means we would drop Ubuntu 14.04 support.
> >> 
> >> That would make life a bit easier though, since Ubuntu 16.04 has systemd
> >> and 14.04 still has sysvinit and that make packaging a problem.
> >> 
> >>> Op 13 mei 2016 om 19:10 schreef Rohit Yadav :
> >>> 
> >>> 
> >>> All,
> >>> 
> >>> 
> >>> I've started some work [pr] that aims to adapt CloudStack to recent
> >> changes in the environments and the ecosystem:
> >>> 
> >>> 
> >>> - Java8, Spring 4.x
> >>> 
> >>> - SystemD
> >>> 
> >>> - MariaDB and MySQL
> >>> 
> >>> - Reduce distro provided package dependency
> >>> 
> >>> - Packaging, CI and testing
> >>> 
> >>> 
> >>> These are long term goals but I've identified some concrete goals:
> >>> 
> >>> 
> >>> - Migrate to Java8 both for building codebase and running CloudStack
> >> (mgmt server, usage, agent etc)
> >>> 
> >>> - Migrate to Spring 4.x as 3.x is not supported to work with Java7
> >>> 
> >>> - Fix CI and packaging to use Java8
> >>> 
> >>> - Reduce distro specific package dependency such as Tomcat, since we're
> >> already using Jetty (maven-jetty-plugin) during development we can use
> >> embedded Jetty for mgmt server(s) as well
> >>> 
> >>> - Update systemvm template to include Java8 JRE
> >>> 
> >>> - Update packaging to support systemd (CentOS7+ has some systemd support
> >> and thanks to Wido's recent PR we would have systemd support for debian
> >> packages in future too)
> >>> 
> >>> - Optimize JVM options for long running mgmt server(s), agent(s) and
> >> usage server(s) to run on JRE8
> >>> 
> >>> 
> >>> I've sent a [pr] to show some initial progress in this regard where
> >> we've some outstanding issues but we're able to build/run/test with Java8 +
> >> Spring 4.x and TravisCI has been fixed to use JDK8 as well.
> >>> 
> >>> 
> >>> Testing in general would be a huge requirement for this initiative,
> >> especially testing of all the plugins. Java7 has EOL-ed and Java9 is around
> >> the corner; we've seen good amount of security and memory issues with
> >> Java7/6 and Tomcat6.x; therefore it seems necessary to work on above as we
> >> move towards a LTS release in upcoming months.
> >>> 
> >>> 
> >>> Request for comments, suggestions and guidance. Thanks.
> >>> 
> >>> 
> >>> [pr] https://github.com/apache/cloudstack/pull/1546
> >>> 
> >>> 
> >>> Regards.
> >>> 
> >>> Regards,
> >>> 
> >>> Rohit Yadav
> >>> 
> >>> rohit.ya...@shapeblue.com
> >>> www.shapeblue.com
> >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >>> @shapeblue
> >> 
>


[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219160164
  
Ok, we need one more review on this.

tag:needsreview tag:needreview


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1495


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1537


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1532#issuecomment-219158465
  
@swill you should always count the opinion of the RM as that of a real 
memeber of the community ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: L10n update master 20160127

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1376


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS PRs Status - 2016/05/12

2016-05-13 Thread Will Stevens
Thank you, I added 1376 to my ready to merge list.  I have 6 more ready to
merge, so we should be down to 155 tonight...

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Fri, May 13, 2016 at 3:45 PM, Milamber  wrote:

>
> - 1376 - master (ready, pending 1515 conflict)
>>
>
> 1376 is ready to merge to master branch (Jenkins and Travis are green).
> 1515 is already merged on 4.8
>
>
>
> On 12/05/2016 22:02, Will Stevens wrote:
>
>> ACS PRs
>>
>> - 1537 - master (ready, pending Jenkins)
>> - 1514 - 4.7 (pending Jenkins)
>> - 1520 - master (ready, pending Jenkins)
>> - 1482 - 4.7 (pending Jenkins & LGTM)
>> - 1403 - master (pending LGTM, run CI again to be sure)
>> - 1532 - master (ready, pending LGTM and Jenkins)
>> - 956 - master (ready, pending Jenkins and verification)
>> - 1516 - master (ready, pending Travis)
>> - 1455 - master (ready, pending LGTM)
>> - 1376 - master (ready, pending 1515 conflict)
>> - 1280 - master (ready, pending LGTM)
>> - 1424 - master (pending LGTM)
>> - 1297 - master (pending verification)
>> - 1464 - master (pending LGTM)
>> - 1410 - 4.7 (ready, pending LGTM)
>> - 1486 - 4.7 (ready, pending LGTM)
>> - 1436 - master (CI posted, needs review)
>> - * 1423 - master + svm (*pending CI)
>> - 1371 - master + svm (figure out how to test)
>> - 872 - master + svm (pending CI)
>> - 866 - master (pending LGTM)
>> - 1523 - master (*pending CI)
>> - 1304 - master (needs work)
>> - 1503 - master (bbl1)
>> - 1513 - 4.8 (bbl2)
>> - 1450 - 4.7 (ready, pending LGTM)
>> - 1331 - 4.7 (cs1)
>> - 1470 - 4.7 (being fixed)
>> - 1471 - 4.7 (pending comments)
>> - 1412 - 4.6 (pending ALL)
>> - 1406 - 4.6 (pending LGTM)
>> - 1378 - 4.6 (pending LGTM)
>> - 1533 - master (pending LGTM)
>> - 1491 - 4.7 (ready, pending LGTM)
>> - 1360 - master (pending LGTM)
>> - 1499 - master (pending ALL)
>> - 883 - master (pending ALL)
>> - 956 - master (needs work)
>> - 846 - master (pending CI)
>> - 1244 - master (needs work)
>> - 1511 - master (bbl4)
>> - 1530 (1351) - master (pending tests)
>> - 1519 - 4.7 (needs work)
>> - 1437 - master (pending HyperV CI)
>> - 985 - master (bbl3)
>> - 1269 - master (pending LGTM)
>> - 669 - master (pending ALL)
>> - 1494 - master (bbl3)
>> - 1417 - master (marvin fails to import)
>> - 1540 - master (pending LGTM and verification)
>>
>> ​Sorry this update is so late.  I have been pretty buried trying to stay
>> on
>> top of everything in preparation for the freeze next week.
>>
>> If you have some time *PLEASE* help out with some code review.  We have​
>> 18
>> PRs that are pending LGTM reviews and most of them are ready to merge
>> assuming I get some code review.
>>
>> I will be freezing master early next week.  I said Monday, but it will
>> likely be Tuesday since I expect to have a lot of work trying to get the
>> last stuff in that has been reviewed.
>>
>> If there are PRs that you think are ready that you think should be in 4.9,
>> speak now or forever hold your peace.  I am doing my best to keep things
>> moving and getting the different PRs into a good place...
>>
>> Right now we are down to *161 PRs* so we have definitely made progress.  I
>> think there are another 20 that we could reasonably get in if we do a bit
>> of a blitz of code review...
>>
>> Cheers,
>>
>> Will
>>
>> PS: I don't know how Remi did this for so long.  I need some sleep...  :P
>>
>>
>


[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219157668
  
LGTM, tag:easypr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Moving to Java8

2016-05-13 Thread John Burwell
All,

Java8 is targeted for post 4.9.  Oracle provides an official PPA for Java6, 
Java7, Java8, and Java9 [1] that supports Ubuntu 14.04.  It is important to 
bear in mind that Java7 was EOL’ed on April 2015 [2].  In my opinion, the 
recent history of Java vulnerabilities dictates that we cannot allow a 
particular distribution’s failure to update their to supported JDK place our 
user community at risk.

Thanks,
-John

[1]: https://launchpad.net/~webupd8team/+archive/ubuntu/java
[2]: http://www.oracle.com/technetwork/java/eol-135779.html

> 
Regards,

John Burwell

john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 13, 2016, at 4:37 PM, Erik Weber  wrote:
> 
> It only means that we are dropping support for newer ACS versions.
> It most likely won't get into 4.9, which means 14.04 will be supported a
> few more weeks/months.
> 
> We could mention in the 4.9 RN that for the next release (call it 5.0
> because of the change?) will only be supported by $xyz distribution versjons
> 
> -- 
> Erik
> 
> On Fri, May 13, 2016 at 9:10 PM, Wido den Hollander  wrote:
> 
>> I am in favor of Java 8, but it means we would drop Ubuntu 14.04 support.
>> 
>> That would make life a bit easier though, since Ubuntu 16.04 has systemd
>> and 14.04 still has sysvinit and that make packaging a problem.
>> 
>>> Op 13 mei 2016 om 19:10 schreef Rohit Yadav :
>>> 
>>> 
>>> All,
>>> 
>>> 
>>> I've started some work [pr] that aims to adapt CloudStack to recent
>> changes in the environments and the ecosystem:
>>> 
>>> 
>>> - Java8, Spring 4.x
>>> 
>>> - SystemD
>>> 
>>> - MariaDB and MySQL
>>> 
>>> - Reduce distro provided package dependency
>>> 
>>> - Packaging, CI and testing
>>> 
>>> 
>>> These are long term goals but I've identified some concrete goals:
>>> 
>>> 
>>> - Migrate to Java8 both for building codebase and running CloudStack
>> (mgmt server, usage, agent etc)
>>> 
>>> - Migrate to Spring 4.x as 3.x is not supported to work with Java7
>>> 
>>> - Fix CI and packaging to use Java8
>>> 
>>> - Reduce distro specific package dependency such as Tomcat, since we're
>> already using Jetty (maven-jetty-plugin) during development we can use
>> embedded Jetty for mgmt server(s) as well
>>> 
>>> - Update systemvm template to include Java8 JRE
>>> 
>>> - Update packaging to support systemd (CentOS7+ has some systemd support
>> and thanks to Wido's recent PR we would have systemd support for debian
>> packages in future too)
>>> 
>>> - Optimize JVM options for long running mgmt server(s), agent(s) and
>> usage server(s) to run on JRE8
>>> 
>>> 
>>> I've sent a [pr] to show some initial progress in this regard where
>> we've some outstanding issues but we're able to build/run/test with Java8 +
>> Spring 4.x and TravisCI has been fixed to use JDK8 as well.
>>> 
>>> 
>>> Testing in general would be a huge requirement for this initiative,
>> especially testing of all the plugins. Java7 has EOL-ed and Java9 is around
>> the corner; we've seen good amount of security and memory issues with
>> Java7/6 and Tomcat6.x; therefore it seems necessary to work on above as we
>> move towards a LTS release in upcoming months.
>>> 
>>> 
>>> Request for comments, suggestions and guidance. Thanks.
>>> 
>>> 
>>> [pr] https://github.com/apache/cloudstack/pull/1546
>>> 
>>> 
>>> Regards.
>>> 
>>> Regards,
>>> 
>>> Rohit Yadav
>>> 
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> @shapeblue
>> 



[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread serg38
Github user serg38 commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-219154273
  
This doesn't seem to be related to this PR.Can you post 
managment-server.log extract around the failure time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Moving to Java8

2016-05-13 Thread Erik Weber
It only means that we are dropping support for newer ACS versions.
It most likely won't get into 4.9, which means 14.04 will be supported a
few more weeks/months.

We could mention in the 4.9 RN that for the next release (call it 5.0
because of the change?) will only be supported by $xyz distribution versjons

-- 
Erik

On Fri, May 13, 2016 at 9:10 PM, Wido den Hollander  wrote:

> I am in favor of Java 8, but it means we would drop Ubuntu 14.04 support.
>
> That would make life a bit easier though, since Ubuntu 16.04 has systemd
> and 14.04 still has sysvinit and that make packaging a problem.
>
> > Op 13 mei 2016 om 19:10 schreef Rohit Yadav :
> >
> >
> > All,
> >
> >
> > I've started some work [pr] that aims to adapt CloudStack to recent
> changes in the environments and the ecosystem:
> >
> >
> > - Java8, Spring 4.x
> >
> > - SystemD
> >
> > - MariaDB and MySQL
> >
> > - Reduce distro provided package dependency
> >
> > - Packaging, CI and testing
> >
> >
> > These are long term goals but I've identified some concrete goals:
> >
> >
> > - Migrate to Java8 both for building codebase and running CloudStack
> (mgmt server, usage, agent etc)
> >
> > - Migrate to Spring 4.x as 3.x is not supported to work with Java7
> >
> > - Fix CI and packaging to use Java8
> >
> > - Reduce distro specific package dependency such as Tomcat, since we're
> already using Jetty (maven-jetty-plugin) during development we can use
> embedded Jetty for mgmt server(s) as well
> >
> > - Update systemvm template to include Java8 JRE
> >
> > - Update packaging to support systemd (CentOS7+ has some systemd support
> and thanks to Wido's recent PR we would have systemd support for debian
> packages in future too)
> >
> > - Optimize JVM options for long running mgmt server(s), agent(s) and
> usage server(s) to run on JRE8
> >
> >
> > I've sent a [pr] to show some initial progress in this regard where
> we've some outstanding issues but we're able to build/run/test with Java8 +
> Spring 4.x and TravisCI has been fixed to use JDK8 as well.
> >
> >
> > Testing in general would be a huge requirement for this initiative,
> especially testing of all the plugins. Java7 has EOL-ed and Java9 is around
> the corner; we've seen good amount of security and memory issues with
> Java7/6 and Tomcat6.x; therefore it seems necessary to work on above as we
> move towards a LTS release in upcoming months.
> >
> >
> > Request for comments, suggestions and guidance. Thanks.
> >
> >
> > [pr] https://github.com/apache/cloudstack/pull/1546
> >
> >
> > Regards.
> >
> > Regards,
> >
> > Rohit Yadav
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
>


[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-219152627
  
@swill Yes, running this in production on our cloud

I just started an Instance and the Agent (backport to 4.8, clean merge) 
produced this XML:

```

i-2-25-VM
bd93ca81-d976-41be-823c-6fc0ea013111
Ubuntu 12.04 (64-bit)


Apache Software Foundation
CloudStack KVM Hypervisor
bd93ca81-d976-41be-823c-6fc0ea013111



hvm




restart
destroy
destroy
4194304



2






1000






/usr/libexec/qemu-kvm





















d70d7e6e753d4a0ead5f









3fcb9970cf634251b1b9

















```

There you see this channel added:

```





```

In the Ubuntu 14.04 the Guest Agent is running:


root@vhosting-relay:~# ps aux|grep qemu
root  2789  0.0  0.0  17468   700 ?Ss   22:19   0:00 
/usr/sbin/qemu-ga --daemonize -m virtio-serial -p 
/dev/virtio-ports/org.qemu.guest_agent.0
root  2890  0.0  0.0  10460   908 pts/6S+   22:20   0:00 grep qemu
root@vhosting-relay:~#


From the HV I can send commands through libvirt:


[root@n06 ~]# virsh qemu-agent-command i-2-25-VM '{"execute":"guest-ping"}'
{"return":{}}

[root@n06 ~]#


I also re-started a Console Proxy which has a additional channel, that 
works as well:

```










```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-219150983
  
@syed failed again.  :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-13 Thread jburwell
Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/1403#issuecomment-219148309
  
@DaanHoogland in my experience, stack traces are a critical piece of 
information for operationally debugging CloudStack.  Unfortunately, our logging 
lacks the clarity and specify to use the error message alone.  I hope our 
logging improves overtime to omit them from ``INFO``, ``WARN``, and ``ERROR``.  
However, today, this information is vital to resolving issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-13 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1403#issuecomment-219146275
  
@jburwell @DaanHoogland I have a solution for quickly looking up if a 
cluster supports resigning that I think we'll all be happy with.

Upon a host connecting to the management server is when I check to see if 
the host supports resigning (and update the host_details table).

I added logic to this connection code to not only update the host_details 
table with info about resigning, but also the cluster_details table about 
resigning.

A host connecting to the management server should not be a frequent 
occurrence, so I believe it's OK at this point to run through the list of hosts 
in the cluster of the connecting host and see if all of those hosts support 
resigning. If they do, then I update the cluster_details table that the cluster 
in question supports resigning.

I also changed the logic to not bother to add a row to either the 
host_details table or the cluster_details table if the "supportsResign" 
property would be false (only a true value is stored now). We can then save 
space by understanding that a missing "supportsResign" property for a host or 
cluster indicates false (I was proceeding under that assumption anyways).

When the time comes to ask the cluster if it supports resigning, it's a 
simple matter of looking for the "supportsResign" property in the 
cluster_details table.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS PRs Status - 2016/05/12

2016-05-13 Thread Milamber



- 1376 - master (ready, pending 1515 conflict)


1376 is ready to merge to master branch (Jenkins and Travis are green). 
1515 is already merged on 4.8



On 12/05/2016 22:02, Will Stevens wrote:

ACS PRs

- 1537 - master (ready, pending Jenkins)
- 1514 - 4.7 (pending Jenkins)
- 1520 - master (ready, pending Jenkins)
- 1482 - 4.7 (pending Jenkins & LGTM)
- 1403 - master (pending LGTM, run CI again to be sure)
- 1532 - master (ready, pending LGTM and Jenkins)
- 956 - master (ready, pending Jenkins and verification)
- 1516 - master (ready, pending Travis)
- 1455 - master (ready, pending LGTM)
- 1376 - master (ready, pending 1515 conflict)
- 1280 - master (ready, pending LGTM)
- 1424 - master (pending LGTM)
- 1297 - master (pending verification)
- 1464 - master (pending LGTM)
- 1410 - 4.7 (ready, pending LGTM)
- 1486 - 4.7 (ready, pending LGTM)
- 1436 - master (CI posted, needs review)
- * 1423 - master + svm (*pending CI)
- 1371 - master + svm (figure out how to test)
- 872 - master + svm (pending CI)
- 866 - master (pending LGTM)
- 1523 - master (*pending CI)
- 1304 - master (needs work)
- 1503 - master (bbl1)
- 1513 - 4.8 (bbl2)
- 1450 - 4.7 (ready, pending LGTM)
- 1331 - 4.7 (cs1)
- 1470 - 4.7 (being fixed)
- 1471 - 4.7 (pending comments)
- 1412 - 4.6 (pending ALL)
- 1406 - 4.6 (pending LGTM)
- 1378 - 4.6 (pending LGTM)
- 1533 - master (pending LGTM)
- 1491 - 4.7 (ready, pending LGTM)
- 1360 - master (pending LGTM)
- 1499 - master (pending ALL)
- 883 - master (pending ALL)
- 956 - master (needs work)
- 846 - master (pending CI)
- 1244 - master (needs work)
- 1511 - master (bbl4)
- 1530 (1351) - master (pending tests)
- 1519 - 4.7 (needs work)
- 1437 - master (pending HyperV CI)
- 985 - master (bbl3)
- 1269 - master (pending LGTM)
- 669 - master (pending ALL)
- 1494 - master (bbl3)
- 1417 - master (marvin fails to import)
- 1540 - master (pending LGTM and verification)

​Sorry this update is so late.  I have been pretty buried trying to stay on
top of everything in preparation for the freeze next week.

If you have some time *PLEASE* help out with some code review.  We have​ 18
PRs that are pending LGTM reviews and most of them are ready to merge
assuming I get some code review.

I will be freezing master early next week.  I said Monday, but it will
likely be Tuesday since I expect to have a lot of work trying to get the
last stuff in that has been reviewed.

If there are PRs that you think are ready that you think should be in 4.9,
speak now or forever hold your peace.  I am doing my best to keep things
moving and getting the different PRs into a good place...

Right now we are down to *161 PRs* so we have definitely made progress.  I
think there are another 20 that we could reasonably get in if we do a bit
of a blitz of code review...

Cheers,

Will

PS: I don't know how Remi did this for so long.  I need some sleep...  :P





[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219137807
  
LGTM based on the manual testing above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1241#issuecomment-219137690
  
@kansal can you close and reopen for do a force push to try to get Jenkins 
green.  I am not sure what to do about this PR because I don't know that I have 
a way to verify it works.  @rhtyd and @DaanHoogland suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219137482
  
Kill the Master VR:


![int_before_fo](https://cloud.githubusercontent.com/assets/17278194/15259402/b4659c14-1916-11e6-8169-b397f102.png)


![kill_the_vr](https://cloud.githubusercontent.com/assets/17278194/15259406/b8539466-1916-11e6-9351-b510c8abdf7b.png)


![int_after_fo](https://cloud.githubusercontent.com/assets/17278194/15259409/bc168d10-1916-11e6-9145-e98c4efdcfd8.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219137332
  
Add a private gw:


![add_pg](https://cloud.githubusercontent.com/assets/17278194/15259388/a3d1da2a-1916-11e6-8077-d9980fc8641a.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219137269
  
Add a new ACL, add a rule to it and apply it to a Tier:


![acs_before](https://cloud.githubusercontent.com/assets/17278194/15259376/94178760-1916-11e6-845d-62fc715d0630.png)


![acl_after](https://cloud.githubusercontent.com/assets/17278194/15259378/9766df42-1916-11e6-9cc8-af58d2ffe377.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219137126
  
Hot add static route:


![hot_add_static_route](https://cloud.githubusercontent.com/assets/17278194/15259361/77dad958-1916-11e6-904c-d0ae35b8554a.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-219137064
  
I have tried to CI this PR a couple times.  I get the following during 
Deploy DC.
```
 Deploy DC Started 
Exception Occurred :['Traceback (most recent call last):\n', '  File 
"/data/git/cs1/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 142, 
in addHosts\nret = self.__apiClient.addHost(hostcmd)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 1530, in addHost\nresponse = self.connection.marvinRequest(command, 
response_type=response, method=method)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in 
marvinRequest\nraise e\n', 'CloudstackAPIException: Execute cmd: addhost 
failed, due to: errorCode: 530, errorText:Unable to add the host\n']
Exception Occurred :['Traceback (most recent call last):\n', '  File 
"/data/git/cs1/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 142, 
in addHosts\nret = self.__apiClient.addHost(hostcmd)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 1530, in addHost\nresponse = self.connection.marvinRequest(command, 
response_type=response, method=method)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in 
marvinRequest\nraise e\n', 'CloudstackAPIException: Execute cmd: addhost 
failed, due to: errorCode: 530, errorText:Guid is not updated for cluster with 
specified cluster id; need to wait for hosts in this cluster to come up\n']
```

I can't find anything in the `jetty.log` to show why it is failing.  I am a 
bit confused honestly...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1212#issuecomment-219134524
  
@rhtyd I can run CI on this, but it is based against 4.6.  I am not sure 
what to do about that.  Should @ustcweizhou at least rebase against 4.7 so we 
can get it in and forward merge?  I don't really want to be working against the 
4.6 branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Moving to Java8

2016-05-13 Thread Wido den Hollander
I am in favor of Java 8, but it means we would drop Ubuntu 14.04 support.

That would make life a bit easier though, since Ubuntu 16.04 has systemd and 
14.04 still has sysvinit and that make packaging a problem.

> Op 13 mei 2016 om 19:10 schreef Rohit Yadav :
> 
> 
> All,
> 
> 
> I've started some work [pr] that aims to adapt CloudStack to recent changes 
> in the environments and the ecosystem:
> 
> 
> - Java8, Spring 4.x
> 
> - SystemD
> 
> - MariaDB and MySQL
> 
> - Reduce distro provided package dependency
> 
> - Packaging, CI and testing
> 
> 
> These are long term goals but I've identified some concrete goals:
> 
> 
> - Migrate to Java8 both for building codebase and running CloudStack (mgmt 
> server, usage, agent etc)
> 
> - Migrate to Spring 4.x as 3.x is not supported to work with Java7
> 
> - Fix CI and packaging to use Java8
> 
> - Reduce distro specific package dependency such as Tomcat, since we're 
> already using Jetty (maven-jetty-plugin) during development we can use 
> embedded Jetty for mgmt server(s) as well
> 
> - Update systemvm template to include Java8 JRE
> 
> - Update packaging to support systemd (CentOS7+ has some systemd support and 
> thanks to Wido's recent PR we would have systemd support for debian packages 
> in future too)
> 
> - Optimize JVM options for long running mgmt server(s), agent(s) and usage 
> server(s) to run on JRE8
> 
> 
> I've sent a [pr] to show some initial progress in this regard where we've 
> some outstanding issues but we're able to build/run/test with Java8 + Spring 
> 4.x and TravisCI has been fixed to use JDK8 as well.
> 
> 
> Testing in general would be a huge requirement for this initiative, 
> especially testing of all the plugins. Java7 has EOL-ed and Java9 is around 
> the corner; we've seen good amount of security and memory issues with Java7/6 
> and Tomcat6.x; therefore it seems necessary to work on above as we move 
> towards a LTS release in upcoming months.
> 
> 
> Request for comments, suggestions and guidance. Thanks.
> 
> 
> [pr] https://github.com/apache/cloudstack/pull/1546
> 
> 
> Regards.
> 
> Regards,
> 
> Rohit Yadav
> 
> rohit.ya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue


[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-219130130
  
@SudharmaJain can you re-push or close and reopen this PR to kick off 
Jenkins again?

@rhtyd and @nvazquez I know you both use VMware.  I don't have a way to 
validate this PR, so can you give me your opinion on if this should be merged 
without validation or can either of you validate this PR in your environment 
and give me a verbal OK?  Since I don't have a way to test this, I want some 
verification from someone who is affected by this PR.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/669#issuecomment-219129109
  
Thanks @anshul1886.  Keep in mind that the freeze date for 4.9 is Monday 
next week.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Organizing CCCNA16 Hackathon

2016-05-13 Thread Paul Angus
I'm keen to sit in on the Ci/CD work, but also the documentation work.  
(re-writing the concepts section is 'onging')


Kind regards,

Paul Angus


Regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-219123470
  
I think we should merge this one at this point.  @sverrirab my 
understanding is that once #1533 is merged, this will be required.  If that is 
the case, when this one is merged, maybe you can work into that PR the 
reverting of this PR.  Does that make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

2016-05-13 Thread olivierlemasle
Github user olivierlemasle commented on the pull request:

https://github.com/apache/cloudstack/pull/1503#issuecomment-219121751
  
In the three tracebacks, the error is located in 
https://github.com/apache/cloudstack/blob/821b2da1267c486bb1f5c9e90d3d1969b6fe947f/tools/marvin/marvin/lib/base.py#L1350
 and occurs because `template.status` is equal to `None`.

This comes from the `Template.list(...)` request just before, which has the 
following response (cf logs):

[
  {
   domain : u'ROOT',
   domainid : u'83f831cd-187e-11e6-92ee-5254001daa61',
   ostypename : u'Other PV (64-bit)',
   zoneid : u'fbbb2ed8-1929-42df-ad74-2a7a2639798c',
   displaytext : u'macchinina kvm',
   ostypeid : u'83e88c7d-187e-11e6-92ee-5254001daa61',
   passwordenabled : False, id : 
u'5c21909e-c641-42d8-b90f-f6795da7d9fb',
   isready : False,
   format : u'QCOW2',
   templatetype : u'USER',
   zonename : u'MCCT-SHARED-1',
   isdynamicallyscalable : False,
   tags : [],
   isfeatured : False,
   sshkeyenabled : False,
   isextractable : False,
   crossZones : False,
   account : u'test-TestRouterRules-test_10_destroy_cpvm-LXQSYL',
   name : u'tiny-kvm-D9K3XF',
   hypervisor : u'KVM',
   ispublic : False,
   checksum : u'f50acb3a4387019b473d0f25a42bf06e'
 }
]

As you can see, there's no "status" in this response.
So somehow, the issue is due to the fact that a `listTemplates` request 
returned a result without status during a template download.

I cannot see how it can be related to this change. Moreover, I tested my 
pull request, and my tests included a template download and a VM deployment.

@swill Is it possible that an error in the template download would cause 
the absence of the status field, and therefore this error?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1547#issuecomment-219121539
  
I like the first two.
The third should read something like:
CLOUDSTACK-8303 allow multiple ranges & finite lease time
the 4th and 5th I really need to think about but these are not very concise 
or clear
the 6th could be something like
```
Fixing router ipaddress issues
 cleanup imports,
 fix get_str(),
 improve & fix service post_config logic
```
that way all the info is there for who takes the trouble to click the (...) 
and for those that are to lazy there is a clear subtract in less then 72 chars.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread PaulAngus
Github user PaulAngus commented on the pull request:

https://github.com/apache/cloudstack/pull/1537#issuecomment-219119839
  

Thanks Will.

Kind regards,

Paul Angus


Regards

Paul Angus
VP Technology
www.shapeblue.com
From: Will Stevens [mailto:notificati...@github.com]
Sent: 13 May 2016 16:38
To: apache/cloudstack 
Cc: Paul Angus ; State change 

Subject: Re: [apache/cloudstack] Remove extraneous log directory and add 
catalina.out log rotation (#1537)


Thank you for your patience sir. 👍 I will get this merged...

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on 
GitHub



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-13 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request:

https://github.com/apache/cloudstack/pull/1297

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1297


commit 151c1fb2f15813db724752e435dd5817afafe06d
Author: Daan Hoogland 
Date:   2016-04-11T18:22:34Z

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java

commit b8dbaf7fa439c941af0b3e21110ef33ff310d974
Author: Loic Lambiel 
Date:   2015-05-15T13:15:26Z

CLOUDSTACK-9203 Prevent security group update while instance is running

  cherry-picked from a exoscale internal fix

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

commit f6aaf3323cb0f0b4b1cfe08a58c2e4e391698c77
Author: Daan Hoogland 
Date:   2015-12-30T12:13:38Z

CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

commit 2fa8b22ec6a4f24e08c34f2e0de361c414eecaa4
Author: Daan Hoogland 
Date:   2015-12-30T12:13:38Z

CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

commit 545e8adfe7a8d6e63639d34f8160efa559f4fc83
Author: Wei Zhou 
Date:   2016-01-12T09:56:07Z

CLOUDSTACK-9203: fix issue if there are multiple shared networks

commit ae558e9f34fb239e35a6e3e078f121b7440f917d
Author: Wei Zhou 
Date:   2016-01-22T11:45:13Z

CLOUDSTACK-9203: fix issue when update vm in isolated networks

commit 3efc7c2ccc211c0a40f6edf7f1ce394e1e8f64dc
Author: Daan Hoogland 
Date:   2016-04-11T18:22:34Z

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Moving to Java8

2016-05-13 Thread Ron Wheeler
I am not sure what you are using in Spring but I have been using Spring 
3.x.x with Java 8 for some time.


I can believe that Spring 4 is "better" than Spring 3 but you might see 
if you can separate these two technology upgrades just to keep it simple.
There is enough in Java 8 to make a pretty big project if you just look 
at Streams and refactoring interfaces and abstract classes to reduce the 
amount of code.


Just a comment from the cheap seats.

Ron


On 13/05/2016 1:10 PM, Rohit Yadav wrote:

All,


I've started some work [pr] that aims to adapt CloudStack to recent changes in 
the environments and the ecosystem:


- Java8, Spring 4.x

- SystemD

- MariaDB and MySQL

- Reduce distro provided package dependency

- Packaging, CI and testing


These are long term goals but I've identified some concrete goals:


- Migrate to Java8 both for building codebase and running CloudStack (mgmt 
server, usage, agent etc)

- Migrate to Spring 4.x as 3.x is not supported to work with Java7

- Fix CI and packaging to use Java8

- Reduce distro specific package dependency such as Tomcat, since we're already 
using Jetty (maven-jetty-plugin) during development we can use embedded Jetty 
for mgmt server(s) as well

- Update systemvm template to include Java8 JRE

- Update packaging to support systemd (CentOS7+ has some systemd support and 
thanks to Wido's recent PR we would have systemd support for debian packages in 
future too)

- Optimize JVM options for long running mgmt server(s), agent(s) and usage 
server(s) to run on JRE8


I've sent a [pr] to show some initial progress in this regard where we've some 
outstanding issues but we're able to build/run/test with Java8 + Spring 4.x and 
TravisCI has been fixed to use JDK8 as well.


Testing in general would be a huge requirement for this initiative, especially 
testing of all the plugins. Java7 has EOL-ed and Java9 is around the corner; 
we've seen good amount of security and memory issues with Java7/6 and 
Tomcat6.x; therefore it seems necessary to work on above as we move towards a 
LTS release in upcoming months.


Request for comments, suggestions and guidance. Thanks.


[pr] https://github.com/apache/cloudstack/pull/1546


Regards.

Regards,

Rohit Yadav

rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1513#issuecomment-219109520
  
Holy errors batman!!!



It looks like it started like this:
```
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-server ---
[INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file
[cobertura] WARN  [main] 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter - Unable to 
instrument file 
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/server/target/generated-classes/cobertura/com/cloud/ha/AbstractInvestigatorImpl.class
java.lang.NullPointerException
at 
net.sourceforge.cobertura.instrument.tp.ClassMap.applyOnProjectData(ClassMap.java:364)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:187)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:121)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.addInstrumentationToSingleClass(CoberturaInstrumenter.java:234)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentationToSingleClass(Main.java:298)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentation(Main.java:307)
at 
net.sourceforge.cobertura.instrument.Main.parseArguments(Main.java:399)
at net.sourceforge.cobertura.instrument.Main.main(Main.java:421)
[cobertura] WARN  [main] 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter - Unable to 
instrument file 
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/server/target/generated-classes/cobertura/com/cloud/ha/HighAvailabilityManagerImpl$WorkerThread.class
java.lang.NullPointerException
at 
net.sourceforge.cobertura.instrument.tp.ClassMap.applyOnProjectData(ClassMap.java:364)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:187)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:121)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.addInstrumentationToSingleClass(CoberturaInstrumenter.java:234)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentationToSingleClass(Main.java:298)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentation(Main.java:307)
at 
net.sourceforge.cobertura.instrument.Main.parseArguments(Main.java:399)
at net.sourceforge.cobertura.instrument.Main.main(Main.java:421)
[cobertura] WARN  [main] 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter - Unable to 
instrument file 
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/server/target/generated-classes/cobertura/com/cloud/ha/RecreatableFencer.class
java.lang.NullPointerException
at 
net.sourceforge.cobertura.instrument.tp.ClassMap.applyOnProjectData(ClassMap.java:364)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:187)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:121)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.addInstrumentationToSingleClass(CoberturaInstrumenter.java:234)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentationToSingleClass(Main.java:298)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentation(Main.java:307)
at 
net.sourceforge.cobertura.instrument.Main.parseArguments(Main.java:399)
at net.sourceforge.cobertura.instrument.Main.main(Main.java:421)
[cobertura] WARN  [main] 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter - Unable to 
instrument file 
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/server/target/generated-classes/cobertura/com/cloud/ha/dao/HighAvailabilityDao.class
java.lang.NullPointerException
at 
net.sourceforge.cobertura.instrument.tp.ClassMap.applyOnProjectData(ClassMap.java:364)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:187)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.instrumentClass(CoberturaInstrumenter.java:121)
at 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter.addInstrumentationToSingleClass(CoberturaInstrumenter.java:234)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentationToSingleClass(Main.java:298)
at 
net.sourceforge.cobertura.instrument.Main.addInstrumentation(Main.java:307)
at 
net.sourceforge.cobertura.instrument.Main.parseArguments(Main.java:399)
at net.sourceforge.cobertura.instrument.Main.main(Main.java:421)
[cobertura] WARN  [main] 
net.sourceforge.cobertura.instrument.CoberturaInstrumenter - Unable to 
instrument file 

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-219105793
  
Awesome, thanks guys.  I will merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-219104928
  
Ya, I like this.  I think this is a nice advancement.  If we are going to 
try to get this into 4.9, I will need some help getting this moving forward 
cause we are pretty tight on time.  @wido are you running this in production 
and what can you provide to show it is working as expected?  I need to review 
the details for releasing when including system VM changes.  I know we wanted 
to try to get StrongSwan into this release (assuming we can get it there), so 
that would require a new system VM template as well.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[DISCUSS] Moving to Java8

2016-05-13 Thread Rohit Yadav
All,


I've started some work [pr] that aims to adapt CloudStack to recent changes in 
the environments and the ecosystem:


- Java8, Spring 4.x

- SystemD

- MariaDB and MySQL

- Reduce distro provided package dependency

- Packaging, CI and testing


These are long term goals but I've identified some concrete goals:


- Migrate to Java8 both for building codebase and running CloudStack (mgmt 
server, usage, agent etc)

- Migrate to Spring 4.x as 3.x is not supported to work with Java7

- Fix CI and packaging to use Java8

- Reduce distro specific package dependency such as Tomcat, since we're already 
using Jetty (maven-jetty-plugin) during development we can use embedded Jetty 
for mgmt server(s) as well

- Update systemvm template to include Java8 JRE

- Update packaging to support systemd (CentOS7+ has some systemd support and 
thanks to Wido's recent PR we would have systemd support for debian packages in 
future too)

- Optimize JVM options for long running mgmt server(s), agent(s) and usage 
server(s) to run on JRE8


I've sent a [pr] to show some initial progress in this regard where we've some 
outstanding issues but we're able to build/run/test with Java8 + Spring 4.x and 
TravisCI has been fixed to use JDK8 as well.


Testing in general would be a huge requirement for this initiative, especially 
testing of all the plugins. Java7 has EOL-ed and Java9 is around the corner; 
we've seen good amount of security and memory issues with Java7/6 and 
Tomcat6.x; therefore it seems necessary to work on above as we move towards a 
LTS release in upcoming months.


Request for comments, suggestions and guidance. Thanks.


[pr] https://github.com/apache/cloudstack/pull/1546


Regards.

Regards,

Rohit Yadav

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom commented on the pull request:

https://github.com/apache/cloudstack/pull/1513#issuecomment-219101084
  
@swill Hmm. Now it's a _different_ Cobertura error


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Kvm plugin restructure

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1521#issuecomment-219101062
  
We have merge conflicts on this one.  As soon as the merge conflicts are 
sorted out, I will run CI against it and hopefully we can get some code reviews 
quickly so we can keep it moving...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1297#issuecomment-219100429
  
This one errored again in both Jenkins and Travis.  Not sure if that 
signifies an actual problem or if things are just acting up.  I fix to some of 
the issues in Jenkins and Travis have been pushed since this was last run.  Can 
we kick this one again to see if it comes back clean now.  If not, we may need 
to investigate.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1543#discussion_r63215625
  
--- Diff: test/integration/component/test_acl_listvolume.py ---
@@ -357,9 +357,9 @@ def tearDownClass(cls):
 cls.apiclient = super(TestVolumeList, 
cls).getClsTestClient().getApiClient()
 cls.apiclient.connection.apiKey = cls.default_apikey
 cls.apiclient.connection.securityKey = cls.default_secretkey
+cleanup_resources(cls.apiclient, cls.cleanup)
--- End diff --

Disregard, I can't read the difference between `test_acl_listvolume.py` and 
`test_acl_listvm.py`.  Deleting both of these comments.  This post is for 
everyone who follows this stuff in their email and are confused...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1543#discussion_r63215404
  
--- Diff: test/integration/component/test_acl_listvolume.py ---
@@ -357,9 +357,9 @@ def tearDownClass(cls):
 cls.apiclient = super(TestVolumeList, 
cls).getClsTestClient().getApiClient()
 cls.apiclient.connection.apiKey = cls.default_apikey
 cls.apiclient.connection.securityKey = cls.default_secretkey
+cleanup_resources(cls.apiclient, cls.cleanup)
--- End diff --

Is this to fix this problem?  This is from #1297, which was ran before I 
got this fix merged.

```
==
ERROR: test suite for 
--
Traceback (most recent call last):
  File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", 
line 228, in run
self.tearDown()
  File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", 
line 351, in tearDown
self.teardownContext(ancestor)
  File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", 
line 367, in teardownContext
try_run(context, names)
  File "/home/travis/.local/lib/python2.7/site-packages/nose/util.py", line 
471, in try_run
return func()
  File 
"/home/travis/build/apache/cloudstack/test/integration/component/test_acl_listvm.py",
 line 346, in tearDownClass
cls.domain_1.delete(cls.apiclient,cleanup="true")
  File 
"/home/travis/.local/lib/python2.7/site-packages/marvin/lib/base.py", line 78, 
in delete
apiclient.deleteDomain(cmd)
  File 
"/home/travis/.local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py",
 line 703, in deleteDomain
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File 
"/home/travis/.local/lib/python2.7/site-packages/marvin/cloudstackConnection.py",
 line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : 
u'2016-05-13T14:25:30+', cmd : 
u'org.apache.cloudstack.api.command.admin.domain.DeleteDomainCmd', userid : 
u'7e18b4b2-1915-11e6-abc2-42010a800044', jobstatus : 2, jobid : 
u'a3e58407-3f1a-4508-9671-733029d283c0', jobresultcode : 530, jobresulttype : 
u'object', jobresult : {errorcode : 530, errortext : u'Failed to clean up 
domain resources and sub domains, delete failed on domain D1-HVOVF7 (id: 2).'}, 
accountid : u'7e188b32-1915-11e6-abc2-42010a800044'}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/798#issuecomment-219096839
  
@maneesha-p can you rebase and push so we can get this PR green?  I would 
love some code review as well.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1543#issuecomment-219095904
  
Thanks for the effort stabilizing Jenkins and Travis the last few days.  
This has been super helpful as we get close to the freeze.  Very much 
appreciated.  Most of the runs are coming back clean now.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1543#issuecomment-219095201
  
Thanks @swill 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread The-Loeki
Github user The-Loeki commented on the pull request:

https://github.com/apache/cloudstack/pull/1547#issuecomment-219094194
  
Like this then :dart: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-219093988
  
I will run this through my KVM CI right now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1532#issuecomment-219093207
  
I am counting my own code review on this one given the scope of the change 
and the fact that a review is the only thing holding this up.  I will merge 
this one...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

2016-05-13 Thread swill
Github user swill commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/38#issuecomment-219092042
  
Thanks for taking care of this @rhtyd.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1513#issuecomment-219091474
  
@insom yes, I tend to agree with you.  the main reason I highlighted it was 
because the error was network related and the code changed details related to 
an interface, so I figured I would check.  Once everything comes back green, I 
will merge this.  Thank you for the work and the quick reply.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-219088252
  
This one is coming back with a clean bill of health.  I think we are ready 
on this one.  Can I get some code review?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-219088009
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 9h 21m 07s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_51_15_RMVFB8:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_51_15_RMVFB8/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_51_15_RMVFB8/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_51_15_RMVFB8/runinfo.txt)

**`/tmp/MarvinLogs/test_network_B5H17M:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_network_B5H17M/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_network_B5H17M/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_network_B5H17M/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_R4QHHL:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_vpc_routers_R4QHHL/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_vpc_routers_R4QHHL/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_vpc_routers_R4QHHL/runinfo.txt)


Uploads will be available until `2016-07-13 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-219087700
  
The CI does not cover the actual code, but instead makes sure nothing else 
is broken by these changes.  The test results provided by @nlivens show the 
tests for the actual code is working as expected.

I would like to get at least one code review on this one so I can merge it. 
 I think this update would be appreciated in the 4.9 release, so please have a 
look.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-219086756
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 9h 17m 55s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_37_00_R77PF3:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_37_00_R77PF3/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_37_00_R77PF3/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_37_00_R77PF3/runinfo.txt)

**`/tmp/MarvinLogs/test_network_2M1WDA:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_2M1WDA/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_2M1WDA/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_2M1WDA/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_VNMRHI:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_VNMRHI/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_VNMRHI/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_VNMRHI/runinfo.txt)


Uploads will be available until `2016-07-13 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom commented on the pull request:

https://github.com/apache/cloudstack/pull/1513#issuecomment-219085734
  
@swill I've closed and re-opened. This change is to a shell script only and 
the failures are within Marvin, so I'm pretty confident that they are unrelated 
to my proposed change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom closed the pull request at:

https://github.com/apache/cloudstack/pull/1513


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
GitHub user insom reopened a pull request:

https://github.com/apache/cloudstack/pull/1513

CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations 
(4.8-2)

From the [JIRA 
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362):

> 
https://github.com/apache/cloudstack/commit/bb8f7c652e42caacff5adce1ce60342603677605
> 
> The above commit introduces rewriting of bridge device names when 
migrating a virtual machine from one host to another. However, it also matches 
bridges called "brvx-1234" and rewrites them to (in my case) "brem1-1234" - 
this doesn't match the bridge name on the destination and causes the migration 
to fail with the error:
> 
> error : virNetDevGetMTU:397 : Cannot get interface MTU on 'brem1-1234': 
No such device
> 
> I have flagged this as major because it's not possible to migrate VMs 
using VXLANs for maintenance, which seems important (it's certainly important 
to me!).

This is a version of #1508 based against 4.8 (sorry!)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/insom/cloudstack CLOUDSTACK-9362-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1513


commit d2eb0a537a1f279a83f4af4f8f1bbae9d5aefba8
Author: Aaron Brady 
Date:   2016-04-21T14:19:56Z

Skip VXLANs when rewriting the bridge name for migrations




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1513#issuecomment-219084969
  
@insom, @dmabry and @kiwiflyer, the CI failure seems like it could be 
related to this change, but I can't be sure.  Can you guys provide some 
guidance since all of you have tested this.  Also, @insom can you do a force 
push or close and re-open the PR so we can get this green to make it mergeable 
once we agree on status.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1513#issuecomment-219084090
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 1
   Errors: 0
 Duration: 9h 01m 07s
```

**Summary of the problem(s):**
```
FAIL: Test Site 2 Site VPN Across redundant VPCs
--
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 984, in test_01_redundant_vpc_site2site_vpn
self.assert_(vpc2 is not None, "VPC2 creation failed")
AssertionError: VPC2 creation failed
--
Additional details in: /tmp/MarvinLogs/test_network_B8TEJ7/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_26_38_6CZAVF:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_26_38_6CZAVF/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_26_38_6CZAVF/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_26_38_6CZAVF/runinfo.txt)

**`/tmp/MarvinLogs/test_network_B8TEJ7:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/test_network_B8TEJ7/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/test_network_B8TEJ7/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/test_network_B8TEJ7/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_XOZ934:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/test_vpc_routers_XOZ934/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/test_vpc_routers_XOZ934/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1513/tmp/MarvinLogs/test_vpc_routers_XOZ934/runinfo.txt)


Uploads will be available until `2016-07-13 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1503#issuecomment-219083712
  
I have never seen these test failures before, so I believe they are somehow 
related to this change.  @olivierlemasle can you review the CI results and post 
your feedback.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread nvazquez
Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-219083470
  
@koushik-das I only use Vmware hypervisor so I couldn't test it for Xen or 
KVM. However, I reviewed code and found 
`copySnapshotToTemplateFromNfsToNfsXenserver` method in 
`NfsSecondaryStorageResource` which will attemp mount using nfs version. I'm 
not very familiar to Xen code in CloudStack but if it uses NfsSecondaryStorage 
for mounting I think I can succeed, but it should be tested or improved to 
support those hypervisors


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1503#issuecomment-219082695
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 0
   Errors: 3
 Duration: 8h 28m 52s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_W3KO3O/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_W3KO3O/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_W3KO3O/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_19_57_00T0NU:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1503/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_19_57_00T0NU/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1503/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_19_57_00T0NU/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1503/tmp/MarvinLogs/DeployDataCenter__May_12_2016_22_19_57_00T0NU/runinfo.txt)

**`/tmp/MarvinLogs/test_network_W3KO3O:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1503/tmp/MarvinLogs/test_network_W3KO3O/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1503/tmp/MarvinLogs/test_network_W3KO3O/results.txt)
* 

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1486#issuecomment-219082129
  
This one is looking pretty good.  Can we get some code review on it so we 
can move it forward.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-219081336
  
@ustcweizhou would you mind doing a force push or close and reopen this PR 
to kickoff jenkins so we are all green when @kiwiflyer posts his test results.  
This will help us get this merged right away once we have his review.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1537#issuecomment-219079650
  
Thank you for your patience sir.  👍   I will get this merged...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread PaulAngus
Github user PaulAngus commented on the pull request:

https://github.com/apache/cloudstack/pull/1537#issuecomment-219077622
  
Hurrah!!
passed both this time @swill 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219077134
  
@kiwiflyer thanks, I will run CI against it as well.  It is good to have CI 
posted as well as manual verification.  that gives us the most confidence that 
everything is in a good place.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-13 Thread nvazquez
Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1539#issuecomment-219077065
  
Thanks, closed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-13 Thread nvazquez
Github user nvazquez closed the pull request at:

https://github.com/apache/cloudstack/pull/1539


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219076184
  
We have the fixes pulled in for testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1470#issuecomment-219074669
  
I will rerun CI on this now.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-219074192
  
@syed can you force push or close and reopen the PR to kick off travis and 
jenkins?  I think this one seems to be in a pretty good state now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-219073755
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 18m 48s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_12_2016_21_43_23_1TT3ZU:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/DeployDataCenter__May_12_2016_21_43_23_1TT3ZU/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/DeployDataCenter__May_12_2016_21_43_23_1TT3ZU/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/DeployDataCenter__May_12_2016_21_43_23_1TT3ZU/runinfo.txt)

**`/tmp/MarvinLogs/test_network_R3P7FB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/test_network_R3P7FB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/test_network_R3P7FB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/test_network_R3P7FB/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_HKWN9Z:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/test_vpc_routers_HKWN9Z/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/test_vpc_routers_HKWN9Z/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1331/tmp/MarvinLogs/test_vpc_routers_HKWN9Z/runinfo.txt)


Uploads will be available until `2016-07-13 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1543


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1543#issuecomment-219071379
  
Most of these things are fixes to Jenkins and travis issues, so those jobs 
being green is good validation of the fixes.  The main functionality change has 
been validated by @kiwiflyer, so I will get this merged right away.  Thanks for 
being on top of this @rhtyd, I really appreciate it.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...

2016-05-13 Thread serg38
Github user serg38 commented on the pull request:

https://github.com/apache/cloudstack/pull/798#issuecomment-219067011
  
It would be nice if this is resolved. The issue still exists in 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1547#issuecomment-219063444
  
:+1: maybe squash the conflict entries out?
you can rebase -i HEAD^7 and then reorder the commits. If you put the last 
one at position 3 and change the prefix 'pick' to 'f' for fixup you should be 
fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread The-Loeki
Github user The-Loeki commented on the pull request:

https://github.com/apache/cloudstack/pull/1547#issuecomment-219062321
  
@DaanHoogland like it better now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1547#discussion_r63188515
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -66,8 +66,13 @@ def is_router(self):
 def get_domain(self):
 return self.cl.get_domain()
 
+def use_extdns(self):
+return self.cmdline().idata().get('useextdns', 'false') == 'true'
+
 def get_dns(self):
+conf = self.cmdline().idata()
 dns = []
+<<< e09480728f4ed77d0bd0bdc6a6c0966d90f7ee26
--- End diff --

I think you want to squash these out with the last commit in your PR. We 
wouldn't want this in our history you dutch commercial fan ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1542#issuecomment-219052329
  
:) no worries, just expect some review comments to this extend ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1547#issuecomment-219054423
  
@The-Loeki those don't show in a short listing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1547#issuecomment-219053999
  
@The-Loeki 6 commits with the same message is not helpful and indeed 
confusing. Can you change them to shortly describe the individual fixes, or if 
you must squash them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   >