Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r79315873
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1448,55 @@ private String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r79315898
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1448,55 @@ private String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r79315948
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1448,55 @@ private String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r79315938
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1448,55 @@ private String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r79315920
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1448,55 @@ private String
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@serg38 @nvazquez I will merge this PR when I get into the office on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1643
@abhinandanprateek this fix seems like it would also be beneficial for
4.8.2.0. How difficult would it be to re-target it to the 4.8 branch?
---
If your project is set up for it, you can
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@abhinandanprateek @koushik-das @marcaurele have you been able to come to
agreement about the correct functionality for this PR?
---
If your project is set up for it, you can reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1659
@murali-reddy what is the status of addressing the review feedback. Also,
have addressed the VPC-related issues as well?
---
If your project is set up for it, you can reply to this email
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@rhtyd have you had a chance to analyze? I would like to include this
change in 4.9.1.0 and 4.10.0.0 for which we are planning to cut RCs on 25 Sept
2016.
---
If your project is set up
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1606
@leprechau I would like to get this fix into 4.8.2.0, 4.9.1.0, and
4.10.0.0. Have you had a chance to add the unit tests requested? Also, is
there a JIRA ticket for this bug?
---
If your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1623
@ProjectMoon I am extending the date for 4.8 to 25 Sept 2016. Therefore,
if we can get the test failure fixed, we can get it into 4.8.2.0, 4.9.1.0, and
4.10.0.0. Also, could you please
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1624
@ProjectMoon I want to get this PR into 4.8.2.0, 4.9.1.0, and 4.10.0.0 for
which we will be cutting RCs on 25 Sept 2016. Tests should be the entire
Marvin smoke test suite against VMware, KVM
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1637
@lmrv I would like to include this PR in the upcoming 4.8.2.0, 4.9.1.0, and
4.10.0.0 releases. In order to merge it, the following items need to be
addressed:
* [ ] Squash commits
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1639
@abhinandanprateek ping regarding the Travis and Jenkins failures. I would
like to include this PR in the upcoming 4.8.2.0, 4.9.1.0, and 4.10.0.0 releases
for which we plan to cut an RC on 25
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@serg38 @nvazquez I just noticed that this bug was merged to master, but it
should also be included in LTS My thinking is that we rollback this commit
from master, re-open this PR against
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1655
@lygutas I would like to get this PR into the upcoming 4.8 (4.8.2.0), 4.9
(4.9.1.0), and 4.10 (4.10.0.0) for which we will be cutting RCs in a week (25
Sept 2016). I see the following minor
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1666
@murali-reddy have you had a chance to investigate the Jenkins failure(s)
and the test failures identified by @karuturi?
Does this PR address
[CLOUDSTACK-9480](https
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1511
@rhtyd given that we have one more release of 4.8 in the pipeline, would it
make sense to re-target this PR to 4.8 and forward merge to 4.9 and master?
---
If your project is set up
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1611
@rhtyd this enhancement/fix seems like it would be useful for on-going
testing of LTS. Therefore, could you please re-target this PR to the 4.9
release branch? Also, could you please
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1611#discussion_r79303367
--- Diff: tools/marvin/marvin/deployDataCenter.py ---
@@ -224,6 +225,15 @@ def createClusters(self, clusters, zoneId, podId,
vmwareDc=None
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1546
@rhtyd Can we close this PR in favor of #1638?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1650
@PaulAngus @abhinandanprateek could you investigate the VMware issue
described by @serg38?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1651
@serg38 @PaulAngus has been on vacation for the past week. Since this
problem is present in 4.8 and 4.9, could you please retarget this PR to the 4.8
release branch? Also, as @serg38
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1652
@PaulAngus following up on PR feedback. @fmaximus did you apply this patch
in another PR? If so, could you please provide a reference?
If this patch has not been addressed elsewhere
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1662
@digitalgust following up on @rhtyd's feedback. I see the following items
to be addressed in order to get this PR merged:
* [ ] Squash commits
* [ ] Re-point the PR
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@wido this fix seems like it would be good for 4.8 and 4.9 as well. Would
you mind re-pointing this PR to the 4.8 branch?
Also, could you investigate the cause of the Jenkins failure
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1673#discussion_r79302819
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -285,9 +286,15 @@ private void init(Map<String, String> c
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski the reason I would like the regression tests run is to
confirm that assumption.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez I will review the test case in the morning. In the interim,
please squash your commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1642#discussion_r79104522
--- Diff: test/integration/plugins/solidfire/TestManagedSystemVMs.py ---
@@ -0,0 +1,585 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1642#discussion_r79104400
--- Diff: test/integration/plugins/solidfire/TestManagedSystemVMs.py ---
@@ -0,0 +1,585 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1642#discussion_r79104336
--- Diff: test/integration/plugins/solidfire/TestManagedSystemVMs.py ---
@@ -0,0 +1,585 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski sorry I forgot the precise way to do it -- thanks for
digging it out. It makes tests far more resilient to differences between test
environments.
As I mentioned
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@koushik-das didn't notice that path, but completely agree. I'd like to
see a generic test requirement for managed storage which make the test cases
more reusable for future storage drivers
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@karuturi there remains the issue of the hard coded template name.
Therefore, I am -1 until the issue of the hardcoded template name is addressed.
These hardcoded values cause massive
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1642#discussion_r78782746
--- Diff: test/integration/plugins/solidfire/TestManagedSystemVMs.py ---
@@ -0,0 +1,586 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1642#discussion_r78780699
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1113,8 +1114,17 @@ public void cleanupStorage(boolean recurring
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1511
@rhtyd this PR is actually fairly important as it upgrades our crypto
implementation to the latest available. Therefore, I want to get it into LTS
for 4.9.2.0.
In addition
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648723
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78649049
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648669
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648573
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648332
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647094
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647052
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648238
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648029
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647513
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -726,17 +729,17 @@ public void runDeleteSslCertInvalidId() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647426
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -686,35 +689,35 @@ public void runDeleteSslCertBoundCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647300
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -571,43 +573,44 @@ public void runUploadSslCertNotX509() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645945
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645447
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -297,48 +297,48 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645238
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -297,48 +297,48 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645782
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646098
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647140
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -571,43 +573,44 @@ public void runUploadSslCertNotX509() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647190
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -571,43 +573,44 @@ public void runUploadSslCertNotX509() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646689
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646330
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646913
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646974
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646545
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646056
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645990
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645872
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645670
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645295
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -297,48 +297,48 @@ public void runUploadSslCertNoRootCert() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644966
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644844
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644684
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -200,23 +200,23 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644729
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -200,23 +200,23 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644594
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -125,48 +125,48 @@ public void runUploadSslCertWithCAChain() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644423
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -125,48 +125,48 @@ public void runUploadSslCertWithCAChain() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78643673
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78643413
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78642099
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78642059
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78641993
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78641717
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78640135
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78639151
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638892
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638846
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638396
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638045
--- Diff: pom.xml ---
@@ -70,7 +70,7 @@
4.12
1.3
-1.46
+1.54
--- End diff --
it appears
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1666
@murali-reddy could you please investigate the cause of the Jenkins build
failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@serg38 I completely agree that it should be in the database, but it's not
a configuration setting. Furthermore, it requires a different transactional
behavior to operate properly. Therefore
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1658
@karuturi the point is that there is no discussion about who can commit.
It is in black and white in Section 2.3 of our bylaws and the Apache Way. As I
said in my previous comment, no one
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@serg38 the git-pr script is not working properly for me. I will debug
further tomorrow.
@rafaelweingartner do you mind doing the merge honors?
---
If your project is set up
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Just realized I hadn't re-reviewed. LGTM for code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1658
@swill where hardware are being varies by PR. In some cases, we have
people running them in their labs and reporting results. Other cases, it's
blueorangatan going through ShapeBlue Jenkins
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1658
@swill other than verifying that the proper review has been done and a
reasonable set of Marvin test cases have been run on the appropriate platforms,
what else are you expecting
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1658
@swill the RM is still maintaining the stability of master. I check that
all non-security merges meet the criteria we have laid out. If/when I find one
that does not, I will roll it back
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1658
@swill we never had a policy that only release managers could merge. Remi
was active that he typically merged PRs before anyone else had a chance. The
[release
principles|https
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1658
@karuturi there is no discussion to be had. According to our bylaws,
committers have the right to commit to any branch. Period. Full stop. If you
would like to change it, propose a change
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@nvazquez this PR has merge conflicts that must be resolved before we can
merge it. @serg38 after @nvazquez has resolved the merge conflicts, could you
please re-execute your tests to ensure
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1651
@rafaelweingarter I prefer squashed commits with a commit message with an
80 character summary as the first line and a paragraphs/bullets following
explaining the reason for the change and any
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@serg38 I will be going through other PRs tomorrow that are due for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@rafaelweingartner @serg38 is correct. Any committer may merge a PR so
long as the following conditions are met:
* At least 1 code review LGTM
* At least 1 test LGTM
401 - 500 of 1850 matches
Mail list logo
