[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1580 CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin Support for underlay features (Source & Static NAT to underlay) with Nuage VSP SDN Plugin including Marvin test coverage for corresponding Source & Static NAT features on master. Moreover, our Marvin tests are written in such a way that they can validate our supported feature set with both Nuage VSP SDN platform's overlay and underlay infra. PR contents: 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN Plugin. 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN Plugin. 3) Marvin test coverage for Source & Static NAT to underlay on master with Nuage VSP SDN Plugin. 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory). 5) PEP8 & PyFlakes compliance with our Marvin test code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1580 commit e5fd206e7e090121798c80745df4629f890e3234 Author: Eric Waegeman <eric.waege...@nuagenetworks.net> Date: 2016-05-26T09:37:52Z CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin commit ec7b6a5f887555e513b1d1d9c5e469eb079d721a Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-05-26T10:48:02Z CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp commit be8ae9376664925255595a50f5c4574c4abb7179 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-06-15T09:04:21Z CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin commit a2e1999bbacf3e00570bd51492b05cda8ca81c7d Author: Rahul Singal <rahul.sin...@nuagenetworks.net> Date: 2016-07-01T13:22:50Z CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1580 CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin Support for underlay features (Source & Static NAT to underlay) with Nuage VSP SDN Plugin including Marvin test coverage for corresponding Source & Static NAT features on master. Moreover, our Marvin tests are written in such a way that they can validate our supported feature set with both Nuage VSP SDN platform's overlay and underlay infra. PR contents: 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN Plugin. 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN Plugin. 3) Marvin test coverage for Source & Static NAT to underlay on master with Nuage VSP SDN Plugin. 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory). 5) PEP8 & PyFlakes compliance with our Marvin test code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1580 commit e5fd206e7e090121798c80745df4629f890e3234 Author: Eric Waegeman <eric.waege...@nuagenetworks.net> Date: 2016-05-26T09:37:52Z CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin commit ec7b6a5f887555e513b1d1d9c5e469eb079d721a Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-05-26T10:48:02Z CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp commit be8ae9376664925255595a50f5c4574c4abb7179 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-06-15T09:04:21Z CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin commit a2e1999bbacf3e00570bd51492b05cda8ca81c7d Author: Rahul Singal <rahul.sin...@nuagenetworks.net> Date: 2016-07-01T13:22:50Z CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1579 CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin This is first phase of support of Shared Network in cloudstack through NuageVsp Network Plugin. A shared network is a type of virtual network that is shared between multiple accounts i.e. a shared network can be accessed by virtual machines that belong to many different accounts. This basic functionality will be supported with the below common use case: - shared network can be used for monitoring purposes. A shared network can be assigned to a domain and can be used for monitoring VMs belonging to all accounts in that domain. With the current implementation with NuageVsp plugin, Each shared network needs its unique IP address range, and can not overlap with another shared network. In VSD, it is implemented in below manner: - In order to have tenant isolation for shared networks, we will have to create a Shared L3 Subnet for each shared network, and instantiate it across the relevant enterprises. A shared network will only exist under an enterprise when it is needed, so when the first VM is spinned under that ACS domain inside that shared network. PR contents: 1) Support for shared networks with tenant isolation on master with Nuage VSP SDN Plugin. 2) Marvin test coverage for shared networks on master with Nuage VSP SDN Plugin. 3) Enhancements on our exiting Marvin test code (nuagevsp plugins directory). 4) PEP8 & PyFlakes compliance with our Marvin test code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack nuage_vsp_shared_networks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1579.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1579 commit f316851375678b048e95d082a9df7035c7de0fa9 Author: Eric Waegeman <eric.waege...@nuagenetworks.net> Date: 2016-05-26T09:37:52Z CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin commit b10af67fef96607f7bf4defc8ccdb5e679f9fdc2 Author: Rahul Singal <rahul.sin...@nuagenetworks.net> Date: 2016-07-01T13:22:50Z CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp commit b6b9589a6b452a1aec7185d26662f24554adf938 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-04-28T14:24:50Z CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin commit 09ee14e3917c69dfcbd5cf182ba44e77f2a31007 Author: rahul singal <rahul.sin...@alcatel-lucent.com> Date: 2016-06-01T15:31:24Z CLOUDSTACK-9403 : Marvin tests for shared networks verification with NuageVsp commit 9b4af844ff2d2ce008b7b8ec315754c2d9712964 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-07-01T14:14:55Z CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin commit 381b1ea79abe5712a346bf917326344abfa7a571 Author: Rahul Singal <rahul.sin...@nuagenetworks.net> Date: 2016-07-01T14:20:58Z CLOUDSTACK-9403 : Marvin tests for shared networks verification with NuageVsp Phase 2: Public Access --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1579 CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin This is first phase of support of Shared Network in cloudstack through NuageVsp Network Plugin. A shared network is a type of virtual network that is shared between multiple accounts i.e. a shared network can be accessed by virtual machines that belong to many different accounts. This basic functionality will be supported with the below common use case: - shared network can be used for monitoring purposes. A shared network can be assigned to a domain and can be used for monitoring VMs belonging to all accounts in that domain. With the current implementation with NuageVsp plugin, Each shared network needs its unique IP address range, and can not overlap with another shared network. In VSD, it is implemented in below manner: - In order to have tenant isolation for shared networks, we will have to create a Shared L3 Subnet for each shared network, and instantiate it across the relevant enterprises. A shared network will only exist under an enterprise when it is needed, so when the first VM is spinned under that ACS domain inside that shared network. PR contents: 1) Support for shared networks with tenant isolation on master with Nuage VSP SDN Plugin. 2) Marvin test coverage for shared networks on master with Nuage VSP SDN Plugin. 3) Enhancements on our exiting Marvin test code (nuagevsp plugins directory). 4) PEP8 & PyFlakes compliance with our Marvin test code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack nuage_vsp_shared_networks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1579.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1579 commit 22fb8acf90d12925790375738f74c7c1ec4f6e63 Author: Eric Waegeman <eric.waege...@nuagenetworks.net> Date: 2016-05-26T09:37:52Z CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin commit 57117e05a0e46a9f49b8065f9a7704a2eaeb86d3 Author: Rahul Singal <rahul.sin...@nuagenetworks.net> Date: 2016-07-01T13:22:50Z CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp commit 62b48f93118665288e3229180078448bb7aab3d5 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-04-28T14:24:50Z CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin commit 596a4332a5e51f766e2b2519125864b9b745dbef Author: rahul singal <rahul.sin...@alcatel-lucent.com> Date: 2016-06-01T15:31:24Z CLOUDSTACK-9403 : Marvin tests for shared networks verification with NuageVsp commit ea3a72da6836b63d5b1d4ccf9aa6faf7c0492fd3 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-07-01T14:14:55Z CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin Phase 2: Public Access commit d66de5e8c0a5bc854557f8465dc3ed954b38e3f2 Author: Frank Maximus <frank.maxi...@nuagenetworks.net> Date: 2016-06-22T13:22:25Z CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin Phase 2: Public Access commit 5d41ba44d5455fe6fce3040367955fcbd96fab2b Author: Rahul Singal <rahul.sin...@nuagenetworks.net> Date: 2016-07-01T14:20:58Z CLOUDSTACK-9403 : Marvin tests for shared networks verification with NuageVsp Phase 2: Public Access --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1580 CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin Support for underlay features (Source & Static NAT to underlay) with Nuage VSP SDN Plugin including Marvin test coverage for corresponding Source & Static NAT features on master. Moreover, our Marvin tests are written in such a way that they can validate our supported feature set with both Nuage VSP SDN platform's overlay and underlay infra. PR contents: 1) Support for Source NAT to underlay feature on master with Nuage VSP SDN Plugin. 2) Support for Static NAT to underlay feature on master with Nuage VSP SDN Plugin. 3) Marvin test coverage for Source & Static NAT to underlay on master with Nuage VSP SDN Plugin. 4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory). 5) PEP8 & PyFlakes compliance with our Marvin test code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1580 commit 22fb8acf90d12925790375738f74c7c1ec4f6e63 Author: Eric Waegeman <eric.waege...@nuagenetworks.net> Date: 2016-05-26T09:37:52Z CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin commit 57117e05a0e46a9f49b8065f9a7704a2eaeb86d3 Author: Rahul Singal <rahul.sin...@nuagenetworks.net> Date: 2016-07-01T13:22:50Z CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp commit fd5f61c4776fb2404177df1108445a4e8809daae Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-06-15T09:04:21Z CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin commit 315e341a893872b0eecfb737cc659e699dde1eae Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-05-26T10:48:02Z CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1585: CLOUDSTACK-9399 : NPE during deletion of host...
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1585 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1585: CLOUDSTACK-9399 : NPE during deletion of host...
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1585 CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null In most network plugins, there's a Resource class which will handle the communication with the actual device / underlaying client / ... They're configured as a host, so ACS is able to send commands towards it. When they're configured as a host, the clusterId is not filled in since it's not relevant. Hence, the NPE while deleting this host because of ```long clusterId = host.getClusterId();``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-9399 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1585 commit ffe72ca227a518907bca396603a2641e10c5d02d Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-06-03T09:04:09Z CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null commit e972273bf17bedd089b0ef0716615b183dec4135 Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-06-03T18:51:25Z CLOUDSTACK-9399 : Marvin test coverage for Nuage VSP device CRUD operations commit 7531f24d7374be18eac04000ffac12ee5c462953 Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-06-08T13:35:33Z Nuage VSP : Enhancing Marvin test coverage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Github user nlivens commented on the issue: https://github.com/apache/cloudstack/pull/1585 @mike-tutkowski, pinging you because I made changes upon your recent merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1585: CLOUDSTACK-9399 : NPE during deletion of host...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1585 CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null In most network plugins, there's a Resource class which will handle the communication with the actual device / underlaying client / ... They're configured as a host, so ACS is able to send commands towards it. When they're configured as a host, the clusterId is not filled in since it's not relevant. Hence, the NPE while deleting this host because of ```long clusterId = host.getClusterId();``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-9399 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1585 commit ffe72ca227a518907bca396603a2641e10c5d02d Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-06-03T09:04:09Z CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null commit a64f0b903e8c421dfef33b1a2c7347548b5f7fa9 Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-06-03T18:51:25Z CLOUDSTACK-9399 : Marvin test coverage for Nuage VSP device CRUD operations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Github user nlivens commented on the issue: https://github.com/apache/cloudstack/pull/756 ### ACS CI BVT Run **Sumarry:** Build Number 132 Hypervisor xenserver NetworkType Advanced Passed=70 Failed=1 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_service_offerings.py * ContextSuite context=TestServiceOfferings>:setup Failing since 7 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vpc_vpn.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_login.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1580 CLOUDSTACK-9402 : Support for underlay features (PAT & FIP2UL) in Nuage VSP plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1580 commit c86ab936f03b9815debaa535065df10dc724149f Author: Eric Waegeman <eric.waege...@nuagenetworks.net> Date: 2016-05-26T09:37:52Z CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin commit 064646de7604ffb58a4ae7ecc3db103e4e067fbf Author: rahul singal <rahul.sin...@alcatel-lucent.com> Date: 2016-06-02T09:30:25Z CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp commit 60a3b4e27bc6384697025f7263428804c43f9b64 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-04-28T13:52:17Z CLOUDSTACK-9402 : Support for underlay features (PAT & FIP2UL) in Nuage VSP plugin commit ef522a07ecd2f0c98d90ba054d4e7d69e95c1f67 Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-05-26T10:48:02Z CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1579 CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin Test Results are:- Valiate that ROOT admin is NOT able to deploy a VM for a user in ROOT domain in a shared network with ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_ROOTuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for a admin user in a shared network with ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_differentdomain | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for admin user in the same domain but in a ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_domainadminuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for user in the same domain but in a different ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_domainuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for regular user in a shared network with scope=account ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_user | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for user in ROOT domain in a shared network with scope=all ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_ROOTuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for a domain admin users in a shared network with scope=all ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_domainadminuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for other users in a shared network with scope=all ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_domainuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for admin user in a domain in a shared network with scope=all ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainadminuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for any user in a subdomain in a shared network with scope=all ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for parent domain admin user in a shared network with scope=domain with no subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_ROOTuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for domain admin user in a shared network with scope=domain with no subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainadminuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for domain user in a shared network with scope=domain with no subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for parent domain admin user in a shared network with scope=domain with no subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainadminuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for parent domain user in a shared network with scope=domain with no subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for sub domain admin user in a shared network with scope=domain with no subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_subdomainadminuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for sub domain user in a shared network with scope=domain with no subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_subdomainuser | Status : SUCCESS === ok Valiate that ROOT admin is NOT able to deploy a VM for user in ROOT domain in a shared network with scope=domain with subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_ROOTuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for domain admin user in a shared network with scope=domain with subdomain access ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_domain_withsubdomainaccess_domainadminuser | Status : SUCCESS === ok Valiate that ROOT admin is able to deploy a VM for domain user in a shared network with scope
[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1578 CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin Testrun:- Verify InternalDns on Isolated Network ... === TestName: test_01_Isolated_Network_with_zone | Status : SUCCESS === ok Verify InternalDns on Isolated Network with ping by hostname ... === TestName: test_02_Isolated_Network | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_03_Update_Network_with_Domain | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network with ping VM ... === TestName: test_04_Update_Network_with_Domain | Status : SUCCESS === ok Verify InternalDns on VPC Network ... === TestName: test_05_VPC_Network_With_InternalDns | Status : SUCCESS === ok Verify InternalDns on VPC Network by ping with hostname ... === TestName: test_06_VPC_Network_With_InternalDns | Status : SUCCESS === ok -- Ran 6 tests in 5736.562s OK cloudstack$ pep8 --max-line-length=150 test_internal_dns.py cloudstack$ pyflakes test_internal_dns.py cloudstack$ You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack nuage_vsp_internal_dns Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1578.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1578 commit c86ab936f03b9815debaa535065df10dc724149f Author: Eric Waegeman <eric.waege...@nuagenetworks.net> Date: 2016-05-26T09:37:52Z CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin commit 064646de7604ffb58a4ae7ecc3db103e4e067fbf Author: rahul singal <rahul.sin...@alcatel-lucent.com> Date: 2016-06-02T09:30:25Z CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1577: CLOUDSTACK-9321 : Multiple Internal LB rules ...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1577 CLOUDSTACK-9321 : Multiple Internal LB rules (more than one Internal LB rule with same source IP address) are not getting resolved in the corresponding InternalLbVm instance's haproxy.cfg file You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-9321 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1577.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1577 commit e44b988372b58fd75c35791121f5baf02add5eb3 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-04-13T15:08:50Z CLOUDSTACK-9321 : Multiple Internal LB rules (more than one Internal LB rule with same source IP address) are not getting resolved in the corresponding InternalLbVm instance's haproxy.cfg file commit 39b932b6b1117687957dc41cd56c8e83b5a97541 Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-04-25T15:13:10Z Adding component tests for VPC Network functionality - Internal LB rules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 @swill, thanks, I appreciate the effort! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 @swill, great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 Yes, that's what I was thinking, in my development setup (```mvn -pl :cloud-client-ui jetty:run```) it's working fine as well. But on our real test setups (```service cloudstack-management start```), it's failing with the issue described. There are other ways we can fix this, but then we have to rethink the whole DB connection pooling :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 @swill, that's what I was afraid of. Are you running ACS as a service, or just running it like a development setup (through jetty)? Since that makes a huge difference. And yes, we are unable to start up ACS 4.9.0 because of this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574#issuecomment-222654633 @rhtyd, thanks for your quick review, handled your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574#issuecomment-222642902 @rhtyd, @DaanHoogland, @swill, pinging you guys for an update regarding the Tomcat start up issue. This is related to #1553. I've also updated this in the mailing thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1574 Make sure that the DB drivers are loaded before creating connections You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack mysql_driver_issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1574 commit e147c0f46883852a7b422d64cce90f42bae1a480 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-05-31T09:42:18Z Make sure that the DB drivers are loaded before creating connections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221891214 @remibergsma, sounds fair. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221791953 @remibergsma, I understand your concern regarding the wait_until method. Perhaps we could use the wait_until with a 2s interval and a max wait of 4s? That's 1 retry only. That means that the max wait time has been drastically reduced from 15s to 4s, but you have that extra window of 2s for potential hiccups to happen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-221222391 @koushik-das, thanks for the review. Yes, all our model objects in the Nuage VSP library are Serializable :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-221212242 @GabrielBrascher, @abhinandanprateek, resolved / commented on your notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64350508
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long
routerId, final long guestNe
sc.setParameters("states", State.Stopped);
return listBy(sc);
}
+
+@Override
+public List listIncludingRemovedByVpcId(long vpcId) {
+SearchCriteria sc = VpcSearch.create();
--- End diff --
These are not column names, these are the names that are given inside that
VpcSearch object. This is how it's done in all DAOs :)
```java
VpcSearch = createSearchBuilder();
VpcSearch.and("role", VpcSearch.entity().getRole(), Op.EQ);
VpcSearch.and("vpcId", VpcSearch.entity().getVpcId(), Op.EQ);
VpcSearch.done();
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229436
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
---
@@ -0,0 +1,370 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.util;
+
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.VlanDao;
+import com.cloud.domain.Domain;
+import com.cloud.domain.DomainVO;
+import com.cloud.domain.dao.DomainDao;
+import com.cloud.exception.InsufficientVirtualNetworkCapacityException;
+import com.cloud.network.Network;
+import com.cloud.network.NetworkModel;
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.dao.NetworkDetailsDao;
+import com.cloud.network.rules.FirewallRule;
+import com.cloud.network.vpc.NetworkACLItem;
+import com.cloud.network.vpc.VpcVO;
+import com.cloud.network.vpc.dao.VpcDao;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
+import com.cloud.offerings.dao.NetworkOfferingServiceMapDao;
+import com.cloud.user.AccountVO;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.net.NetUtils;
+import com.cloud.vm.NicProfile;
+import com.cloud.vm.NicVO;
+import com.cloud.vm.VirtualMachine;
+import com.google.common.collect.Iterables;
+import com.google.common.collect.Lists;
+import net.nuage.vsp.acs.client.api.model.VspAclRule;
+import net.nuage.vsp.acs.client.api.model.VspDomain;
+import net.nuage.vsp.acs.client.api.model.VspNetwork;
+import net.nuage.vsp.acs.client.api.model.VspNic;
+import net.nuage.vsp.acs.client.api.model.VspStaticNat;
+import net.nuage.vsp.acs.client.api.model.VspVm;
+import net.nuage.vsp.acs.client.common.model.Pair;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.commons.lang.StringUtils;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
+import java.util.TreeSet;
+
+public class NuageVspEntityBuilder {
+private static final Logger s_logger =
Logger.getLogger(NuageVspEntityBuilder.class);
+
+@Inject
+VpcDao _vpcDao;
+@Inject
+DomainDao _domainDao;
+@Inject
+AccountDao _accountDao;
+@Inject
+NetworkOfferingDao _networkOfferingDao;
+@Inject
+NetworkOfferingServiceMapDao _networkOfferingServiceMapDao;
+@Inject
+NetworkModel _networkModel;
+@Inject
+VlanDao _vlanDao;
+@Inject
+ConfigurationDao _configurationDao;
+@Inject
+IPAddressDao _ipAddressDao;
+@Inject
+NetworkDetailsDao _networkDetailsDao;
--- End diff --
They're protected since they are being filled by the test classes as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229325
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -270,15 +258,15 @@ public PingCommand getCurrentStatus(long id) {
_shouldAudit = true;
return null;
}
-if (_cmsUserInfo == null || _cmsUserInfo.length < 2) {
+if (_cmsUserLogin == null || _cmsUserLogin.isEmpty() ||
_cmsUserPassword == null || _cmsUserPassword.isEmpty()) {
--- End diff --
Used Strings.isNullOrEmpty since we were using that within that class
already
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220986821 Changed db.x.path to db.x.driver as @DaanHoogland suggested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1553#discussion_r64223798 --- Diff: engine/storage/snapshot/test/resources/db.properties --- @@ -46,6 +47,8 @@ db.cloud.url.params=prepStmtCacheSize=517=true db.usage.username=cloud db.usage.password=cloud db.usage.host=localhost +# It's not guaranteed that using a different DB provider than the one from the regular cloud DB will work --- End diff -- Yeah, it should work, it's just a matter of using a different driver, but unfortunately I'm not able to test such a setup :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220974849 @DaanHoogland, I've added the piece we were talking about, this can be found it the logs regarding loading the driver dynamically : > 2016-05-23 05:42:57,880 DEBUG [c.c.u.d.T.Transaction] (localhost-startStop-1:null) (logid:) Successfully loaded DB driver com.mysql.jdbc.Driver for connection jdbc:mysql://localhost:3306/cloud?autoReconnect=true=517 ePrepStmts=true > 2016-05-23 05:42:57,896 DEBUG [c.c.u.d.T.Transaction] (localhost-startStop-1:null) (logid:) Successfully loaded DB driver com.mysql.jdbc.Driver for connection jdbc:mysql://localhost:3306/cloud_usage?autoReconnect=true& > 2016-05-23 05:42:57,898 DEBUG [c.c.u.d.T.Transaction] (localhost-startStop-1:null) (logid:) Successfully loaded DB driver com.mysql.jdbc.Driver for connection jdbc:mysql://localhost:3306/simulator?autoReconnect=true --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64195563
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
if (dbProps.size() == 0)
return;
+try {
+// Explicitely load JDBC driver because it has been
removed from the classpath as part of commit
c22659d76d73f00f41c13776c490e17a50aacd20
+Class.forName("com.mysql.jdbc.Driver");
--- End diff --
Sure thing, I'll add it to this PR once ready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64191953
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
if (dbProps.size() == 0)
return;
+try {
+// Explicitely load JDBC driver because it has been
removed from the classpath as part of commit
c22659d76d73f00f41c13776c490e17a50aacd20
+Class.forName("com.mysql.jdbc.Driver");
--- End diff --
Yes, that can be changed to make use of a property value, shall I
incorporate that change into this PR as well? :)
A property called : "db.x.type" e.g. db.cloud.type=mysql /
db.cloud.type=mariadb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64178488
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
if (dbProps.size() == 0)
return;
+try {
+// Explicitely load JDBC driver because it has been
removed from the classpath as part of commit
c22659d76d73f00f41c13776c490e17a50aacd20
+Class.forName("com.mysql.jdbc.Driver");
--- End diff --
1. You are absolutely right, but I explicitly loaded this one because
"mysql:jdbc" is hardcoded in the connection URL as well.
2. The problem is that the JAR is actually loaded (so Class.forName works),
but the JDBC driver is not auto-registering itself. Tomcat has a really
specific way of auto-registering its JDBC drivers..
https://tomcat.apache.org/tomcat-7.0-doc/jndi-datasource-examples-howto.html#DriverManager,_the_service_provider_mechanism_and_memory_leaks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220599141 @DaanHoogland, triggering you for review as well, this is only a small code change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220546975 @swill, @rhtyd, @kiwiflyer, triggering you guys because you were part of this mailing thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1553 Explicitely load JDBC driver before creating our MySQL connections Solution to the mailing thread titled "MySQL : No suitable driver found for jdbc:mysql". It doesn't harm that we explicitely load the MySQL driver, and for those which would use a commons-dbcp version < 1.4 this would fix it as well. Since JDBC 4.0, the JDBC driver can auto-register itself, but for some weird cases (like mine), it's not working. Therefore we need to explicitly load the JDBC driver. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack mysql_driver_issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1553.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1553 commit 492c7f2612fdc022d78cd1064ca81e47eb201c04 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-05-20T08:20:48Z Explicitely load JDBC driver before creating our MySQL connections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220019415 @remibergsma, @DaanHoogland, @swill, I've added an update to this PR. We're stepping away from the no-redist model :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-219706255 Great, thanks @swill! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-217875751 @SudharmaJain, I've added a few comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503852
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1588,6 +1588,16 @@ protected StringBuilder
createGuestBootLoadArgs(final NicProfile guestNic, final
return buf;
}
+/**
+ * Return a string representing network Cidr for the specifeid network
+ * @param guestNetwork
+ * @return valid network Cidr for the specified network
+ */
+protected String getValidNetworkCidr(Network guestNetwork){
--- End diff --
I think you should extract this method to another common class (e.g.
NetworkModel) since this method can be reused over the different classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503776
--- Diff: server/src/com/cloud/network/guru/GuestNetworkGuru.java ---
@@ -396,6 +396,16 @@ public NicProfile allocate(final Network network,
NicProfile nic, final VirtualM
return nic;
}
+/**
+ * Return a string representing network Cidr for the specifeid network
+ * @param guestNetwork
+ * @return valid network Cidr for the specified network
+ */
+protected String getValidNetworkCidr(Network guestNetwork){
--- End diff --
I think you should extract this method to another common class (e.g.
NetworkModel) since this method can be reused over the different classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503830
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -755,6 +755,16 @@ protected HypervisorType
getClusterToStartDomainRouterForOvm(final long podId) {
return networks;
}
+/**
+ * Return a string representing network Cidr for the specifeid network
+ * @param guestNetwork
+ * @return valid network Cidr for the specified network
+ */
+protected String getValidNetworkCidr(Network guestNetwork){
--- End diff --
I think you should extract this method to another common class (e.g.
NetworkModel) since this method can be reused over the different classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-217858039 @DaanHoogland, the file has been renamed to make use of the python naming standards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-217791958 @DaanHoogland, @alexandrelimassantana, could you review the PR once again please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-216763100 @jburwell, I think that would be a nice solution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-216524904 @remibergsma, down from 15 to 2 seconds is pretty big in terms of computing time. Is there an internal retry in CS might this script give a timeout? I think this is a good change though, waiting 15 seconds on something to come up is really long. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Set default networkDomain to empty instea...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216513556 According to the explanation of @remibergsma, and the code changes : LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed Unused Void Class
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1440#issuecomment-216511879 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-216476619 Fixed issues with the added multi-zone support to "nuageTestCase.py" and "test_nuage_vpc_network_multizone" testcase in "test_nuage_vpc_network.py": Test basic VPC Network functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS === ok Test basic VPC Network functionality with Nuage VSP SDN plugin on multiple zones ... === TestName: test_nuage_vpc_network_multizone | Status : SUCCESS === ok Ran 2 tests in 711.604s OK PyFlakes and PEP8 compliance: $ pyflakes test/integration/plugins/nuagevsp/.py $ $ $ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py $ $ Test Run: $ nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/ Test Restults: Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS === ok Test Nuage VSP VPC Offering with different combinations of LB service providers ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS === ok Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS === ok Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality by performing (wget) traffic tests within a VPC ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with different LB algorithms by performing (wget) traffic tests ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with restarts of VPC network components by performing (wget) ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with InternalLbVm appliance operations by performing (wget) ... === TestName: test_08_nuage_internallb_appliance_operations_traffic | Status : SUCCESS === ok Test basic VPC Network functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS === ok Test basic VPC Network functionality with Nuage VSP SDN plugin on multiple zones ... === TestName: test_nuage_vpc_network_multizone | Status : SUCCESS === ok Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS === ok Ran 12 tests in 9242.442s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216462358 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-216208745 @rhtyd, rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216208431 @alexandrelimassantana, you're right, I've splitted up the 3 different test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216130431 @cristofolini, @alexandrelimassantana, I've extracted the internal loop logic to a separate method and I've added a unit test for this behavior. This logic couldn't be implemented in the Nic class itself since this just a model class and shouldn't contain any logic :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-215421778 @DaanHoogland, you already have a UserData test script, do you want us to add this test to the same script, or create a new one for it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-215336954 @DaanHoogland, @remibergsma, @swill, @jburwell, these are rather small changes, if any of you could review, that would be great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1523 CLOUDSTACK-9365 : updateVirtualMachine with userdata should not error… … when a VM is attached to multiple networks from which one or more doesn't support userdata You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack bug/CLOUDSTACK-9365 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1523.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1523 commit 150738afbc7434f7a0c682af3610dbd8a5d1cdc2 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-04-28T06:21:33Z CLOUDSTACK-9365 : updateVirtualMachine with userdata should not error when a VM is attached to multiple networks from which one or more doesn't support userdata --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-209912550 @remibergsma, I've added description :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Master nuage
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1494 Master nuage You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack master_nuage Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1494.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1494 commit b738ab0e7a6039e0aec9658bab6a25acf645715f Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-03-02T12:53:47Z CLOUDSTACK-9242 : Remodel Nuage VSP plugin commit 1e98c86cf2f73a49f71443e68f37420c647645df Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-03-16T11:07:50Z CLOUDSTACK-9294 : Make sure to remove VR from VSD when removing the VPC --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-203794406 @pedro-martins, I do like it, but we didn't change that code, we just restructured it a bit so I didn't want to touch the original code, I can still make that change though, that's not an issue :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-202859071 @pedro-martins Updated the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168667533 @runseb, I've handled your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1187#discussion_r46935277 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java --- @@ -106,6 +104,8 @@ private void setupcheckVolumeFileForActivityFile(File file, long minSize) throws writer.write(chars); written += chars.length; } +long creationTime = System.currentTimeMillis(); --- End diff -- Not really, if you move it one line down, after writer.close(), the test could still give false positives because there could still be a hickup during writer.close() while the file has already been written. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1187 Adapted HypervisorUtilsTest to no longer give false positives You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack 4.6_test_improvement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1187.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1187 commit 132c35639bd581f3855b53e204c88ede0f75f20f Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2015-12-07T15:04:41Z Adapted HypervisorUtilsTest to no longer give false positives --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1187#issuecomment-162797756 @bhaisaab, @remibergsma, this is the ported commit for 4.6 described in PR#1185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1142#issuecomment-162523432 @DaanHoogland, below you can find a possible alternative for this test file. [HypervisorUtilsTestPatch.txt](https://github.com/apache/cloudstack/files/53965/HypervisorUtilsTestPatch.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1185 Adapted HypervisorUtilsTest to no longer give false positives You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack test_improvement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1185.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1185 commit 994ce15c743fc0dc277e089f6240b7c09caed219 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2015-12-07T15:04:41Z Adapted HypervisorUtilsTest to no longer give false positives --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1185#issuecomment-162551073 @bhaisaab, this is the PR for the test adaptation discussed in PR#1142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1142#issuecomment-162462731 @jburwell, thanks for the review! I've handled your comments. Thanks @bhaisaab, would be great if we can still get this in 4.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1142#issuecomment-162496553 @bhaisaab, we've looked into the code of that test, and the results are unreliable. The steps that are done in that test (along with the implementation of the called method) 1. Create file 2. Register start time 3. Loop until the diff between now and last modified or last accessed time is higher than a passed threshold (2000ms) 4. Register end time 5. Check if diff between start and end time is lower than passed threshold (2000ms) It's possible that between step 1 and 2, mostly on a loaded system, the thread that is running the test has to wait for available resources on your system. Therefore it's possible that step 3 returns immediately without looping. So, the end time will be really close to the start time, and will be below those 2000ms. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1142 CLOUDSTACK-9095 : Hypervisor changes to support UserData for Nuage VSP You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack master_nuage Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1142 commit 35d5a2b042ebd8437411773e94da5858f7d3fb8c Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2015-11-30T10:32:38Z CLOUDSTACK-9095 : Hypervisor changes to support UserData for Nuage VSP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-159894668 @DaanHoogland, @remibergsma, can this be merged in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-159642930 @rafaelweingartner, implemented the test cases as suggested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-159629890 @rafaelweingartner, I've added a test for those methods --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158381857
@DaanHoogland, how about the following piece of code then? In this case we
are using the getPrefferedCharset()
```java
public static String encodePasswordUtf8(String originalPassword) {
byte[] passwordBytes =
originalPassword.getBytes(StringUtils.getPreferredCharset());
byte[] encodedPasswordBytes = Base64.encodeBase64(passwordBytes);
return new String(encodedPasswordBytes,
StringUtils.getPreferredCharset());
}
public static String decodePasswordUtf8(String encodedPassword) {
byte[] encodedPasswordBytes =
encodedPassword.getBytes(StringUtils.getPreferredCharset());
byte[] passwordBytes = Base64.decodeBase64(encodedPasswordBytes);
return new String(passwordBytes, StringUtils.getPreferredCharset());
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-158375131 @DaanHoogland, @fmaximus was right about the encoding. I rewrote that part so we're always using the same encoding :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-158394211 @DaanHoogland 1. getBytesUtf8() and newStringUtf8() would no longer be used. 2. With this new code, we won't any longer be only dependent on UTF-8, but rather on the Charset returned by StringUtils.getPreferredCharset(). You can have a look at the newly pushed code :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-158026133 @DaanHoogland, this PR contains the fixes for the build-master-slowbuild --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1092 Fix NuageVsp errors for build-master-slowbuild You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1092.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1092 commit 59deffcff7d9f2e0064cb86b68bb1be467416a6f Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2015-11-19T11:11:59Z Fix NuageVsp errors for build-master-slowbuild --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-157683273 Awesome! Thanks @jburwell for the thorough review, thanks @remibergsma for merging it in, thanks to all who helped getting this PR in! Much appreciated! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-157371668 Thanks @remibergsma, much appreciated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43090521
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -129,6 +145,18 @@
AgentManager _agentMgr;
@Inject
NetworkOfferingDao _ntwkOfferingDao;
+@Inject
+ConfigurationDao _configDao;
+@Inject
+NuageVspManager _nuageVspManager;
+@Inject
+FirewallRulesDao _firewallRulesDao;
+@Inject
+FirewallRulesCidrsDao _firewallRulesCidrsDao;
+@Inject
+PhysicalNetworkDao _physicalNetworkDao;
+@Inject
+NetworkACLItemDao _networkACLItemDao;
@Override
public boolean applyIps(Network network, List ipAddress, Set service) throws
ResourceUnavailableException {
--- End diff --
I moved some code here and there, it's shortened now by decomposing into
smaller private methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091274
--- Diff: plugins/network-elements/nuage-vsp/pom.xml ---
@@ -28,6 +28,13 @@
4.6.0-SNAPSHOT
../../pom.xml
+
+
+ org.apache.commons
+ commons-lang3
+ ${cs.lang3.version}
+
+
--- End diff --
Because our client has no dependencies to CloudStack, we had to find a
common library between the 2 which has a Pair class. Which is
commons-lang3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093202
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean isDomainRouter() {
return _isDomainRouter;
}
-public String _getDomainRouterIp() {
+public String getDomainRouterIp() {
return _domainRouterIp;
}
-public String _getVmInstanceName() {
+public String getVmInstanceName() {
return _vmInstanceName;
}
-public String _getVmUuid() {
+public String getVmUuid() {
return _vmUuid;
}
-public String _getVmUserName() {
+public String getVmUserName() {
return _vmUserName;
}
-public String _getVmUserDomainName() {
+public String getVmUserDomainName() {
return _vmUserDomainName;
}
+public boolean useStaticIp() {
+return _useStaticIp;
+}
+
+public String getStaticIp() {
+return _staticIp;
+}
+
+public String getStaticNatIpUuid() {
+return _staticNatIpUuid;
+}
+
+public String getStaticNatIpAddress() {
+return _staticNatIpAddress;
+}
+
+public boolean isStaticNatIpAllocated() {
+return _isStaticNatIpAllocated;
+}
+
+public boolean isOneToOneNat() {
+return _isOneToOneNat;
+}
+
+public String getStaticNatVlanUuid() {
+return _staticNatVlanUuid;
+}
+
+public String getStaticNatVlanGateway() {
+return _staticNatVlanGateway;
+}
+
+public String getStaticNatVlanNetmask() {
+return _staticNatVlanNetmask;
+}
+
+public static class Builder implements
CmdBuilder {
+private String _nicUuid;
+private String _nicMacAddress;
+private String _networkUuid;
+private boolean _isL3Network;
+private boolean _isSharedNetwork;
+private String _vpcUuid;
+private String _networkDomainUuid;
+private String _networksAccountUuid;
+private boolean _isDomainRouter;
+private String _domainRouterIp;
+private String _vmInstanceName;
+private String _vmUuid;
+private String _vmUserName;
+private String _vmUserDomainName;
+private boolean _useStaticIp;
+private String _staticIp;
+private String _staticNatIpUuid;
+private String _staticNatIpAddress;
+private boolean _isStaticNatIpAllocated;
+private boolean _isOneToOneNat;
+private String _staticNatVlanUuid;
+private String _staticNatVlanGateway;
+private String _staticNatVlanNetmask;
+
+public Builder nicUuid(String nicUuid) {
+this._nicUuid = nicUuid;
+return this;
+}
+
+public Builder nicMacAddress(String nicMacAddress) {
+this._nicMacAddress = nicMacAddress;
+return this;
+}
+
+public Builder networkUuid(String networkUuid) {
+this._networkUuid = networkUuid;
+return this;
+}
+
+public Builder isL3Network(boolean isL3Network) {
+this._isL3Network = isL3Network;
+return this;
+}
+
+public Builder isSharedNetwork(boolean isSharedNetwork) {
+this._isSharedNetwork = isSharedNetwork;
+return this;
+}
+
+public Builder vpcUuid(String vpcUuid) {
+this._vpcUuid = vpcUuid;
+return this;
+}
+
+public Builder networkDomainUuid(String networkDomainUuid) {
+this._networkDomainUuid = networkDomainUuid;
+return this;
+}
+
+public Builder networksAccountUuid(String networksAccountUuid) {
+this._networksAccountUuid = networksAccountUuid;
+return this;
+}
+
+public Builder isDomainRouter(boolean isDomainRouter) {
+this._isDomainRouter = isDomainRouter;
+return this;
+}
+
+public Builder domainRouterIp(String domainRouterIp) {
+this._domainRouterIp = domainRouterIp;
+return this;
+}
+
+public Builder vmInstanceName(String vmInstanceName) {
+this._vmInstanceName = vmInstanceName;
+return this;
+}
+
+public Builder
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093132
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid() {
return _vmUuid;
}
+public boolean isExpungingState() {
+return _isExpungingState;
+}
+
+public static class Builder implements
CmdBuilder {
+private String _networkUuid;
+private String _nicFromDdUuid;
+private String _nicMacAddress;
+private String _nicIp4Address;
+private boolean _isL3Network;
+private boolean _isSharedNetwork;
+private String _vpcUuid;
+private String _networksDomainUuid;
+private String _vmInstanceName;
+private String _vmUuid;
+private boolean _isExpungingState;
+
+public Builder networkUuid(String networkUuid) {
+this._networkUuid = networkUuid;
+return this;
+}
+
+public Builder nicFromDbUuid(String nicFromDbUuid) {
+this._nicFromDdUuid = nicFromDbUuid;
+return this;
+}
+
+public Builder nicMacAddress(String nicMacAddress) {
+this._nicMacAddress = nicMacAddress;
+return this;
+}
+
+public Builder nicIp4Address(String nicIp4Address) {
+this._nicIp4Address = nicIp4Address;
+return this;
+}
+
+public Builder isL3Network(boolean isL3Network) {
+this._isL3Network = isL3Network;
+return this;
+}
+
+public Builder isSharedNetwork(boolean isSharedNetwork) {
+this._isSharedNetwork = isSharedNetwork;
+return this;
+}
+
+public Builder vpcUuid(String vpcUuid) {
+this._vpcUuid = vpcUuid;
+return this;
+}
+
+public Builder networksDomainUuid(String networksDomainUuid) {
+this._networksDomainUuid = networksDomainUuid;
+return this;
+}
+
+public Builder vmInstanceName(String vmInstanceName) {
+this._vmInstanceName = vmInstanceName;
+return this;
+}
+
+public Builder vmUuid(String vmUuid) {
+this._vmUuid = vmUuid;
+return this;
+}
+
+public Builder isExpungingState(boolean isExpungingState) {
+this._isExpungingState = isExpungingState;
+return this;
+}
+
+@Override
+public DeallocateVmVspCommand build() {
+return new DeallocateVmVspCommand(_networkUuid,_nicFromDdUuid,
_nicMacAddress, _nicIp4Address, _isL3Network, _isSharedNetwork, _vpcUuid,
+_networksDomainUuid, _vmInstanceName, _vmUuid,
_isExpungingState);
+}
+}
+
@Override
public boolean executeInSequence() {
return false;
}
+@Override
+public boolean equals(Object o) {
--- End diff --
Implemented equals method for the Command super
class, calling it from subclass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093227
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network() {
return _isL3Network;
}
+public boolean isSharedNetwork() {
+return _isSharedNetwork;
+}
+
public String getVpcUuid() {
return _vpcUuid;
}
+public String getDomainTemplateName() {
+return _domainTemplateName;
+}
+
+public static class Builder implements
CmdBuilder {
+private String _domainUuid;
+private String _networkUuid;
+private boolean _isL3Network;
+private boolean _isSharedNetwork;
+private String _vpcUuid;
+private String _domainTemplateName;
+
+public Builder domainUuid(String domainUuid) {
+this._domainUuid = domainUuid;
+return this;
+}
+
+public Builder networkUuid(String networkUuid) {
+this._networkUuid = networkUuid;
+return this;
+}
+
+public Builder isL3Network(boolean isL3Network) {
+this._isL3Network = isL3Network;
+return this;
+}
+
+public Builder isSharedNetwork(boolean isSharedNetwork) {
+this._isSharedNetwork = isSharedNetwork;
+return this;
+}
+
+public Builder vpcUuid(String vpcUuid) {
+this._vpcUuid = vpcUuid;
+return this;
+}
+
+public Builder domainTemplateName(String domainTemplateName) {
+this._domainTemplateName = domainTemplateName;
+return this;
+}
+
+@Override
+public TrashNetworkVspCommand build() {
+return new TrashNetworkVspCommand(_domainUuid, _networkUuid,
_isL3Network, _isSharedNetwork, _vpcUuid, _domainTemplateName);
+}
+}
+
@Override
public boolean executeInSequence() {
return false;
}
+@Override
+public boolean equals(Object o) {
+if (this == o) return true;
+if (o == null || getClass() != o.getClass()) return false;
+
+TrashNetworkVspCommand that = (TrashNetworkVspCommand) o;
+
+if (_isL3Network != that._isL3Network) return false;
+if (_isSharedNetwork != that._isSharedNetwork) return false;
+if (_domainTemplateName != null ?
!_domainTemplateName.equals(that._domainTemplateName) :
that._domainTemplateName != null)
+return false;
+if (_domainUuid != null ? !_domainUuid.equals(that._domainUuid) :
that._domainUuid != null) return false;
+if (_networkUuid != null ? !_networkUuid.equals(that._networkUuid)
: that._networkUuid != null) return false;
+if (_vpcUuid != null ? !_vpcUuid.equals(that._vpcUuid) :
that._vpcUuid != null) return false;
+
+return true;
+}
+
+@Override
+public int hashCode() {
--- End diff --
Implemented hashCode method for the Command super
class, calling it from subclass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093875
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +414,17 @@ protected boolean canHandle(Network network, Service
service) {
}
if (!_networkModel.isProviderForNetwork(getProvider(),
network.getId())) {
-s_logger.debug("NuageElement is not a provider for network " +
network.getDisplayText());
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("NuageVsp is not a provider for network " +
network.getDisplayText());
--- End diff --
This code is just checking whether NuageVsp is included as provider for the
given network, no need for specific information about the Nuage VSP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091431
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -67,25 +74,76 @@
import com.cloud.network.dao.PhysicalNetworkVO;
import com.cloud.network.resource.NuageVspResource;
import com.cloud.network.sync.NuageVspSync;
+import com.cloud.network.vpc.VpcManager;
+import com.cloud.network.vpc.VpcOffering;
+import com.cloud.network.vpc.VpcOfferingServiceMapVO;
+import com.cloud.network.vpc.VpcOfferingVO;
import com.cloud.network.vpc.dao.VpcDao;
import com.cloud.network.vpc.dao.VpcOfferingDao;
import com.cloud.network.vpc.dao.VpcOfferingServiceMapDao;
+import com.cloud.network.vpc.dao.VpcServiceMapDao;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.offerings.NetworkOfferingServiceMapVO;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
+import com.cloud.offerings.dao.NetworkOfferingServiceMapDao;
import com.cloud.resource.ResourceManager;
import com.cloud.resource.ResourceState;
import com.cloud.resource.ServerResource;
+import com.cloud.user.AccountManager;
+import com.cloud.user.DomainManager;
import com.cloud.utils.component.ManagerBase;
+import com.cloud.utils.db.DB;
import com.cloud.utils.db.Transaction;
import com.cloud.utils.db.TransactionCallback;
+import com.cloud.utils.db.TransactionCallbackNoReturn;
import com.cloud.utils.db.TransactionStatus;
import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.fsm.StateListener;
+import com.cloud.utils.fsm.StateMachine2;
+import com.google.common.base.MoreObjects;
+import com.google.common.base.Strings;
+import com.google.common.collect.Maps;
+import com.google.common.collect.Sets;
+import net.nuage.vsp.acs.NuageVspPluginClientLoader;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.framework.config.impl.ConfigurationVO;
+import org.apache.cloudstack.framework.messagebus.MessageBus;
+import org.apache.cloudstack.framework.messagebus.MessageSubscriber;
+import org.apache.cloudstack.network.ExternalNetworkDeviceManager;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.log4j.Logger;
+
+import javax.ejb.Local;
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.StringTokenizer;
+import java.util.UUID;
+import java.util.concurrent.ScheduledExecutorService;
+
+import static com.cloud.agent.api.sync.SyncNuageVspCmsIdCommand.SyncType;
@Local(value = {NuageVspManager.class})
-public class NuageVspManagerImpl extends ManagerBase implements
NuageVspManager, Configurable {
+public class NuageVspManagerImpl extends ManagerBase implements
NuageVspManager, Configurable, StateListener<Status, Status.Event, Host> {
private static final Logger s_logger =
Logger.getLogger(NuageVspManagerImpl.class);
private static final int ONE_MINUTE_MULTIPLIER = 60 * 1000;
+private static final Set NUAGE_VSP_PROVIDERS;
+private static final Map<Network.Service, Set>
NUAGE_VSP_VPC_SERVICE_MAP;
+private static final ConfigKey[] NUAGE_VSP_CONFIG_KEYS = new
ConfigKey[] { NuageVspConfigDns, NuageVspDnsExternal, NuageVspConfigGateway,
--- End diff --
Returning a copy of the array instead of the array itself now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091944
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License.
//
-package com.cloud.agent.api.element;
+package com.cloud.agent.api;
-import com.cloud.agent.api.Answer;
+import com.cloud.host.Host;
-public class ShutDownVpcVspAnswer extends Answer {
+public class PingNuageVspCommand extends PingCommand {
-public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, boolean
success, String details) {
-super(cmd, success, details);
+private final boolean shouldAudit;
+
+public PingNuageVspCommand(Host.Type type, long id, boolean
shouldAudit) {
+super(type, id);
+this.shouldAudit = shouldAudit;
}
-public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, Exception e) {
-super(cmd, e);
+public boolean shouldAudit() {
+return shouldAudit;
}
+@Override
+public boolean equals(Object o) {
--- End diff --
Added attributes from the PingCommand super class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091957
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License.
//
-package com.cloud.agent.api.element;
+package com.cloud.agent.api;
-import com.cloud.agent.api.Answer;
+import com.cloud.host.Host;
-public class ShutDownVpcVspAnswer extends Answer {
+public class PingNuageVspCommand extends PingCommand {
-public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, boolean
success, String details) {
-super(cmd, success, details);
+private final boolean shouldAudit;
+
+public PingNuageVspCommand(Host.Type type, long id, boolean
shouldAudit) {
+super(type, id);
+this.shouldAudit = shouldAudit;
}
-public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, Exception e) {
-super(cmd, e);
+public boolean shouldAudit() {
+return shouldAudit;
}
+@Override
+public boolean equals(Object o) {
+if (this == o) return true;
+if (o == null || getClass() != o.getClass()) return false;
+
+PingNuageVspCommand that = (PingNuageVspCommand) o;
+
+if (shouldAudit != that.shouldAudit) return false;
+
+return true;
+}
+
+@Override
+public int hashCode() {
--- End diff --
Added attributes from the PingCommand super class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092995
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean executeInSequence() {
return false;
}
+@Override
+public boolean equals(Object o) {
+if (this == o) return true;
+if (o == null || getClass() != o.getClass()) return false;
+
+ApplyAclRuleVspCommand that = (ApplyAclRuleVspCommand) o;
+
+if (_egressDefaultPolicy != that._egressDefaultPolicy) return
false;
+if (_isL2Network != that._isL2Network) return false;
+if (_networkAcl != that._networkAcl) return false;
+if (_networkId != that._networkId) return false;
+if (_networkReset != that._networkReset) return false;
+if (_aclRules != null ? !_aclRules.equals(that._aclRules) :
that._aclRules != null) return false;
+if (_acsIngressAcl != null ?
!_acsIngressAcl.equals(that._acsIngressAcl) : that._acsIngressAcl != null)
+return false;
+if (_domainTemplateName != null ?
!_domainTemplateName.equals(that._domainTemplateName) :
that._domainTemplateName != null)
+return false;
+if (_networkDomainUuid != null ?
!_networkDomainUuid.equals(that._networkDomainUuid) : that._networkDomainUuid
!= null)
+return false;
+if (_networkName != null ? !_networkName.equals(that._networkName)
: that._networkName != null) return false;
+if (_networkUuid != null ? !_networkUuid.equals(that._networkUuid)
: that._networkUuid != null) return false;
+if (_vpcOrSubnetUuid != null ?
!_vpcOrSubnetUuid.equals(that._vpcOrSubnetUuid) : that._vpcOrSubnetUuid != null)
+return false;
+
+return true;
+}
+
+@Override
+public int hashCode() {
--- End diff --
Implemented hashCode method for the Command super
class, calling it from subclass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093020
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
@@ -51,13 +61,91 @@ public boolean isL3Network() {
return _isL3Network;
}
+public boolean isVpc() {
+return _isVpc;
+}
+
public List<Map<String, Object>> getStaticNatDetails() {
return _staticNatDetails;
}
+public static class Builder implements
CmdBuilder {
+private String _networkDomainUuid;
+private String _networkUuid;
+private String _vpcOrSubnetUuid;
+private boolean _isL3Network;
+private boolean _isVpc;
+private List<Map<String, Object>> _staticNatDetails;
+
+public Builder networkDomainUuid(String networkDomainUuid) {
+this._networkDomainUuid = networkDomainUuid;
+return this;
+}
+
+public Builder networkUuid(String networkUuid) {
+this._networkUuid = networkUuid;
+return this;
+}
+
+public Builder vpcOrSubnetUuid(String vpcOrSubnetUuid) {
+this._vpcOrSubnetUuid = vpcOrSubnetUuid;
+return this;
+}
+
+public Builder isL3Network(boolean isL3Network) {
+this._isL3Network = isL3Network;
+return this;
+}
+
+public Builder isVpc(boolean isVpc) {
+this._isVpc = isVpc;
+return this;
+}
+
+public Builder staticNatDetails(List<Map<String, Object>>
staticNatDetails) {
+this._staticNatDetails = staticNatDetails;
+return this;
+}
+
+@Override
+public ApplyStaticNatVspCommand build() {
+return new ApplyStaticNatVspCommand(_networkDomainUuid,
_networkUuid, _vpcOrSubnetUuid, _isL3Network, _isVpc, _staticNatDetails);
+}
+}
+
@Override
public boolean executeInSequence() {
return false;
}
+@Override
+public boolean equals(Object o) {
+if (this == o) return true;
+if (o == null || getClass() != o.getClass()) return false;
+
+ApplyStaticNatVspCommand that = (ApplyStaticNatVspCommand) o;
+
+if (_isL3Network != that._isL3Network) return false;
+if (_isVpc != that._isVpc) return false;
+if (_networkDomainUuid != null ?
!_networkDomainUuid.equals(that._networkDomainUuid) : that._networkDomainUuid
!= null)
+return false;
+if (_networkUuid != null ? !_networkUuid.equals(that._networkUuid)
: that._networkUuid != null) return false;
+if (_staticNatDetails != null ?
!_staticNatDetails.equals(that._staticNatDetails) : that._staticNatDetails !=
null)
+return false;
+if (_vpcOrSubnetUuid != null ?
!_vpcOrSubnetUuid.equals(that._vpcOrSubnetUuid) : that._vpcOrSubnetUuid != null)
+return false;
+
+return true;
+}
+
+@Override
+public int hashCode() {
--- End diff --
Implemented hashCode method for the Command super
class, calling it from subclass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092964
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean executeInSequence() {
return false;
}
+@Override
+public boolean equals(Object o) {
--- End diff --
Implemented equals method for the Command super
class, calling it from subclass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093192
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean isDomainRouter() {
return _isDomainRouter;
}
-public String _getDomainRouterIp() {
+public String getDomainRouterIp() {
return _domainRouterIp;
}
-public String _getVmInstanceName() {
+public String getVmInstanceName() {
return _vmInstanceName;
}
-public String _getVmUuid() {
+public String getVmUuid() {
return _vmUuid;
}
-public String _getVmUserName() {
+public String getVmUserName() {
return _vmUserName;
}
-public String _getVmUserDomainName() {
+public String getVmUserDomainName() {
return _vmUserDomainName;
}
+public boolean useStaticIp() {
+return _useStaticIp;
+}
+
+public String getStaticIp() {
+return _staticIp;
+}
+
+public String getStaticNatIpUuid() {
+return _staticNatIpUuid;
+}
+
+public String getStaticNatIpAddress() {
+return _staticNatIpAddress;
+}
+
+public boolean isStaticNatIpAllocated() {
+return _isStaticNatIpAllocated;
+}
+
+public boolean isOneToOneNat() {
+return _isOneToOneNat;
+}
+
+public String getStaticNatVlanUuid() {
+return _staticNatVlanUuid;
+}
+
+public String getStaticNatVlanGateway() {
+return _staticNatVlanGateway;
+}
+
+public String getStaticNatVlanNetmask() {
+return _staticNatVlanNetmask;
+}
+
+public static class Builder implements
CmdBuilder {
+private String _nicUuid;
+private String _nicMacAddress;
+private String _networkUuid;
+private boolean _isL3Network;
+private boolean _isSharedNetwork;
+private String _vpcUuid;
+private String _networkDomainUuid;
+private String _networksAccountUuid;
+private boolean _isDomainRouter;
+private String _domainRouterIp;
+private String _vmInstanceName;
+private String _vmUuid;
+private String _vmUserName;
+private String _vmUserDomainName;
+private boolean _useStaticIp;
+private String _staticIp;
+private String _staticNatIpUuid;
+private String _staticNatIpAddress;
+private boolean _isStaticNatIpAllocated;
+private boolean _isOneToOneNat;
+private String _staticNatVlanUuid;
+private String _staticNatVlanGateway;
+private String _staticNatVlanNetmask;
+
+public Builder nicUuid(String nicUuid) {
+this._nicUuid = nicUuid;
+return this;
+}
+
+public Builder nicMacAddress(String nicMacAddress) {
+this._nicMacAddress = nicMacAddress;
+return this;
+}
+
+public Builder networkUuid(String networkUuid) {
+this._networkUuid = networkUuid;
+return this;
+}
+
+public Builder isL3Network(boolean isL3Network) {
+this._isL3Network = isL3Network;
+return this;
+}
+
+public Builder isSharedNetwork(boolean isSharedNetwork) {
+this._isSharedNetwork = isSharedNetwork;
+return this;
+}
+
+public Builder vpcUuid(String vpcUuid) {
+this._vpcUuid = vpcUuid;
+return this;
+}
+
+public Builder networkDomainUuid(String networkDomainUuid) {
+this._networkDomainUuid = networkDomainUuid;
+return this;
+}
+
+public Builder networksAccountUuid(String networksAccountUuid) {
+this._networksAccountUuid = networksAccountUuid;
+return this;
+}
+
+public Builder isDomainRouter(boolean isDomainRouter) {
+this._isDomainRouter = isDomainRouter;
+return this;
+}
+
+public Builder domainRouterIp(String domainRouterIp) {
+this._domainRouterIp = domainRouterIp;
+return this;
+}
+
+public Builder vmInstanceName(String vmInstanceName) {
+this._vmInstanceName = vmInstanceName;
+return this;
+}
+
+public Builder
[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093221
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network() {
return _isL3Network;
}
+public boolean isSharedNetwork() {
+return _isSharedNetwork;
+}
+
public String getVpcUuid() {
return _vpcUuid;
}
+public String getDomainTemplateName() {
+return _domainTemplateName;
+}
+
+public static class Builder implements
CmdBuilder {
+private String _domainUuid;
+private String _networkUuid;
+private boolean _isL3Network;
+private boolean _isSharedNetwork;
+private String _vpcUuid;
+private String _domainTemplateName;
+
+public Builder domainUuid(String domainUuid) {
+this._domainUuid = domainUuid;
+return this;
+}
+
+public Builder networkUuid(String networkUuid) {
+this._networkUuid = networkUuid;
+return this;
+}
+
+public Builder isL3Network(boolean isL3Network) {
+this._isL3Network = isL3Network;
+return this;
+}
+
+public Builder isSharedNetwork(boolean isSharedNetwork) {
+this._isSharedNetwork = isSharedNetwork;
+return this;
+}
+
+public Builder vpcUuid(String vpcUuid) {
+this._vpcUuid = vpcUuid;
+return this;
+}
+
+public Builder domainTemplateName(String domainTemplateName) {
+this._domainTemplateName = domainTemplateName;
+return this;
+}
+
+@Override
+public TrashNetworkVspCommand build() {
+return new TrashNetworkVspCommand(_domainUuid, _networkUuid,
_isL3Network, _isSharedNetwork, _vpcUuid, _domainTemplateName);
+}
+}
+
@Override
public boolean executeInSequence() {
return false;
}
+@Override
+public boolean equals(Object o) {
--- End diff --
Implemented equals method for the Command super
class, calling it from subclass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
