Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I think #2011 fixes the observed issue, but this PR improves the IP
ordering fix originally added to the strongswan pr. This implementation
ensures (again) that duplicate public ips
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov alright, this is ready for you to start testing. Can you
kick off CI on this as well?
I will be doing testing of this locally as well.
This implementation
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Thanks @remibergsma. I am going to use `source_nat` as it better
represents what it is I am trying to establish and it seems to always be in the
object where `first_i_p` does not always seem
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I am considering changing my implementation to be the same as the old
implementation (which removed the IP from the dbag in the initial loop of the
merge), but if `source_nat` is present
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Does anyone know what `first_i_p` represents in the `ips.json` dbag? I am
assuming it is the Source NAT IP, but I can't find it represented anywhere in
the code (other than in a test
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Ya, I am not sure where the problem is stemming from. The fact that my
code is not defensive around this problem is a problem. That is for sure. But
given my understanding of the moving parts
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
So... Looking at this with a different perspective. If there is a bug
elsewhere which would cause an IP to be duplicated in the `dbag`, the old
implementation would have cleaned up this bug
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
This `ips.json` file confuses the hell out of me. From what I can tell
both `eth2` and `eth3` both have the ip `10.1.35.83` twice for each (for a
total of the IP being configured 4 times over
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov I have a suspicion that the ip_association.json is a
transient file which may be short lived. I am not sure because I have not seen
it either, but it was the file being processed
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov we are still trying to understand how the IP was found when
looping through the `dbag` but it is not associated with the expected dev when
we try to update the index which
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
On the Jira ticket, Wei Zhou mentioned that this could potentially happen
if you have two different public IP ranges. So if you associate a public IP
which is in a different range than
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I have to admit, I am not sure how the IP was found when looping through
the list initially, but then when trying to update the index for the IP that
was found, it is not there. The only way I
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@ustcweizhou the `else` case did not change from the original code:
https://github.com/apache/cloudstack/pull/1741/files#diff-a7d6f7150cca74029f23c19b72ad0622L49
@karuturi I have updated
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack/pull/2003
fixed an issue if the dev is not in the databag
Defend against the specified dev not being in the databag.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
This has the required reviews and both @remibergsma (sbp) and us (cloud.ca)
have been using this fix in production.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1966
I can't see what branch this is opened against on my phone. What version of
ACS is this opened against and which version do you have a problem in. The
reason I ask is because #1741 was added
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
@rafaelweingartner the only change was to remove the extra gateway
verification if it was a 'guest' network because this is now handled by the
code in #1871.
```
+guest_gw
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
I have squash merged the changes that @ustcweizhou requested. Would you
mind reviewing again so we can get this important fix into 4.10. Thanks...
@rafaelweingartner, it looks like I
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1954
LGTM. This change makes the VPC router behave the same way as the Isolated
Guest Network router. eg:
https://github.com/myENA/cloudstack/blob/450deed8472c06c4fec88e045bef28091502c638/systemvm
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/35
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1907#discussion_r101062037
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
gw
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@deepthimachiraju remember that you need a new system vm built from this PR
for this functionality to work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
Beauty. Good job. Thanks for doing that. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1907#discussion_r100902927
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
gw
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
Yes, I think we are good to go to merge this change.
On Mon, Feb 13, 2017 at 1:45 PM, Rafael Weingärtner <
notificati...@github.com> wrote:
> I agree with you @swi
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
Yes @rafaelweingartner, that is also my concern. It **probably** would be
fine because the `.gitignore` would handle the problem cases with the merges (I
hope), but it would make it less
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/34#discussion_r100826211
--- Diff: content/about.html ---
@@ -79,7 +78,7 @@
Get
Involved
Developers
Mailing
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
So how would this work? We would have a `.gitignore` tracked in `master`
which would make the `content` folder untracked? The `.gitignore` tracked in
the `asf-site` branch would not include
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1938
@ustcweizhou I am not comfortable with that change. If more than one java
is installed and Java 8 is not the default, then this will incorrectly set
java_home (if I understand correctly
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1938
So the short answer is that I ran into this issue when I upgraded and since
`jenv` did not correctly set the `JAVA_HOME` directory, I ran into this, so I
don't have a deep understanding for all
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1938
@rhtyd, @wido, @nvazquez, @rafaelweingartner please review...
This fixes an issue with #1888.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack/pull/1938
CLOUDSTACK-9780: Fixed the default JAVA_HOME value to be Java8 if not set
Now that PR-1888 is merged, Java8 is required. Unfortunately, the file
pushed to `/etc/cloudstack/management
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
Here is another set of tests run to validate all the settings (in addition
to the normal tests
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@DaanHoogland: yes, I want it run in Trillian, but my understanding is that
manual steps need to be taken in the test setup for Trillian in order to first
build the SystemVM from this PR
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@DaanHoogland did you make the test run in Trillian install a SystemVM
built from this PR? If you didn't it won't actually be a valid test run...
---
If your project is set up for it, you can
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
Here is the CI run for this PR using my KVM Bubble environment. This CI
run is using a SystemVM built from this PR branch (required for a valid test)
and since we have not been able to do
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
### CI RESULTS
```
Tests Run: 87
Skipped: 1
Failed: 4
Errors: 0
Duration: 9h 13m 51s
```
**Summary of the problem(s):**
```
FAIL
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@DaanHoogland I don't think this will work. I think you have to manually
specify a SystemVM template built from this PR in order for the tests to work.
I don't think a SystemVM from this PR
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/34#discussion_r99876345
--- Diff: README.md ---
@@ -15,14 +15,42 @@ Build the site with:
To serve it locally:
$ middleman server
-
-IMPORTANT
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/34#discussion_r99876616
--- Diff: README.md ---
@@ -15,14 +15,42 @@ Build the site with:
To serve it locally:
$ middleman server
-
-IMPORTANT
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/34#discussion_r99875679
--- Diff: README.md ---
@@ -15,14 +15,42 @@ Build the site with:
To serve it locally:
$ middleman server
-
-IMPORTANT
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/34#discussion_r99877060
--- Diff: README.md ---
@@ -15,14 +15,42 @@ Build the site with:
To serve it locally:
$ middleman server
-
-IMPORTANT
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/34#discussion_r99876892
--- Diff: README.md ---
@@ -15,14 +15,42 @@ Build the site with:
To serve it locally:
$ middleman server
-
-IMPORTANT
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/34#discussion_r99876990
--- Diff: README.md ---
@@ -15,14 +15,42 @@ Build the site with:
To serve it locally:
$ middleman server
-
-IMPORTANT
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@borisstoyanov thanks. Yes, that explains why there are failures. When I
ran my tests, I did it with a system VM built from this PR:
https://github.com/apache/cloudstack/pull/1741#issuecomment
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
Unless you know how everything works behind the scene (which is like nobody
pretty much), then it can be hard to understand initially. I think this makes
it easier for more people
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
If you wouldn't mind, we might as well. We also need to document that the
upstream ASF repo is at `
https://git-wip-us.apache.org/repos/asf/cloudstack-www.git`. I don't think
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
Ya, thats basically where I think we have netted out to. The `site-asf`
branch which tracks the compiled content is served by the ASF (from somewhere).
If we push compiled content
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
Maybe we should be defaulting this file to Java 8 now???
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
I found the issue. `jenv` was not setting the `JAVA_HOME` correctly, so
the following logic in `/etc/cloudstack/management/classpath.conf` was getting
hit.
```
if ([ -z "$JAVA
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
@rhtyd I built the Java 8 version on a CentOS6 slave and I am trying to
install it on a CentOS 6.8 host and I am getting a similar issue.
The details are here:
https://lists.apache.org
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
OK. What would it be solving for? Just trying to understand because we
have to build the site locally anyway to check the changes and then we have to
push the changes (which currently
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
Right, so the site currently goes live with the ICLA commit, so why add
more steps (kinda).
We could remove the built content from the master branch though. I think
we could probably
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
So the flow would be:
- pull from github/asf
- make changes
- build locally to verify the changes, but the resulting markup is not
tracked (removed + ignored)
- push changes
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
Rebased against current master to try to fix new issues with tomcat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
I am curious. For the Trillian tests, is a new SystemVM being being built
with this PR and that system VM is being used for the test? This PR requires a
new system VM template, so
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
We can't merge into `apache/cloudstack-www`, that repo is read only and is
only updated when we push to the upstream ASF repo, so that is too late in the
process I think. Also, the build
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/34
Yes he should, I missed that. When you build it will update the html files,
but the markdown/rst should be updated.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/33
I fixed some malformed html that was causing the security page to render
incorrectly. I did not change any content in that commit, so I am going to
assume that a fix of that nature does
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/33#discussion_r98104217
--- Diff: source/index.html.erb ---
@@ -113,22 +113,23 @@ Join Us
- 2016 CloudStack Collaboration
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/33#discussion_r98102918
--- Diff: source/index.html.erb ---
@@ -113,22 +113,23 @@ Join Us
- 2016 CloudStack Collaboration
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/33
@pdion891 I updated the copyright date as you requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/33
You mean the Miami event? That is the one that is being done at apachecon.
I intentionally left it out so they would go to the CCC website to get
details since there are additional
Github user swill commented on the issue:
https://github.com/apache/cloudstack-www/pull/33
@pdion891 and @rhtyd you guys mind reviewing / approving these changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack-www/pull/33
Updated the 2017 conference details
Added Miami, removed the broken link for Brazil and referenced the correct
video playlist for the Montreal event.
You can merge this pull request
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
Thanks @PaulAngus. I have been side tracked recently. I need to get our
Jenkins fixed to be able to build with Java 8 to be able to test the latest
rebase to see if anything changed due
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@remibergsma last time we tested rvr we had a lot of problems and have not
yet been able to adopt it. @pdion891 do you have any details on this? I am not
sure if we have tested it recently
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
This set of test was run on KVM. I am not sure of the current state of RVR
in general, so I can run this PR again because some of those issues were SSH
connectivity issues (which could be env
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
I don't believe any of these issues are related to the StrongSwan feature...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
### CI RESULTS
```
Tests Run: 87
Skipped: 1
Failed: 6
Errors: 0
Duration: 9h 25m 26s
```
**Summary of the problem(s):**
```
FAIL
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
Wow, these builds are getting complicated now. I will see if I can get
Java8 installed on my CentOS6 Jenkins slaves so I can get my existing build
pipelines working again. Thanks
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
Any suggestions to resolve this? I have built from master using JDK8 and
have setup my `cloudstack.repo` to point to my build. I have been doing this
successfully for the past month
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1706
We have proven that the fix in this PR does not work. I have removed it
from #1741.
A new PR which we have proven does work is at: #1907
---
If your project is set up for it, you can
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1706
@vilisseranen can you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack/pull/1907
Fix public IPs not being removed from the VR when deprovisioned
This PR replaces #1706. It does not remove the IP from the database, but
it does deprovision the IP correctly from the VR when
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
I don't think we should try to support non-DH connections since they are
security risk. DH should be required. I have made it required in the UI and
have added a bunch of additional hashing
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
BTW, something that is worth noting is that even if you use a new system vm
template, but the box that the vm template was built on is running Java 7, you
will get the same error that @syed just
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
@syed if you have not built the system vm templates yet, here are a couple
built from master today for XenServer and KVM.
**XenServer**
Name: systemvm-xenserver-4.10.0
Description
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1888
This is supposed to do it @syed:
https://github.com/apache/cloudstack/pull/1888/files#diff-e8e4d31bb5d860c8e7ada3120f758ee9R98
You built a new system VM template or used a new one
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1858
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@rhtyd yes I know. I am not pushing for this to be in 4.10. I will be
pushing for it to go into 4.11 right away, but I know how hard it is to wrap
things up as we get close to freeze. Your doing
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1706
The merge conflict between this PR and #1741 is a bit tricky, so I have
included this fix in #1741. @vilisseranen and I are currently running both PRs
in production so we had to resolve
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
We are running this PR as well as #1706 in production and the merge
conflict for merging the two PRs together is quite complicated. Because we had
to do the merge conflict for our production
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@jayapalu were you working off the latest version of my PR? I have fixed
the issue of the IP being out of order on reboot in this PR.
---
If your project is set up for it, you can reply
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
Rebased again because changes in #1659 caused the fixes to
`systemvm/patches/debian/config/opt/cloud/bin/cs_ip.py` to conflict...
---
If your project is set up for it, you can reply
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@rhtyd If you merge this you will break #1600. We may want to do some more
testing on the upgrade path, but I believe @syed has done some testing of the
upgrade path. Maybe we can put together
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
Rebased against master and fixed merge conflicts...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1525
Not relevant anymore. Closing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user swill closed the pull request at:
https://github.com/apache/cloudstack/pull/1525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@murali-reddy I have tested with Isolated Guest Networks. The problem that
we experienced with the SourceNAT IP not being primary on the public nic if
more than one public IP exists does
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@murali-reddy I will check isolated guest networks today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
I have isolated and fixed the issue where the reboot through the API
results in the Remote Access VPN no longer working if either a PF rule or
Static NAT rule is defined. The problem existed
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
I am troubleshooting an issue right now behaves as follows.
- I create a VR and connect with the Remote Access VPN and everything works.
- I create a Port Forwarding rule on that VR, Remote
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
Thanks guys. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@rhtyd & @jburwell this PR requires a new System VM template to function.
I have a XenServer test environment which I have been using where I deploy RPMs
and the System VM which I b
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/872
I am not able to merge my changes with @jayapalu's branch, so I have
created a new PR #1741 which includes everything from this PR as well as all
the changes I had to make to get both Remote
GitHub user swill opened a pull request:
https://github.com/apache/cloudstack/pull/1741
Updated StrongSwanVPN Implementation
This PR is a merge of @jayapalu changes in #872 and the changes I had to
make to get the functionality working.
I have done pretty extensive testing
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/872
@jayapalu I need to get all my changes merged into this PR though. This PR
has bugs as it is. I will open a new PR with a merge of your changes and my
changes today.
---
If your project is set
1 - 100 of 1154 matches
Mail list logo
