Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
Tracking this with: https://issues.apache.org/jira/browse/COLLECTIONS-855 On Sat, 18 May 2024 at 08:26, Alex Herbert wrote: > Thanks for highlighting this. I did not use the original paper and based > the implementation on Wikipedia. > > I think the issue is that we use i in [0

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
Thanks for highlighting this. I did not use the original paper and based the implementation on Wikipedia. I think the issue is that we use i in [0, k); we can correct this by using i in [1, k]. The order inside the loop would not change but we would have to decrement i to use in the assignment

Re: [COLLECTIONS] Is the changes.xml file automatically updated by pull merge?

2024-05-12 Thread Alex Herbert
No. Just add it as a second commit after merge. On Sun, 12 May 2024, 11:12 Claude Warren, wrote: > -- > LinkedIn: http://www.linkedin.com/in/claudewarren >

Re: [Collections] Suppliers, Iterables, and Producers

2024-04-30 Thread Alex Herbert
On Tue, 30 Apr 2024 at 14:45, Gary D. Gregory wrote: > Hi Claude, > > Thank you for the detailed reply :-) A few comments below. > > On 2024/04/30 06:29:38 Claude Warren wrote: > > I will see if I can clarify the javadocs and make things clearer. > > > > What I think I specifically heard is: > >

Re: [Collections] Suppliers, Iterables, and Producers

2024-04-28 Thread Alex Herbert
Hi Gary, I am in favour of using nomenclature and patterns that will be familiar to a Java developer. But only if they match the familiar JDK use patterns. The Bloom filter package has some atypical use patterns that have driven the current API to where it is. I'll try and describe these below.

Re: [Collections] Bloom filter package's Hasher to extend Function

2024-04-26 Thread Alex Herbert
On Thu, 25 Apr 2024 at 21:47, Gary D. Gregory wrote: > Hi Clause, Albert, and all, > > Why not make Hasher more functional like so: > > public interface Hasher extends Function > > It would implement the standard `apply` instead of `indices`. > > WDYT? > > Gary > I do not see any problems with

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-20 Thread Alex Herbert
IndexProducer indexProducer, Consumer result) Why else do you require indices of layers? If there is no use case other than layer retrieval then this seems to be the wrong API. Alex > Claude > > On Fri, Apr 19, 2024 at 11:06 AM Alex Herbert > wrote: > > > On Fri, 19 Apr 2024

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-19 Thread Alex Herbert
t.next(); if (i == 3) { it.remove(); } } System.out.println(d); prints: [1, 2, 4, 5] So it is easy to iterate the layers and remove them in Order(1) time (per removal). Alex > > On Wed, Apr 17, 2024 at 2:17 PM Alex Herbert > wrote: > > > Looks go

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-17 Thread Alex Herbert
(so 2 new methods, one exposed). > > > > The next() method is used when external circumstances dictate that a new > > layer should be created. I think a StableBloomFilter I implemented > > required it, but I do not have the code to hand at the moment. > > > > Clau

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-09 Thread Alex Herbert
Hi Claude, Q. What is your current clean-up filter, i.e. the Consumer>? I assume you are using a custom one. The current collections code only has 2 functional implementations. One will remove the newest filter if it is empty, one will remove the oldest filters until the size is below a limit.

Re: [Collections] New release candidate for 4.5.0-beta1 or -M1 and new Bloom Filter package

2024-03-25 Thread Alex Herbert
On Mon, 25 Mar 2024 at 13:12, Gary Gregory wrote: > Hi All, > > 4.5.0 will contain a new package for Bloom Filters. > > Since this is a new package and is non-trivial, I propose we release a > version called 4.5.0-M1 or 4.5.0-beta1 to let users try this out while > giving us the change to make

Re: [Net] JUnit 5 migration discussion

2024-02-29 Thread Alex Herbert
Use of abstract classes does work in JUnit 5. I've written a lot of JUnit 5 tests that use abstract test classes which define the @ParameterizedTest/@Test fixtures and then concrete child classes that are run by the framework. It is supported but IIRC it is not recommended in the JUnit 5

Re: New to community-Introducing myself

2023-12-31 Thread Alex Herbert
On Sun, 31 Dec 2023 at 20:54, Narasimha asuri wrote: > > Hi, > > Chary here, I am a beginner java developer and I used many components > of Apache commons library in my previous project, Lang, IO, Math. Saw the > commons - math library and am on looking to help solve some issues. > > > >

Re: (commons-numbers) branch master updated: Simplify conversion of numbers to unsigned

2023-12-24 Thread Alex Herbert
he.org/repos/asf/commons-numbers.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new a15b3e68 Simplify conversion of numbers to unsigned > > a15b3e68 is described below > > > > commit a15b3e68136dd94ea20e4085afc45aa73d4

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 16:31, sebb wrote: > > On Sun, 24 Dec 2023 at 16:14, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > > > > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert > > > wrote: > > > > &g

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold > > wrote: > > > > > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > &g

Re: (commons-numbers) 01/01: Use Java 1.8 methods to simplify the ArithmeticUtils methods remainderUnsigned and divideUnsigned (both int and long)

2023-12-24 Thread Alex Herbert
I would be wary of this simplification without a performance test. In the Numbers class the int methods do not use long arithmetic. The long methods do not use BigInteger. This is unlike those methods in my JDK 8 source code which do and are likely much slower. A quick check in JDK 21 finds this

Re: (commons-numbers) branch java8-simplify created (now 2f60d424)

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 13:20, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a change to branch java8-simplify > in repository https://gitbox.apache.org/repos/asf/commons-numbers.git > > > at 2f60d424 Use Java 1.8 methods to simplify the

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold wrote: > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > Both Numbers and Statistics have implementations of > > > > BigInteger toUnsignedBigInteger(long treatedAsUnsigned) > > > > Can you describe a use case for this? That might help

Re: [ALL] Deploying SNAPSHOTS from GH workflows

2023-12-20 Thread Alex Herbert
On Wed, 20 Dec 2023 at 17:15, sebb wrote: > > Numbers is now deploying OK, as does Crypto. I cannot see anything in the GH action config that specifies that deploy should be only on the master/main branch in the original Apache repo. How is the deploy goal handled in forked repos and

Re: [NUMBERS] GH deploy snapshot test

2023-12-20 Thread Alex Herbert
On Wed, 20 Dec 2023 at 13:19, sebb wrote: > > On Tue, 19 Dec 2023 at 16:08, Alex Herbert wrote: > > > > Thanks Sebb, > > > > Note that previously the GH action was running the default goal: > > 'clean verify javadoc:javadoc'. > > > > Since

Re: [NUMBERS] GH deploy snapshot test

2023-12-19 Thread Alex Herbert
Thanks Sebb, Note that previously the GH action was running the default goal: 'clean verify javadoc:javadoc'. Since we now need to specify the 'deploy' goal as well the above defaults can be switched in for your additions when Infra have created the credentials. Alex On Tue, 19 Dec 2023 at

Re: [ALL] Deploying SNAPSHOTS from GH workflows

2023-12-19 Thread Alex Herbert
On Tue, 19 Dec 2023 at 10:41, sebb wrote: > > Crypto now has a workflow [4] that deploys a SNAPSHOT version. > > I don't know if we want to do this for all components, but if so, the > process is: > - raise INFRA Jira to request access to the secrets that hold the > credentials [1] > - use the

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
On Tue, 12 Dec 2023 at 13:20, Gary Gregory wrote: > > What's the best way to document this do you think? That lang is tested (and so should be built) with the latest JDK of the respective stable release (8, 11, 17, 21)? This could live on the README in the GH repo. This would require an update

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
se line you are using, which is not the case here, and > might not matter. > > Note that some of the tests make allowances for bugs in the JDK date > classes. > > Gary > > On Tue, Dec 12, 2023, 6:18 AM Alex Herbert wrote: > > > I can con

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
I can confirm I see 3 test failures in the FastDateParser using: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Java version: 17.0.6, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home Default locale: en_GB, platform encoding: UTF-8 OS

Re: [LAZY] was: [VOTE] Release Apache Commons Parent 65 based on RC1

2023-11-18 Thread Alex Herbert
On Sat, 18 Nov 2023 at 12:49, Gary Gregory wrote: > > On Sat, Nov 18, 2023 at 3:36 AM Alex Herbert wrote: > > > > Installed from the maven tag. > > > > Built lang and statistics using JDK 8 and 11: > > > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b

Re: [LAZY] was: [VOTE] Release Apache Commons Parent 65 based on RC1

2023-11-18 Thread Alex Herbert
Installed from the maven tag. Built lang and statistics using JDK 8 and 11: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /Users/ah403/mvn/mvn Java version: 1.8.0_362, vendor: Temurin, runtime: /Library/Java/JavaVirtualMachines/temurin-8.jdk/Contents/Home/jre Default

Re: (commons-rng) branch master updated: Normalize spelling to US English

2023-10-31 Thread Alex Herbert
Note: On Tue, 31 Oct 2023 at 10:21, wrote: > Normalize spelling to US English > .../commons/rng/examples/stress/RNGUtils.java | 30 > ++ > +/** Message for an unrecognized source64 mode. */ > +private static final String UNRECOGNISED_SOURCE_64_MODE =

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
method by other means. Alex On Fri, 20 Oct 2023 at 20:16, Gary D. Gregory wrote: > > Hi Alex, > > I'd prefer if you could give a shot at adjusting this test when you can take > the time. > > TY, > Gary > > On 2023/10/20 18:17:35 Alex Herbert wrote: > > On Fri

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
On Fri, 20 Oct 2023 at 18:55, Alex Herbert wrote: > > The chi-square critical value (13.82) is correct: > > >>> from scipy.stats import chi2 > >>> chi2(2).isf(0.001) > 13.815510557964274 > > The test seems to fail with the expected frequency when run loca

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
The chi-square critical value (13.82) is correct: >>> from scipy.stats import chi2 >>> chi2(2).isf(0.001) 13.815510557964274 The test seems to fail with the expected frequency when run locally. I annotated with: @RepeatedTest(value = 10) I observe 93 failures (just under 1 in 1000). So it

Re: [ALL] Java CI badge does not agree with workflow status

2023-10-20 Thread Alex Herbert
Navigating to the Java CI workflow you can generate a badge using the ... menu in the top right next to the search filter. This creates a badge with a different URL to that currently in use: Current: [![GitHub Actions

Re: [Text] Java 21 failure with a double

2023-10-20 Thread Alex Herbert
check against the digits output from Double.toString to ensure all digits are present. Alex [1] https://github.com/apache/commons-text/pull/467 On Mon, 16 Oct 2023 at 18:37, Alex Herbert wrote: > > TLDR; The Double.toString(double) value is different for > -9.354004711977437E17 on JDK 21 and

Re: [Text] Java 21 failure with a double

2023-10-16 Thread Alex Herbert
TLDR; The Double.toString(double) value is different for -9.354004711977437E17 on JDK 21 and earlier JDKs: JDK 21: -9.354004711977437E17 JDK 17: -9.3540047119774374E17 The DoubleFormat class is built upon Double.toString. So the test fails due to this change. --- More details: On JDK 21

Re: [ALL] Standardise Maven defaultGoal in components?

2023-10-08 Thread Alex Herbert
On Sun, 8 Oct 2023 at 22:53, sebb wrote: > > > > On Oct 8, 2023, at 7:11 AM, sebb wrote: > > > > > > There are currently lots of variations of the defaultGoal in different > > > components. > > > > > > It may be sensible to establish a standard setting which components > > > should adopt

Re: [VOTE][LAZY] Release Apache Commons Parent 63 based on RC2

2023-10-02 Thread Alex Herbert
Can you provide the usage for the new property? This is listed in the release notes as a new feature thanks to dependabot. But the commit was a single line added by Gary. I do not think it is attributed to dependabot. It is added under the release management section for properties for the Commons

Re: [BUILD-PLUGIN] Drop component list from README template?

2023-10-02 Thread Alex Herbert
On Mon, 2 Oct 2023 at 10:05, sebb wrote: > > The Build Plugin currently includes a list of components in the README > template. > > This duplicates information provided elsewhere, and gets out of date. > > Since this info is in every GH repo, any changes also need to be > applied to every one of

[statistics] descriptive module

2023-09-26 Thread Alex Herbert
I have been looking at continuing the work on the descriptive module to add the remaining stats found in Commons Math. Before adding more classes I would like to address the current implementation pattern. The statistics in the descriptive module are currently abstract classes with a concrete

Re: [MATH] Inconsistent artifactId for parent pom

2023-09-20 Thread Alex Herbert
On Wed, 20 Sept 2023 at 14:24, sebb wrote: > > The artifactId for the parent pom is > > commons-math-parent > > whereas all the child poms have the prefix > > commons-math4- > > Seems to me this ought to be fixed before the first GA release > (current is 4.0-beta2) The current parent was

Re: [DRAFT][REPORT] September 2023

2023-09-13 Thread Alex Herbert
You could add that we had a successful participant in Google Summer of Code 2023 working on the statistics sub-project. This may apply to the community section. Alex On Wed, 13 Sept 2023 at 02:59, Gary Gregory wrote: > > Here is the report I plan on filing, probably in the AM (EST): > > ##

Re: [collections] AbstractLinkedList is source incompatible with JDK 21

2023-09-08 Thread Alex Herbert
On Fri, 8 Sept 2023 at 13:46, Alex Herbert wrote: > The problem then becomes how to support AbstractLinkedList and > CursorableLinkedList. Currently collections4 will not be source > compatible with JDK 21. Any downstream project that extends these > classes will not be sourc

[collections] AbstractLinkedList is source incompatible with JDK 21

2023-09-08 Thread Alex Herbert
JDK 21 has added these methods to java.util.List: default public void addFirst(E o) default public void addLast(E o) These are source incompatible with Commons Collections AbstractLinkedList: public boolean addFirst(E o) public boolean addLast(E o) This affects AbstractLinkedList and any list

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
On Wed, 9 Aug 2023 at 17:13, Daniel Watson wrote: > BigSigFig result = new BigSigFig("1.1").multiply(new BigSigFig("2")) Multiply is easy as you take the minimum significant figures. What about addition? 12345 + 0.0001 Here the significant figures should remain at 5. And for this: 12345 +

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
On Wed, 9 Aug 2023 at 15:43, Daniel Watson wrote: > > Hope that answers more questions than it creates! It does not address the issue of the last significant zero, e.g: 1 (4 sf) 1 (3 sf) 1 (2 sf) One way to solve this with standard parsing would be to use scientific notation:

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
Hi, On Wed, 9 Aug 2023 at 12:27, Daniel Watson wrote: > This feature is necessary when working with scientific/clinical data which > was reported with significant figures in mind, and for which calculation > results must respect the sigfig count. As far as I could tell there is no > Number

Re: [VOTE][LAZY] Release Apache Commons Parent 59 based on RC1

2023-07-24 Thread Alex Herbert
I installed it locally from the git tag. I build the following projects with their default mvn goal using: Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) Maven home: /usr/local/apache-maven-3 Java version: 1.8.0_362, vendor: Private Build, runtime:

Re: [Pool] Toward version 2.12.0 and 3.0

2023-07-19 Thread Alex Herbert
On Wed, 19 Jul 2023 at 19:38, Gary Gregory wrote: > > OK, that sounds good. > > Gary > > On Tue, Jul 18, 2023 at 5:50 PM Phil Steitz wrote: > > > > I would say 17 for 3.0. > > > > Phil Are there aspects of Pool that require moving away from JDK 8? Such a move would restrict downstream consumers

Re: Move math algorithms from all projects to math libraries

2023-07-18 Thread Alex Herbert
On Tue, 18 Jul 2023 at 09:43, Gilles Sadowski wrote: > > Hello. > > Le mar. 18 juil. 2023 à 02:48, Dimitrios Efthymiou > a écrit : > > > > Thanks Gilles. I checked NUMBERS-193 and i have an implementation of DD and > > i will put it in *.ext package (TBD) along with some tests. Do i have to > >

Re: Move math algorithms from all projects to math libraries

2023-07-18 Thread Alex Herbert
On Tue, 18 Jul 2023 at 01:48, Dimitrios Efthymiou wrote: > > Thanks Gilles. I checked NUMBERS-193 and i have an implementation of DD and > i will put it in *.ext package (TBD) along with some tests. Do i have to > look at Dfd.java or something, because these dfd classes in math legacy > core have

Re: Are any of these types of projects needed?

2023-07-14 Thread Alex Herbert
I would suggest you develop code that you will use. As volunteers we have a main focus for our interests and put work in where we can, or where it also benefits us back. Contributions of large functionality are typically from an existing project that would like to donate mature code to the ASF.

Re: [commons-lang] 02/02: Add IntToIntFunction

2023-07-10 Thread Alex Herbert
Is this not the same as: java.util.function.IntUnaryOperator On Mon, 10 Jul 2023 at 12:56, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-lang.git > > commit

Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-03 Thread Alex Herbert
On Mon, 3 Jul 2023 at 08:29, sebb wrote: > > Is null checked or unchecked? > > I think neither, so isUnchecked also needs to check for null. > > I wonder whether it might be better to throw NPE in both cases for null. > > It may be confusing for users if not checked != unchecked. > e.g. it is

Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-02 Thread Alex Herbert
This change is not null-safe for isUnchecked. This case is missing from the tests (and currently fails): @Test public void testIsUnchecked_null() { assertFalse(ExceptionUtils.isUnchecked(null)); } The case fails because it simply negates isChecked. Both methods should return

Re: [COLLECTIONS] Thread safe Bloom filter

2023-07-02 Thread Alex Herbert
I do not think concurrent write usage is a general use case for the filter. So this seems like a specialisation. If implementing it would harm performance then I would be against it for the base implementation. For specialisation I would prefer the JDK pattern used for Synchronized collections

Re: [VOTE] Release Apache Commons IO 2.12.0 based on RC2

2023-05-14 Thread Alex Herbert
Built from src zip using: mvn install site Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: /Users/ah403/mvn/mvn Java version: 17.0.6, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home Default locale: en_GB, platform

Re: [VOTE] Release Apache Commons IO 2.12.0 based on RC1

2023-05-02 Thread Alex Herbert
Validated signatures and checksums. Build from source tar.gz file using 'mvn verify site' with: Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) Maven home: /usr/local/apache-maven-3 Java version: 11.0.18, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64 Default locale:

Re: [VOTE] Release Apache Commons Parent 57 based on RC2

2023-04-23 Thread Alex Herbert
+1 Installed from the tag. Builds Statistics (multi-module) and Lang using Java 8 and 17. Note: I do get this error from several plugins (pmd, site, bundle, remote-resources): [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid use of ArtifactRepository type. If you need

Re: [ALL] Eventually, soon, Java 11

2023-04-23 Thread Alex Herbert
Free commercial support for JDK 8 from Oracle ended in 2022. Non-commercial and extended commercial support ends in 2030. Other providers have free support for longer than 2023 [1]. I would rather maintain Java 8 support when JDK 8 still has broad support and usage. Alex [1]

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Alex Herbert
Installed from the git tag. I can build projects on JDK 11 and 17. But not on JDK 8. The new profile to conditionally configure the maven-compiler-release plugin for JDK 9+ is incorrect. The parent pom defines the property: 8 Then activates it using: jdk9-compiler

Re: [all] Failed Jenkins builds

2023-03-20 Thread Alex Herbert
On Mon, 20 Mar 2023 at 10:26, Gary Gregory wrote: > > All Commons components are Java 8 (or older), so all could be disabled? I > only rely on GitHub builds since it validates PRs. There is a way to make > releases from GH but I've not looked into it yet. I do not want to waste my time fixing

[all] Failed Jenkins builds

2023-03-20 Thread Alex Herbert
A recent update in Jenkins has updated some part of the Jenkins tooling that reports on the job to a jar file compiled for Java 11. This is making all the Java 8 Jenkins jobs fail. I am not sure of the relevance of many of these Jenkins builds given the use of GH actions for CI builds. The

[numbers][GSoC2023] About “Add support for extended precision floating-point numbers” project

2023-03-06 Thread Alex Herbert
FYI: I added the [numbers] prefix to the subject line. > > ・ I read David Bailey's paper on the QD library and understood its > > algorithms. I also briefly looked over its C++ implementation. This is where I would start with an API design. E.g. what OO API does the c++ reference

Re: [math] The build is broken

2023-03-04 Thread Alex Herbert
Is it consistently broken? One test for the optimisers requires 15 restarts due to randomness in the optimiser and the difficulty of the optimisation problem. This runs in a different phase. See the surefire plug-in configuration in the math parent pom. We tried to make the test suite more robust

[gsoc][statistics] Request for advice about the Commons Statistics project.

2023-02-24 Thread Alex Herbert
Hi, Thanks for your interest in Apache Commons. The GSoC project for Statistics is part of the ongoing project to refactor the large Commons Math (CM) component into smaller modular components (see [1-5]). I have CC'd the commons developer's list on this e-mail. If you subscribe you will be

[GSoC 2023][statistics] Summary Statistics API for Java 8 streams

2023-02-16 Thread Alex Herbert
Hi Mostafa, Thanks for your interest in Apache Commons. The GSoC project for Statistics is part of the ongoing project to refactor the large Commons Math (CM) component into smaller modular components (see [1-5]). I have CC'd the commons developer's list on this e-mail. If you subscribe you

[GSoC 2023] Re: Regarding contribution to Commons Numbers Project under GSoC 2023

2023-02-02 Thread Alex Herbert
Hi Manav, Thanks for your interest in Apache Commons. At present we do not know if there will be projects with Apache Commons for the GSoC 2023 season. If we do have any projects then we will post them with appropriate labels on our issue tracking system so they can be easily found, see for

Re: [commons-math] branch master updated: Add "checkFinite" utility method.

2023-01-05 Thread Alex Herbert
Note there is an isFinite method. if (!Double.isFinite(x)) { ... The isFinite method is a JVM intrinsic method in JDK 20. It was added in JDK 8 so can be used in [math]. PMD rules would also change this to a forEach loop: > +for (double x : value) { > +if

Re: [VOTE] Release Apache Commons Parent 56 based on RC1

2023-01-01 Thread Alex Herbert
Locally installed from the git tag. Builds fine for [rng] and [numbers] using: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/local/apache-maven-3.6.3 Java version: 17, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home

Re: [Math] Post-release 4.0-beta1, still to do

2022-12-21 Thread Alex Herbert
On Wed, 21 Dec 2022 at 15:08, Gilles Sadowski wrote: > > Hello. > > Le mer. 21 déc. 2022 à 15:08, Alex Herbert a écrit > : > > > > On Wed, 21 Dec 2022 at 12:26, Gilles Sadowski wrote: > > > > > > Hello. > > > > > >

Re: [Math] Post-release 4.0-beta1, still to do

2022-12-21 Thread Alex Herbert
On Wed, 21 Dec 2022 at 12:26, Gilles Sadowski wrote: > > Hello. > > Artefacts are available from Maven Central, distribution files > are available from the ASF server and "rel/..." tag was created Thanks. > The [Math] web is not up-to-date yet. > IIUC, a new module must be added that will

Re: svn commit: r1906114 - in /commons/cms-site/trunk: conf/component_releases.properties content/xdoc/index.xml.vm doap/doap_math.rdf

2022-12-20 Thread Alex Herbert
On Tue, 20 Dec 2022 at 17:10, Gilles Sadowski wrote: > > Hi. > > I've updated the occurrences of "math", but the script > conf/parse-latest-release.py > in > https://svn.apache.org/repos/asf/commons/cms-site/trunk > seems to behave weirdly (creating spurious entries?). > > Please check that

Re: [VOTE][RC1] Release Commons Math 4.0-beta1

2022-12-18 Thread Alex Herbert
On Sun, 18 Dec 2022, 23:06 Gilles Sadowski, wrote: > Le dim. 18 déc. 2022 à 23:10, Alex Herbert a > écrit : > > > > I think the name for the distribution archive is collected in: > > > > dist-archive/src/assembly/[bin|src].xml > > > > These u

Re: [VOTE][RC1] Release Commons Math 4.0-beta1

2022-12-18 Thread Alex Herbert
I think the name for the distribution archive is collected in: dist-archive/src/assembly/[bin|src].xml These use ${project.artifactId}-${project.version} by specifying the tag. So renaming the artifactId for the dist-archive in the pom.xml from commons-math to commons-math4 fixes this.

Re: [VOTE][RC1] Release Commons Math 4.0-beta1

2022-12-17 Thread Alex Herbert
Verified the checksums on the source and binary archives. Verified the binary jar files have the correct module entries in the MANIFEST.MF. Built from the git tag using: 'mvn' Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/local/apache-maven-3.6.3 Java version:

Re: [Math] Release hurdles

2022-12-15 Thread Alex Herbert
On Thu, 15 Dec 2022 at 11:28, Gilles Sadowski wrote: > > Hi. > > Le jeu. 15 déc. 2022 à 12:00, Alex Herbert a écrit > : > > > > On Thu, 15 Dec 2022 at 10:52, Gilles Sadowski wrote: > > > > > > Le jeu. 15 déc. 2022 à 11:01, Gilles Sadowski a >

Re: [Math] Release hurdles

2022-12-15 Thread Alex Herbert
On Thu, 15 Dec 2022 at 10:52, Gilles Sadowski wrote: > > Le jeu. 15 déc. 2022 à 11:01, Gilles Sadowski a écrit : > > > > Le jeu. 15 déc. 2022 à 10:53, Gilles Sadowski a > > écrit : > > > > > > Hi. > > > > > > So using the insecure way of passing a password on the command-line, > > > I'm one

Re: [Math] Release hurdles

2022-12-15 Thread Alex Herbert
On Thu, 15 Dec 2022 at 10:24, Gilles Sadowski wrote: > > Le jeu. 15 déc. 2022 à 11:01, Gilles Sadowski a écrit : > > > > Le jeu. 15 déc. 2022 à 10:53, Gilles Sadowski a > > écrit : > > > > > > Hi. > > > > > > So using the insecure way of passing a password on the command-line, > > > I'm one

Re: [Math] Release hurdles

2022-12-14 Thread Alex Herbert
On Wed, 14 Dec 2022 at 13:31, Gilles Sadowski wrote: > > Le mer. 14 déc. 2022 à 09:09, Alex Herbert a écrit > : > > > > On Wed, 14 Dec 2022 at 00:49, Gilles Sadowski wrote: > > > > > > Hello. > > > > > > Next problem: > > > $

Re: [Math] Release hurdles

2022-12-14 Thread Alex Herbert
On Wed, 14 Dec 2022 at 00:49, Gilles Sadowski wrote: > > Hello. > > Next problem: > $ JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 mvn -Duser.name=erans > clean deploy -Prelease > [...] > [INFO] Reactor Summary for Apache Commons Math 4.0-beta1: > [INFO] > [INFO] Apache Commons Math

Re: [Math] "mvn commons-build:download-page" fails with Java 11

2022-12-13 Thread Alex Herbert
On Tue, 13 Dec 2022 at 01:05, Gilles Sadowski wrote: > > Hello. > > Running > $ JAVA_HOME=~/java/jdk/oracle/jdk1.8.0_333 mvn commons-build:download-page > [...] > [INFO] BUILD SUCCESS > [...] > > Running > $ JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64/ mvn > commons-build:download-page > [...]

Re: [Math] "maven site" fails

2022-12-12 Thread Alex Herbert
Deleting the line: Works. I had to do this for the statistics userguide. IIRC the stylesheet was empty there so it did not matter. However for math the style sheet contains some elements. It includes some styles that do not exist and the project.css which is empty apart from an import of a url

Re: [Math] Towards 4.0

2022-12-12 Thread Alex Herbert
I think a beta would be good. Ideally we would get some feedback from those migrating from CM3 to CM4 and there could be a chance to adjust the API. Alex On Mon, 12 Dec 2022 at 15:22, Gary Gregory wrote: > > I'd be happy with at least one beta release. > > Gary > > On Mon, Dec 12, 2022, 10:03

Re: [VOTE][LAZY] Release Apache Commons Parent 55 based on RC1

2022-12-11 Thread Alex Herbert
On Sun, 11 Dec 2022 at 13:23, Gary Gregory wrote: > > > find ~/.m2 -name '*spdx*' -exec rm {} \; > > This command also deletes SPDX files. Was that your intent or did you > only want to delete jar files? Yes. I wanted to clear everything out. Anything needed would be downloaded again. It worked

Re: [VOTE][LAZY] Release Apache Commons Parent 55 based on RC1

2022-12-09 Thread Alex Herbert
acts under org.apache.commons. Now my builds are OK under java 8. So I do not know the reason why, but clearing out the spdx artifacts used by maven fixed it. Alex On Thu, 8 Dec 2022 at 20:31, Gary Gregory wrote: > > Thanks for the update Alex! > > Gary > > On Thu, Dec 8, 2022, 15:11

Re: [VOTE][LAZY] Release Apache Commons Parent 55 based on RC1

2022-12-08 Thread Alex Herbert
ld on my other machine is loading a Java 11 class. I may have some problem with the maven cache and the jars that are loaded. Alex On Thu, 8 Dec 2022 at 18:30, Alex Herbert wrote: > > On Thu, 8 Dec 2022 at 18:18, Gary Gregory wrote: > > > > Java version: 1.8.0_352, vendor: P

Re: [VOTE][LAZY] Release Apache Commons Parent 55 based on RC1

2022-12-08 Thread Alex Herbert
On Thu, 8 Dec 2022 at 18:18, Gary Gregory wrote: > > Java version: 1.8.0_352, vendor: Private Build > > Private build? What's that? I did not notice that. It is strange. I believe this is the version installed by my package manager on Ubuntu: $ java -version openjdk version "1.8.0_352" OpenJDK

Re: [All] Main site is outdated

2022-12-08 Thread Alex Herbert
On Thu, 8 Dec 2022 at 13:50, Gilles Sadowski wrote: > > Le jeu. 8 déc. 2022 à 14:13, Alex Herbert a écrit : > > > > On Thu, 8 Dec 2022 at 12:43, Gilles Sadowski wrote: > > > > > > > > > > > conf/parse-latest-release.py > > > >

Re: [VOTE][LAZY] Release Apache Commons Parent 55 based on RC1

2022-12-08 Thread Alex Herbert
Hi Gary, I tried with the latest git master for numbers, rng and lang. The updated spdx-maven-plugin is not compatible with java 8. I get the following error: [ERROR] Failed to execute goal org.spdx:spdx-maven-plugin:0.6.3:createSPDX (build-spdx) on project commons-lang3: Execution build-spd x

Re: [All] Main site is outdated

2022-12-08 Thread Alex Herbert
On Thu, 8 Dec 2022 at 12:43, Gilles Sadowski wrote: > > > > > conf/parse-latest-release.py > > > > currently makes no changes. > > I've just run it, and it "downgrades" > * RNG (to 1.1) > * Collections (to 4.1) > > :-? That is strange. The script shebang uses env to pick the python version.

Re: [All] Main site is outdated

2022-12-08 Thread Alex Herbert
On Thu, 8 Dec 2022 at 10:17, Gilles Sadowski wrote: > > Le jeu. 8 déc. 2022 à 00:32, sebb a écrit : > > > > On Wed, 7 Dec 2022 at 13:20, Alex Herbert wrote: > > > > > > So I can see the file to edit is index.html at this location: > > >

Re: [All] Main site is outdated

2022-12-07 Thread Alex Herbert
So I can see the file to edit is index.html at this location: svn checkout --depth files https://svn.apache.org/repos/infra/websites/production/commons/content/ But should this be edited manually, or is it generated/updated via some automation? I ask as the newly released statistics component

[rng] LGTM switch to CodeQL GH action

2022-12-07 Thread Alex Herbert
The [rng] project was signed up to LGTM.com analysis (I presume at their website). This is now being decommissioned. The underlying analysis engine is CodeQL and this is migrating to direct support as a Github action. Do we want to continue with this for [rng]? There is a PR open by their bot to

[ANNOUNCE] Apache Commons Statistics Version 1.0 Released

2022-12-07 Thread Alex Herbert
The Apache Commons Team is pleased to announce the availability of version 1.0 of "Apache Commons Statistics". Apache Commons Statistics provides tools for statistics. This is the first release of Apache Commons Statistics. Contains the following modules: commons-statistics-distribution.

Re: [VOTE] Release Apache Commons Statistics 1.0 based on RC1

2022-12-07 Thread Alex Herbert
On Tue, 6 Dec 2022 at 12:21, Gilles Sadowski wrote: > > > > So the issue with staging the RC site to home.apache.org does not > > apply when staged to the commons.apache.org. > > > > You could perhaps (FTR) file a JIRA issue to INFRA. Since I had deleted the site from my home area I uploaded it

Re: [All] Main site is outdated

2022-12-06 Thread Alex Herbert
On Tue, 6 Dec 2022 at 23:31, sebb wrote: > > On Tue, 6 Dec 2022 at 22:28, Gilles Sadowski wrote: > > > > Hello. > > > > Homepage > >https://commons.apache.org/ > > contains inconsistent information: Some "(maven-central) badges" display > > a version number but the link points to another

Re: [rng][lang] Shuffling arrays

2022-12-06 Thread Alex Herbert
On Tue, 6 Dec 2022 at 17:22, Gary Gregory wrote: > > I agree this should be in rng. > > Does rng duplicate all of the lang APIs such that we can deprecate the lang > methods? In short, yes. (cd src/main && git grep -c Random) - ArrayUtils - RandomStringUtils - RandomUtils The proposed

Re: [rng][lang] Shuffling arrays

2022-12-06 Thread Alex Herbert
On Tue, 6 Dec 2022 at 14:38, Bruno Kinoshita wrote: > > Hi Alex, > > I also don't have a use case for this right now. What about creating a JIRA > issue to wait to see if someone has the need for this feature? Maybe users > will confirm they need it, or provide other suggestions? > > -Bruno I do

[rng][lang] Shuffling arrays

2022-12-06 Thread Alex Herbert
Currently the [rng] sampler package can only shuffle primitive int[] arrays: o.a.c.rng.sampling.PermutationSampler: public static void shuffle(UniformRandomProvider rng, int[] list) public static void shuffle(UniformRandomProvider rng, int[] list, int start, boolean towardHead) I would

Re: [VOTE] Release Apache Commons Statistics 1.0 based on RC1

2022-12-06 Thread Alex Herbert
FYI On Mon, 5 Dec 2022 at 00:46, Alex Herbert wrote: > I am wondering why the module page on the site I uploaded does not > render correctly. I have deployed the 1.0 release to the live site. The module page renders correctly: https://commons.apache.org/proper/commons-statistics/c

  1   2   3   4   5   6   7   8   9   >