Nightly build #440 for cordova has succeeded!

Nightly build #440 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/440/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/578#discussion_r129996355 --- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js --- @@ -0,0 +1,79 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-lib issue #580: CB-12895 : Replaced jshint with eslint

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/580 Huge PR! haha LGTM. I did a quick scan. Looks like spacing formatting for the most part. A few unused vars that you added exceptions for. Merge it --- If your project is set up

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/579#discussion_r129981636 --- Diff: spec/cordova/platform/save.spec.js --- @@ -0,0 +1,71 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/579#discussion_r129981726 --- Diff: spec/cordova/platform/save.spec.js --- @@ -0,0 +1,71 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

Github user wilsolutions commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Hi, please, can we get this in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/578#discussion_r129969368 --- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js --- @@ -0,0 +1,79 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Hey @infil00p, latest master has a tiny tweak to the appveyor build file that works around some troubles appveyor is experiencing with one of their VM images. I think if you rebase this,

[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/397 Hey @matrosov-nikita, rebase w/ latest master, I should have a fix (workaround) in for appveyor troubles. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/399 Hey @macdonst if you rebase w/ latest master, I think we can clear up the appveyor failure we're seeing in here. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-android pull request #400: Trying AppVeyor-supplied workaround for c...

Github user filmaj closed the pull request at: https://github.com/apache/cordova-android/pull/400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #400: Trying AppVeyor-supplied workaround for current ...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/400 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=h1) Report > Merging [#400](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=desc) into

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

Please retweet: https://twitter.com/shazron/status/890686444808818688 On Thu, Jul 27, 2017 at 2:05 PM, Shazron wrote: > Sorry, didn't appear that the attachment was included by the mailing list. > > Here it is: >

[GitHub] cordova-android pull request #400: Trying AppVeyor-supplied workaround for c...

GitHub user filmaj opened a pull request: https://github.com/apache/cordova-android/pull/400 Trying AppVeyor-supplied workaround for current appveyor time out issues See http://help.appveyor.com/discussions/problems/7159-builds-timing-out-after-an-hour You can merge this pull

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

Sorry, didn't appear that the attachment was included by the mailing list. Here it is: https://gist.github.com/shazron/7a7f4fbca4dc21b8dfba97fe45a89c6b On Thu, Jul 27, 2017 at 11:45 AM, Shazron wrote: > Thanks Darryl, > To make it easier, I've attached a Brisk [1] file so

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 (I actually still had this tab open for a issue, rebase etc later - sorry about that. But thanks for taking the initiative.) --- If your project is set up for it, you can reply to

Re: [DISCUSS] Accepting new apps into the App Showcase

https://issues.apache.org/jira/browse/CB-13126 On Thu, Jul 27, 2017 at 1:52 PM, Steven Gill wrote: > File it! > > On Thu, Jul 27, 2017 at 1:42 PM, Filip Maj wrote: > >> Is that concensus? Time to file an issue? I love :knife:'ing code >> >> On Tue, Jul

Re: [DISCUSS] Accepting new apps into the App Showcase

File it! On Thu, Jul 27, 2017 at 1:42 PM, Filip Maj wrote: > Is that concensus? Time to file an issue? I love :knife:'ing code > > On Tue, Jul 25, 2017 at 11:21 PM, Tommy Williams > wrote: > > +1 to drop it > > > > On Wed, Jul 26, 2017 at 10:01 AM, Simon

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 I rebased / merged this in. Thanks @janpio ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-statusbar pull request #82: README: Fix issue tracker link

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [DISCUSS] Accepting new apps into the App Showcase

Is that concensus? Time to file an issue? I love :knife:'ing code On Tue, Jul 25, 2017 at 11:21 PM, Tommy Williams wrote: > +1 to drop it > > On Wed, Jul 26, 2017 at 10:01 AM, Simon MacDonald > wrote: > >> +1 to drop it. >> >> Simon Mac Donald >>

[GitHub] cordova-plugin-inappbrowser pull request #232: InAppBrowser

Github user bernatch closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser pull request #232: InAppBrowser

GitHub user bernatch opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/232 InAppBrowser ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

Thanks Darryl, To make it easier, I've attached a Brisk [1] file so you can easily file that bug report. Make sure you enter your credentials in the Brisk preferences first before submitting. This will cross-post your bug report to Apple and OpenRadar. OpenRadar is cross-posted to for visibility

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/578#discussion_r129926425 --- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js --- @@ -0,0 +1,79 @@ +/** +Licensed to the Apache Software Foundation

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

I did a bit of digging in the WebKit sources last night, and it looks like the WebRTC/MediaCapture stuff is all gated behind a preference that's only accessible via a private API. There was also a commit that mentioned something about apps needing to handle all the setup for A/V permissions. In

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/584 CB-12361 : added tests for plugin/save.js ### Platforms affected ### What does this PR do? added tests for plugin/save.js ### What testing has been

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

Github user lunaru commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 +1 for this change. I was confused by this as well when I was looking for the issue tracker. --- If your project is set up for it, you can reply to this email and have your reply

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

IIRC, it's not uncommon for the webview to lag behind Mobile Safari. On Wed, Jul 26, 2017 at 11:47 PM, Toplak Daniel wrote: > He devs, > > Does anyone played with WebRTC on iOS? > > I get a test running only in Safari with iOS 11 Beta 4, but not in a cordova > app. > Both

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 Ideally this kind of stuff lands across all major platforms in Cordova. Generally, if something is not doable due to platform-specific restrictions, we, at the minimum,

[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-android/pull/397 @filmaj, thanks for the information, I'm planning to merge in once Appveyor is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 @filmaj, I would expand this section (https://github.com/apache/cordova-plugin-inappbrowser#more-usage-info) by adding samples with Data URIs. But, for now, I

[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...

Github user luissilvaos commented on the issue: https://github.com/apache/cordova-ios/pull/328 Yes, it is. Please check my last commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser pull request #231: CB-13028 (CI) Browser builds ...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/231 CB-13028 (CI) Browser builds on Travis and AppVeyor, Fixes tests on b… ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis

[GitHub] cordova-plugin-globalization pull request #59: CB-13028 (CI) Browser builds ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

WebRTC (getUserMedia) in cordova-ios on iOS11

He devs, Does anyone played with WebRTC on iOS? I get a test running only in Safari with iOS 11 Beta 4, but not in a cordova app. Both WKWebView and UIWebView seems to have no support of WebRTC. I did not find any official thing from apple, besides what'*s new in Safari 11:

[GitHub] cordova-plugin-globalization pull request #59: CB-13028 (CI) Browser builds ...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/59 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on

[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/328 Thanks for the PR. Is this issue reproducible by a unit test? See https://github.com/apache/cordova-ios/blob/master/tests/CordovaLibTests/CDVWebViewDelegateTests.m --- If your project is set

[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/713#discussion_r129762417 --- Diff: www/docs/en/dev/guide/platforms/ios/webview.md --- @@ -220,5 +222,16 @@ After using either of these two methods, continue with the **"Using