[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-09-25 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/558 There is also https://issues.apache.org/jira/browse/CB-13009, they are similar, not sure if duplicated

[GitHub] cordova-plugin-media pull request #148: CB-13265 Remove ios usage descriptio...

2017-09-11 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-media/pull/148 CB-13265 Remove ios usage description from media plugin ### Platforms affected ios ### What does this PR do? Removes the MICROPHONE_USAGE_DESCRIPTION

[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...

2017-09-09 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137936966 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah

[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...

2017-09-09 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137936915 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah

[GitHub] cordova-plugin-device issue #71: Auto Hide Splashscreen issue in android

2017-09-04 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-device/pull/71 This is not the place to ask questions, sorry, try on cordova slack or stack overflow --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-splashscreen issue #132: Auto Hide Splashscreen issue in andr...

2017-09-02 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/132 Hi, You have created a Pull Request by mistake, can you close it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-device issue #71: Auto Hide Splashscreen issue in android

2017-09-02 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-device/pull/71 Hi, You have created a Pull Request by mistake, can you close it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-inappbrowser issue #230: when i use cordova.InAppBrowser.open...

2017-07-26 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/230 You have send a pull request, can you close it? You just have to add gap: to your Content-Security-Policy meta tag --- If your project is set up for it, you can

[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...

2017-07-23 Thread jcesarmobile
Github user jcesarmobile closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...

2017-07-23 Thread jcesarmobile
GitHub user jcesarmobile reopened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 CB-12586 (iOS) fix method hide doesn't work ### Platforms affected iOS ### What does this PR do? Fix hide method self.viewController wasn't

[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...

2017-07-23 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 CB-12586 (iOS) fix method hide doesn't work ### Platforms affected iOS ### What does this PR do? Fix hide method self.viewController wasn't

[GitHub] cordova-plugin-inappbrowser pull request #228: CB-13035 fix Create issue Lin...

2017-07-23 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/228 CB-13035 fix Create issue Link ### Platforms affected README.md ### What does this PR do? Fix the JIRA link on the README.md ### What

[GitHub] cordova-ios issue #313: CB-12856 - Skip CocoaPods check_reqs if on non-darwi...

2017-07-17 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/313 @andreszs I've been reading some of your comments and issues that you have been opening in different projects and it's not the first time you publicly embarrass yourself because of your

[GitHub] cordova-plugin-media-capture issue #77: Suport iPhone 6

2017-07-17 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/77 If you add a new commit to your local `patch-1` branch and push it to your remote branch `patch-1`, the changes will be added to this PR --- If your project is set up

[GitHub] cordova-plugin-media-capture issue #77: Suport iPhone 6

2017-07-17 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/77 @eduardokraus I saw the images on that link, but can you add them to the PR? if you don't add them to the CDVCapture.bundle they won't work --- If your project is set up

[GitHub] cordova-plugin-media-capture issue #77: Suport iPhone 6

2017-07-16 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/77 The code looks good, but the problem is those images don't exist. Could you add them to the PR? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

2017-07-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 I think it should be better to just change the component to `"cordova-plugin-statusbar"`. Right now it redirects to the one you used, but if some day CB-9742 is close

[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...

2017-06-27 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 @bgallz there is a bug (already reported) about hide not working because of other changes. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...

2017-06-20 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/246 only downgrade to previous CLI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...

2017-06-20 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/246 But you said that you were removing and re adding the platforms, so it shouldn't complain in that case. This might be related to Cordova CLI 7 also using the package.json for storing

[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...

2017-06-20 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/246 What is your error exactly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-battery-status issue #53: CI Rerun test

2017-05-25 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/53 cordova-qa run tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-node-xcode pull request #2: CB-12844 Update pbxProject.js

2017-05-24 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-node-xcode/pull/2#discussion_r118257164 --- Diff: lib/pbxProject.js --- @@ -1546,7 +1546,7 @@ function pbxShellScriptBuildPhaseObj(obj, options, phaseName) { obj.inputPaths

[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work

2017-05-23 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 @filmaj I know, I've done it a few times, but I like to wait a few days because if the user closes it, we have less empty commits --- If your project is set up

[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work

2017-05-22 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 Hi. You have created a Pull Request. Can you close it? If you want to report a bug, you can do it on issues.cordova.io --- If your project is set up

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Yeah, so the solution should be to deprecate `trustAllHosts`, documenting it and then remove those methods, not to implement them with a safe implementation because

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Those methods are there to ignore the certificates if you pass `trustAllHosts` param set to true (default is false) --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request #703: CB-12770: revise security documentation

2017-05-08 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/703#discussion_r115360483 --- Diff: www/docs/en/dev/guide/appdev/security/index.md --- @@ -27,69 +27,155 @@ description: Information and tips for building a secure

[GitHub] cordova-plugin-geolocation pull request #87: Update CDVLocation.m

2017-04-26 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/87#discussion_r113578907 --- Diff: src/ios/CDVLocation.m --- @@ -94,61 +94,62 @@ - (BOOL)isLocationServicesEnabled - (void)startLocation:(BOOL

[GitHub] cordova-plugin-inappbrowser issue #219: [CB-9148] (android) add setType() me...

2017-04-26 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/219 Please, don't reuse the same id as that issue is already closed. Create a new one telling what was broken --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...

2017-04-25 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/76 @momomatteo can you put the issue id (CB-12562) on the title so it's linked with the original issue on JIRA? Also, can you remove one of the `#import `? you duplicated

[GitHub] cordova-plugin-camera issue #253: CB-12458 - [cordova-plugin-camera] - The i...

2017-03-25 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/253 A version with the deprecated id of the camera plugin will crash on new installs on iOS 10 devices, so everybody using camera plugin should be using at least 2.3.1, also 2.2.0

[GitHub] cordova-plugin-camera issue #253: CB-12458 - [cordova-plugin-camera] - The i...

2017-03-25 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/253 @camilamacedo86 I just explained to you how the deprecated ID works so you could understand, but I don't think we need to document it considering version 1 is two years old

[GitHub] cordova-ios issue #296: CB-12571 - Podfile gets overwritten and some depende...

2017-03-14 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/296 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

2017-03-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 Thanks, merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-media issue #132: CB-12542 - Can't record to a wav file

2017-03-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 Can we have wav and m4a as in https://github.com/apache/cordova-plugin-media/pull/131? In any case, the README.md needs an update, right now it says that iOS only accept wav

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-03-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron there is an issue https://issues.apache.org/jira/browse/CB-12542, and it has a PR already --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-media issue #131: CB-1254: (ios) Fix wav file recording, add ...

2017-03-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/131 Hi. The title should CB-12542, you missed the 2. Change it so it's linked with the issue. Also, the PR is showing 13 commit's, that is wrong. Can you rebase your

[GitHub] cordova-plugin-dialogs issue #92: added support for destructive Button on iO...

2017-03-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/92 A change like this should be documented. Also, we usually don't accept this kind of changes to only one platform, do you know if it's possible to use destructive button styles

[GitHub] cordova-ios issue #293: CB-12523 - Remove iOS 8 support

2017-03-02 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/293 A few tests are set to iOS 8 like https://github.com/apache/cordova-ios/blob/master/tests/spec/unit/fixtures/test-config-2.xml#L15 Should them also be updated? --- If your

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

2017-02-27 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 can you rebase and squash the commits into one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

2017-02-26 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 I think the PR is ok and I don't think that we need the weakSelf in this case. In fact, I think we are overusing it in most cases, we should only use it when we might have

[GitHub] cordova-plugin-inappbrowser issue #209: CB-12366: (ios) Reduce tmpWindow lev...

2017-02-21 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/209 Thanks for the PR, I've merged it after making sure that changing the window level doesn't break the changes introduced in #187 --- If your project is set up for it, you

[GitHub] cordova-plugin-inappbrowser issue #121: Fixed issues causing spinner to not ...

2017-02-21 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/121 Closed the PR, it was already covered by #89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser issue #88: CB-3750: Add loading spinner for andr...

2017-02-21 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/88 @cjpearson as this was never merged for CB-3750, I've created CB-12479 to track the Android spinner. Can you change the title to link CB-12479 and also rebase fixing

[GitHub] cordova-plugin-media issue #128: CB-12422: (iOS) Fix readme issue on backgro...

2017-02-15 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/128 Changes look good, not sure why CI fails now. Can you squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-media issue #128: CB-12422: (iOS) Fix readme issue on backgro...

2017-02-14 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/128 "iOS doesn't allow background audio unless you enable it in the info.plist file" can be rephrased to something like "To allow playback with the screen locked or b

[GitHub] cordova-plugin-media issue #127: CB-12434 (Android) fix Stoping a Paused Rec...

2017-02-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/127 @macdonst can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-media pull request #127: CB-12434 (Android) fix Stoping a Pau...

2017-02-09 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-media/pull/127 CB-12434 (Android) fix Stoping a Paused Recording throws exception ### Platforms affected Android ### What does this PR do? When you pause the recording

[GitHub] cordova-plugin-camera issue #168: CB-10369: Added getVideo() feature with th...

2017-02-02 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/168 @infil00p see comments on https://issues.apache.org/jira/browse/CB-10369, I commented that in the 2015 plugin audit there were recommendations to deprecate the media-capture

[GitHub] cordova-plugin-camera issue #251: CB-12368: Fix permission check on Android

2017-01-30 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/251 Thanks, I've merged it. BTW, how did you do to get READ_EXTERNAL_STORAGE permission asked? I get it granted and it never ask for it. --- If your project is set up

[GitHub] cordova-android issue #342: CB-12028: (android) update distributionUrl , cur...

2017-01-30 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-android/pull/342 @hye This has landed in another commit, can you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

2017-01-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 You can read there that there are 3 different pull requests to add quality and all of them want to do it in a different way. We voted and decided that the quality should

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

2017-01-28 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 I started a discussion on the developer list about the quality https://lists.apache.org/thread.html/e115b2a47b4e72e114825dedc5de8e55eaba76f7865f377907cf1df9

[GitHub] cordova-plugin-statusbar pull request #:

2017-01-24 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/fa57e92c5582d0edc7fc4b1f4be7f5e3380d93cf#commitcomment-2054 `statusBarOverlaysWebView` has never affected InAppBrowser plugin or any other plugin, it only applies

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2017-01-18 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 @reidab Can you create a new issue for that on issues.cordova.io? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...

2017-01-16 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/205 @infil00p `openFileChooser` wasn't a public API, but it was working before Android 4.4.0. In android 4.4.0 they decided to remove it and said that it wasn't a public API

[GitHub] cordova-plugin-media issue #124: CB-12319: (Android) Fix bug that record...

2017-01-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/124 AAC_ADTS is API level 16, which is fine as is the min used in cordova-android 6.1.0, but then you should make the plugin require that cordova-android version on the engine tag

[GitHub] cordova-plugin-wkwebview-engine issue #25: CB-12317: Allow to configure navi...

2017-01-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25 You should also document it on the README.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser pull request #205: CB-9148 - (android) Add suppo...

2017-01-03 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94507888 --- Diff: src/android/InAppBrowser.java --- @@ -722,7 +729,57 @@ public void onClick(View v) { inAppWebView

[GitHub] cordova-plugin-inappbrowser pull request #205: CB-9148 - (android) Add suppo...

2017-01-03 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94467650 --- Diff: src/android/InAppBrowser.java --- @@ -722,7 +729,57 @@ public void onClick(View v) { inAppWebView

[GitHub] cordova-plugin-network-information issue #49: CB-11838 ios: Unregister callb...

2016-12-28 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/49 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-network-information issue #48: --save flag

2016-12-28 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/48 Thanks for the PR, but I don't think this is necessary --save flag is documented, but I don't think we should use --save in every example of plugin install

[GitHub] cordova-plugin-media pull request #123: Fix getCurrentAmplitude definition, ...

2016-12-28 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/123#discussion_r94079923 --- Diff: README.md --- @@ -104,7 +104,7 @@ The following constants are reported as the only parameter to the ### Methods

[GitHub] cordova-plugin-media pull request #123: Fix getCurrentAmplitude definition, ...

2016-12-28 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/123#discussion_r94078703 --- Diff: README.md --- @@ -104,7 +104,7 @@ The following constants are reported as the only parameter to the ### Methods

[GitHub] cordova-plugin-statusbar pull request #74: CB-12196 (iOS) fix Status Bar Not...

2016-12-27 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/74 CB-12196 (iOS) fix Status Bar Not Hiding ### Platforms affected iOS ### What does this PR do? Fix the statusbar not hiding when overlaysWebView

[GitHub] cordova-plugin-statusbar pull request #:

2016-12-21 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262925 Well, that issue was created before this was merged, so this couldn't cause that issue. But will use

[GitHub] cordova-plugin-statusbar pull request #:

2016-12-21 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262818 @regnete can you create a new issue on http://issues.cordova.io? --- If your project is set up

[GitHub] cordova-ios pull request #282: CB-11810 (ios) fix unable to load index page ...

2016-12-17 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-ios/pull/282 CB-11810 (ios) fix unable to load index page from frameworkpath ### Platforms affected iOS ### What does this PR do? In cordova-ios 4.2.0 it was included

[GitHub] cordova-plugin-statusbar pull request #73: CB-12141 (ios) fix white app scre...

2016-12-15 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/73 CB-12141 (ios) fix white app screen after camera overlay shown on iPad ### Platforms affected iOS ### What does this PR do? fix white app screen

[GitHub] cordova-docs issue #664: Update images.md

2016-12-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-docs/pull/664 Yes @shazron, the icon problem is fixed in cordova-android 6.1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-statusbar issue #72: Update plugin.xml

2016-12-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/72 Those are the default values, if you provide your own values in the config.xml the app should use those. If that isn't working then create an issue about it in http

[GitHub] cordova-android issue #350: 6.1.x App Crash when put number input

2016-12-05 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-android/pull/350 You can start by creating a proper issue on http://issues.cordova.io/ and closing the PR you created, because opening PRs is not the way of creating issues. --- If your project

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-05 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90834795 --- Diff: README.md --- @@ -131,6 +132,7 @@ instance, or the system browser. - __presentationstyle__: Set to `pagesheet

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559621 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -246,25 +246,11 @@ - (void)show:(CDVInvokedUrlCommand*)command - (void)hide

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559723 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -815,6 +827,13 @@ - (void)close }); } +- (void)hide --- End

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559822 --- Diff: src/ios/CDVInAppBrowser.h --- @@ -96,6 +97,7 @@ @property (nonatomic) NSURL* currentURL; - (void)close

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559216 --- Diff: README.md --- @@ -131,6 +132,7 @@ instance, or the system browser. - __presentationstyle__: Set to `pagesheet

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90560844 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -568,7 +576,11 @@ - (void)createViews self.spinner.userInteractionEnabled

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559136 --- Diff: README.md --- @@ -114,6 +114,7 @@ instance, or the system browser. - __hardwareback__: set to `yes` to use

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/468 Then looks good to me, I can't think any example right now where the same file should be needed for all platforms --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-11-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/468 I think top level might make sense here if it's a file that the IDE needs but not the app (configuration file like google-services.json/plist) Can the launch images and icons

[GitHub] cordova-plugin-inappbrowser pull request #199: CB-12184 executeScript leads ...

2016-11-24 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/199 CB-12184 executeScript leads to a null pointer on exception on Android. ### Platforms affected Android ### What does this PR do? Avoid null pointer

[GitHub] cordova-plugin-inappbrowser issue #196: CB-12140: (android) Content descript...

2016-11-14 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 Yes, it's ok, I'll merge it later, thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...

2016-11-14 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 @vladimir-kotikov I have tried to generate the README.md from the TEMPLATE.md, but it's failing. Can you take a look? --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Thanks, merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-inappbrowser issue #107: CB-9274 Adds missing methods to InAp...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/107 Ok, I've merged this in case there were still people using amazon-fireos, but it's deprecated and the plugin code might be deleted in future releases --- If your project

[GitHub] cordova-plugin-inappbrowser issue #66: CB-7608 : add option useWidthViewPort...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/66 @sebastienblanc I would like to merge this, can you fix the conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 I agree with @jonathanli2, as this way is a bit hackish, I think it's better doing it were it's strictly necessary to fix the bug --- If your project is set up

[GitHub] cordova-plugin-inappbrowser issue #196: CB-NONE: (android) Set correct conte...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 @PhilippeMorier, can you create an issue on issues.cordova.io and use the id you get as start of the title of this PR? --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 @jonathanli2 can you rebase your PR squashing the 3 commits into one? I'm having trouble merging this with the tool we use to merge --- If your project is set up

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 I had the chance to test this on a real device and looks good, so I'm merging it in --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 I didn't meant to reuse the existing hide, but make the old hide just call the new browserHide as browserHide has the exact same code ```- (void)hide

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-11 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 The existing hide and the new browserHide do exactly the same, can you make the old hide just call browserHide instead of duplicating code. Can you try adding

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

2016-11-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 I think it makes more sense for photo gallery images, as you might have downloaded them with a low resolution, or maybe when using the front camera in some devices with less than

[GitHub] cordova-plugin-statusbar issue #68: CB-10158: (ios) StatusBar issue when rec...

2016-11-03 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/68 Ah, didn't think about the pause event and good to know about the webkitDisplayingFullscreen. Anyway, I fixed the issue last weekend, you can close the PR now

[GitHub] cordova-android issue #343: CB-12077: Fix paths for Android icons/splashscre...

2016-11-03 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-android/pull/343 you can use cordova-android from master with `cordova platform add android@https://github.com/apache/cordova-android` or the previous version with `cordova platform add android@5.2.2

[GitHub] cordova-lib pull request #:

2016-10-31 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19629338 Ah, thanks, so I can close the issue and say that this is only a warning? --- If your project is set up for it, you

  1   2   3   4   >