Nightly build #440 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #440 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/440/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/578#discussion_r129996355
  
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var rewire = require('rewire');
+var cordova_util = require('../../../src/cordova/util');
+var platform_getPlatformDetails = 
rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
+var events = require('cordova-common').events;
+var fail;
+
+describe('cordova/platform/getPlatformDetailsFromDir', function () {
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.name = 'io.cordova.hellocordova';
+package_json_mock.version = '1.0.0';
+
+beforeEach(function () {
+spyOn(Q, 'reject');
+spyOn(fs, 'existsSync');
+spyOn(cordova_util, 'requireNoCache');
+spyOn(events, 'emit');
+});
+
+it('should throw if no config.xml or pkgJson', function (done) {
+platform_getPlatformDetails('dir', ['ios']);
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a valid package.json or a valid Cordova platform/));
+done();
+});
+
+it('should throw if no platform is provided', function (done) {
+cordova_util.requireNoCache.and.returnValue({});
+platform_getPlatformDetails('dir');
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a Cordova platform:/));
+done();
+});
+
+it('should return a promise with platform and version', function 
(done) {
+fs.existsSync.and.callFake(function(filePath) {
+if(path.basename(filePath) === 'package.json') {
+return true;
+} else {
+return false;
+}
+});
+cordova_util.requireNoCache.and.returnValue(package_json_mock);
+platform_getPlatformDetails('dir', ['cordova-android'])
+.then(function(result) {
+expect(result.platform).toBe('io.cordova.hellocordova');
+expect(result.version).toBe('1.0.0');
+expect(Q.reject).not.toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {
+platform_getPlatformDetails.platformFromName('cordova-ios');
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
+
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
--- End diff --

yup


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #580: CB-12895 : Replaced jshint with eslint

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/580
  
Huge PR! haha LGTM. I did a quick scan. Looks like spacing formatting for 
the most part. A few unused vars that you added exceptions for. 

Merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/579#discussion_r129981636
  
--- Diff: spec/cordova/platform/save.spec.js ---
@@ -0,0 +1,71 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q');
+var rewire = require('rewire');
+var platform_save = rewire('../../../src/cordova/platform/save');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var fail;
+var semver = require('semver');
+
+describe('cordova/platform/save', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+
+beforeEach(function () {
+spyOn(semver, 'valid');
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
mock', ['write', 'removeEngine', 'addEngine','getEngines']);
+cfg_parser_revert_mock = platform_save.__set__('ConfigParser', 
cfg_parser_mock);
+cfg_parser_mock.prototype.getEngines.and.returnValue(['android']);
+});
+
+afterEach(function () {
+cfg_parser_revert_mock();
+});
+
+it('should first remove platforms already in config.xml', function 
(done) {
+platform_save(hooks_mock, projectRoot, {save : true})
+.then(function(res){
+
expect(cfg_parser_mock.prototype.getEngines).toHaveBeenCalled();
+
expect(cfg_parser_mock.prototype.removeEngine).toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('add and write to config.xml', function (done) {
+spyOn(platform_metadata, 
'getPlatformVersions').and.returnValue(Q(['6.3.0']));
--- End diff --

so getPlatformVersions returns in the format of `{platform: platform, 
version: version}`. So instead of returning `Q([6.3.0])`, you could return 
`Q({platform: 'android', version: 6.3.0})`. That way the first argument for 
line 58 won't be undefined. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/579#discussion_r129981726
  
--- Diff: spec/cordova/platform/save.spec.js ---
@@ -0,0 +1,71 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q');
+var rewire = require('rewire');
+var platform_save = rewire('../../../src/cordova/platform/save');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var fail;
+var semver = require('semver');
+
+describe('cordova/platform/save', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+
+beforeEach(function () {
+spyOn(semver, 'valid');
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
mock', ['write', 'removeEngine', 'addEngine','getEngines']);
+cfg_parser_revert_mock = platform_save.__set__('ConfigParser', 
cfg_parser_mock);
+cfg_parser_mock.prototype.getEngines.and.returnValue(['android']);
+});
+
+afterEach(function () {
+cfg_parser_revert_mock();
+});
+
+it('should first remove platforms already in config.xml', function 
(done) {
+platform_save(hooks_mock, projectRoot, {save : true})
+.then(function(res){
+
expect(cfg_parser_mock.prototype.getEngines).toHaveBeenCalled();
+
expect(cfg_parser_mock.prototype.removeEngine).toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('add and write to config.xml', function (done) {
+spyOn(platform_metadata, 
'getPlatformVersions').and.returnValue(Q(['6.3.0']));
+semver.valid.and.returnValue('6.0.0');
+platform_save(hooks_mock, projectRoot, {save : true})
+.then(function(result) {
+
expect(cfg_parser_mock.prototype.addEngine).toHaveBeenCalledWith(undefined, 
'~6.0.0');
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should first remove platforms already in config.xml', function 
(done) {
--- End diff --

I think you forgot to update the description here when you copied the first 
test :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

[wilsolutions]

Github user wilsolutions commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/99
  
Hi, please, can we get this in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/578#discussion_r129969368
  
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var rewire = require('rewire');
+var cordova_util = require('../../../src/cordova/util');
+var platform_getPlatformDetails = 
rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
+var events = require('cordova-common').events;
+var fail;
+
+describe('cordova/platform/getPlatformDetailsFromDir', function () {
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.name = 'io.cordova.hellocordova';
+package_json_mock.version = '1.0.0';
+
+beforeEach(function () {
+spyOn(Q, 'reject');
+spyOn(fs, 'existsSync');
+spyOn(cordova_util, 'requireNoCache');
+spyOn(events, 'emit');
+});
+
+it('should throw if no config.xml or pkgJson', function (done) {
+platform_getPlatformDetails('dir', ['ios']);
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a valid package.json or a valid Cordova platform/));
+done();
+});
+
+it('should throw if no platform is provided', function (done) {
+cordova_util.requireNoCache.and.returnValue({});
+platform_getPlatformDetails('dir');
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a Cordova platform:/));
+done();
+});
+
+it('should return a promise with platform and version', function 
(done) {
+fs.existsSync.and.callFake(function(filePath) {
+if(path.basename(filePath) === 'package.json') {
+return true;
+} else {
+return false;
+}
+});
+cordova_util.requireNoCache.and.returnValue(package_json_mock);
+platform_getPlatformDetails('dir', ['cordova-android'])
+.then(function(result) {
+expect(result.platform).toBe('io.cordova.hellocordova');
+expect(result.version).toBe('1.0.0');
+expect(Q.reject).not.toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {
+platform_getPlatformDetails.platformFromName('cordova-ios');
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
+
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
--- End diff --

ohh okay do you mean just like this?

```
 it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {

expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
done();
});
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Hey @infil00p, latest master has a tiny tweak to the appveyor build file 
that works around some troubles appveyor is experiencing with one of their VM 
images. I think if you rebase this, you'll find that'll clear up the appveyor 
failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/397
  
Hey @matrosov-nikita, rebase w/ latest master, I should have a fix 
(workaround) in for appveyor troubles.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/399
  
Hey @macdonst if you rebase w/ latest master, I think we can clear up the 
appveyor failure we're seeing in here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #400: Trying AppVeyor-supplied workaround for c...

[filmaj]

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-android/pull/400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #400: Trying AppVeyor-supplied workaround for current ...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/400
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=h1) 
Report
> Merging 
[#400](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/c3ce2f8a074f6f6f691fc33bf0f66f53bfbf8856?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/400/graphs/tree.svg?width=650=q14nMf6C5a=150=pr)](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=tree)

```diff
@@   Coverage Diff   @@
##   master #400   +/-   ##
===
  Coverage   42.55%   42.55%   
===
  Files  17   17   
  Lines1678 1678   
  Branches  304  304   
===
  Hits  714  714   
  Misses964  964
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=footer).
 Last update 
[c3ce2f8...458e479](https://codecov.io/gh/apache/cordova-android/pull/400?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

[Shazron]

Please retweet: https://twitter.com/shazron/status/890686444808818688

On Thu, Jul 27, 2017 at 2:05 PM, Shazron  wrote:

> Sorry, didn't appear that the attachment was included by the mailing list.
>
> Here it is:
> https://gist.github.com/shazron/7a7f4fbca4dc21b8dfba97fe45a89c6b
>
> On Thu, Jul 27, 2017 at 11:45 AM, Shazron  wrote:
>
>> Thanks Darryl,
>> To make it easier, I've attached a Brisk [1] file so you can easily file
>> that bug report. Make sure you enter your credentials in the Brisk
>> preferences first before submitting. This will cross-post your bug report
>> to Apple and OpenRadar. OpenRadar is cross-posted to for visibility --
>> since your Apple bug report is private to you and Apple employees only.
>>
>> Steps:
>> 1. Install Brisk (instructions at  https://github.com/br1sk/brisk)
>> 2. Launch Brisk
>> 3. On the menubar, select Brisk -> Preferences... (menubar icon is an
>> ant-eater on a skateboard)
>> 4. In the Apple Radar tab, Sign In with your developer Apple ID
>> 5. In the Open Radar tab, enter your API key from http://openradar.me
>> (Sign In -> My API Key)
>> 6. Download the attached .brisk file
>> 7. Double-click on it
>> 8. Press the "Submit" button
>>
>> Let's produce a lot of dupes. Dupes are what brings an issue to the
>> forefront within Apple.
>>
>> [1] https://github.com/br1sk/brisk
>>
>> On Thu, Jul 27, 2017 at 11:31 AM, Darryl Pogue  wrote:
>>
>>> I did a bit of digging in the WebKit sources last night, and it looks
>>> like
>>> the WebRTC/MediaCapture stuff is all gated behind a preference that's
>>> only
>>> accessible via a private API.  There was also a commit that mentioned
>>> something about apps needing to handle all the setup for A/V permissions.
>>>
>>> In any case, the result is that getUserMedia doesn't work in WKWebView,
>>> even on iOS11 :(
>>>
>>> I've filed a radar (rdar://33571214 and http://www.openradar.me/33571214)
>>> and
>>> encourage everyone else to do the same.
>>>
>>> On 27 July 2017 at 08:55, Filip Maj  wrote:
>>>
>>> > IIRC, it's not uncommon for the webview to lag behind Mobile Safari.
>>> >
>>> > On Wed, Jul 26, 2017 at 11:47 PM, Toplak Daniel 
>>> > wrote:
>>> > > He devs,
>>> > >
>>> > > Does anyone played with WebRTC on iOS?
>>> > >
>>> > > I get a test running only in Safari with iOS 11 Beta 4, but not in a
>>> > cordova app.
>>> > > Both WKWebView and UIWebView seems to have no support of WebRTC.
>>> > >
>>> > > I did not find any official thing from apple, besides what'*s new in
>>> > Safari 11: https://developer.apple.com/library/content/releasenotes/
>>> > General/WhatsNewInSafari/Safari_11_0/Safari_11_0.html
>>> > > They announce the WebRTC support.
>>> > >
>>> > > Grüße / Regards
>>> > > Daniel Toplak
>>> > > Head of Mobile Development
>>> > >
>>> > >
>>> >
>>> > -
>>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> > For additional commands, e-mail: dev-h...@cordova.apache.org
>>> >
>>> >
>>>
>>
>>
>

[GitHub] cordova-android pull request #400: Trying AppVeyor-supplied workaround for c...

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-android/pull/400

Trying AppVeyor-supplied workaround for current appveyor time out issues

See 
http://help.appveyor.com/discussions/problems/7159-builds-timing-out-after-an-hour

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-android appveyor-workaround

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #400


commit 458e47968158642e803a36b2aaed15b5a789a994
Author: filmaj 
Date:   2017-07-27T21:33:16Z

Trying AppVeyor-supplied workaround for current appveyor time out issues. 
See 
http://help.appveyor.com/discussions/problems/7159-builds-timing-out-after-an-hour




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

[Shazron]

Sorry, didn't appear that the attachment was included by the mailing list.

Here it is:
https://gist.github.com/shazron/7a7f4fbca4dc21b8dfba97fe45a89c6b

On Thu, Jul 27, 2017 at 11:45 AM, Shazron  wrote:

> Thanks Darryl,
> To make it easier, I've attached a Brisk [1] file so you can easily file
> that bug report. Make sure you enter your credentials in the Brisk
> preferences first before submitting. This will cross-post your bug report
> to Apple and OpenRadar. OpenRadar is cross-posted to for visibility --
> since your Apple bug report is private to you and Apple employees only.
>
> Steps:
> 1. Install Brisk (instructions at  https://github.com/br1sk/brisk)
> 2. Launch Brisk
> 3. On the menubar, select Brisk -> Preferences... (menubar icon is an
> ant-eater on a skateboard)
> 4. In the Apple Radar tab, Sign In with your developer Apple ID
> 5. In the Open Radar tab, enter your API key from http://openradar.me
> (Sign In -> My API Key)
> 6. Download the attached .brisk file
> 7. Double-click on it
> 8. Press the "Submit" button
>
> Let's produce a lot of dupes. Dupes are what brings an issue to the
> forefront within Apple.
>
> [1] https://github.com/br1sk/brisk
>
> On Thu, Jul 27, 2017 at 11:31 AM, Darryl Pogue  wrote:
>
>> I did a bit of digging in the WebKit sources last night, and it looks like
>> the WebRTC/MediaCapture stuff is all gated behind a preference that's only
>> accessible via a private API.  There was also a commit that mentioned
>> something about apps needing to handle all the setup for A/V permissions.
>>
>> In any case, the result is that getUserMedia doesn't work in WKWebView,
>> even on iOS11 :(
>>
>> I've filed a radar (rdar://33571214 and http://www.openradar.me/33571214)
>> and
>> encourage everyone else to do the same.
>>
>> On 27 July 2017 at 08:55, Filip Maj  wrote:
>>
>> > IIRC, it's not uncommon for the webview to lag behind Mobile Safari.
>> >
>> > On Wed, Jul 26, 2017 at 11:47 PM, Toplak Daniel 
>> > wrote:
>> > > He devs,
>> > >
>> > > Does anyone played with WebRTC on iOS?
>> > >
>> > > I get a test running only in Safari with iOS 11 Beta 4, but not in a
>> > cordova app.
>> > > Both WKWebView and UIWebView seems to have no support of WebRTC.
>> > >
>> > > I did not find any official thing from apple, besides what'*s new in
>> > Safari 11: https://developer.apple.com/library/content/releasenotes/
>> > General/WhatsNewInSafari/Safari_11_0/Safari_11_0.html
>> > > They announce the WebRTC support.
>> > >
>> > > Grüße / Regards
>> > > Daniel Toplak
>> > > Head of Mobile Development
>> > >
>> > >
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > For additional commands, e-mail: dev-h...@cordova.apache.org
>> >
>> >
>>
>
>

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

[janpio]

Github user janpio commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/82
  
(I actually still had this tab open for a issue, rebase etc later - sorry 
about that. But thanks for taking the initiative.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Accepting new apps into the App Showcase

[Filip Maj]

https://issues.apache.org/jira/browse/CB-13126

On Thu, Jul 27, 2017 at 1:52 PM, Steven Gill  wrote:
> File it!
>
> On Thu, Jul 27, 2017 at 1:42 PM, Filip Maj  wrote:
>
>> Is that concensus? Time to file an issue? I love :knife:'ing code
>>
>> On Tue, Jul 25, 2017 at 11:21 PM, Tommy Williams 
>> wrote:
>> > +1 to drop it
>> >
>> > On Wed, Jul 26, 2017 at 10:01 AM, Simon MacDonald <
>> simon.macdon...@gmail.com
>> >> wrote:
>> >
>> >> +1 to drop it.
>> >>
>> >> Simon Mac Donald
>> >> http://simonmacdonald.com
>> >>
>> >> On Tue, Jul 25, 2017 at 7:00 PM, Shazron  wrote:
>> >>
>> >> > +1 drop it altogether.
>> >> > We can't be the arbiter of what's good or bad, and of course we don't
>> >> have
>> >> > the time nor desire to do so IMO.
>> >> >
>> >> > On Tue, Jul 25, 2017 at 2:32 PM, Steven Gill 
>> >> > wrote:
>> >> >
>> >> > > +1000 I was strongly against having an app showcase when it was
>> >> proposed
>> >> > > for the new site. Nobody ever wants to maintain it.
>> >> > >
>> >> > > On Tue, Jul 25, 2017 at 2:08 PM, Jesse 
>> >> wrote:
>> >> > >
>> >> > > > +1 to dropping it from cordova
>> >> > > > Let's just link to phonegap-showcase, onsenui-showcase and
>> >> > ionic-showcase
>> >> > > > pages ... I think we should focus on being the best engine and let
>> >> the
>> >> > > > downstreams do the marketing.
>> >> > > >
>> >> > > >
>> >> > > > @purplecabbage
>> >> > > > risingj.com
>> >> > > >
>> >> > > > On Tue, Jul 25, 2017 at 12:43 PM, julio cesar sanchez <
>> >> > > > jcesarmob...@gmail.com> wrote:
>> >> > > >
>> >> > > > > I liked Kerri's idea about only posting open source apps. I
>> think
>> >> > users
>> >> > > > can
>> >> > > > > benefit of it.
>> >> > > > >
>> >> > > > > El 25 jul. 2017 7:52 p. m., "Joe Bowser" 
>> >> > escribió:
>> >> > > > >
>> >> > > > > > +1 to no longer supporting the Apps section.  Downstream
>> projects
>> >> > get
>> >> > > > > more
>> >> > > > > > benefit from this than we do, IMO.
>> >> > > > > >
>> >> > > > > > On Tue, Jul 25, 2017 at 10:36 AM, Filip Maj <
>> maj@gmail.com>
>> >> > > wrote:
>> >> > > > > >
>> >> > > > > > > I'm of the opinion that we, the cordova devs are already
>> >> sinking
>> >> > > > under
>> >> > > > > > > the amount of incoming PRs and TODOs just with maintaining
>> the
>> >> > > > > > > tooling, platforms, plugins, and docs.
>> >> > > > > > >
>> >> > > > > > > I think it would be better to turf it and let downstream
>> >> projects
>> >> > > do
>> >> > > > > > > that stuff if they wish. I think PhoneGap has one, so does
>> >> ionic.
>> >> > > > > > >
>> >> > > > > > > On Tue, Jul 25, 2017 at 9:58 AM, Kerri Shotts <
>> >> > > kerrisho...@gmail.com
>> >> > > > >
>> >> > > > > > > wrote:
>> >> > > > > > > > If we’re going to have an apps section on the website, it
>> >> would
>> >> > > be
>> >> > > > > good
>> >> > > > > > > to keep it updated. For example, the ReactEurope app goes
>> to a
>> >> > 404
>> >> > > > > page.
>> >> > > > > > > Buildr navigates to an iTunes page that is not available in
>> the
>> >> > US
>> >> > > > > > region,
>> >> > > > > > > so doesn’t tell me anything (would be better to link to a
>> >> website
>> >> > > > > > instead).
>> >> > > > > > > >
>> >> > > > > > > > Personally, it might be better just to drop the section
>> >> > entirely,
>> >> > > > > since
>> >> > > > > > > it will require maintenance, would end up with some
>> subjective
>> >> > > > criteria
>> >> > > > > > > (leading to “why them and not us?”), and would need to be
>> >> rotated
>> >> > > as
>> >> > > > > new
>> >> > > > > > > apps are added to prevent a huge list of apps on the front
>> >> page.
>> >> > I
>> >> > > > like
>> >> > > > > > the
>> >> > > > > > > idea, but maybe it would be better to have a Cordova App
>> >> gallery
>> >> > > > (akin
>> >> > > > > to
>> >> > > > > > > Plugin search, cocoapods, etc.)… but that could easily be
>> done
>> >> by
>> >> > > the
>> >> > > > > > > community, since we’re tight on resources as it is.
>> >> > > > > > > >
>> >> > > > > > > > That said, if we’re going to accept apps, we need some
>> >> > > (reasonable)
>> >> > > > > > > criteria for acceptance, along with the proviso that we
>> won’t
>> >> > > > > necessarily
>> >> > > > > > > always feature the app (since we don’t want to end up
>> featuring
>> >> > > 1000
>> >> > > > > apps
>> >> > > > > > > on the front page).
>> >> > > > > > > >
>> >> > > > > > > > Some starting criteria:
>> >> > > > > > > >
>> >> > > > > > > > * Should currently be available for sale/download on the
>> >> > > > appropriate
>> >> > > > > > app
>> >> > > > > > > stores.
>> >> > > > > > > > * The product needs to have a website where we can link
>> >> > > > (redirecting
>> >> > > > > > > into iTunes is not ideal).
>> >> > > > > > > > * The product should fit with Cordova’s CoC, since it’s
>> being
>> >> > > > > featured
>> >> > > 

Re: [DISCUSS] Accepting new apps into the App Showcase

[Steven Gill]

File it!

On Thu, Jul 27, 2017 at 1:42 PM, Filip Maj  wrote:

> Is that concensus? Time to file an issue? I love :knife:'ing code
>
> On Tue, Jul 25, 2017 at 11:21 PM, Tommy Williams 
> wrote:
> > +1 to drop it
> >
> > On Wed, Jul 26, 2017 at 10:01 AM, Simon MacDonald <
> simon.macdon...@gmail.com
> >> wrote:
> >
> >> +1 to drop it.
> >>
> >> Simon Mac Donald
> >> http://simonmacdonald.com
> >>
> >> On Tue, Jul 25, 2017 at 7:00 PM, Shazron  wrote:
> >>
> >> > +1 drop it altogether.
> >> > We can't be the arbiter of what's good or bad, and of course we don't
> >> have
> >> > the time nor desire to do so IMO.
> >> >
> >> > On Tue, Jul 25, 2017 at 2:32 PM, Steven Gill 
> >> > wrote:
> >> >
> >> > > +1000 I was strongly against having an app showcase when it was
> >> proposed
> >> > > for the new site. Nobody ever wants to maintain it.
> >> > >
> >> > > On Tue, Jul 25, 2017 at 2:08 PM, Jesse 
> >> wrote:
> >> > >
> >> > > > +1 to dropping it from cordova
> >> > > > Let's just link to phonegap-showcase, onsenui-showcase and
> >> > ionic-showcase
> >> > > > pages ... I think we should focus on being the best engine and let
> >> the
> >> > > > downstreams do the marketing.
> >> > > >
> >> > > >
> >> > > > @purplecabbage
> >> > > > risingj.com
> >> > > >
> >> > > > On Tue, Jul 25, 2017 at 12:43 PM, julio cesar sanchez <
> >> > > > jcesarmob...@gmail.com> wrote:
> >> > > >
> >> > > > > I liked Kerri's idea about only posting open source apps. I
> think
> >> > users
> >> > > > can
> >> > > > > benefit of it.
> >> > > > >
> >> > > > > El 25 jul. 2017 7:52 p. m., "Joe Bowser" 
> >> > escribió:
> >> > > > >
> >> > > > > > +1 to no longer supporting the Apps section.  Downstream
> projects
> >> > get
> >> > > > > more
> >> > > > > > benefit from this than we do, IMO.
> >> > > > > >
> >> > > > > > On Tue, Jul 25, 2017 at 10:36 AM, Filip Maj <
> maj@gmail.com>
> >> > > wrote:
> >> > > > > >
> >> > > > > > > I'm of the opinion that we, the cordova devs are already
> >> sinking
> >> > > > under
> >> > > > > > > the amount of incoming PRs and TODOs just with maintaining
> the
> >> > > > > > > tooling, platforms, plugins, and docs.
> >> > > > > > >
> >> > > > > > > I think it would be better to turf it and let downstream
> >> projects
> >> > > do
> >> > > > > > > that stuff if they wish. I think PhoneGap has one, so does
> >> ionic.
> >> > > > > > >
> >> > > > > > > On Tue, Jul 25, 2017 at 9:58 AM, Kerri Shotts <
> >> > > kerrisho...@gmail.com
> >> > > > >
> >> > > > > > > wrote:
> >> > > > > > > > If we’re going to have an apps section on the website, it
> >> would
> >> > > be
> >> > > > > good
> >> > > > > > > to keep it updated. For example, the ReactEurope app goes
> to a
> >> > 404
> >> > > > > page.
> >> > > > > > > Buildr navigates to an iTunes page that is not available in
> the
> >> > US
> >> > > > > > region,
> >> > > > > > > so doesn’t tell me anything (would be better to link to a
> >> website
> >> > > > > > instead).
> >> > > > > > > >
> >> > > > > > > > Personally, it might be better just to drop the section
> >> > entirely,
> >> > > > > since
> >> > > > > > > it will require maintenance, would end up with some
> subjective
> >> > > > criteria
> >> > > > > > > (leading to “why them and not us?”), and would need to be
> >> rotated
> >> > > as
> >> > > > > new
> >> > > > > > > apps are added to prevent a huge list of apps on the front
> >> page.
> >> > I
> >> > > > like
> >> > > > > > the
> >> > > > > > > idea, but maybe it would be better to have a Cordova App
> >> gallery
> >> > > > (akin
> >> > > > > to
> >> > > > > > > Plugin search, cocoapods, etc.)… but that could easily be
> done
> >> by
> >> > > the
> >> > > > > > > community, since we’re tight on resources as it is.
> >> > > > > > > >
> >> > > > > > > > That said, if we’re going to accept apps, we need some
> >> > > (reasonable)
> >> > > > > > > criteria for acceptance, along with the proviso that we
> won’t
> >> > > > > necessarily
> >> > > > > > > always feature the app (since we don’t want to end up
> featuring
> >> > > 1000
> >> > > > > apps
> >> > > > > > > on the front page).
> >> > > > > > > >
> >> > > > > > > > Some starting criteria:
> >> > > > > > > >
> >> > > > > > > > * Should currently be available for sale/download on the
> >> > > > appropriate
> >> > > > > > app
> >> > > > > > > stores.
> >> > > > > > > > * The product needs to have a website where we can link
> >> > > > (redirecting
> >> > > > > > > into iTunes is not ideal).
> >> > > > > > > > * The product should fit with Cordova’s CoC, since it’s
> being
> >> > > > > featured
> >> > > > > > > on the front page.
> >> > > > > > > > * The app itself should:
> >> > > > > > > > * be visually appealing and well designed (this is
> >> > > subjective,
> >> > > > > but
> >> > > > > > > no getting around that…)
> >> > > > > > > > * actually work (this would 

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/82
  
I rebased / merged this in. Thanks @janpio !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #82: README: Fix issue tracker link

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/82


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Accepting new apps into the App Showcase

[Filip Maj]

Is that concensus? Time to file an issue? I love :knife:'ing code

On Tue, Jul 25, 2017 at 11:21 PM, Tommy Williams  wrote:
> +1 to drop it
>
> On Wed, Jul 26, 2017 at 10:01 AM, Simon MacDonald > wrote:
>
>> +1 to drop it.
>>
>> Simon Mac Donald
>> http://simonmacdonald.com
>>
>> On Tue, Jul 25, 2017 at 7:00 PM, Shazron  wrote:
>>
>> > +1 drop it altogether.
>> > We can't be the arbiter of what's good or bad, and of course we don't
>> have
>> > the time nor desire to do so IMO.
>> >
>> > On Tue, Jul 25, 2017 at 2:32 PM, Steven Gill 
>> > wrote:
>> >
>> > > +1000 I was strongly against having an app showcase when it was
>> proposed
>> > > for the new site. Nobody ever wants to maintain it.
>> > >
>> > > On Tue, Jul 25, 2017 at 2:08 PM, Jesse 
>> wrote:
>> > >
>> > > > +1 to dropping it from cordova
>> > > > Let's just link to phonegap-showcase, onsenui-showcase and
>> > ionic-showcase
>> > > > pages ... I think we should focus on being the best engine and let
>> the
>> > > > downstreams do the marketing.
>> > > >
>> > > >
>> > > > @purplecabbage
>> > > > risingj.com
>> > > >
>> > > > On Tue, Jul 25, 2017 at 12:43 PM, julio cesar sanchez <
>> > > > jcesarmob...@gmail.com> wrote:
>> > > >
>> > > > > I liked Kerri's idea about only posting open source apps. I think
>> > users
>> > > > can
>> > > > > benefit of it.
>> > > > >
>> > > > > El 25 jul. 2017 7:52 p. m., "Joe Bowser" 
>> > escribió:
>> > > > >
>> > > > > > +1 to no longer supporting the Apps section.  Downstream projects
>> > get
>> > > > > more
>> > > > > > benefit from this than we do, IMO.
>> > > > > >
>> > > > > > On Tue, Jul 25, 2017 at 10:36 AM, Filip Maj 
>> > > wrote:
>> > > > > >
>> > > > > > > I'm of the opinion that we, the cordova devs are already
>> sinking
>> > > > under
>> > > > > > > the amount of incoming PRs and TODOs just with maintaining the
>> > > > > > > tooling, platforms, plugins, and docs.
>> > > > > > >
>> > > > > > > I think it would be better to turf it and let downstream
>> projects
>> > > do
>> > > > > > > that stuff if they wish. I think PhoneGap has one, so does
>> ionic.
>> > > > > > >
>> > > > > > > On Tue, Jul 25, 2017 at 9:58 AM, Kerri Shotts <
>> > > kerrisho...@gmail.com
>> > > > >
>> > > > > > > wrote:
>> > > > > > > > If we’re going to have an apps section on the website, it
>> would
>> > > be
>> > > > > good
>> > > > > > > to keep it updated. For example, the ReactEurope app goes to a
>> > 404
>> > > > > page.
>> > > > > > > Buildr navigates to an iTunes page that is not available in the
>> > US
>> > > > > > region,
>> > > > > > > so doesn’t tell me anything (would be better to link to a
>> website
>> > > > > > instead).
>> > > > > > > >
>> > > > > > > > Personally, it might be better just to drop the section
>> > entirely,
>> > > > > since
>> > > > > > > it will require maintenance, would end up with some subjective
>> > > > criteria
>> > > > > > > (leading to “why them and not us?”), and would need to be
>> rotated
>> > > as
>> > > > > new
>> > > > > > > apps are added to prevent a huge list of apps on the front
>> page.
>> > I
>> > > > like
>> > > > > > the
>> > > > > > > idea, but maybe it would be better to have a Cordova App
>> gallery
>> > > > (akin
>> > > > > to
>> > > > > > > Plugin search, cocoapods, etc.)… but that could easily be done
>> by
>> > > the
>> > > > > > > community, since we’re tight on resources as it is.
>> > > > > > > >
>> > > > > > > > That said, if we’re going to accept apps, we need some
>> > > (reasonable)
>> > > > > > > criteria for acceptance, along with the proviso that we won’t
>> > > > > necessarily
>> > > > > > > always feature the app (since we don’t want to end up featuring
>> > > 1000
>> > > > > apps
>> > > > > > > on the front page).
>> > > > > > > >
>> > > > > > > > Some starting criteria:
>> > > > > > > >
>> > > > > > > > * Should currently be available for sale/download on the
>> > > > appropriate
>> > > > > > app
>> > > > > > > stores.
>> > > > > > > > * The product needs to have a website where we can link
>> > > > (redirecting
>> > > > > > > into iTunes is not ideal).
>> > > > > > > > * The product should fit with Cordova’s CoC, since it’s being
>> > > > > featured
>> > > > > > > on the front page.
>> > > > > > > > * The app itself should:
>> > > > > > > > * be visually appealing and well designed (this is
>> > > subjective,
>> > > > > but
>> > > > > > > no getting around that…)
>> > > > > > > > * actually work (this would require someone downloading &
>> > > > testing
>> > > > > > > it. Paid apps would need to supply a review copy for free.)
>> > > > > > > > * be performant (no jank, quick response to user input,
>> > etc.)
>> > > > > > > > * be in production (not just a demo app)
>> > > > > > > > * be more than just wrapping a remote website
>> > > > > > > > * Plusses for (but not required):

[GitHub] cordova-plugin-inappbrowser pull request #232: InAppBrowser

[bernatch]

Github user bernatch closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #232: InAppBrowser

[bernatch]

GitHub user bernatch opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/232

InAppBrowser



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adriantodorov/cordova-plugin-inappbrowser 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit 571cfb5c2960a54c3d6e5762bb894030c8b0d392
Author: Adrian Todorov 
Date:   2016-01-14T16:51:53Z

Update InAppBrowser.java

commit bd1d494c0fef94add21316454757afd18307aa46
Author: Adrian Todorov 
Date:   2016-01-14T16:59:35Z

Update InAppBrowser.java

commit cca43163927b94bc0c3a1d7a5e640b7d6d8ffae1
Author: Adrian Todorov 
Date:   2016-01-14T17:02:40Z

Update InAppBrowser.java

commit 98714b08f26c5279900222367ec2c0ee5656be47
Author: Adrian Todorov 
Date:   2016-04-28T14:08:41Z

Hide the status bar

Hide the status Bar in InAppBrowser

commit 51207f4a643a07858f350f4ba0a847b7fe7c7891
Author: Adrian Todorov 
Date:   2016-04-28T14:28:09Z

Update InAppBrowser.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

[Shazron]

Thanks Darryl,
To make it easier, I've attached a Brisk [1] file so you can easily file
that bug report. Make sure you enter your credentials in the Brisk
preferences first before submitting. This will cross-post your bug report
to Apple and OpenRadar. OpenRadar is cross-posted to for visibility --
since your Apple bug report is private to you and Apple employees only.

Steps:
1. Install Brisk (instructions at  https://github.com/br1sk/brisk)
2. Launch Brisk
3. On the menubar, select Brisk -> Preferences... (menubar icon is an
ant-eater on a skateboard)
4. In the Apple Radar tab, Sign In with your developer Apple ID
5. In the Open Radar tab, enter your API key from http://openradar.me (Sign
In -> My API Key)
6. Download the attached .brisk file
7. Double-click on it
8. Press the "Submit" button

Let's produce a lot of dupes. Dupes are what brings an issue to the
forefront within Apple.

[1] https://github.com/br1sk/brisk

On Thu, Jul 27, 2017 at 11:31 AM, Darryl Pogue  wrote:

> I did a bit of digging in the WebKit sources last night, and it looks like
> the WebRTC/MediaCapture stuff is all gated behind a preference that's only
> accessible via a private API.  There was also a commit that mentioned
> something about apps needing to handle all the setup for A/V permissions.
>
> In any case, the result is that getUserMedia doesn't work in WKWebView,
> even on iOS11 :(
>
> I've filed a radar (rdar://33571214 and http://www.openradar.me/33571214)
> and
> encourage everyone else to do the same.
>
> On 27 July 2017 at 08:55, Filip Maj  wrote:
>
> > IIRC, it's not uncommon for the webview to lag behind Mobile Safari.
> >
> > On Wed, Jul 26, 2017 at 11:47 PM, Toplak Daniel 
> > wrote:
> > > He devs,
> > >
> > > Does anyone played with WebRTC on iOS?
> > >
> > > I get a test running only in Safari with iOS 11 Beta 4, but not in a
> > cordova app.
> > > Both WKWebView and UIWebView seems to have no support of WebRTC.
> > >
> > > I did not find any official thing from apple, besides what'*s new in
> > Safari 11: https://developer.apple.com/library/content/releasenotes/
> > General/WhatsNewInSafari/Safari_11_0/Safari_11_0.html
> > > They announce the WebRTC support.
> > >
> > > Grüße / Regards
> > > Daniel Toplak
> > > Head of Mobile Development
> > >
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/578#discussion_r129926425
  
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var rewire = require('rewire');
+var cordova_util = require('../../../src/cordova/util');
+var platform_getPlatformDetails = 
rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
+var events = require('cordova-common').events;
+var fail;
+
+describe('cordova/platform/getPlatformDetailsFromDir', function () {
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.name = 'io.cordova.hellocordova';
+package_json_mock.version = '1.0.0';
+
+beforeEach(function () {
+spyOn(Q, 'reject');
+spyOn(fs, 'existsSync');
+spyOn(cordova_util, 'requireNoCache');
+spyOn(events, 'emit');
+});
+
+it('should throw if no config.xml or pkgJson', function (done) {
+platform_getPlatformDetails('dir', ['ios']);
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a valid package.json or a valid Cordova platform/));
+done();
+});
+
+it('should throw if no platform is provided', function (done) {
+cordova_util.requireNoCache.and.returnValue({});
+platform_getPlatformDetails('dir');
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a Cordova platform:/));
+done();
+});
+
+it('should return a promise with platform and version', function 
(done) {
+fs.existsSync.and.callFake(function(filePath) {
+if(path.basename(filePath) === 'package.json') {
+return true;
+} else {
+return false;
+}
+});
+cordova_util.requireNoCache.and.returnValue(package_json_mock);
+platform_getPlatformDetails('dir', ['cordova-android'])
+.then(function(result) {
+expect(result.platform).toBe('io.cordova.hellocordova');
+expect(result.version).toBe('1.0.0');
+expect(Q.reject).not.toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {
+platform_getPlatformDetails.platformFromName('cordova-ios');
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
+
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
--- End diff --

You can take the expect from line 76 and combine it with line 74 and delete 
76. So line 74 gets replaced by line 76. Line 75 should still pass


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

[Darryl Pogue]

I did a bit of digging in the WebKit sources last night, and it looks like
the WebRTC/MediaCapture stuff is all gated behind a preference that's only
accessible via a private API.  There was also a commit that mentioned
something about apps needing to handle all the setup for A/V permissions.

In any case, the result is that getUserMedia doesn't work in WKWebView,
even on iOS11 :(

I've filed a radar (rdar://33571214 and http://www.openradar.me/33571214) and
encourage everyone else to do the same.

On 27 July 2017 at 08:55, Filip Maj  wrote:

> IIRC, it's not uncommon for the webview to lag behind Mobile Safari.
>
> On Wed, Jul 26, 2017 at 11:47 PM, Toplak Daniel 
> wrote:
> > He devs,
> >
> > Does anyone played with WebRTC on iOS?
> >
> > I get a test running only in Safari with iOS 11 Beta 4, but not in a
> cordova app.
> > Both WKWebView and UIWebView seems to have no support of WebRTC.
> >
> > I did not find any official thing from apple, besides what'*s new in
> Safari 11: https://developer.apple.com/library/content/releasenotes/
> General/WhatsNewInSafari/Safari_11_0/Safari_11_0.html
> > They announce the WebRTC support.
> >
> > Grüße / Regards
> > Daniel Toplak
> > Head of Mobile Development
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/584

CB-12361 : added tests for plugin/save.js



### Platforms affected


### What does this PR do?

 added tests for plugin/save.js

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-16-plugin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #584






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

[lunaru]

Github user lunaru commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/82
  
+1 for this change. I was confused by this as well when I was looking for 
the issue tracker.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: WebRTC (getUserMedia) in cordova-ios on iOS11

[Filip Maj]

IIRC, it's not uncommon for the webview to lag behind Mobile Safari.

On Wed, Jul 26, 2017 at 11:47 PM, Toplak Daniel  wrote:
> He devs,
>
> Does anyone played with WebRTC on iOS?
>
> I get a test running only in Safari with iOS 11 Beta 4, but not in a cordova 
> app.
> Both WKWebView and UIWebView seems to have no support of WebRTC.
>
> I did not find any official thing from apple, besides what'*s new in Safari 
> 11: 
> https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Safari_11_0/Safari_11_0.html
> They announce the WebRTC support.
>
> Grüße / Regards
> Daniel Toplak
> Head of Mobile Development
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
Ideally this kind of stuff lands across all major platforms in Cordova.

Generally, if something is not doable due to platform-specific 
restrictions, we, at the minimum, document it (via "Quirks" in our docs).

I think it's a judgment call by you. If it's not possible to do on Windows, 
or the implementation is very hard and would take long, then perhaps it is 
worth skipping one platform implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-android/pull/397
  
@filmaj, thanks for the information, I'm planning to merge in once Appveyor 
is fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
@filmaj, I would expand this section 
(https://github.com/apache/cordova-plugin-inappbrowser#more-usage-info) by 
adding samples with Data URIs.

But, for now, I found that this patch doesn't work on windows with data URI 
in case of using `_blank` target. Not sure, whether it supposed to work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...

[luissilvaos]

Github user luissilvaos commented on the issue:

https://github.com/apache/cordova-ios/pull/328
  
Yes, it is. Please check my last commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #231: CB-13028 (CI) Browser builds ...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/231

CB-13028 (CI) Browser builds on Travis and AppVeyor, Fixes tests on b…

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor and Travis to run tests on browser platform

### What testing has been done on this change?
See AppVeyor and Travis results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-inappbrowser CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #231


commit 72ac4d7eca06562193f89b42aa542f546ec22f16
Author: Alexander Sorokin 
Date:   2017-07-27T12:55:11Z

CB-13028 (CI) Browser builds on Travis and AppVeyor, Fixes tests on browser 
and browser implementation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request #59: CB-13028 (CI) Browser builds ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-globalization/pull/59


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

WebRTC (getUserMedia) in cordova-ios on iOS11

[Toplak Daniel]

He devs,

Does anyone played with WebRTC on iOS?

I get a test running only in Safari with iOS 11 Beta 4, but not in a cordova 
app.
Both WKWebView and UIWebView seems to have no support of WebRTC.

I did not find any official thing from apple, besides what'*s new in Safari 11: 
https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Safari_11_0/Safari_11_0.html
They announce the WebRTC support.

Grüße / Regards
Daniel Toplak
Head of Mobile Development

[GitHub] cordova-plugin-globalization pull request #59: CB-13028 (CI) Browser builds ...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-globalization/pull/59

CB-13028 (CI) Browser builds on Travis and AppVeyor

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor and Travis to run tests on browser platform

### What testing has been done on this change?
See AppVeyor and Travis results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-globalization 
CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-globalization/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #59


commit e9a2b1771549ef7e30ccb5edc424daa31d32aa70
Author: Alexander Sorokin 
Date:   2017-07-27T06:41:37Z

CB-13028 (CI) Browser builds on Travis and AppVeyor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #328: CB-13093: (iOS) Infinite looping when stressing navi...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/328
  
Thanks for the PR. Is this issue reproducible by a unit test? See 
https://github.com/apache/cordova-ios/blob/master/tests/CordovaLibTests/CDVWebViewDelegateTests.m


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

[shazron]

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/713#discussion_r129762417
  
--- Diff: www/docs/en/dev/guide/platforms/ios/webview.md ---
@@ -220,5 +222,16 @@ After using either of these two methods, continue with 
the **"Using CDVViewContr
 */
 viewController.wwwFolderName = @"myfolder";
 viewController.startPage = @"mypage.html"
-```
+    ```
+## Adding Plugins files used in you cordova project
--- End diff --

It's just that you skipped over all the parts of how they get the plugin 
source in the first place. That part is missing, since your steps assume a CLI 
workflow (assuming a Plugins folder and such).

In a CLI workflow, they just do "cordova plugin add". In an embedded 
webview workflow, how do they get it in without the CLI? This is the thing we 
haven't solved yet. By the way, just adding plugin source does not solve the 
problem totally, they have to add entries in config.xml, etc. It is not a 
trivial problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org