Re: [DISCUSS] InAppBrowser 4.0.0 major release
As far as I know, the versions are the minimum required to work, not the minimum supported by the plugin. But yeah, ideally we could set all of them to recent versions to make sure people don't use them in very old versions. For the record, not all plugins have engines or some have but not for all versions, and really don't know if they properly work. El jue., 4 jun. 2020 a las 19:40, Chris Brody () escribió: > The whole motivation behind adding the minimum Cordova engine version, in > the first place, seems to be here: > > https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L33 > > It says "Needs cordova/urlutil". > > I think we do not specify the minimum Cordova engine version on most of the > plugins, unfortunately don't have much time to check this right now. > > Whenever we do specify a minimum Cordova engine version, I would favor > specifying a version that is not excessively old such as 6 or 7. This is > analogous to the Node.js ecosystem where the node field in engines does > actually specify the minimum Node version it can work with. > > But yes, definitely should not update with the current Cordova version. > > Yeah, probably not worth blocking a release. I wish I had more time to help > with this kind of improvement. > > > On Thu, Jun 4, 2020 at 1:20 PM Niklas Merz wrote: > > > Correct me if I am wrong, but I don't think we want to update the > > dependency versions to the current ones. It's just another version we > > have to track and update. > > > > I must say I don't really know what they are for and would love to learn > > about that. > > > > The PR updates them to be consistent and working with a bare minimum > > like said in the PR with code checks. These old version numbers don't > > mean that these version have to be supported and compatible. If users > > have I issues we always advise to use the latest versions of everything. > > > > IMHO this shouldn't block a release. > > > > Am 04.06.20 um 17:14 schrieb Chris Brody: > > > I would favor updating the minimum Cordova requirement in both > > package.json > > > and plugin.xml, as I just commented in PR #685. I wish I would have > seen > > it > > > before PR #685 was merged. > > > > > > > > > On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz > > wrote: > > > > > >> I merged two outstanding patches just now. > > >> > > >> If no reviews or concern come up, I will start the release in a few > > hours. > > >> > > >> June 2, 2020 8:31 PM, "Niklas Merz" wrote: > > >> > > >>> Hi all, > > >>> > > >>> since cordova-ios 6.0 was released recently the inappbrowser plugin > > does > > >> not work properly because > > >>> of the removal of UIWebView. I would suggest we do a plugin *release > as > > >> soon as possible*. > > >>> > > >>> Since we already merged some major changes (including the UIWebview > > >> removal) this will be a major > > >>> release. > > >>> > > >>> Does anyone have a reason to delay the release? > > >>> > > >>> From my personal use of the plugin to pending PRs would be helpfull > for > > >> this release, but they need > > >>> reviews. I would not delay the release for them and proceed without > > >> merging them. > > >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688 > > >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656 > > >>> > > >>> Any other outstanding patches to land? > > >>> > > >>> If not, I will start the release tomorrow. > > >>> > > >>> - > > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > >>> For additional commands, e-mail: dev-h...@cordova.apache.org > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > >> For additional commands, e-mail: dev-h...@cordova.apache.org > > >> > > >> > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
Re: [DISCUSS] InAppBrowser 4.0.0 major release
The whole motivation behind adding the minimum Cordova engine version, in the first place, seems to be here: https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L33 It says "Needs cordova/urlutil". I think we do not specify the minimum Cordova engine version on most of the plugins, unfortunately don't have much time to check this right now. Whenever we do specify a minimum Cordova engine version, I would favor specifying a version that is not excessively old such as 6 or 7. This is analogous to the Node.js ecosystem where the node field in engines does actually specify the minimum Node version it can work with. But yes, definitely should not update with the current Cordova version. Yeah, probably not worth blocking a release. I wish I had more time to help with this kind of improvement. On Thu, Jun 4, 2020 at 1:20 PM Niklas Merz wrote: > Correct me if I am wrong, but I don't think we want to update the > dependency versions to the current ones. It's just another version we > have to track and update. > > I must say I don't really know what they are for and would love to learn > about that. > > The PR updates them to be consistent and working with a bare minimum > like said in the PR with code checks. These old version numbers don't > mean that these version have to be supported and compatible. If users > have I issues we always advise to use the latest versions of everything. > > IMHO this shouldn't block a release. > > Am 04.06.20 um 17:14 schrieb Chris Brody: > > I would favor updating the minimum Cordova requirement in both > package.json > > and plugin.xml, as I just commented in PR #685. I wish I would have seen > it > > before PR #685 was merged. > > > > > > On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz > wrote: > > > >> I merged two outstanding patches just now. > >> > >> If no reviews or concern come up, I will start the release in a few > hours. > >> > >> June 2, 2020 8:31 PM, "Niklas Merz" wrote: > >> > >>> Hi all, > >>> > >>> since cordova-ios 6.0 was released recently the inappbrowser plugin > does > >> not work properly because > >>> of the removal of UIWebView. I would suggest we do a plugin *release as > >> soon as possible*. > >>> > >>> Since we already merged some major changes (including the UIWebview > >> removal) this will be a major > >>> release. > >>> > >>> Does anyone have a reason to delay the release? > >>> > >>> From my personal use of the plugin to pending PRs would be helpfull for > >> this release, but they need > >>> reviews. I would not delay the release for them and proceed without > >> merging them. > >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688 > >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656 > >>> > >>> Any other outstanding patches to land? > >>> > >>> If not, I will start the release tomorrow. > >>> > >>> - > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > >> > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] InAppBrowser 4.0.0 major release
Correct me if I am wrong, but I don't think we want to update the dependency versions to the current ones. It's just another version we have to track and update. I must say I don't really know what they are for and would love to learn about that. The PR updates them to be consistent and working with a bare minimum like said in the PR with code checks. These old version numbers don't mean that these version have to be supported and compatible. If users have I issues we always advise to use the latest versions of everything. IMHO this shouldn't block a release. Am 04.06.20 um 17:14 schrieb Chris Brody: > I would favor updating the minimum Cordova requirement in both package.json > and plugin.xml, as I just commented in PR #685. I wish I would have seen it > before PR #685 was merged. > > > On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz wrote: > >> I merged two outstanding patches just now. >> >> If no reviews or concern come up, I will start the release in a few hours. >> >> June 2, 2020 8:31 PM, "Niklas Merz" wrote: >> >>> Hi all, >>> >>> since cordova-ios 6.0 was released recently the inappbrowser plugin does >> not work properly because >>> of the removal of UIWebView. I would suggest we do a plugin *release as >> soon as possible*. >>> >>> Since we already merged some major changes (including the UIWebview >> removal) this will be a major >>> release. >>> >>> Does anyone have a reason to delay the release? >>> >>> From my personal use of the plugin to pending PRs would be helpfull for >> this release, but they need >>> reviews. I would not delay the release for them and proceed without >> merging them. >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688 >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656 >>> >>> Any other outstanding patches to land? >>> >>> If not, I will start the release tomorrow. >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] InAppBrowser 4.0.0 major release
I would favor updating the minimum Cordova requirement in both package.json and plugin.xml, as I just commented in PR #685. I wish I would have seen it before PR #685 was merged. On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz wrote: > I merged two outstanding patches just now. > > If no reviews or concern come up, I will start the release in a few hours. > > June 2, 2020 8:31 PM, "Niklas Merz" wrote: > > > Hi all, > > > > since cordova-ios 6.0 was released recently the inappbrowser plugin does > not work properly because > > of the removal of UIWebView. I would suggest we do a plugin *release as > soon as possible*. > > > > Since we already merged some major changes (including the UIWebview > removal) this will be a major > > release. > > > > Does anyone have a reason to delay the release? > > > > From my personal use of the plugin to pending PRs would be helpfull for > this release, but they need > > reviews. I would not delay the release for them and proceed without > merging them. > > https://github.com/apache/cordova-plugin-inappbrowser/pull/688 > > https://github.com/apache/cordova-plugin-inappbrowser/pull/656 > > > > Any other outstanding patches to land? > > > > If not, I will start the release tomorrow. > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] InAppBrowser 4.0.0 major release
I merged two outstanding patches just now. If no reviews or concern come up, I will start the release in a few hours. June 2, 2020 8:31 PM, "Niklas Merz" wrote: > Hi all, > > since cordova-ios 6.0 was released recently the inappbrowser plugin does not > work properly because > of the removal of UIWebView. I would suggest we do a plugin *release as soon > as possible*. > > Since we already merged some major changes (including the UIWebview removal) > this will be a major > release. > > Does anyone have a reason to delay the release? > > From my personal use of the plugin to pending PRs would be helpfull for this > release, but they need > reviews. I would not delay the release for them and proceed without merging > them. > https://github.com/apache/cordova-plugin-inappbrowser/pull/688 > https://github.com/apache/cordova-plugin-inappbrowser/pull/656 > > Any other outstanding patches to land? > > If not, I will start the release tomorrow. > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Splashscreen Plugin Release 5.0.4
I vote +1: * Ran npm test (on linux) * Ran verify-tags * Ran verify-archive On 2020-06-03 3:21 p.m., Niklas Merz wrote: (sending again because previous email was attached to discuss thread) Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/ The packages were published from their corresponding git tags: cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md How to vote on a plugins release at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Did the tests with Xcode like instructed Please note some CI test could fail but I think the test setup is faulty. Works locally in Xcode for me. Let me know in DISCUSS. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Splashscreen Plugin Release 5.0.4
I guess Erisu sorted this out in https://github.com/apache/cordova-plugin-splashscreen/pull/266 There are a couple of reasons for the fail we think, mostly because pandemic tests only tests against the master. So in this case, it was using cordova-ios 6, which expects Xcode 11, and drops support for iOS less than 11. Splashscreen tests were configured to use iPhone 5, which can only go up to iOS 10. So the travis was failing basically because cordova-ios@6 stuff was merged into master. A formal +1 vote is incoming. On 2020-06-04 3:03 a.m., Niklas Merz wrote: I must say I don't really understand that failure, too. I think it's something strange in the CI/Travis. (Hopefully this will be on Github Actions, too sometime). CI uses Xcode 10.3 which is not supported by our latests cordova-ios anymore. I think we should not rely on the CI tests for this quick release, and fix them for the new major version that follows very soon. The tests work fine locally after changeing the simulator to one I have installed. The line that failed looks different with "x86_64" Ld /tmp/CDVSplashScreenLibTests.xctest/CDVSplashScreenLibTests normal x86_64 (in target 'CDVSplashScreenLibTests' from project 'CDVSplashScreenTest') CI seems to run in 32 bit which produces this error: >warning: ignoring file /tmp/libCordova.a, file was built for archive which is not the architecture being linked (i386): /tmp/libCordova.a June 4, 2020 2:18 AM, "Norman Breau" wrote: We probably should resolve the travis issue, just to be sure it isn't hiding some other error. ld: warning: ignoring file /tmp/libCordova.a, file was built for archive which is not the architecture being linked (i386): /tmp/libCordova.a 658Undefined symbols for architecture i386: 659"_OBJC_CLASS_$_CDVPlugin", referenced from: 660_OBJC_CLASS_$_CDVSplashScreen in libCDVSplashScreenLib.a(CDVSplashScreen.o) 661"_CDVPageDidLoadNotification", referenced from: 662-[CDVSplashScreen pluginInitialize] in libCDVSplashScreenLib.a(CDVSplashScreen.o) 663"_OBJC_METACLASS_$_CDVPlugin", referenced from: 664_OBJC_METACLASS_$_CDVSplashScreen in libCDVSplashScreenLib.a(CDVSplashScreen.o) 665ld: symbol(s) not found for architecture i386 666clang: error: linker command failed with exit code 1 (use -v to see invocation) Unfortunately I'm not very well knowledgeable on iOS development, but it does seem some kind of configuration issue. On 2020-06-03 2:28 p.m., Niklas Merz wrote: Seems like we are good to go for this plugin. I will start the release now! Am 02.06.20 um 20:39 schrieb Niklas Merz: Hi all, Since cordova-ios 6.0, which includes a splashscreen implementation, was released recently, we should release a patch version of the splashscreen plugin which sets the version requirements correctly [1]. Does anyone have any reason to delay this patch release? Any outstanding patches to land? If not, I will start the release tomorrow. After this patch release we will introduce some some breaking changes including the removal of iOS code in a major release after that. The PRs are already open. [1] https://github.com/apache/cordova-plugin-splashscreen/pull/261 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[ANNOUNCEMENT] Cordova iOS 6.0.0 Release
We have just released a major update to our ios platform! - cordova-ios@6.0.0 You can view the release blog post at https://cordova.apache.org/announcements/2020/06/01/cordova-ios-release-6.0.0.html - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[ANNOUNCEMENT] Cordova Tooling Release
We have just released a major update and patch release to our cordova tooling! - cordova-common@4.0.1 (2020-05-19) - cordova-node-xcode@3.0.1 (2020-05-19) - cordova-create@3.0.0 You can view the release blog post at https://cordova.apache.org/news/2020/06/01/tools-release.html - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Splashscreen Plugin Release 5.0.4
I must say I don't really understand that failure, too. I think it's something strange in the CI/Travis. (Hopefully this will be on Github Actions, too sometime). CI uses Xcode 10.3 which is not supported by our latests cordova-ios anymore. I think we should not rely on the CI tests for this quick release, and fix them for the new major version that follows very soon. The tests work fine locally after changeing the simulator to one I have installed. The line that failed looks different with "x86_64" > Ld /tmp/CDVSplashScreenLibTests.xctest/CDVSplashScreenLibTests normal x86_64 > (in target 'CDVSplashScreenLibTests' from project 'CDVSplashScreenTest') CI seems to run in 32 bit which produces this error: >warning: ignoring file /tmp/libCordova.a, file was built for archive which is >not the architecture being linked (i386): /tmp/libCordova.a June 4, 2020 2:18 AM, "Norman Breau" wrote: > We probably should resolve the travis issue, just to be sure it isn't hiding > some other error. > > ld: warning: ignoring file /tmp/libCordova.a, file was built for archive > which is not the > architecture being linked (i386): /tmp/libCordova.a > 658Undefined symbols for architecture i386: > 659"_OBJC_CLASS_$_CDVPlugin", referenced from: > 660_OBJC_CLASS_$_CDVSplashScreen in libCDVSplashScreenLib.a(CDVSplashScreen.o) > 661"_CDVPageDidLoadNotification", referenced from: > 662-[CDVSplashScreen pluginInitialize] in > libCDVSplashScreenLib.a(CDVSplashScreen.o) > 663"_OBJC_METACLASS_$_CDVPlugin", referenced from: > 664_OBJC_METACLASS_$_CDVSplashScreen in > libCDVSplashScreenLib.a(CDVSplashScreen.o) > 665ld: symbol(s) not found for architecture i386 > 666clang: error: linker command failed with exit code 1 (use -v to see > invocation) > > Unfortunately I'm not very well knowledgeable on iOS development, but it does > seem some kind of > configuration issue. > > On 2020-06-03 2:28 p.m., Niklas Merz wrote: > >> Seems like we are good to go for this plugin. I will start the release now! >> >> Am 02.06.20 um 20:39 schrieb Niklas Merz: >>> Hi all, >>> >>> Since cordova-ios 6.0, which includes a splashscreen implementation, was >>> released recently, we >>> should release a patch version of the splashscreen plugin which sets the >>> version requirements >>> correctly [1]. >>> >>> Does anyone have any reason to delay this patch release? >>> Any outstanding patches to land? >>> >>> If not, I will start the release tomorrow. >>> >>> After this patch release we will introduce some some breaking changes >>> including the removal of iOS >>> code in a major release after that. The PRs are already open. >>> >>> [1] https://github.com/apache/cordova-plugin-splashscreen/pull/261 >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
