Re: Reactive Streams dependency in Project Reactor module

2018-02-05 Thread Sergey Beryozkin
Hi John I think I indeed sent some confusing messages yesterday :-) OK, what I meant was that the module had the original code to do with supporting the client only Rx invocations (such a client code can be server scoped as in your example), and the server only invocations (Json subcriber).

Re: Reactive Streams dependency in Project Reactor module

2018-02-04 Thread John D. Ament
Well, now that I understand that it was meant specifically for client only (its kind of odd, because JsonStreamingAsyncSubscriber is really for subscribers, which is more on the server produced response). What if we just had distinct modules for reactive-client and reactive-server? But either way

Re: Reactive Streams dependency in Project Reactor module

2018-02-04 Thread Sergey Beryozkin
The same though applies to the client code - it makes no sense on the server side, so may be it is just simpler to make that dep non-optional for the consistency purpose, up to you guys... Sergey On 04/02/18 18:57, Sergey Beryozkin wrote: You've already concluded it is a bug... I recall now,

Re: Reactive Streams dependency in Project Reactor module

2018-02-04 Thread Sergey Beryozkin
You've already concluded it is a bug... I recall now, I made it optional because that code makes no sense on the client side only, while the reactive streams api is also pulled from the reactor dep... Cheers, Sergey On 04/02/18 18:12, Andriy Redko wrote: Same conclusion, it shouldn't be opti

Re: Reactive Streams dependency in Project Reactor module

2018-02-04 Thread Andriy Redko
Same conclusion, it shouldn't be optional/provided. Thanks for spotting it. Best Regards, Andriy Redko JDA> That's what I'm asking basically. If you look at JDA> https://github.com/apache/cxf/blob/master/rt/rs/extensions/reactor/pom.xml#L47-L49 JDA> I JDA> don't believe it should be provide

Re: Reactive Streams dependency in Project Reactor module

2018-02-04 Thread John D. Ament
That's what I'm asking basically. If you look at https://github.com/apache/cxf/blob/master/rt/rs/extensions/reactor/pom.xml#L47-L49 I don't believe it should be provided/optional. On Sun, Feb 4, 2018 at 12:49 PM Sergey Beryozkin wrote: > Why should be optional ? > > Sergey > On 04/02/18 14:00,

Reactive Streams dependency in Project Reactor module

2018-02-04 Thread John D. Ament
Hi, As far as I can tell, the dependency on reactive streams isn't optional in the project reactor module. I'm wondering, was this just a typo, or am I missing something? John