Re: [GitHub] [daffodil] stevedlawrence commented on pull request #567: Update scala-library, scala-reflect to 2.13.6

2021-05-18 Thread Beckerle, Mike
Is scala reflect 2.13.6 actually about scala 2.13, or is it just a coincidence of the numbering that their sub-version number just rolled up to 13? From: GitBox Sent: Tuesday, May 18, 2021 12:55 PM To: comm...@daffodil.apache.org Subject: [GitHub] [daffodil]

Re: [GitHub] [daffodil] stevedlawrence commented on pull request #567: Update scala-library, scala-reflect to 2.13.6

2021-05-18 Thread Steve Lawrence
According to the scala-relfect pom [1], scala-reflect 2.13.6 depends on scala-library 2.13.6, so I think it's the same as scala 2.13 and they need to be upgraded together. I'd guess that scala-reflect is split into a separate jar because it's still considered experimental. [1]

224 legacy Resolved Daffodil JIRA tickets

2021-05-18 Thread Thompson, Dave
All, There are currently 224 Daffodil JIRA tickets resolved in previous releases, all but 2 from v2.5.0 (1/2/2020) and earlier. I want to check with the group to see if it would be acceptable to close these tickets with "Closed due to no activity." Any other suggestions would be appreciated.

Re: Windows debug clues needed

2021-05-18 Thread Beckerle, Mike
So some of these errors seem to be font & charset related. I installed the japanese language pack, so I have unicode character capability, but perhaps I have to set something up to tell it to use unicode and a sensible font which has the Kanji characters that are in our tests, for example.

Re: Windows debug clues needed

2021-05-18 Thread Steve Lawrence
I'm not sure where it exists on windows, but if you run git config --global core.autocrlf true then it should enable it globally. I think you could also try reinstallting git for Windows. Last I installed git on Windows (a long time ago) I think the installer let me pick how to handle line

Re: Windows debug clues needed

2021-05-18 Thread Beckerle, Mike
The XML comments was definitely part of it. Found that one and fixed it with the override def comment(..) as you suggest. There are still other tests failing though. I have been spinning up a windows dev environment and I noticed that the comments contain CRLFs on windows, and likely due to

Re: Windows debug clues needed

2021-05-18 Thread Steve Lawrence
Finished the review and I didn't find anything, but I just noticed that some of the failed TMDL tests have infosets that include comments, that include newlines. I'm guessing these comments aren't stripped out by the loader and also aren't normalized. So when git autocrlf kicks in, it changes

[RESULT][VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-18 Thread Steve Lawrence
The VOTE to release Apache Daffodil 3.1.0-rc2 is now closed. The vote passes with 7 +1 votes, and NO -1 votes. The VOTE thread: https://lists.apache.org/thread.html/r9a3d0a52f863b29db3c0b3c1e5b212f72b5fc1074510f38697f4449a%40%3Cdev.daffodil.apache.org%3E +1's were: John Interrante (binding)

Re: [VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-18 Thread Olabusayo Kilo
+1 I checked: [OK] links in email are correct [OK] verified Summary of Changes pages (maven, sbt and download) [OK] JavaDoc and ScalaDoc are correct [OK] RAT check passes On 5/14/21 3:26 PM, Steve Lawrence wrote: Hi all, I'd like to call a vote to release Apache Daffodil 3.1.0-rc2. All

RE: [VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-18 Thread Thompson, Dave
Vote +1 Verified and closed all "Resolved" v3.1.0 JIRA tickets. Verified all Daffodil sub-project SBT test suites execute successfully. Verified all nightly performance test schemas compile and save successfully on java 8, 11 and 16. Verified the nightly performance test suite successfully

Re: [VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-18 Thread Steve Lawrence
I've talked to a couple others that are still reviewing and planning to vote. Just giving a chance for extra votes to come in and make sure there are no issues. Especially since much of the 72 hours was over the weekend and people may not have had time yesterday. On 5/18/21 9:24 AM, Interrante,

[VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-18 Thread Interrante, John A (GE Research, US)
More than 72 hours have passed and we're up to 5 +1's now with no 0's or -1's. When will the release come out? :-) John -Original Message- From: John Wass Sent: Tuesday, May 18, 2021 8:55 AM To: dev@daffodil.apache.org Subject: EXT: Re: [VOTE] Release Apache Daffodil 3.1.0-rc2 +1 I

Re: Windows debug clues needed

2021-05-18 Thread Steve Lawrence
I'm reviewing the PR now, I'll let you know if I see anything that jumps out at me. My guess is this probably an autocrlf issue. It's possible your windows git installation didn't set this to true so git isn't replacing LF with CRLF. If you change the core.autocrlf git config option to true and

Windows debug clues needed

2021-05-18 Thread Beckerle, Mike
My PR https://github.com/apache/daffodil/pull/560 Keeps failing its tests on MS-Windows. I am unable to reproduce the failures on Linux obviously. But... I am also unable to reproduce these failures on MS-Windows. I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. When I

Re: [VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-18 Thread John Wass
+1 I checked [OK] RPM install in centos 8 and fedora 32 [OK] spot check schematron validation and svrl output [OK] misc CLI operations [OK] hash of each download matches [OK] rat check passes [OK] use of staged artifacts in existing applications On Fri, May 14, 2021 at 3:26 PM Steve Lawrence