Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984925
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/util/Utils.java ---
@@ -445,35 +440,35 @@ public void processResult
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984863
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/metadata/MetadataUpdater.java
---
@@ -56,7 +56,7
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984852
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/metadata/LogStreamMetadataStore.java
---
@@ -59,7 +59,7
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984844
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/metadata/LogSegmentMetadataStoreUpdater.java
---
@@ -73,7 +72,7
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984837
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/logsegment/LogSegmentEntryStore.java
---
@@ -58,7 +57,7
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984828
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/lock/ZKSessionLock.java
---
@@ -1088,9 +1063,9 @@ public String
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984799
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/impl/metadata/ZKLogStreamMetadataStore.java
---
@@ -237,15 +227,13
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984772
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/impl/logsegment/BKLogSegmentEntryStore.java
---
@@ -186,13 +185,13
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984743
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/impl/ZKLogSegmentMetadataStore.java
---
@@ -350,40 +349,40
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984733
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/bk/SimpleLedgerAllocator.java
---
@@ -105,73 +103,71 @@ public
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984686
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BookKeeperClient.java
---
@@ -198,52 +196,52 @@ public
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984676
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKLogWriteHandler.java
---
@@ -483,23 +482,23 @@ protected long
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984610
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKLogHandler.java
---
@@ -397,15 +398,15 @@ private Long sum(List
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984594
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKDistributedLogManager.java
---
@@ -525,75 +495,63 @@ public
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984515
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKAsyncLogWriter.java
---
@@ -206,7 +197,7 @@ private
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984462
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKAsyncLogReader.java
---
@@ -404,7 +392,7 @@ public String
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984456
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKAsyncLogReader.java
---
@@ -381,16 +369,16 @@ public String
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984432
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKAbstractLogWriter.java
---
@@ -357,80 +354,72 @@ private void
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/130#discussion_r117600405
--- Diff:
distributedlog-core/src/test/java/org/apache/distributedlog/TestBKDistributedLogNamespace.java
---
@@ -143,7 +172,7 @@ public
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/130#discussion_r117600348
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/util/DLUtils.java
---
@@ -281,41 +281,89 @@ public static boolean
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/130#discussion_r117600036
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/util/DLUtils.java
---
@@ -281,41 +281,89 @@ public static boolean
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/116
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/109
+1
Thanks for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/125
there seems an flaky test error not related with this issue.
```
Stacktrace
java.lang.AssertionError: Write should not fail before closing
at
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/128
+1 Thanks for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/127
+1 Thanks for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jiazhai opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/124
DL-195: exclude DISCLAIMER.bin.txt for Apache Rat Check Failures
"mvn apache-rat:check package findbugs:check -DskipTests" would fail with
report:
```
[ERROR]
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/123
Thanks for the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/108
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/21#discussion_r89146667
--- Diff:
distributedlog-core/src/main/java/com/twitter/distributedlog/EnvelopedEntry.java
---
@@ -254,21 +253,22 @@ private void read
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/43
Is there a test case for it?
So we would know a little of the use-case for DLFS.
:)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/21#discussion_r85869899
--- Diff:
distributedlog-core/src/main/java/com/twitter/distributedlog/BKLogSegmentWriter.java
---
@@ -17,27 +17,18
Github user jiazhai commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/10
Thanks a lot for all of your help and review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jiazhai opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/10
DL-1: Clean up the distributedlog pom files
- changed the version to 0.4.0-incubating
- changed names to include 'Apache DistributedLog' and use '::' as
34 matches
Mail list logo
