[GitHub] drill pull request: DRILL-4479: Use varchar for default column whe...

2016-03-08 Thread amansinha100
GitHub user amansinha100 opened a pull request: https://github.com/apache/drill/pull/420 DRILL-4479: Use varchar for default column when all_text_mode is enab… …led. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (DRILL-4492) TestMergeJoinWithSchemaChanges depends on order files in a directory are read to pass, should be refactored

2016-03-08 Thread Jason Altekruse (JIRA)
Jason Altekruse created DRILL-4492: -- Summary: TestMergeJoinWithSchemaChanges depends on order files in a directory are read to pass, should be refactored Key: DRILL-4492 URL:

[GitHub] drill pull request: DRILL-4491: FormatPluginOptionsDescriptor requ...

2016-03-08 Thread adityakishore
Github user adityakishore commented on the pull request: https://github.com/apache/drill/pull/418#issuecomment-194097775 Until I looked at the code, I was under assumption that we are using Jackson to extract the serializable properties. We can, and should, definitely go that route.

[GitHub] drill pull request: DRILL-4482: Avro subselection broken by 4382

2016-03-08 Thread StevenMPhillips
Github user StevenMPhillips commented on the pull request: https://github.com/apache/drill/pull/419#issuecomment-194060258 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4482: Avro subselection broken by 4382

2016-03-08 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/419 DRILL-4482: Avro subselection broken by 4382 This fix includes a number of test updates to ensure Avro files are being read correctly. The branch includes 4441, which is on a different

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Time for the 1.6 Release

2016-03-08 Thread Parth Chandra
Okay we are down to the final one - DRILL-4482 - Avro no longer selects data correctly from a sub-structure.(Jason) Note that MapR QA team is going to start testing 1.6 snapshot now before I roll out the release candidate. DRILL-4482 can be merged in later as it is not likely to affect the

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4491: FormatPluginOptionsDescriptor requ...

2016-03-08 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/418#issuecomment-194049783 Is there a way to ask Jackson to look at a POJO and give you what it considers to be the serializable fields? This isn't quite the right fix because it is valid to

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/416#discussion_r55457004 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -117,6 +117,24 @@ public void

[GitHub] drill pull request: DRILL-4491: FormatPluginOptionsDescriptor requ...

2016-03-08 Thread adityakishore
GitHub user adityakishore opened a pull request: https://github.com/apache/drill/pull/418 DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfig… … fields to be public You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/416#issuecomment-194042039 Overall, LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (DRILL-4491) FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public

2016-03-08 Thread Aditya Kishore (JIRA)
Aditya Kishore created DRILL-4491: - Summary: FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public Key: DRILL-4491 URL: https://issues.apache.org/jira/browse/DRILL-4491

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/416#discussion_r55455931 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -117,6 +117,24 @@ public void

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/416#discussion_r55455592 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -117,6 +117,24 @@ public void

[GitHub] drill pull request: DRILL-4485 - MapR profile - switch to MapR 5.1...

2016-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/416#discussion_r55454105 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -117,6 +117,24 @@ public void

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/416#discussion_r55453543 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -117,6 +117,24 @@ public void

[GitHub] drill pull request: DRILL-4485 - MapR profile - switch to MapR 5.1...

2016-03-08 Thread pwong-mapr
GitHub user pwong-mapr opened a pull request: https://github.com/apache/drill/pull/417 DRILL-4485 - MapR profile - switch to MapR 5.1.0, and improve compatibility with maprfs storage format and MapR DB storage plugin You can merge this pull request into a Git repository by

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
GitHub user jinfengni opened a pull request: https://github.com/apache/drill/pull/416 DRILL-4474: Ensure that ConvertCountToDirectScan does not push through project when nullable input of count is not RexInputRef You can merge this pull request into a Git repository by running:

[GitHub] drill pull request: DRILL-4485 - switch to MapR 5.1.0

2016-03-08 Thread pwong-mapr
Github user pwong-mapr closed the pull request at: https://github.com/apache/drill/pull/413 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (DRILL-4490) Count(*) function returns as optional instead of required

2016-03-08 Thread Krystal (JIRA)
Krystal created DRILL-4490: -- Summary: Count(*) function returns as optional instead of required Key: DRILL-4490 URL: https://issues.apache.org/jira/browse/DRILL-4490 Project: Apache Drill Issue

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/406#discussion_r5563 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -103,6 +104,10 @@ public void

Re: Drill Hangout Today?

2016-03-08 Thread Jason Altekruse
Meeting notes - Hangout 3/8/2016 Parth, Aman, John O., Jason, Zelaine - release - 4474 - incorect direct scans, MapR will run regression tests - Avro issues, one is ready, had a +1 there is just an update for a related issue - the other one Jason was having an issue with

[jira] [Created] (DRILL-4489) Add ValueVector tests from Drill

2016-03-08 Thread Steven Phillips (JIRA)
Steven Phillips created DRILL-4489: -- Summary: Add ValueVector tests from Drill Key: DRILL-4489 URL: https://issues.apache.org/jira/browse/DRILL-4489 Project: Apache Drill Issue Type: Bug

Re: UnrecognizedPropertyException: Unrecognized field "config" (class org.apache.drill.exec.store.dfs.FileSystemConfig), not marked as ignorable (4 known properties: "enabled", "formats", "connection"

2016-03-08 Thread Abhishek Girish
You mentioned you were able to successfully run queries now, right? I tried on the latest build and on MapR Drill RPM - don't see any issues. So this might have been a one-off issue. If you happen to reproduce it again, we could investigate this further. On Tue, Mar 8, 2016 at 10:11 AM, Khurram

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/406#issuecomment-193971973 Agree with @jinfengni that the current fix can cause performance regression for simpler count queries. I will change my review to -1 and let's see how to get the

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/406#discussion_r55428219 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -103,6 +104,10 @@ public void

[GitHub] drill pull request: DRILL-4487: add unit test for DRILL-4449

2016-03-08 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/414#issuecomment-193960370 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/406#discussion_r55422075 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -103,6 +104,10 @@ public void

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

2016-03-08 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/406#discussion_r55421789 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java --- @@ -103,6 +104,10 @@ public void

[jira] [Created] (DRILL-4488) Prefix "-" cause failure (NPE) in constant folding

2016-03-08 Thread Sean Hsuan-Yi Chu (JIRA)
Sean Hsuan-Yi Chu created DRILL-4488: Summary: Prefix "-" cause failure (NPE) in constant folding Key: DRILL-4488 URL: https://issues.apache.org/jira/browse/DRILL-4488 Project: Apache Drill

[GitHub] drill pull request: DRILL-4184: support variable length decimal fi...

2016-03-08 Thread daveoshinsky
Github user daveoshinsky commented on a diff in the pull request: https://github.com/apache/drill/pull/372#discussion_r55417098 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java --- @@ -69,11 +73,16 @@

Re: On improving project maintainence

2016-03-08 Thread John Omernik
I've been meaning to respond to this (Even have the spreadsheet still open) I want to volunteer to do more list responding. Not sure what I have for time commitment, but in general, I want to be more helpful to user questions etc. We could also start to evaluate some of the response we get and

[GitHub] drill pull request: DRILL-4474: Use varchar for default column whe...

2016-03-08 Thread amansinha100
Github user amansinha100 closed the pull request at: https://github.com/apache/drill/pull/415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-4474: Use varchar for default column whe...

2016-03-08 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/415#issuecomment-193901238 oops ... sorry, closing this and will reopen against the correct JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Drill Hangout Today?

2016-03-08 Thread Parth Chandra
Joining in a minute On Tue, Mar 8, 2016 at 10:17 AM, Jason Altekruse wrote: > For anyone else interested in joining the hangout here is the link. > > https://plus.google.com/hangouts/_/dremio.com/drillhangout?authuser=1 > > On Tue, Mar 8, 2016 at 10:15 AM, Jason

Re: Drill Hangout Today?

2016-03-08 Thread Jason Altekruse
For anyone else interested in joining the hangout here is the link. https://plus.google.com/hangouts/_/dremio.com/drillhangout?authuser=1 On Tue, Mar 8, 2016 at 10:15 AM, Jason Altekruse wrote: > Yes, sorry I forgot to sign on. > > Can you try to join again? > > On

Re: Drill Hangout Today?

2016-03-08 Thread Jason Altekruse
Yes, sorry I forgot to sign on. Can you try to join again? On Tue, Mar 8, 2016 at 10:10 AM, Zelaine Fong wrote: > Are we having one today? We're trying to connect from the MapR end, but > not getting a response. > > -- Zelaine >

Re: UnrecognizedPropertyException: Unrecognized field "config" (class org.apache.drill.exec.store.dfs.FileSystemConfig), not marked as ignorable (4 known properties: "enabled", "formats", "connection"

2016-03-08 Thread Khurram Faraaz
I am running against MapR rpm. I did not build from source. This is the RPM that was used mapr-drill-1.6.0.201603072015-1.noarch.rpm On Tue, Mar 8, 2016 at 11:34 PM, Abhishek Girish wrote: > Khurram, > > Can you confirm if this issue is specific to MapR RPMs or is seen with >

Drill Hangout Today?

2016-03-08 Thread Zelaine Fong
Are we having one today? We're trying to connect from the MapR end, but not getting a response. -- Zelaine

Re: UnrecognizedPropertyException: Unrecognized field "config" (class org.apache.drill.exec.store.dfs.FileSystemConfig), not marked as ignorable (4 known properties: "enabled", "formats", "connection"

2016-03-08 Thread Abhishek Girish
Khurram, Can you confirm if this issue is specific to MapR RPMs or is seen with latest builds as well? -Abhishek On Tue, Mar 8, 2016 at 9:22 AM, Khurram Faraaz wrote: > Thanks Jason. Here is what I did before I hit the Exception > > clush -g khurram rpm -e mapr-drill

[GitHub] drill pull request: DRILL-4474: Use varchar for default column whe...

2016-03-08 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/415#issuecomment-193884035 Could you also close this PR and open a new one? the JIRA number was wrong in your commit so this is posting to the JIRA about incorrect creation if direct scans. The

[GitHub] drill pull request: DRILL-4474: Use varchar for default column whe...

2016-03-08 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/415#issuecomment-193880193 Can you generate the test file as part of the test rather than check in static? --- If your project is set up for it, you can reply to this email and have your reply

Re: Time for the 1.6 Release

2016-03-08 Thread Parth Chandra
OK, let's leave it out then. On Tue, Mar 8, 2016 at 9:25 AM, Jason Altekruse wrote: > To be honest I was expecting a longer review cycle so I hadn't run the unit > tests before posting it for review. There were only very minor functional > changes, so I wasn't thinking

[GitHub] drill pull request: DRILL-4474: Use varchar for default column whe...

2016-03-08 Thread amansinha100
GitHub user amansinha100 opened a pull request: https://github.com/apache/drill/pull/415 DRILL-4474: Use varchar for default column when all_text_mode is enab… …led. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill pull request: DRILL-4487: add unit test for DRILL-4449

2016-03-08 Thread adeneche
GitHub user adeneche opened a pull request: https://github.com/apache/drill/pull/414 DRILL-4487: add unit test for DRILL-4449 @amansinha100 can you please review ? thanks You can merge this pull request into a Git repository by running: $ git pull

Re: Time for the 1.6 Release

2016-03-08 Thread Parth Chandra
Sounds good Jason. Let's finalize this in the hangout. Do you have the expected plans for the failing tests? If so can you update those and put in a pull request and we'll merge and run the tests. Any reason for the operator test framework to be punted? You have a +1 to merge it. On Mon, Mar 7,

[jira] [Resolved] (DRILL-4313) C++ client - Improve method of drillbit selection from cluster

2016-03-08 Thread Parth Chandra (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Chandra resolved DRILL-4313. -- Resolution: Fixed Fixed in df0f0af3d963c1b65eb01c3141fe84532c53f5a5 > C++ client - Improve

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

2016-03-08 Thread parthchandra
Github user parthchandra commented on the pull request: https://github.com/apache/drill/pull/396#issuecomment-193864509 Merged in df0f0af3d963c1b65eb01c3141fe84532c53f5a5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

2016-03-08 Thread parthchandra
Github user parthchandra closed the pull request at: https://github.com/apache/drill/pull/396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Resolved] (DRILL-4332) tests in TestFrameworkTest fail in Java 8

2016-03-08 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-4332. Resolution: Fixed Fix Version/s: (was: Future) 1.6.0 Fixed in

[jira] [Resolved] (DRILL-4486) Expression serializer incorrectly serializes escaped characters

2016-03-08 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-4486. Resolution: Fixed Fix Version/s: 1.6.0 Fixed in

[jira] [Resolved] (DRILL-4375) Fix the maven release profile, broken by jdbc jar size enforcer added in DRILL-4291

2016-03-08 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-4375. Resolution: Fixed Fix Version/s: 1.6.0 Fixed in

Re: UnrecognizedPropertyException: Unrecognized field "config" (class org.apache.drill.exec.store.dfs.FileSystemConfig), not marked as ignorable (4 known properties: "enabled", "formats", "connection"

2016-03-08 Thread Jason Altekruse
This exception should only occur if you start an older version of Drill using a configuration (stored in zookeeper or your local temp directory) that was created by starting a version of Drill after 4383 was merged (0842851c854595f140779e9ed09331dbb63f6623). This change added a new property to

UnrecognizedPropertyException: Unrecognized field "config" (class org.apache.drill.exec.store.dfs.FileSystemConfig), not marked as ignorable (4 known properties: "enabled", "formats", "connection", "w

2016-03-08 Thread Khurram Faraaz
Hi All, I am seeing an Exception on Drill 1.6.0 commit ID 447b093c (I am using the RPM) I did not see this Exception on earlier version of Drill 1.6.0 commit ID 6d5f4983 Could this be related to DRILL-4383 Drill version where we see the

[GitHub] drill pull request: DRILL-4443: MIN/MAX on VARCHAR throw a NullPoi...

2016-03-08 Thread adeneche
Github user adeneche closed the pull request at: https://github.com/apache/drill/pull/409 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is