[GitHub] drill pull request #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] cl...

2018-04-11 Thread jiang-wu
Github user jiang-wu commented on a diff in the pull request: https://github.com/apache/drill/pull/1184#discussion_r180933601 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -509,15 +509,15 @@ public long getTwoAsLong(int index) { public ${fri

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

2018-04-11 Thread jiang-wu
Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 The unit test failure is due to additional changes in master after the pull request is made. I can merge and update on the branch to fix them. ---

[GitHub] drill pull request #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] cl...

2018-04-11 Thread jiang-wu
Github user jiang-wu commented on a diff in the pull request: https://github.com/apache/drill/pull/1184#discussion_r180925699 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -509,15 +509,15 @@ public long getTwoAsLong(int index) { public ${fri

[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...

2018-04-11 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 @arina-ielchiieva / @dvjyothsna Updated the PR with changes based on the comments. Could you please review and let me know what else would need to be fixed. ---

Re: [DISCUSS] Regarding mutator interface

2018-04-11 Thread Aman Sinha
Here's some background on what Gautam is trying to do: Currently, SQL does not have a standard way to do a DISTINCT on a subset of the columns in the SELECT list. Suppose there are 2 columns: a: INTEGER b: MAP Suppose I want to only do DISTINCT on 'a' and I don't really care about the colum

[GitHub] drill issue #1207: DRILL-6320: Fixed License Headers

2018-04-11 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1207 Abhishek has already updated jenkins to the latest maven. So we should be clear to merge after review is done. ---

[GitHub] drill pull request #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] cl...

2018-04-11 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1184#discussion_r180914676 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -509,15 +509,15 @@ public long getTwoAsLong(int index) { public $

[jira] [Resolved] (DRILL-6132) HashPartitionSender leaks memory

2018-04-11 Thread Timothy Farkas (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Farkas resolved DRILL-6132. --- Resolution: Fixed > HashPartitionSender leaks memory > > >

[GitHub] drill issue #1207: DRILL-6320: Fixed License Headers

2018-04-11 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1207 There is a large number of files affected - it might be good to get this in early so that we don't have to keep rebasing. @vrozov/ @Ben-Zvi can you glance through the changes? @Ben-Zvi, s

[GitHub] drill pull request #1207: DRILL-6320: Fixed License Headers

2018-04-11 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1207 DRILL-6320: Fixed License Headers There were several issues with license headers before this change: 1. We used the apache-rat-plugin to check licenses which was not thread safe. So when do

Re: [DISCUSS] Regarding mutator interface

2018-04-11 Thread Paul Rogers
What semantics are wanted? SetSafe sets a single value in a vector. What does it mean to set a single map or array value? What would we pass as an argument? For non-simple types, something needs to iterate over the values: be they elements of a map, elements in an array, elements of an array of m

Re: [DISCUSS] Regarding mutator interface

2018-04-11 Thread Padma Penumarthy
I guess you can add a setSafe method which recursively does setSafe for all children. Thanks Padma > On Apr 11, 2018, at 1:19 PM, Gautam Parai wrote: > > Hi Paul/Padma, > > > Thank you so much for the responses. This function is supposed to return `any > value` from the batch of incoming r

Re: [DISCUSS] Regarding mutator interface

2018-04-11 Thread Gautam Parai
Hi Paul/Padma, Thank you so much for the responses. This function is supposed to return `any value` from the batch of incoming rows. Hence, the need to handle maps/lists. This codegen is for the StreamingAggregator for Complex type(e.g. maps) in the incoming batch. It is trying to assign the

[jira] [Created] (DRILL-6325) Memory usage stats may not be updated correctly for an operator.

2018-04-11 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6325: - Summary: Memory usage stats may not be updated correctly for an operator. Key: DRILL-6325 URL: https://issues.apache.org/jira/browse/DRILL-6325 Project: Apache Dril

Re: [DISCUSS] Regarding mutator interface

2018-04-11 Thread Paul Rogers
Note that, for maps and lists, there is nothing to set. Maps are purely containers for other vectors. Lists (you didn't mention whether "repeated" or "non-repeated") are also containers. Non-repeated lists are containers for unions, repeated-lists are containers for arrays. Any setting should be

Re: [DISCUSS] Regarding mutator interface

2018-04-11 Thread Padma Penumarthy
Can you explain how aggregation on complex type works (or supposed to work). Thanks Padma > On Apr 11, 2018, at 12:15 PM, Gautam Parai wrote: > > Hi all, > > > I am implementing a new aggregate function which also handles Complex types > (map and list). However, the codegen barfs with > >

[DISCUSS] Regarding mutator interface

2018-04-11 Thread Gautam Parai
Hi all, I am implementing a new aggregate function which also handles Complex types (map and list). However, the codegen barfs with CompileException: Line 104, Column 39: A method named "setSafe" is not declared in any enclosing class nor any supertype, nor through a static import It looks