[GitHub] kkhatua commented on issue #1637: DRILL-7032: Ignore corrupt rows in a PCAP file

2019-02-12 Thread GitBox
kkhatua commented on issue #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#issuecomment-463073442 It's interesting that the `is_corrupt = 1` clause works. I'd expect a `boolean` field to throw an error for that. @cgivre , it might be

[GitHub] cgivre commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-12 Thread GitBox
cgivre commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r256233003 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVRecordReader.java ## @@

[GitHub] gparai commented on issue #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
gparai commented on issue #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#issuecomment-463005668 @amansinha100 thanks for the quick review. I will address all the review comments in the next commit. Parser support was added in the very

[GitHub] cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256207563 ## File path: contrib/native/client/src/protobuf/UserBitShared.pb.h ## @@ -1,65 +1,152 @@ // Generated by

[GitHub] cgivre commented on issue #1612: DRILL-6970: fix issue with logregex format plugin where drillbuf was overflowing

2019-02-12 Thread GitBox
cgivre commented on issue #1612: DRILL-6970: fix issue with logregex format plugin where drillbuf was overflowing URL: https://github.com/apache/drill/pull/1612#issuecomment-463003936 @jcmcote Could you just modify one of the existing unit tests with a long string?

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256195252 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256195822 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256195735 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256202774 ## File path: exec/java-exec/src/test/java/org/apache/drill/test/DrillTestWrapper.java ## @@

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256200490 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillAnalyzeRel.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256200721 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AnalyzePrule.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256203102 ## File path:

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256196463 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/StatisticsMerge.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r256199914 ## File path:

[GitHub] gparai commented on issue #729: Drill 1328: Support table statistics for Parquet

2019-02-12 Thread GitBox
gparai commented on issue #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#issuecomment-462947689 @amansinha100 I have added support for cpu sampling. Please take a look.

[GitHub] aravi5 commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled

2019-02-12 Thread GitBox
aravi5 commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled URL: https://github.com/apache/drill/pull/1626#discussion_r256137047 ## File path:

[GitHub] aravi5 commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled

2019-02-12 Thread GitBox
aravi5 commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled URL: https://github.com/apache/drill/pull/1626#discussion_r256136965 ## File path:

Apache Drill Hangout - 14 Feb, 2019

2019-02-12 Thread Kunal Khatua
Resending under a modified subject. Time: 10 AM Pacific Standard Time Venue: https://meet.google.com/yki-iqdf-tai?authuser=3 [https://meet.google.com/yki-iqdf-tai?authuser=3] (Hangout Link)  We'll be geting a preview of Charles' work on Apache Superset using Drill. ~ Kunal On 2/12/2019

[GitHub] sohami commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled

2019-02-12 Thread GitBox
sohami commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled URL: https://github.com/apache/drill/pull/1626#discussion_r256120073 ## File path:

[GitHub] sohami commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled

2019-02-12 Thread GitBox
sohami commented on a change in pull request #1626: DRILL-6855: Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled URL: https://github.com/apache/drill/pull/1626#discussion_r256115976 ## File path:

Re: BI Tool Demo on Drill

2019-02-12 Thread Charles Givre
Hi Kunal, It looks like there is enough interest to justify a hangout for this. Want to send out the invite? —C > On Feb 11, 2019, at 02:02, Kunal Khatua wrote: > > Hi guys > > We often use the hangouts to discuss about issues or some integral framework > related feature to improve Drill.

Re: BI Tool Demo on Drill

2019-02-12 Thread Karthikeyan Manivannan
+1 On Tue, Feb 12, 2019 at 10:23 AM Sorabh Hamirwasia wrote: > +1 > > On Tue, Feb 12, 2019 at 5:05 AM Vitalii Diravka > wrote: > > > +1 > > > > Kind regards > > Vitalii > > > > > > On Tue, Feb 12, 2019 at 1:31 AM Veera Naranammalpuram < > > vnaranammalpu...@mapr.com> wrote: > > > > > +1 > > >

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256074380 ## File path: protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ## @@ -895,6 +903,7

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256075337 ## File path: distribution/src/assemble/component.xml ## @@ -426,4 +427,4 @@ - + Review

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256084710 ## File path: contrib/format-syslog/src/main/java/org/apache/drill/exec/store/syslog/SyslogFormatPlugin.java

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256077643 ## File path: contrib/format-syslog/src/main/resources/drill-module.conf ## @@ -0,0 +1,22 @@ +// Licensed

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256081405 ## File path: contrib/format-syslog/src/main/java/org/apache/drill/exec/store/syslog/SyslogRecordReader.java

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256077359 ## File path: contrib/format-syslog/src/test/java/org/apache/drill/exec/store/syslog/TestSyslogFormat.java

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-12 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256076616 ## File path: contrib/native/client/src/protobuf/UserBitShared.pb.h ## @@ -1,65 +1,152 @@ // Generated

Re: BI Tool Demo on Drill

2019-02-12 Thread Sorabh Hamirwasia
+1 On Tue, Feb 12, 2019 at 5:05 AM Vitalii Diravka wrote: > +1 > > Kind regards > Vitalii > > > On Tue, Feb 12, 2019 at 1:31 AM Veera Naranammalpuram < > vnaranammalpu...@mapr.com> wrote: > > > +1 > > > > > > On Mon, Feb 11, 2019 at 5:55 PM Gautam Parai wrote: > > > > > +1 > > > > > > On Mon,

Re: BI Tool Demo on Drill

2019-02-12 Thread Vitalii Diravka
+1 Kind regards Vitalii On Tue, Feb 12, 2019 at 1:31 AM Veera Naranammalpuram < vnaranammalpu...@mapr.com> wrote: > +1 > > > On Mon, Feb 11, 2019 at 5:55 PM Gautam Parai wrote: > > > +1 > > > > On Mon, Feb 11, 2019 at 2:54 PM Hanumanth Maduri > > wrote: > > > > > +1 > > > > > > > On Feb 11,

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-12 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r255861297 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java ##