Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/517
unfortunately, I don't have access to a windows machine. I would suggest a
few options:
1. I just noticed that your test run shows 7 tests. Mine had 6 tests. I
suppose you added a ne
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/517
The tests passed for me (I am running on a linux box).
mvn install -DskipTests
mvn -Dtest=TestDecimal surefire:test -DfailIfNoTests=false
Running
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/518
hmm.. I still see 4 commits in the pull request. Can you squash them into
one ? (let me know if you need help with that). Also, the commit message needs
to be in the format: "DRILL
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/517
This patch is missing a unit test..can you add a unit test for this in
TestDecimal.java ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/525
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/521
Just to be sure, I confirmed with @jinfengni that the new generated code
would look like the following: (assume 100 expressions in the Project and
limit of 50 exprs per block):
doEval
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/521
I had couple of minor comments. Changes LGTM. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r67442811
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/SizedJBlock.java ---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r67442526
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -215,22 +219,47 @@ public JVar
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67426795
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -179,4 +180,43 @@ public void testNestedFilter
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67426381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +191,33 @@ private long
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/518
Looks much better. Sorry for the nitpick but I still have a couple more
related to the coding conventions. :)Also, could you squash the commits
into 1 and use the DRILL-: format for
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67392462
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
---
@@ -208,8 +209,18 @@ public DrillTable
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67390506
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -179,4 +181,28 @@ public void testNestedFilter
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389956
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -116,6 +117,7 @@ public void
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389846
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +194,37 @@ private long
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389726
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +194,37 @@ private long
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389362
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +194,37 @@ private long
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389073
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -135,6 +135,9 @@
BooleanValidator JSON_EXTENDED_TYPES = new
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67388118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -39,6 +40,7 @@
import
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67289117
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
---
@@ -208,8 +209,18 @@ public DrillTable
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/518
Yes, it does in fact have a conflict with DRILL-3764 which has changes to
the JsonRecordReader, although this issue is still in progress. I noticed
that @adeneche mentioned this in the JIRA
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67267511
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -217,11 +228,11 @@ public int next
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67267273
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -64,6 +64,8 @@
private final boolean
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/518
A high level comment I have about this PR is that keeping the number of
'malformed' records in the json file may not be sufficient..I would expect the
user would want to know the fil
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/519
DRILL-4530: Optimize partition pruning with metadata caching for the â¦
â¦single partition case.
- Enhance PruneScanRule to detect single partitions based on referenced
dirs in the
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/514
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/514#discussion_r65795257
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestCTASJson.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed to the Apache Software
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/514#discussion_r65795093
--- Diff: exec/java-exec/src/test/resources/json/ctas_alltypes_map_out.json
---
@@ -0,0 +1,41 @@
+{
--- End diff --
minor point: in
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/514#discussion_r65795030
--- Diff:
exec/java-exec/src/main/codegen/templates/JsonOutputRecordWriter.java ---
@@ -120,7 +127,13 @@ public void writeField() throws IOException
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/514#discussion_r65795019
--- Diff:
exec/java-exec/src/main/codegen/templates/JsonOutputRecordWriter.java ---
@@ -61,7 +62,13 @@
@Override
public void
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/508#discussion_r64677891
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java
---
@@ -81,6 +83,18 @@ public SelectionVectorMode
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/508#issuecomment-221746191
@jinfengni could you pls review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/508
DRILL-4693: Ensure final column re-ordering is done if any select liâ¦
â¦st expression is convert_fromjson.
You can merge this pull request into a Git repository by running:
$ git pull
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/470#issuecomment-220730748
Committed in 3d92d2829
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/504#issuecomment-220730151
Committed in 3d92d2829.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user amansinha100 closed the pull request at:
https://github.com/apache/drill/pull/504
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/504#discussion_r64103528
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -146,6 +159,27 @@ protected
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/504#discussion_r64101122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -136,6 +145,10 @@ public
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/504#discussion_r64091394
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -146,6 +159,27 @@ protected
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/504#issuecomment-220525522
@jinfengni could you pls review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/504
DRILL-4679: When convert() functions are present, ensure that Projectâ¦
â¦RecordBatch produces a schema even for empty result set.
Add unit tests
You can merge this pull request into
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/499#issuecomment-217587650
+1. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/368#issuecomment-216933980
My review comments were previously addressed, so +1 assuming tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/470#issuecomment-214773110
@parthchandra are you ok with the explanation that @chunhui-shi provided ?
Can this be merged ?
---
If your project is set up for it, you can reply to this email
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/485#issuecomment-212110488
+1 (I had already reviewed the previous #430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/485#discussion_r60304024
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/485#discussion_r60303921
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -60,4 +60,45 @@ public static int hash(ByteBuffer buf
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/462#issuecomment-210647305
I had one comment on the latest commit but overall LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r59941224
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableConfig.java
---
@@ -22,25 +22,36 @@
import
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/462#issuecomment-210085324
I think additional support may be needed; the hash table only stores the
equality join keys, so the generated code in ChainedHashTable is targeted to
the those
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/462#issuecomment-210047513
Right, the HashJoin and MergeJoin currently can handle one type of
comparison, not mixed...this is why when we have a join condition such as
t1.a1 = t2.a2 AND t2
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/471#issuecomment-208572783
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/470#issuecomment-208103314
Got it. LGTM. +1. The only other comment I have is about the
testing...have you thought about creating a unit test for this ?
---
If your project is set up
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/470#issuecomment-207904457
The code change is in the reading of the cache file but the commit message
and JIRA descriptions indicates a permission issue when writing the metadata
cache file
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-207153608
@jacques-n regarding re-implementation, agree with the general concern;
however in this case the core logic is directly taken from the java based
murmur hash
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-207132298
LGTM. +1. Since this fix is not directly changing the cost of per-row
filter evaluation itself (it is reducing the number of rows on which filter
evaluation is
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-207082651
@jacques-n ok to merge into master ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58926583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58921685
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -148,13 +139,41 @@ public String getName
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58921279
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58761862
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
---
@@ -169,4 +176,223 @@ private static boolean
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58761755
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
---
@@ -169,4 +176,223 @@ private static boolean
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58757060
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java ---
@@ -407,11 +342,94 @@ public void
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58751332
--- Diff:
exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java ---
@@ -215,6 +192,36 @@ public void eval
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58730151
--- Diff:
exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java ---
@@ -215,6 +192,36 @@ public void eval
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58728331
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
---
@@ -169,4 +176,223 @@ private static boolean
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58631107
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58629311
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -133,6 +133,10 @@ private RpcChannel(int index, int value
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58628326
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58625882
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58624266
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623875
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623402
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623171
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58622650
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/368#issuecomment-205994496
@yufeldman , sorry for the delay in reviewing. I will review the
parallelizer related enhancements (the new code since existing parallelizer is
not impacted) and
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-205420100
+1 revised version LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/425#issuecomment-201908762
If you could clarify what we want to do with the ObjectHolder, I am ok
with getting this patch merged in and address remaining issues incrementally.
The benefits
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/425#issuecomment-201908491
@vkorukanti have you had a chance to test this with metadata caching ?
Since the row count stats is stored in both the metadata cache and the
.drill.stats file, I
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/425#discussion_r57517236
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java
---
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/425#discussion_r57517122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java
---
@@ -0,0 +1,295
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/425#discussion_r57517080
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java
---
@@ -0,0 +1,295
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/425#discussion_r57517061
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java
---
@@ -0,0 +1,295
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/444#issuecomment-201086825
+1. Are there other rules that also may be getting applied with mixed
convention (Calcite logical and Drill logical) ? I am surprised that we don't
encoun
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/444#discussion_r57380087
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterAggregateTransposeRule.java
---
@@ -0,0 +1,28
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/425#discussion_r57015590
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java
---
@@ -0,0 +1,295
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56901020
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900515
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900362
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900294
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900085
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899651
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899529
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899331
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/397#issuecomment-198539051
+1.
As a separate exercise, I have suggested to the performance QA team to add
planning specific perf tests with large number of expressions to measure type
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/428#discussion_r55952285
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -402,7 +402,8 @@ private void writeDataAllText
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/428
DRILL-4503: Write nulls as varchar when all_text_mode is enabled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amansinha100/incubator
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/424#issuecomment-195140460
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
301 - 400 of 523 matches
Mail list logo
