Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/1016
@amansinha100 maybe you are familiar with this part of codes . Could you
give a review ? anyone else will also be welcome.
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@amansinha100 thanks for sharing the information. Got your point. I think
your propose on
[CALCITE-1048](https://issues.apache.org/jira/browse/CALCITE-1048) is possible.
Since [CALCITE-794
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
done
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
applied the review comments
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
ping @arina-ielchiieva @amansinha100
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi any more advice ?
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi thanks for your help! have done, please review.
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@amansinha100 I have removed the override of `getMaxRowCount` method of
`TableScan` type to avoid your worry about unexpected results . This PR's
target adjusts to just enhance the current
GitHub user weijietong opened a pull request:
https://github.com/apache/drill/pull/1016
DRILL-5913:solve the mixed processing of same functions with same inputRefs
but diâ¦
`DrillReduceAggregatesRule` mix the processing of same functions with same
inputRefs but different
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi thanks for your hard work, I have rewritten the corresponding
method. But I have not rewritten the other Locate related cases. Since mockup
is a white box testing , I payed some
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi the problem with mocking strategy is that when I run the test
case just with the single method `testToDateForTimeStamp` it will pass. but
when I run the whole test cases
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi thanks for your patient review . As you pointed out , the
timezone would not take effect when test cases run in parallel. I also tried
the mock strategy. It will also fail in parallel
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r140756869
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdMaxRowCount.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva @amansinha100 any further advice ?
---
GitHub user weijietong opened a pull request:
https://github.com/apache/drill/pull/943
DRILL-5749: solve deadlock between foreman and netty threads
@paul-rogers please review this PR again ,fail to squash the commits at
last PR, sorry about that.
related thread stack
Github user weijietong closed the pull request at:
https://github.com/apache/drill/pull/925
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/925
@paul-rogers have refactored the codes. @sudheeshkatkam nothing to fix
,once the netty thread got the re-spawned RPC connection ,it will send out the
message.
---
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/925#discussion_r137953813
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java ---
@@ -54,10 +52,14 @@ void channelClosed(Throwable ex
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r137424972
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -203,35 +203,27 @@ public static void
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/925
anyone can review this PR ? more details about thread stacks see
[DRLL-5749](https://issues.apache.org/jira/browse/DRILL-5749)
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva @amansinha100 isScalarSubquery method has been
refactored , please review.
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi has updated the mentioned parts. These
[4ea36c3](https://github.com/apache/drill/commit/4ea36c3f18841b229aca5048b7d162ea16bfd5a1),
[caa8b78](https://github.com/apache/drill/commit
GitHub user weijietong opened a pull request:
https://github.com/apache/drill/pull/925
DRILL-5749: solve foreman and netty threads deadlock
break the nest invocation of channelClosed method to avoid nested lock
holding
You can merge this pull request into a Git repository
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/921
@dvjyothsna thanks for your contribution. Some objections please consider,
the shutdown process should be quick and allow fault occurred. Google calls it
lame duck model. If your cluster is large
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r135254275
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -231,6 +236,12 @@ public static boolean
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r135249441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -204,24 +205,28 @@ public static void
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi please review the update ones
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva thanks for the advice, has corrected that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user weijietong closed the pull request at:
https://github.com/apache/drill/pull/918
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva other tests have passed separately and time zone related
test cases have been corrected in PR 5717
---
If your project is set up for it, you can reply to this email and have
GitHub user weijietong opened a pull request:
https://github.com/apache/drill/pull/918
Drill-5734: exclude commons-codes dependency confliction
exclude commons-codes from pom files: contrib/format-maprdb/pom.xml ,
contrib/storage-hive/hive-exec-shade/pom.xml
You can merge
Github user weijietong closed the pull request at:
https://github.com/apache/drill/pull/917
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user weijietong opened a pull request:
https://github.com/apache/drill/pull/917
Drill-5734: exclude the conflicted dependency commons-codec
exclude commons-codes from pom files: contrib/format-maprdb/pom.xml ,
contrib/storage-hive/hive-exec-shade/pom.xml
You can merge
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
@vvysotskyi sorry for the late update as have passed a busy week.
update points:
* move out the pom update
* recover the date related templates and update the related test cases
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
update points :
>
* remove commons-codec dependency for 1.4 vs 1.10 conflict
* fix to_date , to_timestamp ,to_time ,sql_to_date ,sql_to_timestamp,
sql_to_time funct
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
Yes, thanks for the notice ,have noticed those cases before ,the work is in
process.some of that will be part of this PR. Others like sql_to_timestamp
function need to discuss whether it should
GitHub user weijietong opened a pull request:
https://github.com/apache/drill/pull/904
DRILL-5717: let some date time test cases be Local independent
Some date time test cases is US Local .This will cause developers from
other areas to fail. Fix is to specify the explicit Local
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva have passed all the unit tests under java-exec bundle ,
got some errors which are sure not associated with this change, maybe my branch
was old from the master
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva your test case can not reproduce the error . You can
search the dev email to find the origin error description with the keyword
"Drill query planning error". Your que
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@arina-ielchiieva I have corrected the codes as you guide. But sorry for
the unit tests, I have tried a long time to simulate a scan with 1 row ,but
failed to do that. The row count of a scan
Github user weijietong closed the pull request at:
https://github.com/apache/drill/pull/888
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
The build process is good at my laptop. anyone please work this out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user weijietong opened a pull request:
https://github.com/apache/drill/pull/889
Drill 5691 enhance scalar sub queries checking for the cartesian join
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weijietong/drill drill
43 matches
Mail list logo
