Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r59290968
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestHashBase.java ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r59290818
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r59290217
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DrillHash.java
---
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r58969685
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-207153608
@jacques-n regarding re-implementation, agree with the general concern;
however in this case the core logic is directly taken from the java based
murmur hash
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r58968289
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/XXHash.java ---
@@ -24,14 +24,15 @@
import
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r58968083
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestHashBase.java ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r58967457
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DrillHash.java
---
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r58967081
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java ---
@@ -163,10 +163,10 @@ private static void appendByte(StringBuilder
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-207147567
Just to clarify since I didn't say so. I'm ok with this to be merged given
Aman's +1.
---
If your project is set up for it, you can reply to this email and have your
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-207147616
Did you guys do a perf analysis to ensure no regressions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-205420100
+1 revised version LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Thanks for pointing to openHFT. I went through multiple Java
implementations including this one. The reason I decided to use smhasher as
the source of truth was, the smhasher implementation includes comprehensive
tests to cover the attributes for measuring goodness of a non-cryptographic
hash
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-203726680
Did you consider leveraging this library:
https://github.com/OpenHFT/Zero-Allocation-Hashing
---
If your project is set up for it, you can reply to this
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r57206301
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r57203072
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r57202442
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56925560
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56924863
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56907606
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56901020
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900515
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900362
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900294
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56900085
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899651
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899529
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899331
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56899122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/430
DRILL-4237 DRILL-4478 fully implement hash to use murmur3 and correspâ¦
Since we have to have our own implementations of hash functions, UNIT tests
should guarantee the correctness of
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/408
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/408#issuecomment-193430786
As to the test code that use original cpp implementation to generate the
test vectors in murmur3_buf.json and murmur3_double.json. Please refer to here:
33 matches
Mail list logo
