Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/984
---
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r15009
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetComparison.java
---
@@ -255,4 +257,39 @@ private void verifyArray(String colLabel,
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150097140
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSet.java ---
@@ -85,8 +85,7 @@
* new row set with the updated columns,
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150096444
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/file/JsonFileBuilder.java
---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150096261
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSet.java ---
@@ -85,8 +85,7 @@
* new row set with the updated columns, then
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150073673
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetComparison.java
---
@@ -255,4 +257,39 @@ private void verifyArray(String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150072992
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/file/JsonFileBuilder.java
---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150073945
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSet.java ---
@@ -85,8 +85,7 @@
* new row set with the updated columns,
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148396417
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TableFileBuilder.java ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148395420
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
@@ -377,21 +386,21 @@ public
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148394268
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestExternalSort.java
---
@@ -138,34 +141,34 @@ public void
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148393893
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148157850
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148157170
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148157140
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r148144235
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BaseDirTestWatcher.java ---
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147262655
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java ---
@@ -59,6 +59,9 @@
@Ignore
public class ExampleTest {
+
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147261203
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -226,43 +217,16 @@ private void createConfig(FixtureBuilder builder)
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147258230
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -213,7 +204,7 @@ private void configureZk(FixtureBuilder builder) {
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147257244
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BaseDirTestWatcher.java ---
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147256621
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
---
@@ -147,7 +152,7 @@ public void
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147255211
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
@@ -19,24 +19,33 @@
import
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147229671
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
@@ -76,43 +78,50 @@
//
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147229627
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
@@ -76,43 +78,50 @@
//
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147229478
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
---
@@ -33,8 +35,11 @@
@Category(UnlikelyTest.class)
public class
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147229235
--- Diff: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147009092
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147008923
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java ---
@@ -59,48 +58,48 @@ public void withDistribution() throws Exception
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147007945
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
@@ -64,9 +73,9 @@ public void testJoinWithLimit() throws Exception{
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r147007663
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
@@ -19,24 +19,33 @@
import
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145827440
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
@@ -64,9 +73,9 @@ public void testJoinWithLimit() throws Exception{
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145815670
--- Diff: exec/java-exec/src/test/resources/topN/one_key_sort.json ---
@@ -12,11 +12,11 @@
pop:"mock-scan",
url:
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145790506
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -908,6 +908,15 @@ public void generateTestData(int count) {
}
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145575975
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java ---
@@ -21,29 +21,25 @@
import
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145575781
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -247,7 +248,7 @@ drill.exec: {
}
},
sort: {
-
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145575588
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java
---
@@ -116,6 +116,14 @@ public void clear() {
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145575310
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -335,20 +336,42 @@ private void purge() throws
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145574915
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -335,20 +336,42 @@ private void purge() throws
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145574026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java
---
@@ -20,22 +20,58 @@
import
Github user ilooner-mapr commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145572262
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java
---
@@ -20,22 +20,58 @@
import
Github user ilooner-mapr commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145571158
--- Diff: common/src/test/java/org/apache/drill/test/DirTestWatcher.java ---
@@ -32,23 +32,50 @@
public class DirTestWatcher extends TestWatcher {
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145561518
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -584,11 +492,14 @@ public static void defineWorkspace(Drillbit
Github user ilooner-mapr commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145561373
--- Diff: common/src/main/java/org/apache/drill/common/util/TestTools.java
---
@@ -17,15 +17,28 @@
*/
package org.apache.drill.common.util;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145522320
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java ---
@@ -59,6 +59,9 @@
@Ignore
public class ExampleTest {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145516665
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145522737
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TableFileBuilder.java ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145505524
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
@@ -76,43 +78,50 @@
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145515947
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BaseDirTestWatcher.java ---
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145516134
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BaseDirTestWatcher.java ---
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145523267
--- Diff: exec/java-exec/src/test/resources/topN/one_key_sort.json ---
@@ -12,11 +12,11 @@
pop:"mock-scan",
url:
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145509549
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
---
@@ -147,7 +152,7 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145519174
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -213,7 +204,7 @@ private void configureZk(FixtureBuilder builder)
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145516858
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145521268
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -584,11 +492,14 @@ public static void defineWorkspace(Drillbit
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145297931
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145520129
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -226,43 +217,16 @@ private void createConfig(FixtureBuilder
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145508960
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestExternalSort.java
---
@@ -138,34 +141,34 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145556819
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -908,6 +908,15 @@ public void generateTestData(int count) {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145518566
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145505747
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
@@ -76,43 +78,50 @@
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145298677
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggrSpill.java
---
@@ -43,146 +44,122 @@
import static
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145292655
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -247,7 +248,7 @@ drill.exec: {
}
},
sort: {
-
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144943191
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java ---
@@ -90,12 +89,11 @@
private String generatedCode;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145292776
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java ---
@@ -21,29 +21,25 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145294641
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
---
@@ -33,8 +35,11 @@
@Category(UnlikelyTest.class)
public class
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144943882
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java
---
@@ -20,22 +20,58 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144946834
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -335,20 +336,42 @@ private void purge() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145517411
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145292056
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -335,20 +336,42 @@ private void purge() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145294064
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
@@ -19,24 +19,33 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144944018
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java
---
@@ -20,22 +20,58 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145293197
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java ---
@@ -61,10 +57,8 @@ public void testHashAggNullableColumns() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145292505
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java
---
@@ -116,6 +116,14 @@ public void clear() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145297229
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java ---
@@ -559,7 +563,7 @@ public void testRankWithGroupBy() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144945381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java
---
@@ -20,22 +20,58 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145294835
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java ---
@@ -59,48 +58,48 @@ public void withDistribution() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144936994
--- Diff: common/src/test/java/org/apache/drill/test/DirTestWatcher.java ---
@@ -32,23 +32,50 @@
public class DirTestWatcher extends TestWatcher {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144936263
--- Diff: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144935089
--- Diff: common/src/main/java/org/apache/drill/common/util/TestTools.java
---
@@ -17,15 +17,28 @@
*/
package org.apache.drill.common.util;
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144205146
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -335,20 +333,32 @@ private void purge() throws
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144195098
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -95,7 +91,9 @@ public TopNBatch(TopN popConfig,
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144194940
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144194617
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java
---
@@ -20,22 +20,58 @@
import
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144194241
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java ---
@@ -90,12 +89,11 @@
private String generatedCode;
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144193392
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144147623
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -335,20 +333,32 @@ private void purge() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144132366
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java ---
@@ -90,12 +89,11 @@
private String generatedCode;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144131729
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144142548
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java
---
@@ -20,22 +20,58 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144147991
--- Diff:
common/src/test/java/org/apache/drill/testutils/SubDirTestWatcher.java ---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144131909
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144147334
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -95,7 +91,9 @@ public TopNBatch(TopN popConfig,
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/984
DRILL-5783 Made a unit test for generated Priority Queue. DRILL-5841 Fix
tmp folder errors.
## DRILL-5783
- A unit test is created for the priority queue in the TopN operator
- The code
93 matches
Mail list logo
