[GitHub] [drill] paul-rogers opened a new pull request #2010: DRILL-7620: Fix plugin mutability isues

2020-03-03 Thread GitBox
paul-rogers opened a new pull request #2010: DRILL-7620: Fix plugin mutability isues URL: https://github.com/apache/drill/pull/2010 A recent commit made the plugin registry more strict about the rule that, once a plugin is registered, it must be immutable. A flaw enforcing that rule in

[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-03-03 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-594289758 @akkapur Sorry, I misunderstood the intent of that change. The unit tests are very thorough and let's leave them for the time being.

[GitHub] [drill] akkapur commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-03-03 Thread GitBox
akkapur commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-594262755 > Same comment. If Druid isn't running, the tests that depend on it will fail, so wouldn't we want to fail fast and throw an exception

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-03 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-594184068 Hmm Safari, that does make it a bit more tricky since I'm using Windows & Linux only currently.

[GitHub] [drill] cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#issuecomment-594170892 @paul-rogers I believe this is ready for round 2 of review. My only question at this point is around the `toString()` methods.

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387294099 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387294231 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387288823 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpSchemaFactory.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387288823 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpSchemaFactory.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387287844 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanSpec.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387286385 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387285551 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-03 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r387285053 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by URL: https://github.com/apache/drill/pull/2009#discussion_r387160301 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by URL: https://github.com/apache/drill/pull/2009#discussion_r387160301 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by URL: https://github.com/apache/drill/pull/2009#discussion_r387160620 ## File path: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by URL: https://github.com/apache/drill/pull/2009#discussion_r387163842 ## File path: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by URL: https://github.com/apache/drill/pull/2009#discussion_r387160301 ## File path:

[GitHub] [drill] oleg-zinovev opened a new pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by

2020-03-03 Thread GitBox
oleg-zinovev opened a new pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by URL: https://github.com/apache/drill/pull/2009 # [DRILL-7622](https://issues.apache.org/jira/browse/DRILL-7622): DRILL-7622: Compilation error when using HLL / TDigest with

[jira] [Created] (DRILL-7622) CompileException in HashAggBatch.createAggregator for HLL/tdigest function

2020-03-03 Thread Oleg Zinoviev (Jira)
Oleg Zinoviev created DRILL-7622: Summary: CompileException in HashAggBatch.createAggregator for HLL/tdigest function Key: DRILL-7622 URL: https://issues.apache.org/jira/browse/DRILL-7622 Project:

[jira] [Created] (DRILL-7621) Refactor ExecConstants and PlannerSettings constant classes

2020-03-03 Thread Igor Guzenko (Jira)
Igor Guzenko created DRILL-7621: --- Summary: Refactor ExecConstants and PlannerSettings constant classes Key: DRILL-7621 URL: https://issues.apache.org/jira/browse/DRILL-7621 Project: Apache Drill

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387075673 ## File path: _docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md ## @@ -16,21

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387069605 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -160,19

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387070626 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -160,19

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387066806 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -160,19

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387065974 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -48,42

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387072594 ## File path: _docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md ## @@ -16,21

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387068212 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -160,19

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387067007 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -160,19

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387086209 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -10,6 +10,31

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r386536928 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -48,42

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r386537174 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -48,42

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387073399 ## File path: _docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md ## @@ -16,21

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r386493673 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -10,6 +10,31

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r386535350 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -10,6 +10,31

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387073214 ## File path: _docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md ## @@ -16,21

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387071335 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -364,7

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387065418 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -48,42

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387064394 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -48,42

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387077646 ## File path: _docs/sql-reference/sql-commands/007-analyze-table-refresh-metadata.md ## @@ -1,35 +1,18

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r386537049 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -48,42

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387072270 ## File path: _docs/performance-tuning/drill-metastore/010-using-drill-metastore.md ## @@ -364,7

[GitHub] [drill] vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986#discussion_r387077079 ## File path: _docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md ## @@ -16,21

[jira] [Created] (DRILL-7620) Storage plugin update page shows that a plugin is disabled though it is actually enabled.

2020-03-03 Thread Anton Gozhiy (Jira)
Anton Gozhiy created DRILL-7620: --- Summary: Storage plugin update page shows that a plugin is disabled though it is actually enabled. Key: DRILL-7620 URL: https://issues.apache.org/jira/browse/DRILL-7620

Invitation: Apache Drill Hangout @ Fri Mar 6, 2020 9:30am - 10:30am (EST) (dev@drill.apache.org)

2020-03-03 Thread charles . givre
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20200306T143000Z DTEND:20200306T153000Z DTSTAMP:20200303T134029Z ORGANIZER;CN=charles.gi...@gtkcyber.com:mailto:charles.gi...@gtkcyber.com

[GitHub] [drill] vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value URL: https://github.com/apache/drill/pull/2006#discussion_r386956424 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value URL: https://github.com/apache/drill/pull/2006#discussion_r386907067 ## File path: common/src/main/java/org/apache/drill/common/types/Types.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value URL: https://github.com/apache/drill/pull/2006#discussion_r386916026 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value URL: https://github.com/apache/drill/pull/2006#discussion_r386928587 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value

2020-03-03 Thread GitBox
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value URL: https://github.com/apache/drill/pull/2006#discussion_r386997680 ## File path:

[GitHub] [drill] agozhiy opened a new pull request #2008: DRILL-7619: Fixed link to the metrics endpoint

2020-03-03 Thread GitBox
agozhiy opened a new pull request #2008: DRILL-7619: Fixed link to the metrics endpoint URL: https://github.com/apache/drill/pull/2008 # [DRILL-7619](https://issues.apache.org/jira/browse/DRILL-7619): Fixed link to the metrics endpoint ## Description Fixed link to the

[jira] [Created] (DRILL-7619) Metrics is not displayed due to incorrect endpoint link on the Drill index page

2020-03-03 Thread Anton Gozhiy (Jira)
Anton Gozhiy created DRILL-7619: --- Summary: Metrics is not displayed due to incorrect endpoint link on the Drill index page Key: DRILL-7619 URL: https://issues.apache.org/jira/browse/DRILL-7619 Project:

[GitHub] [drill] weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-593929455 @arina-ielchiieva has applied your advice ,thanks. This is an

[GitHub] [drill] arina-ielchiieva merged pull request #2007: DRILL-7617: Disabled plugins not showing in Web UI

2020-03-03 Thread GitBox
arina-ielchiieva merged pull request #2007: DRILL-7617: Disabled plugins not showing in Web UI URL: https://github.com/apache/drill/pull/2007 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] arina-ielchiieva commented on issue #2007: DRILL-7617: Disabled plugins not showing in Web UI

2020-03-03 Thread GitBox
arina-ielchiieva commented on issue #2007: DRILL-7617: Disabled plugins not showing in Web UI URL: https://github.com/apache/drill/pull/2007#issuecomment-593888247 +1 This is an automated message from the Apache Git Service.

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-03 Thread GitBox
arina-ielchiieva edited a comment on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-593863200 @dobesv thanks for the video, re-checked one more time. Looks like issue is

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-03 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-593863200 @dobesv thanks for the video, re-checked one more time. Looks like issue is Safari

Re: [DISCUSS] ExecConstants class refactoring

2020-03-03 Thread Arina Yelchiyeva
+1 for ExecConstants refactoring. Igor, could you please create Jira to capture discussion in Jira and decision on the fix? Thanks. Kind regards, Arina > On Mar 2, 2020, at 9:30 PM, Paul Rogers wrote: > > Hi Igor, > > You know the old joke about how you eat an elephant? One bite at a time. >

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386877314 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386883292 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/data/TestBitRpc.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386884155 ## File path: protocol/src/main/protobuf/BitData.proto ## @@ -36,6 +36,8 @@ enum

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386879942 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/AckSender.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386881973 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/data/TestBitRpc.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386880732 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386879614 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DynamicSemaphore.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386881117 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386883217 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/data/TestBitRpc.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386878197 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386878951 ## File path: