paul-rogers opened a new pull request #2010: DRILL-7620: Fix plugin mutability
isues
URL: https://github.com/apache/drill/pull/2010
A recent commit made the plugin registry more strict about the rule that,
once a plugin is registered, it must be immutable. A flaw enforcing that rule
in
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid
URL: https://github.com/apache/drill/pull/1888#issuecomment-594289758
@akkapur Sorry, I misunderstood the intent of that change. The unit tests
are very thorough and let's leave them for the time being.
akkapur commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache
Druid
URL: https://github.com/apache/drill/pull/1888#issuecomment-594262755
> Same comment. If Druid isn't running, the tests that depend on it will
fail, so wouldn't we want to fail fast and throw an exception
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-594184068
Hmm Safari, that does make it a bit more tricky since I'm using Windows &
Linux only currently.
cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP
REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-594170892
@paul-rogers
I believe this is ready for round 2 of review. My only question at this
point is around the `toString()` methods.
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387294099
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387294231
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387288823
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpSchemaFactory.java
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387288823
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpSchemaFactory.java
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387287844
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanSpec.java
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387286385
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387285551
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r387285053
##
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation
error when using HLL / TDigest with group by
URL: https://github.com/apache/drill/pull/2009#discussion_r387160301
##
File path:
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation
error when using HLL / TDigest with group by
URL: https://github.com/apache/drill/pull/2009#discussion_r387160301
##
File path:
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation
error when using HLL / TDigest with group by
URL: https://github.com/apache/drill/pull/2009#discussion_r387160620
##
File path: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation
error when using HLL / TDigest with group by
URL: https://github.com/apache/drill/pull/2009#discussion_r387163842
##
File path: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation
error when using HLL / TDigest with group by
URL: https://github.com/apache/drill/pull/2009#discussion_r387160301
##
File path:
oleg-zinovev opened a new pull request #2009: DRILL-7622: Compilation error
when using HLL / TDigest with group by
URL: https://github.com/apache/drill/pull/2009
# [DRILL-7622](https://issues.apache.org/jira/browse/DRILL-7622):
DRILL-7622: Compilation error when using HLL / TDigest with
Oleg Zinoviev created DRILL-7622:
Summary: CompileException in HashAggBatch.createAggregator for
HLL/tdigest function
Key: DRILL-7622
URL: https://issues.apache.org/jira/browse/DRILL-7622
Project:
Igor Guzenko created DRILL-7621:
---
Summary: Refactor ExecConstants and PlannerSettings constant
classes
Key: DRILL-7621
URL: https://issues.apache.org/jira/browse/DRILL-7621
Project: Apache Drill
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387075673
##
File path:
_docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md
##
@@ -16,21
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387069605
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -160,19
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387070626
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -160,19
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387066806
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -160,19
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387065974
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -48,42
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387072594
##
File path:
_docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md
##
@@ -16,21
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387068212
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -160,19
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387067007
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -160,19
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387086209
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -10,6 +10,31
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r386536928
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -48,42
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r386537174
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -48,42
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387073399
##
File path:
_docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md
##
@@ -16,21
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r386493673
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -10,6 +10,31
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r386535350
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -10,6 +10,31
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387073214
##
File path:
_docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md
##
@@ -16,21
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387071335
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -364,7
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387065418
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -48,42
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387064394
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -48,42
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387077646
##
File path:
_docs/sql-reference/sql-commands/007-analyze-table-refresh-metadata.md
##
@@ -1,35 +1,18
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r386537049
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -48,42
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387072270
##
File path:
_docs/performance-tuning/drill-metastore/010-using-drill-metastore.md
##
@@ -364,7
vvysotskyi commented on a change in pull request #1986: Additional changes for
Drill Metastore docs
URL: https://github.com/apache/drill/pull/1986#discussion_r387077079
##
File path:
_docs/performance-tuning/drill-metastore/030-drill-iceberg-metastore.md
##
@@ -16,21
Anton Gozhiy created DRILL-7620:
---
Summary: Storage plugin update page shows that a plugin is
disabled though it is actually enabled.
Key: DRILL-7620
URL: https://issues.apache.org/jira/browse/DRILL-7620
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VEVENT
DTSTART:20200306T143000Z
DTEND:20200306T153000Z
DTSTAMP:20200303T134029Z
ORGANIZER;CN=charles.gi...@gtkcyber.com:mailto:charles.gi...@gtkcyber.com
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL
query returns the wrong result for the decimal value
URL: https://github.com/apache/drill/pull/2006#discussion_r386956424
##
File path:
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL
query returns the wrong result for the decimal value
URL: https://github.com/apache/drill/pull/2006#discussion_r386907067
##
File path: common/src/main/java/org/apache/drill/common/types/Types.java
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL
query returns the wrong result for the decimal value
URL: https://github.com/apache/drill/pull/2006#discussion_r386916026
##
File path:
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL
query returns the wrong result for the decimal value
URL: https://github.com/apache/drill/pull/2006#discussion_r386928587
##
File path:
vvysotskyi commented on a change in pull request #2006: DRILL-7615: UNION ALL
query returns the wrong result for the decimal value
URL: https://github.com/apache/drill/pull/2006#discussion_r386997680
##
File path:
agozhiy opened a new pull request #2008: DRILL-7619: Fixed link to the metrics
endpoint
URL: https://github.com/apache/drill/pull/2008
# [DRILL-7619](https://issues.apache.org/jira/browse/DRILL-7619): Fixed link
to the metrics endpoint
## Description
Fixed link to the
Anton Gozhiy created DRILL-7619:
---
Summary: Metrics is not displayed due to incorrect endpoint link
on the Drill index page
Key: DRILL-7619
URL: https://issues.apache.org/jira/browse/DRILL-7619
Project:
weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based
flow control
URL: https://github.com/apache/drill/pull/2000#issuecomment-593929455
@arina-ielchiieva has applied your advice ,thanks.
This is an
arina-ielchiieva merged pull request #2007: DRILL-7617: Disabled plugins not
showing in Web UI
URL: https://github.com/apache/drill/pull/2007
This is an automated message from the Apache Git Service.
To respond to the
arina-ielchiieva commented on issue #2007: DRILL-7617: Disabled plugins not
showing in Web UI
URL: https://github.com/apache/drill/pull/2007#issuecomment-593888247
+1
This is an automated message from the Apache Git Service.
arina-ielchiieva edited a comment on issue #1994: DRILL-7203: Accept
impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-593863200
@dobesv thanks for the video, re-checked one more time. Looks like issue is
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation
userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-593863200
@dobesv thanks for the video, re-checked one more time. Looks like issue is
Safari
+1 for ExecConstants refactoring.
Igor, could you please create Jira to capture discussion in Jira and decision
on the fix? Thanks.
Kind regards,
Arina
> On Mar 2, 2020, at 9:30 PM, Paul Rogers wrote:
>
> Hi Igor,
>
> You know the old joke about how you eat an elephant? One bite at a time.
>
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386877314
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386883292
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/data/TestBitRpc.java
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386884155
##
File path: protocol/src/main/protobuf/BitData.proto
##
@@ -36,6 +36,8 @@ enum
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386879942
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/AckSender.java
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386881973
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/data/TestBitRpc.java
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386880732
##
File path:
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386879614
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DynamicSemaphore.java
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386881117
##
File path:
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386883217
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/data/TestBitRpc.java
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386878197
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##
arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386878951
##
File path:
69 matches
Mail list logo