Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173545351
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -227,11 +280,19 @@ public void run
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173526625
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -245,19 +306,17 @@ public Void run() throws
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173527617
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -227,11 +280,19 @@ public void run
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173528013
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -488,47 +548,74 @@ void receiverFinished
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173527951
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -488,47 +548,74 @@ void receiverFinished
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173529580
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BitRpcUtility.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173529523
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BitRpcUtility.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1158#discussion_r173901690
--- Diff: distribution/pom.xml ---
@@ -324,6 +324,14 @@
org.apache.hbase
hbase-protocol
+
--- End
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1163
DRILL-6053 & DRILL-6237
- Avoid excessive locking in LocalPersistentStore
- Upgrade checkstyle version to 5.9 or above
@arina-ielchiieva Please review
You can merge this pull req
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1158#discussion_r174285398
--- Diff: distribution/pom.xml ---
@@ -324,6 +324,14 @@
org.apache.hbase
hbase-protocol
+
--- End
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1154
@vladimirtkach Use JIRA in PR title (to automatically update JIRA with a
link to the PR and PR updates).
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173234604
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -312,6 +312,11 @@ public synchronized void connect(String connect
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173237142
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java
---
@@ -103,6 +96,23 @@ protected void handle(ControlConnection
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173236107
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -371,17 +376,20 @@ protected void afterExecute(final Runnable r
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173224242
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -475,6 +483,8 @@ public void drillbitUnregistered
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173229346
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -475,6 +483,8 @@ public void drillbitUnregistered
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173375649
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -96,6 +96,8 @@
import io.netty.channel.EventLoopGroup
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1163#discussion_r174530802
--- Diff: common/src/main/java/org/apache/drill/common/AutoCloseables.java
---
@@ -25,6 +25,11 @@
*/
public class AutoCloseables
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1163#discussion_r174533741
--- Diff: pom.xml ---
@@ -259,7 +259,13 @@
org.apache.maven.plugins
maven-checkstyle-plugin
2.12.1
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1165#discussion_r174483759
--- Diff: README.md ---
@@ -1,5 +1,8 @@
# Apache Drill
+[ throws Exception
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r173303074
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -488,47 +527,66 @@ void receiverFinished
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1151
DRILL-6151: Fragment executors may terminate without sending final batch to
a downstream causing query to hang
You can merge this pull request into a Git repository by running:
$ git pull
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1163#discussion_r174551433
--- Diff: common/src/main/java/org/apache/drill/common/AutoCloseables.java
---
@@ -25,6 +25,11 @@
*/
public class AutoCloseables
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r179296715
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -161,30 +162,25 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r179293968
--- Diff: exec/java-exec/pom.xml ---
@@ -836,6 +836,14 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r179321187
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VLAbstractEntryReader.java
---
@@ -0,0 +1,214
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r179295162
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/MemoryUtils.java
---
@@ -0,0 +1,199 @@
+/**
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1202#discussion_r179626383
--- Diff: exec/vector/pom.xml ---
@@ -69,6 +69,7 @@
org.apache.drill
drill-common
${project.version}
+ test
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1195
LGTM
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r179344792
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/MemoryUtils.java
---
@@ -0,0 +1,199 @@
+/**
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r179229891
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BaseScalarWriter.java
---
@@ -211,7 +211,7 @@ protected boolean canExpand
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r179226227
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -777,23 +778,20 @@ public int getActualMemoryConsumed() {
* @return
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r179231151
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
+
--- End diff --
I commented out
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1193
@rongfengliang If you have a question regarding Drill ask it on
`u...@drill.apache.org`. If you have something to contribute, please follow
contributions guidelines to open a PR.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1207
-1 on removing apache-rat maven plugin. It is an Apache plugin to invoke
"Release Audit Tool". More plugins can be added to check license headers if
they do a better job in addition to
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1208
DRILL-6295: PartitionerDecorator may close partitioners while
CustomRunnable are active during query cancellation
@ilooner Please review
You can merge this pull request into a Git repository
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1207
@arina-ielchiieva In Apex we use special git user Apex Dev
`d...@apex.apache.org` to make format only changes. I'd recommend doing the
same for Drill.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181197514
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181198668
--- Diff: pom.xml ---
@@ -375,12 +449,12 @@
-
com.mycila
license-maven
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181197234
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181196340
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1207
LGTM, @ilooner please double check that Apache source distribution can be
built with '-Drat.skip=false -Dlicense.skip=false':
- build with `-P apache.release -Dgpg.skip=true`
- extract
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1202#discussion_r180226298
--- Diff: exec/vector/pom.xml ---
@@ -69,6 +69,7 @@
org.apache.drill
drill-common
${project.version}
+ test
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1202#discussion_r180249547
--- Diff: exec/vector/pom.xml ---
@@ -69,6 +69,7 @@
org.apache.drill
drill-common
${project.version}
+ test
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1202#discussion_r180275891
--- Diff: exec/vector/pom.xml ---
@@ -69,6 +69,7 @@
org.apache.drill
drill-common
${project.version}
+ test
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181267547
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181434241
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1202
LGTM +1.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182444596
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestPromotableWriter.java
---
@@ -33,6 +33,7 @@
public void list
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182445595
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/util/CallBack.java ---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff --
The same
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182445146
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/exception/OversizedAllocationException.java
---
@@ -27,6 +27,7 @@
* {@link RecordBatch#next
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182445689
--- Diff:
exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java
---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182440952
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestPromotableWriter.java
---
@@ -1,4 +1,4
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1208#discussion_r181865979
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java
---
@@ -118,105 +127,114 @@ public
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1213
LGTM
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1225
@arina-ielchiieva I don't see why using [maven
embedder](http://maven.apache.org/ref/3.5.2/maven-embedder) is a less
preferable option. Using maven it is possible to create source jars using
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r183868650
--- Diff: pom.xml ---
@@ -1164,7 +1164,27 @@
io.dropwizard.metrics
metrics-core
-4.0.2
+4.1.0
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r183870299
--- Diff: pom.xml ---
@@ -1333,6 +1353,12 @@
+
--- End diff --
Where is the dependency used
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183865249
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -45,21 +46,24 @@
import org.bson.BsonTimestamp
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1234
LGTM
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184070218
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184075517
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184084128
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
---
@@ -253,10 +261,12 @@ public boolean transferBalance(final
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184085544
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -153,8 +153,10 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184050305
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -182,13 +184,18 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184068798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -153,8 +153,10 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184049558
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1238
DRILL-6281: Refactor TimedRunnable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL-6281
Alternatively you can review
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
@parthchandra Please review.
Note to a committer: please do *not* squash commits.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183397526
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1236
IMO, neither `append` or `appendField` is a good choice (otherwise it is
necessary to change `startNode/endNode` to `appendStart/EndNode`). It is either
`field` or `visitField` and should follow
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183578626
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FooterGatherer.java
---
@@ -66,8 +69,8 @@ private static void checkMagicBytes
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183562766
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -272,6 +276,9 @@ public static void cleanUp
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183564004
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r183571786
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
+
--- End diff --
IMO the same applies
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
There is no need to expose implementation details as part of the class API.
Whether `DebugStringBuilder` uses `PrintWriter.print()` or something else to
implement `append()` must be hidden from
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183563218
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183741516
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183747252
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -272,6 +276,9 @@ public static void cleanUp
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183779660
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1215#discussion_r182259451
--- Diff: protocol/pom.xml ---
@@ -149,8 +152,12 @@
com.mycila
license-maven-plugin
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1193
Can one of PMCs request INFRA to close the PR?
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1196
+1
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1208
@parthchandra Please review
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1208#discussion_r181927070
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java
---
@@ -262,68 +280,122 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1208#discussion_r181926928
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerTemplate.java
---
@@ -161,8 +161,11 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r181932078
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/exception/OversizedAllocationException.java
---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1224#discussion_r182874214
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182590683
--- Diff:
exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java
---
@@ -37,6 +37,7 @@ public void testSettingSameValueCount
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r182902723
--- Diff:
exec/java-exec/src/test/resources/udf/dynamic/CustomAbsFunctionTemplate ---
@@ -0,0 +1,45 @@
+package org.apache.drill.udf.dynamic
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r182902596
--- Diff:
exec/java-exec/src/test/resources/udf/dynamic/CustomAbsFunctionTemplate ---
@@ -0,0 +1,45 @@
+package org.apache.drill.udf.dynamic;
--- End
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r182902184
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/FunctionInitializerTest.java
---
@@ -53,17 +56,27 @@
@Category
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184144021
--- Diff: logical/pom.xml ---
@@ -85,14 +85,12 @@
- com.codahale.metrics
+ io.dropwizard.metrics
--- End
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184146733
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -182,13 +184,18 @@ public
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1189
Please update JIRA, PR and commit titles and squash commits.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184144853
--- Diff: pom.xml ---
@@ -1333,6 +1353,12 @@
+
--- End diff --
I am not sure why
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1189
Why not make Drill to use `io.dropwizard.metrics` instead of
`com.codahale.metrics`? As far as I can see it is the same library (this is why
it causes the conflict).
---
201 - 300 of 342 matches
Mail list logo
