Re: Potential copyright issue with transitive npm dependency

2019-03-21 Thread Hen
(including Huxing) On Thu, Mar 21, 2019 at 10:55 PM Hen wrote: > > Give substack a few days to reply and then nudge them on Twitter: > https://twitter.com/substack or their email (listed on > https://substack.net/ ). > > On Thu, Mar 21, 2019 at 6:57 AM Huxing Zhang wrote: > >> Hi, >> >> >> On

Re: Potential copyright issue with transitive npm dependency

2019-03-21 Thread Hen
Give substack a few days to reply and then nudge them on Twitter: https://twitter.com/substack or their email (listed on https://substack.net/ ). On Thu, Mar 21, 2019 at 6:57 AM Huxing Zhang wrote: > Hi, > > > On Thu, Mar 21, 2019 at 8:42 PM Daniel Shahaf > wrote: > > > > Huxing Zhang wrote on

Re: Potential copyright issue with transitive npm dependency

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 8:42 PM Daniel Shahaf wrote: > > Huxing Zhang wrote on Thu, 21 Mar 2019 09:43 +00:00: > > The dubbo admin 0.2.0 release candidate contains a front end project > > which is based on Nodejs and npm. There is a transitive dependency > > called wordwrap[1], in this

Re: Potential copyright issue with transitive npm dependency

2019-03-21 Thread Daniel Shahaf
Huxing Zhang wrote on Thu, 21 Mar 2019 09:43 +00:00: > The dubbo admin 0.2.0 release candidate contains a front end project > which is based on Nodejs and npm. There is a transitive dependency > called wordwrap[1], in this dependency there is a file called > idleness.txt which is written by

Re: Applying a label "first-time-contributor" to pull request

2019-03-21 Thread Yuhao Bi
Hi, I think manual apply a label is fine enough for me. +1 to the original proposal Huxing Zhang 于2019年3月21日周四 下午5:58写道: > Hi, > > On Thu, Mar 21, 2019 at 3:58 PM Taosheng, Wei > wrote: > > > > hi, > > how about let dubbo bot to find which pr is first-time, and then it > opens a corresponding

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Ian Luo
I also reported the issue in eslint [1] community and in webpack [2] community. Considering these two tools are widely adopted for javascript development, they may take this seriously. But from our side, I guess there's nothing more we could do for now but wait for the responses from them and what

Re: Applying a label "first-time-contributor" to pull request

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 3:58 PM Taosheng, Wei wrote: > > hi, > how about let dubbo bot to find which pr is first-time, and then it opens a > corresponding issue to refer the pr > Well I admit it is a way to solve the problem, but I looks going too far... I am +0 to this, let's see how

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 4:34 PM Huxing Zhang wrote: > > Hi, > > > On Thu, Mar 21, 2019 at 3:55 PM Justin Mclean > wrote: > > > > Hi, > > > > This is probably against copyright law, and IMO just because others ignore > > it doesn’t mean we should. > > > > There probably a couple of courses

Potential copyright issue with transitive npm dependency

2019-03-21 Thread Huxing Zhang
Hi Legal team, I am not subscribing the list so please cc me when reply. Thanks. :) The Apache Dubbo podling community is reviewing a release candidate of dubbo-admin, a potential copyright issue is identified, and the community would like to confirm with ASF legal team. The dubbo admin 0.2.0

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 5:35 PM Justin Mclean wrote: > > Hi, > > > I also did't find the echarts dependency in this release candidate. It > > is introduced in this commit[1] just 6 hours ago, it is impossible to > > be included in the release candidate. > > npm ls just list what installed,

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Justin Mclean
Hi, > I also did't find the echarts dependency in this release candidate. It > is introduced in this commit[1] just 6 hours ago, it is impossible to > be included in the release candidate. npm ls just list what installed, which may not be helpful, what the best way to work out what version the

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 3:55 PM Justin Mclean wrote: > > Hi, > > This is probably against copyright law, and IMO just because others ignore it > doesn’t mean we should. > > There probably a couple of courses of action: > - Ask the maintainer of that npm module to replace that file with

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 3:41 PM Justin Mclean wrote: > > Hi, > > >I run "npm ls | grep echarts" on tag 0.2.0, but gets no result. dubbo > > admin use echarts 4.0.4 to support metrics on develop branch, but the > > feature is not in the release > > I’m looking at the source release not

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Justin Mclean
Hi, > I did a search in Github [1], it looks quite a lot, some of them made > releases. How to deal with these releases? AFAIK Most of these would not be the primary release / offical release. Thanks, Justin

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 3:43 PM Justin Mclean wrote: > > Hi, > > > If that is the case, I doubt that there are lots of ASF projects could > > not make releases. > > There are very few Apache projects that use npm as their primary build tool. I did a search in Github [1], it looks quite a

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Justin Mclean
Hi, This is probably against copyright law, and IMO just because others ignore it doesn’t mean we should. There probably a couple of courses of action: - Ask the maintainer of that npm module to replace that file with something that's permissible to use. - Ask on legal discuss for advice, they

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Justin Mclean
Hi, > If that is the case, I doubt that there are lots of ASF projects could > not make releases. There are very few Apache projects that use npm as their primary build tool. Thanks, Justin

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Justin Mclean
Hi, >I run "npm ls | grep echarts" on tag 0.2.0, but gets no result. dubbo > admin use echarts 4.0.4 to support metrics on develop branch, but the > feature is not in the release I’m looking at the source release not the tag. It shows on the very first line. Perhaps I might be picking up

Re: Applying a label "first-time-contributor" to pull request

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 2:24 PM Taosheng, Wei wrote: > > It’s a good idea. Can we let the dubbo bot do this work to add the label to > prs automatically? > > I wish it could. dubbo-bot does not have write access, so the bot can neither be able to see it nor apply any label. > > >

Re: Applying a label "first-time-contributor" to pull request

2019-03-21 Thread Taosheng, Wei
It??s a good idea. Can we let the dubbo bot do this work to add the label to prs automatically? -- Original -- From: Huxing Zhang Date: Thu,Mar 21,2019 1:47 PM To: dev Subject: Re: Applying a label "first-time-contributor" to pull request Hi, On Thu, Mar

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Minxuan Zhuang
Hi Justin I run "npm ls | grep echarts" on tag 0.2.0, but gets no result. dubbo admin use echarts 4.0.4 to support metrics on develop branch, but the feature is not in the release On Thu, Mar 21, 2019 at 2:11 PM Huxing Zhang wrote: > Hi, > > On Thu, Mar 21, 2019 at 1:45 PM Justin Mclean

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 1:45 PM Justin Mclean wrote: > > Hi, > > > These dependencies are all development time dependencies, which can be > > found in "devDependencies" section of package.json file. > > Anyone who compiles the source will get these and be unaware of them, that > seems a

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-21 Thread Justin Mclean
Hi, Having a closer look I see that “npm ls” shows a dependancy on echarts@4.2.1-rc1. This is unreleased code [1]. Is this correct? Thanks, Justin 1. https://github.com/apache/incubator-echarts/releases/tag/4.2.1-rc1