Re: Hi, Why close this issue #6067 silently without any response for months?

2020-08-10 Thread Jason Joo
Aha Feel sorry to you two guys. Not stake holder. I also have several such cases but try to think of the other hand, different people have different minds. Some can be merged together while some can't. And open sources in china have a common trouble which is the inactive communities. Maybe due

Re: Adaptive thread isolation between services about Dubbo

2020-07-21 Thread Jason Joo
Hi, 陆 The scenario you described in last post is more like a scene in which a protector may participate in. General implementation includes hystrix[1], sentinel[2], etc. . They can introduce abilities like flow control, traffic shaping, circuit breaking to various systems including Dubbo,

Re: Maximize the consumer throughput and CPU usage

2019-11-29 Thread Jason Joo
on that if the consumer sends requests to a cluster of > providers, the number of threads might need to be increased to a very high > number. > This still need to be benched to make sure. > > That is our information so far. Hope this one can be helpful also. > Thank you also for your

Re: Maximize the consumer throughput and CPU usage

2019-11-27 Thread Jason Joo
onfiguration of the consumer process. > > We have tried the Arthas tool that you suggested. A very useful tool in > general. However, it still does not show any interesting lead that can > explain the problem. > > We are stuck for now :( > > Best > Dat > > On 2019/11

Re: Maximize the consumer throughput and CPU usage

2019-11-27 Thread Jason Joo
Tien, Performance issue is quite a complicated problem and the open files count you just mentioned in last mail is not the only factor. According to the persistent connection in dubbo design I don't think is the cause due to your issue and maybe the value you saw in your work machine is not

Re: Dubbo connection random port

2019-11-06 Thread Jason Joo
Tien, Generally it's a server socket. So all connections to provider will use the specific (listening) port on PROVIDER side but it may be a random one on consumer side. This is the rule from TCP. Connections are recognized by 4-element on both side: src:srcPort-dst:dstPort. best regards,

Re: Duplicate class on dubbo-common

2019-10-25 Thread Jason Joo
ersion} > > >com.esotericsoftware >kryo >4.0.1 > > > If you really need a project for quicker reproduction, I can make a github > project. The content will most likely just these poms. > > Best > Tie

Re: Duplicate class on dubbo-common

2019-10-25 Thread Jason Joo
solution for this case. > > Best regards > Dat > > On 2019/10/25 10:47:32, Jason Joo wrote: >> Tien, >> >> It makes sense because it (and others like this) is an optional extension / >> support / function. We should decide to introduce the extra depen

Re: Duplicate class on dubbo-common

2019-10-25 Thread Jason Joo
not relevant, since we have to update the version of > com.esotericsoftware.kryo according to > org.apache.dubbo:dubbo-serialization-kryo. > > Best > Dat > > On 2019/10/25 08:17:18, Jason Joo wrote: >> Hi, tien >> >> `dubbo` is a "fat" jar which incl

Re: Duplicate class on dubbo-common

2019-10-25 Thread Jason Joo
.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html`) > > Best > Dat > > On 2019/10/25 01:48:29, Jason Joo wrote: >> Hi, tien >> >> There is a problem in your `dependencies` section. >> `dubbo` is a single package includin

Re: Duplicate class on dubbo-common

2019-10-24 Thread Jason Joo
Hi, tien There is a problem in your `dependencies` section. `dubbo` is a single package including all codes related dubbo core like `netty-all` while `dubbo-serialization-kryo` is already included in `dubbo`. If you want to do some customizing like removing some useless support in `dubbo` you

Re: How can I configure to start the client first and then start the server

2019-10-23 Thread Jason Joo
:46, Tien Dat PHAN wrote: > > Hi Jason, > > Does this mean even I re-invoke the ReferenceConfig.get() the second time, > the reference may not need to be generated, as it is already cached somewhere > in Dubbo client holder? > > Best > Dat > > On 2019/10/23 09:4

Re: How can I configure to start the client first and then start the server

2019-10-23 Thread Jason Joo
t; Tien Dat > > On 2019/10/23 09:03:06, Jason Joo wrote: >> Hi, tien >> >> I just curious on why you use `ReferenceConfigCache` to get the reference? >> Why not using `@Reference` everywhere instead? >> >> best regards, >> >> Jason >>

Re: How can I configure to start the client first and then start the server

2019-10-23 Thread Jason Joo
Hi, tien I just curious on why you use `ReferenceConfigCache` to get the reference? Why not using `@Reference` everywhere instead? best regards, Jason > On Oct 23, 2019, at 16:55, Tien Dat PHAN wrote: > > Dear > > Related to the topic of this thread, I have a question: > When starting the

Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-10-23 Thread Jason Joo
Hi, Ian Generally in practice it's good to create a new repository with a new name (eg. log4j, log4j2, while they haven't so much inner connections). My proposal is to name it with something like `dubbo-python2` or others. Just for reference. best regards, Jason > On Oct 23, 2019, at

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread Jason Joo
to fix it in a fix > version on this week. > > Jason Joo 于2019年10月21日周一 下午3:26写道: > >> And I'm ok to file a NEW issue but will anyone to discuss and follow >> together? >> >> It seems that most guys are busy currently. Maybe for the event of 11.11? >> Th

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread Jason Joo
l report an > NPE problem. > >> 在 2019年10月21日,下午2:30,victory 写道: >> >> I have released dubbo-2.7.4 two days ago. >> If you have some problem, please file an issue on >> https://github.com/apache/dubbo/issues >> If your problem is very severe, we will try

Re: Customize the target content to be hashed with Consistent hash load balance

2019-09-25 Thread Jason Joo
l option? The default option is still using 'toString' method. > > Best > Tien Dat > > On 2019/09/25 01:14:39, Jason Joo wrote: >> Hi, tien >> >> `hashCode` maybe consistent in single node but will be inconsistent between >> JVM processes.(under default i

Re: Customize the target content to be hashed with Consistent hash load balance

2019-09-24 Thread Jason Joo
sers can override the hashCode() method of their own objects. > > What do you think? > > Best regards > Tien Dat PHAN > > On 2019/06/12 11:56:25, Jason Joo wrote: >> Hi, Dat >> >> Stand at the point of DUBBO maybe it is too complex to support a grammar as

Re: Gracefully unexporting/passivating the exported services

2019-09-24 Thread Jason Joo
our interesting material. > This would answer the need of our use case. > Just a small question is: Does Dubbo provide a JAVA API for such QoS features? > > Best > Tien Dat > > On 2019/09/24 00:50:58, Jason Joo wrote: >> Hi Tien >> >> You can refer to Q

Re: Gracefully unexporting/passivating the exported services

2019-09-23 Thread Jason Joo
Hi Tien You can refer to QOS feature of DUBBO. QoS's Parameters: http://dubbo.apache.org/en-us/docs/user/references/qos.html Usage: https://dubbo.apache.org/en-us/blog/introduction-to-dubbo-qos.html

Re: 2.7.4 release plan

2019-09-09 Thread Jason Joo
Hi, victory There's one old issue (https://github.com/apache/dubbo/issues/4693) which hasn't got any further response or discussion for long time but closed five days ago. I want to figure out should we should treat it not an issue? Because there was one related PR

Re: Using FileInputStream with dubbo protocol

2019-07-23 Thread Jason Joo
rialization. > Have you ever played with this protocol for large file transfer? > > Best > Tien Dat > > On 2019/07/19 17:58:56, Jason Joo wrote: >> Hi, Tien >> >> Questions on the road map it's better to turn to @lan luo. He will get you >> k

Re: Using FileInputStream with dubbo protocol

2019-07-19 Thread Jason Joo
ow, Dubbo version 3.x will come with reactive stream supported. > So whether the InputStream can be also supported in this version? > > Best > Tien Dat > > On 2019/07/19 01:07:51, Jason Joo wrote: >> Hi, Tien >> >> You can only use serializable types as par

Re: Using FileInputStream with dubbo protocol

2019-07-18 Thread Jason Joo
Hi, Tien You can only use serializable types as parameters in API definition and maybe you cannot do that. You can choose an alternative design like: 1. use byte[] (When the size of file is small) (If it's large or undetermined splitting it into pieces will also work) 2. use a place to store

Re: Customizing the Zookeeper Znode name for Dubbo

2019-07-12 Thread Jason Joo
ode contains the metadata directory. >> Is this out of the group name setting? >> >> Since it would be better to collocated both the public APIs states and the >> metadata within the same parent Znode >> >> Best >> Tien Dat >> >> On 2019/07/1

Re: Customizing the Zookeeper Znode name for Dubbo

2019-07-11 Thread Jason Joo
Hi Tien You can try dubbo.registry.group But because of multiple storage implementation maybe it's hard to add sub folders. eg. dubbo.registry.group=dubbo_alternative best regards, Jason > On Jul 11, 2019, at 16:50, tphan@gmail.com wrote: > > Dear experts, > > We just wonder if it is

Re: No such extension org.apache.dubbo.rpc.Protocol by name dubbo

2019-07-10 Thread Jason Joo
Hi Brooks, If you use zookeeper as configuration center you should add it to your dubbo.properties: dubbo.registry.protocol=zookeeper best regards, Jason > On Jul 10, 2019, at 23:30, bro...@chtrak.com wrote: > > java.lang.IllegalStateException: No such extension >

Re: [DISCUSS] Dubbo release versioning

2019-06-17 Thread Jason Joo
+1 It seems like the beginning which is Jun's opinion, and for addition optimizing the version naming strategy. Users won't care about whether we go with 2.7.1, 2.7.2 or 2.7.x, 2.8.x, 2.9.x, 2.10.x so i think both of them are fine for me. Just pick one and go on. best regards, Jason > On

Re: [DISCUSS] Observation of performance degradation of 2.7.2 under JDK 1.8.

2019-06-13 Thread Jason Joo
2.7.3" but things could be clear if name it "2.7.3-RC1" or "2.7.3-BETA". Sure it's a personal opinion. best regards, Jason > On Jun 14, 2019, at 12:50, Huxing Zhang wrote: > > Hi, > > On Fri, Jun 14, 2019 at 11:42 AM Jason Joo <mailto:hblz...@163.com>

Re: Customize the target content to be hashed with Consistent hash load balance

2019-06-12 Thread Jason Joo
for now, as we do not find a > better solution for this yet. > > Best > Dat > > On 2019/06/12 08:28:32, Jason Joo wrote: >> Hi, Tien >> >> Agree to you that it will break the principle of design if overriding >> toString(). >> Currently consist

Re: Customize the target content to be hashed with Consistent hash load balance

2019-06-12 Thread Jason Joo
e MyRequestParams has multiple fields, we would like to avoid > implementing the toString method that return a string containing only the URI > field. > This would break the purpose of the toString method. > > Do you know any other approaches/work around for this? > > Best &g

Re: Customize the target content to be hashed with Consistent hash load balance

2019-06-11 Thread Jason Joo
Hi, Tien Consistent hash is relying mainly the object's "toString()" protocol. So pls make sure your objects have a unique and stable toString() method and it will be ok. best regards, Jason > On Jun 11, 2019, at 16:58, tphan@gmail.com wrote: > > Dear experts, > > We are using Dubbo to

Re: How about add warning notes to 2.7.1 release notes to warn users of one known critical problem?

2019-06-03 Thread Jason Joo
time to take it to production environments mixed together. > > > This is really a good idea, to give users a chance to evaluate if it's > stable enough to deploy the new version into production environment. We > will consider it. > > Thanks, > -Ian. > > > >

Re: How about add warning notes to 2.7.1 release notes to warn users of one known critical problem?

2019-06-03 Thread Jason Joo
s week. We are now > considering to init a regression test project. Again, sorry about it. > > -Ian. > > On Fri, May 31, 2019 at 11:50 AM Jason Joo wrote: > >> hi, jun >> >> Long time not focus on dubbo but this news surprises me. I just upgraded >> some

Re: How about add warning notes to 2.7.1 release notes to warn users of one known critical probletm?

2019-05-30 Thread Jason Joo
an check this issue[1] for more details. The > community is working on 2.7.2 to fix it. > > 1. https://github.com/apache/dubbo/issues/4213 > > Jun > >> On May 31, 2019, at 11:50 AM, Jason Joo wrote: >> >> hi, jun >> >> Long time not focus on dub

Re: How about add warning notes to 2.7.1 release notes to warn users of one known critical problem?

2019-05-30 Thread Jason Joo
hi, jun Long time not focus on dubbo but this news surprises me. I just upgraded some new spring-boot projects to use a new internal branch based on 2.7.1. I think it maybe better to describe how to trigger it in the notes? best regards, Jason > On May 31, 2019, at 11:39, Jun Liu wrote: >

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-22 Thread Jason Joo
extension don’t include it, there is no need to let the users extend by > themselves, > > A little change for Consistent Hash LoadBalance will support such function. > > Kitito > >> 在 2019年2月22日,上午11:39,Jason Joo 写道: >> >> hi, moe >> >> I think what

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-21 Thread Jason Joo
hi, moe I think what you mention is like "ip_hash" in NGINX or some other. ConsistentHashLB is hashed by parameters because a same logic will just act the same under the same parameters (which we call it reenterability). Adding other parameters will break it. While DUBBO provides the ability

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-13 Thread Jason Joo
+1 Methods with no arguments or little possible values of arguments should not be applied `ConsistentHashLoadBalance`. Or requests can not be smoothly distributed when nodes change. best regards, Jason > On Feb 13, 2019, at 22:30, 田 小波 wrote: > > 数

Re: [Discuss] About Clean Code Plan

2019-01-28 Thread Jason Joo
clean code, while > the purpose doesn't limit to grammar sugar? > > Regards, > -Ian. > > 1. https://github.com/apache/incubator-dubbo/projects > > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo wrote: > >> Hi, Huxing & LiZhen >> >> Things like dia

Re: [Discuss] About Clean Code Plan

2019-01-28 Thread Jason Joo
Hi, Huxing & LiZhen Things like diamond is something called grammar SUGAR. Tasted good for developers but the same on byte code. So in my opinion we should not take it as a kind of "policy correct". we can make the changes in the code of recent PRs but not for all the code. Think about there

Re: [Discuss] The Timer Design in Dubbo from 2.6 to 2.7

2019-01-23 Thread Jason Joo
e from > Schedule to HashedWheelTimer, but didn’t give a vert detailed reason. > > Is HashedWheelTimer really an unquestionable choice? > > [1] https://github.com/apache/incubator-dubbo/issues/1371 > <https://github.com/apache/incubator-dubbo/issues/1371> > >> 在 2019年1月24日,

Re: [Discuss] The Timer Design in Dubbo from 2.6 to 2.7

2019-01-23 Thread Jason Joo
Maybe because the main scenario dubbo faces is persistent connection. For persistent connections the most frequent thing is ticking. ScheduledThreadPoolExecutor is O(1)*connections compared to O(C) in HashedWheelTimer when ticking. Considering connections is far less then C

Re: Telnet optimization suggest

2018-12-17 Thread Jason Joo
And is there other situations to deal with? group/version/etc... For now there is only different implementations in same application and looks good to deal with. best regards, Jason > On Dec 18, 2018, at 10:33, yeling wrote: > > Ok,I've created an issue. >

Re: dubbo使用中的疑问

2018-11-09 Thread Jason Joo
t;>> >>>> 最终每个consumer是N * n,对于每个provider则是N * m >>> >>> >> 我这里针对他的问题,提供建议,让他增大连接数验证,netty收到同一个client多个channel连接一定会均衡绑定eventloop(默认策略)。 >>> >>> -yiji >>> >>> Ian Luo 于2018年11月9日周五 上午10:37写道: >>> >>>

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-25 Thread Jason Joo
hi, Luo Implementation of 2.5.3 is indeed fast but it's not correct. Here is example running report: Weights array: 100, 100, 200, 200, 300, 300, 400, 400, 500, 500 2.5.3: 2, 2, 45000, 45000, 78333, 78333, 128333, 128333, 228334, 228334 before patch: 33400, 33400, 66700, 66700,

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-25 Thread Jason Joo
weight = 0; > } > if (weightedRoundRobin == null) { >weightedRoundRobin = new WeightedRoundRobin(); >weightedRoundRobin.setWeight(weight); >map.putIfAbsent(identifyString, weightedRoundRobin); >weightedRoundRobin = map.get(identifyString); > } > > > Thank

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-25 Thread Jason Joo
ote: > > Jason, > > what I suggest is to simply declare methodWeightMap from > ConcurrentMap> to > ConcurrentMap>, then > you will have 'putIfAbsent', what do you think? > > Thanks, > -Ian. > > On Thu, Oct 25, 2018 at 3:47 PM Jason Joo wrote: >>

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-25 Thread Jason Joo
hi, luo Just replace putIfAbsent with put for compatibility and tested in racing condition. best regards, Jason > On Oct 25, 2018, at 11:33, Ian Luo wrote: > > great. > On Thu, Oct 25, 2018 at 11:33 AM Jason Joo wrote: >> >> hi, Luo >> >> I am swi

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread Jason Joo
M Ian Luo wrote: >> >> Jason, >> >> More comments, pls. take a look :) >> >> Thanks, >> -Ian. >> On Thu, Oct 25, 2018 at 10:50 AM Jason Joo wrote: >>> >>> hi, Luo >>> >>> Thanks for your great suggestions and PR has b

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread Jason Joo
;> >> >> Thanks, >> -Ian. >> On Thu, Oct 25, 2018 at 1:17 AM Jason Joo wrote: >>> >>> hi, king >>> >>> I think we also care about if it would cause abusing in practices of DUBBO. >>> The smooth version is at least twent

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread Jason Joo
ote: > > The data seems convincing. What's meaning of 'before patch' and 'after patch'? > > > Thanks, > -Ian. > On Thu, Oct 25, 2018 at 1:17 AM Jason Joo wrote: >> >> hi, king >> >> I think we also care about if it would cause abusing in practices of DUBBO

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread Jason Joo
number of invokers is small,we could not care about its change, check stage is not a key point.At 2018-10-24 17:48:31, "Jason Joo" <hblz...@163.com> wrote:hi, xiuAfter some deeper research on the algorithm i found it seemed like thread-safe.I updated my PR and unit test on it so we

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread Jason Joo
need more discussion and solutions on this issue. Looking forward to > your solutions. :) > > Thx > > Jason Joo 于2018年10月24日周三 下午4:32写道: > >> hi, xiu >> >> Good proposal. >> >> The old not-very-smooth RoundRobin implementation can work fi

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread Jason Joo
如果这个provider承受不住同时进行N个请求,我们需要做的应该是把他的权重调低。 > > 综上,我个人认为,当前的smooth实现方式不是很理想,我们没法在锁、线程和内存上都达到一个非常优秀的平衡。所以我认为可以不使用smooth的方式。 > > 谢谢。 > > Jason Joo 于2018年10月24日周三 下午3:57写道: > >> hi, Luo >> >> Glad to receive your response. I posted a reply before including

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread Jason Joo
hi, Luo Glad to receive your response. I posted a reply before including some minds about the lock: * Separated recycle thread (more threads) or * Lock free (more memory in special conditions) It's truly a struggling job to make a decision and we can do it together. For the lock-free

Re: A preformance issue And Optimizing RoundRobinLoadBalance

2018-10-21 Thread Jason Joo
er people to revisit this issue later :) >> >> Thanks, >> -Ian. >> >> On Tue, Oct 16, 2018 at 2:25 PM Jason Joo wrote: >> >>> Hi, lan >>> >>> I gave a sample from Nginx® Code in JAVA and gained better performance >>>

Re: A preformance issue And Optimizing RoundRobinLoadBalance

2018-10-16 Thread Jason Joo
gt; > Jason, if you've had a pull request ready, or you are willing to work on > it, why not :) > > Thanks, > -Ian. > > On Tue, Oct 16, 2018 at 3:16 PM Jason Joo wrote: > >> Hi lan, >> >> I will update it. >> >> Should I submit a PR as pro

Re: A preformance issue And Optimizing RoundRobinLoadBalance

2018-10-16 Thread Jason Joo
Hi lan, I will update it. Should I submit a PR as proposal? The implementation is just a little "longer" then before and we can't have a real performance result in unit test because the mock's poor performance. best regards, Jason > On Oct 16, 2018, at 14:37, Ian Luo wrote: > > other

Re: A preformance issue And Optimizing RoundRobinLoadBalance

2018-10-16 Thread Jason Joo
Hi, lan I gave a sample from Nginx® Code in JAVA and gained better performance compared to previous one(in that issue reply list). Junlan's point is not to shuffle the addresses list and to select a different node every time as possible, eg: A:B:C = 1:2:3 [A, B, C, B, C, C, A, B, C, B,

Re: about grpc support

2018-09-12 Thread Jason Joo
hi, dp According to principle of gRPC which is a solution crossing front-end(mobile) to back-end(server) using HTTP/2, i think it's suitable to be integrated in Controller layer(some like dubbo-consumer) but not service layer(dubbo-provider). Nothing blocks us to use gRPC in consumers, right?

Re: The chats must be public

2018-09-07 Thread Jason Joo
+1 Maybe we all have so much work to do, and also need time to write whole thoughts down. IM will destroy it and can't go deeper and multi-thread. best regards, Jason > On Sep 7, 2018, at 23:14, Huxing Zhang wrote: > > Hi, > > On Fri, Sep 7, 2018 at 11:33 AM Jerrick Zhu

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

2018-08-20 Thread Jason Joo
hi, I suggest the next iteration of development should be on another branch such as "2.6.4" or "2.6.x". We indeed should keep the pre-release branch clean (I just do some local work changing versions for our own nexus repo before). best regards, Jason > On Aug 20, 2018, at 11:02, Jun Liu

Re: 2.6.3 compatible problem with 2.5.[9, 10]

2018-08-02 Thread Jason Joo
add the table as image: best regards, Jason > On Aug 3, 2018, at 10:38, Jason Joo wrote: > > hey, everyone > > Today i found a big compatible problem in our staging env. > > Issue has been submitted as > https://github.com/apache/incubator-dubbo/issues/2174 >

2.6.3 compatible problem with 2.5.[9, 10]

2018-08-02 Thread Jason Joo
hey, everyone Today i found a big compatible problem in our staging env. Issue has been submitted as https://github.com/apache/incubator-dubbo/issues/2174 And we can check it quickly in below table: dubbo protocolfail 2.5.8