[GitHub] HaoZhang6 commented on issue #1012: Wanted: who's using dubbo

2018-04-07 Thread GitBox
HaoZhang6 commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379522858 公司:上海烈熊网络技术有限公司 地址:中国上海 联系方式: t...@billbear.cn 场景:统一RPC框架、服务治理框架 This

[GitHub] ralf0131 commented on issue #606: 提供更优雅的异步方式实现

2018-04-07 Thread GitBox
ralf0131 commented on issue #606: 提供更优雅的异步方式实现 URL: https://github.com/apache/incubator-dubbo/pull/606#issuecomment-379522767 Hi, Please update the title and description using English. Dubbo is a global community and we would like the PR to be reviewed by people all over the world.

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

2018-04-07 Thread GitBox
kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite. URL: https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424 Thanks for a wonderful integration framework. But I guess the "best practices" were

[GitHub] ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的,不起作用

2018-04-07 Thread GitBox
ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的,不起作用 URL: https://github.com/apache/incubator-dubbo/pull/639#issuecomment-379522657 Hi, Please update the title and description using English. Dubbo is a global community and we would like the PR to be reviewed by

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

2018-04-07 Thread GitBox
kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite. URL: https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424 Thanks for a wonderful integration framework. But I guess the "best practices" were

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

2018-04-07 Thread GitBox
kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite. URL: https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424 Thanks for a wonderful integration framework. But I guess the "best practices" were

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

2018-04-07 Thread GitBox
kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite. URL: https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424 Thanks for a wonderful integration framework. But I guess the "best practices" were

[GitHub] xiaomaijiang closed issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild

2018-04-07 Thread GitBox
xiaomaijiang closed issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild URL: https://github.com/apache/incubator-dubbo/issues/1532 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的,不起作用

2018-04-07 Thread GitBox
ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的,不起作用 URL: https://github.com/apache/incubator-dubbo/pull/639#issuecomment-379521121 Please resolve the conflict before we can merge. This is an automated

[GitHub] ralf0131 commented on issue #606: 提供更优雅的异步方式实现

2018-04-07 Thread GitBox
ralf0131 commented on issue #606: 提供更优雅的异步方式实现 URL: https://github.com/apache/incubator-dubbo/pull/606#issuecomment-379521045 This pull request has conflict, please resolve it before we can merge. This is an automated

[GitHub] mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-07 Thread GitBox
mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935444 ## File path:

[GitHub] mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-07 Thread GitBox
mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935398 ## File path:

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-07 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935223 ## File path:

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-07 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935223 ## File path:

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-07 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935223 ## File path:

[GitHub] mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-07 Thread GitBox
mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935101 ## File path:

[GitHub] nzomkxia opened a new pull request #11: update dubbo book address

2018-04-07 Thread GitBox
nzomkxia opened a new pull request #11: update dubbo book address URL: https://github.com/apache/incubator-dubbo-docs/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607 ` ChildListener zkListener = listeners.get(listener);

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607 ` ChildListener zkListener = listeners.get(listener); if (zkListener

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607 ` ChildListener zkListener = listeners.get(listener); if (zkListener

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607 ` ChildListener zkListener = listeners.get(listener); if (zkListener

[GitHub] beiwei30 closed issue #1512: dubbo service register zookeeper very slow

2018-04-07 Thread GitBox
beiwei30 closed issue #1512: dubbo service register zookeeper very slow URL: https://github.com/apache/incubator-dubbo/issues/1512 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] cvictory commented on issue #1522: 启动时检查依赖,无论我check设为true或者false,它都不检测直接启动成功

2018-04-07 Thread GitBox
cvictory commented on issue #1522: 启动时检查依赖,无论我check设为true或者false,它都不检测直接启动成功 URL: https://github.com/apache/incubator-dubbo/issues/1522#issuecomment-379517483 @zeng54088 Is the issue ok ? And what is the reason? This is an

[GitHub] nzomkxia closed pull request #10: update dubbo docs address in readme

2018-04-07 Thread GitBox
nzomkxia closed pull request #10: update dubbo docs address in readme URL: https://github.com/apache/incubator-dubbo-docs/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] nzomkxia opened a new pull request #10: update dubbo docs address in readme

2018-04-07 Thread GitBox
nzomkxia opened a new pull request #10: update dubbo docs address in readme URL: https://github.com/apache/incubator-dubbo-docs/pull/10 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379516916 when register center is zookeeper, the invokerUrls will not be empty,it has one element and the

[GitHub] beiwei30 commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
beiwei30 commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517349 with which registry center did you experience the problem? we may need to discuss this further.

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379516916 but when register center lost all provider instance , invokerUrls will not be empty,it has one

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379516916 but when register center lost all provider instance , invokerUrls will not be empty,it has one

Re: List volume and issue tracking

2018-04-07 Thread Ian Luo
I think this can be solved by distinguishing github notifications from regular dev@dubbo.apache.org traffic. For github notifications, including issue and pull request, the update message should only go to the interested parties who are involved in this particular topic, but @dev should never be

[GitHub] skykong1981 commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo.

2018-04-07 Thread GitBox
skykong1981 commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo. URL: https://github.com/apache/incubator-dubbo/pull/1387#issuecomment-379516277 @lovepoem @diecui1202 Sorry. I'm very busy with my recent work in company. I'll fix it when company work done.

[GitHub] cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer side in RpcContext

2018-04-07 Thread GitBox
cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer side in RpcContext URL: https://github.com/apache/incubator-dubbo/pull/1444#issuecomment-379515681 where is the usage of isProviderSide and isConsumerSide? I cannot judge whether it is right.

[GitHub] cvictory commented on issue #1426: fix isShutdown always return true

2018-04-07 Thread GitBox
cvictory commented on issue #1426: fix isShutdown always return true URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379515269 Review the commit , change isShutdown to isTerminated. * java.util.concurrent.ExecutorService#isShutdown will return true , after

[GitHub] ralf0131 opened a new issue #9: Update the legacy links in docs

2018-04-07 Thread GitBox
ralf0131 opened a new issue #9: Update the legacy links in docs URL: https://github.com/apache/incubator-dubbo-docs/issues/9 Some of the links in doc link to unavailable resource, e.g. * http://dubbo.io/books/dubbo-admin-book-en/install/provider-demo.html *

[GitHub] empireaaron opened a new issue #1565: dubbo最佳实践案例,全自动开源框架Emsite

2018-04-07 Thread GitBox
empireaaron opened a new issue #1565: dubbo最佳实践案例,全自动开源框架Emsite URL: https://github.com/apache/incubator-dubbo/issues/1565 望dubbo团队快速完成到apache顶级项目的升级,申请做dubbo的最佳使用示范项目:https://gitee.com/hackempire/emsite-parent This is an

[GitHub] beiwei30 commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

2018-04-07 Thread GitBox
beiwei30 commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP URL: https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379514920 dubbo already considered this scenario: ```java if (invokerUrls.isEmpty() &&

[GitHub] celesky commented on issue #1544: dubbo能否支持netty4?

2018-04-07 Thread GitBox
celesky commented on issue #1544: dubbo能否支持netty4? URL: https://github.com/apache/incubator-dubbo/issues/1544#issuecomment-379514741 原来搞it的也有低级喷子和键盘侠,佩服啊 This is an automated message from the Apache Git Service. To respond

[GitHub] mercyblitz closed issue #63: Replace META-INF/spring-configuration-metadata.json manually

2018-04-07 Thread GitBox
mercyblitz closed issue #63: Replace META-INF/spring-configuration-metadata.json manually URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/63 This is an automated message from the Apache Git

[GitHub] mercyblitz commented on issue #98: how to configure multiple protocols

2018-04-07 Thread GitBox
mercyblitz commented on issue #98: how to configure multiple protocols URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/98#issuecomment-379514595 ```properties dubbo.protocols[hessian].id = hessian dubbo.protocols[hessian].name = hessian

[GitHub] mercyblitz closed issue #98: how to configure multiple protocols

2018-04-07 Thread GitBox
mercyblitz closed issue #98: how to configure multiple protocols URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/98 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mercyblitz commented on issue #99: How to Generic reference

2018-04-07 Thread GitBox
mercyblitz commented on issue #99: How to Generic reference URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/99#issuecomment-379514543 How to reference "fzjh" Bean? This is an automated message from

[GitHub] beiwei30 closed pull request #1388: Remove unnecessary StringBuilder

2018-04-07 Thread GitBox
beiwei30 closed pull request #1388: Remove unnecessary StringBuilder URL: https://github.com/apache/incubator-dubbo/pull/1388 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] beiwei30 commented on a change in pull request #1388: Remove unnecessary StringBuilder

2018-04-07 Thread GitBox
beiwei30 commented on a change in pull request #1388: Remove unnecessary StringBuilder URL: https://github.com/apache/incubator-dubbo/pull/1388#discussion_r179933003 ## File path: dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java ## @@

[GitHub] beiwei30 closed pull request #1562: typo fix

2018-04-07 Thread GitBox
beiwei30 closed pull request #1562: typo fix URL: https://github.com/apache/incubator-dubbo/pull/1562 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] diecui1202 commented on issue #1501: local mock not work according by the user manual

2018-04-07 Thread GitBox
diecui1202 commented on issue #1501: local mock not work according by the user manual URL: https://github.com/apache/incubator-dubbo/issues/1501#issuecomment-379513750 @vangoleo The user book has not been corrected. Please commit a PR under https://github.com/apache/incubator-dubbo-docs

[GitHub] diecui1202 commented on issue #1503: ServiceBean.getSpringContext() is null

2018-04-07 Thread GitBox
diecui1202 commented on issue #1503: ServiceBean.getSpringContext() is null URL: https://github.com/apache/incubator-dubbo/issues/1503#issuecomment-379513106 @hengyunabc will check this problem in his hands-on working.

[GitHub] diecui1202 commented on issue #1503: ServiceBean.getSpringContext() is null

2018-04-07 Thread GitBox
diecui1202 commented on issue #1503: ServiceBean.getSpringContext() is null URL: https://github.com/apache/incubator-dubbo/issues/1503#issuecomment-379513106 @hengyuanabc will check this problem in his hands-on working.

[GitHub] CoderDade commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数(I can't get the attachment in Dubbo Filter)?

2018-04-07 Thread GitBox
CoderDade commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数(I can't get the attachment in Dubbo Filter)? URL: https://github.com/apache/incubator-dubbo/issues/1533#issuecomment-379512794 @techyang 2.5.7 This is an

[GitHub] htynkn commented on a change in pull request #1564: update CXF to latest version and add test case for webservice protocol

2018-04-07 Thread GitBox
htynkn commented on a change in pull request #1564: update CXF to latest version and add test case for webservice protocol URL: https://github.com/apache/incubator-dubbo/pull/1564#discussion_r179932240 ## File path: dubbo-rpc/dubbo-rpc-webservice/pom.xml ## @@ -43,10

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean

2018-04-07 Thread GitBox
kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean URL: https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379483154 generic test case is not a good demo, I update CXF to

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean

2018-04-07 Thread GitBox
kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean URL: https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379483154 generic test case is not a good demo, I update CXF to

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean

2018-04-07 Thread GitBox
kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean URL: https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379483154 generic test case is not a good demo, I update CXF to

[GitHub] kimmking opened a new pull request #1564: update CXF to latest version and add test case for webservice protocol

2018-04-07 Thread GitBox
kimmking opened a new pull request #1564: update CXF to latest version and add test case for webservice protocol URL: https://github.com/apache/incubator-dubbo/pull/1564 ## What is the purpose of the change update CXF to latest version 3.2.4 and add test case for webservice protocol

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean

2018-04-07 Thread GitBox
kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean URL: https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379479046 @rongmin you can use the latest version by packaging from the

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean

2018-04-07 Thread GitBox
kimmking commented on issue #1560: Dubbo multi-protocol, dubbo & webservice protocol to publish service,when startup fail to init webservice bean URL: https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379479046 @rongmin you can use the latest version by packaging from the

[GitHub] codecov-io commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

2018-04-07 Thread GitBox
codecov-io commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379465423 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr=h1) Report

[GitHub] mercyblitz closed pull request #97: update readme

2018-04-07 Thread GitBox
mercyblitz closed pull request #97: update readme URL: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/97 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] binarySortTree opened a new issue #24: 打包失败

2018-04-07 Thread GitBox
binarySortTree opened a new issue #24: 打包失败 URL: https://github.com/apache/incubator-dubbo-ops/issues/24 命令行进入incubator-dubbo-ops-master目录,然后执行mvn package,结果显示打包失败: ![20180407164745](https://user-images.githubusercontent.com/29702355/38453136-7449c1b0-3a83-11e8-890f-e5f08d879db4.png)

[GitHub] codecov-io commented on issue #1562: typo fix

2018-04-07 Thread GitBox
codecov-io commented on issue #1562: typo fix URL: https://github.com/apache/incubator-dubbo/pull/1562#issuecomment-379448004 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #1561: exclude dubbo-demo when calc coverage

2018-04-07 Thread GitBox
codecov-io commented on issue #1561: exclude dubbo-demo when calc coverage URL: https://github.com/apache/incubator-dubbo/pull/1561#issuecomment-379438764 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1561?src=pr=h1) Report > Merging