[GitHub] [felix-atomos] stbischof opened a new pull request #1: WIP: Maven - Native Image

2020-02-27 Thread GitBox
stbischof opened a new pull request #1: WIP: Maven - Native Image URL: https://github.com/apache/felix-atomos/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [felix-atomos] tjwatson opened a new pull request #2: Code clean up

2020-02-27 Thread GitBox
tjwatson opened a new pull request #2: Code clean up URL: https://github.com/apache/felix-atomos/pull/2 - Move LoaderType from AtomosRuntime to AtomosLayer - remove unnecessary public modifier - Use method references where possible - Remove extra lambdas where possible - Fix up j

[GitHub] [felix-atomos] tjwatson commented on issue #2: Code clean up

2020-02-27 Thread GitBox
tjwatson commented on issue #2: Code clean up URL: https://github.com/apache/felix-atomos/pull/2#issuecomment-592053400 Cancelling this PR to try a new one for auto-linking Felix JIRA This is an automated message from the Apac

[GitHub] [felix-atomos] tjwatson closed pull request #2: Code clean up

2020-02-27 Thread GitBox
tjwatson closed pull request #2: Code clean up URL: https://github.com/apache/felix-atomos/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [felix-atomos] tjwatson opened a new pull request #3: FELIX-6226: Code clean up

2020-02-27 Thread GitBox
tjwatson opened a new pull request #3: FELIX-6226: Code clean up URL: https://github.com/apache/felix-atomos/pull/3 - Move LoaderType from AtomosRuntime to AtomosLayer - remove unnecessary public modifier - Use method references where possible - Remove extra lambdas where possible

[GitHub] [felix-atomos] tjwatson merged pull request #3: FELIX-6226: Code clean up

2020-02-27 Thread GitBox
tjwatson merged pull request #3: FELIX-6226: Code clean up URL: https://github.com/apache/felix-atomos/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [felix-atomos] tjwatson commented on issue #1: WIP: FELIX-6228: Atomos maven plugin

2020-02-27 Thread GitBox
tjwatson commented on issue #1: WIP: FELIX-6228: Atomos maven plugin URL: https://github.com/apache/felix-atomos/pull/1#issuecomment-592093576 I opened JIRA https://issues.apache.org/jira/browse/FELIX-6228 to track this. This

[GitHub] [felix-dev] DominikSuess opened a new pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-02 Thread GitBox
DominikSuess opened a new pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1 This is an automated message from the Apache Git Service. To respond

[GitHub] [felix-dev] bosschaert commented on issue #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-02 Thread GitBox
bosschaert commented on issue #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#issuecomment-593343108 Hi @DominikSuess the change looks good to me. This is a

[GitHub] [felix-dev] kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-02 Thread GitBox
kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r386324692 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java

[GitHub] [felix-dev] kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-02 Thread GitBox
kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r386325480 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java

[GitHub] [felix-dev] amitjoy commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-02 Thread GitBox
amitjoy commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r386368563 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.j

[GitHub] [felix-dev] kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-02 Thread GitBox
kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r386387233 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java

[GitHub] [felix-dev] cziegeler commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-02 Thread GitBox
cziegeler commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r386392472 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet

[GitHub] [felix-dev] coheigea opened a new pull request #2: FELIX-6234 - Updating Snakeyaml

2020-03-02 Thread GitBox
coheigea opened a new pull request #2: FELIX-6234 - Updating Snakeyaml URL: https://github.com/apache/felix-dev/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [felix-dev] coheigea opened a new pull request #3: Update some old sslfilter test dependencies

2020-03-02 Thread GitBox
coheigea opened a new pull request #3: Update some old sslfilter test dependencies URL: https://github.com/apache/felix-dev/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [felix-dev] coheigea opened a new pull request #4: FELIX-6235 - Disallow DTDs when reading OBR repository files

2020-03-02 Thread GitBox
coheigea opened a new pull request #4: FELIX-6235 - Disallow DTDs when reading OBR repository files URL: https://github.com/apache/felix-dev/pull/4 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [felix-dev] coheigea opened a new pull request #5: FELIX-6189 - Make sure jar/zip files are jailed to the destination di…

2020-03-03 Thread GitBox
coheigea opened a new pull request #5: FELIX-6189 - Make sure jar/zip files are jailed to the destination di… URL: https://github.com/apache/felix-dev/pull/5 …rectory This is an automated message from the Apache Git Service.

[GitHub] [felix-dev] cziegeler commented on issue #3: Update some old sslfilter test dependencies

2020-03-03 Thread GitBox
cziegeler commented on issue #3: Update some old sslfilter test dependencies URL: https://github.com/apache/felix-dev/pull/3#issuecomment-593862462 Thanks for the PR This is an automated message from the Apache Git Service. To

[GitHub] [felix-dev] cziegeler merged pull request #3: Update some old sslfilter test dependencies

2020-03-03 Thread GitBox
cziegeler merged pull request #3: Update some old sslfilter test dependencies URL: https://github.com/apache/felix-dev/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [felix-dev] coheigea opened a new pull request #6: Updating Commons Compress, FileUpload and IO

2020-03-03 Thread GitBox
coheigea opened a new pull request #6: Updating Commons Compress, FileUpload and IO URL: https://github.com/apache/felix-dev/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [felix-dev] jbonofre commented on issue #6: Updating Commons Compress, FileUpload and IO

2020-03-03 Thread GitBox
jbonofre commented on issue #6: Updating Commons Compress, FileUpload and IO URL: https://github.com/apache/felix-dev/pull/6#issuecomment-593864795 LGTM. However, let me do a complete build/use pass just in case. This is an au

[GitHub] [felix-dev] jbonofre commented on issue #5: FELIX-6189 - Make sure jar/zip files are jailed to the destination di…

2020-03-03 Thread GitBox
jbonofre commented on issue #5: FELIX-6189 - Make sure jar/zip files are jailed to the destination di… URL: https://github.com/apache/felix-dev/pull/5#issuecomment-593865505 Not sure it's a good idea. This kind of change already breaks Felix Utils. Let me do a pass and also reopen about Fe

[GitHub] [felix-dev] coheigea opened a new pull request #7: Updating pax url in a few places

2020-03-03 Thread GitBox
coheigea opened a new pull request #7: Updating pax url in a few places URL: https://github.com/apache/felix-dev/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [felix-dev] coheigea opened a new pull request #8: FELIX-6193 - Update maven-archiver + plexus-utils

2020-03-03 Thread GitBox
coheigea opened a new pull request #8: FELIX-6193 - Update maven-archiver + plexus-utils URL: https://github.com/apache/felix-dev/pull/8 We should update the versions of maven-archiver + plexus-utils in the maven-bundle-plugin to remove the CVEs: plexus-archiver-2.8.1.jar (pkg:mave

[GitHub] [felix-dev] jsedding commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-03 Thread GitBox
jsedding commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r387001151 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.

[GitHub] [felix-atomos] tjwatson commented on issue #1: WIP: FELIX-6228: Atomos maven plugin

2020-03-03 Thread GitBox
tjwatson commented on issue #1: WIP: FELIX-6228: Atomos maven plugin URL: https://github.com/apache/felix-atomos/pull/1#issuecomment-594123632 This is looking great so far. To get the web console to work I had to patch the `additionalResourceConfig.json` file. This is because the webconso

[GitHub] [felix-atomos] sebratton opened a new pull request #4: Allow public access to ConnectContent via the AtomosContent interface

2020-03-03 Thread GitBox
sebratton opened a new pull request #4: Allow public access to ConnectContent via the AtomosContent interface URL: https://github.com/apache/felix-atomos/pull/4 This is an automated message from the Apache Git Service. To re

[GitHub] [felix-atomos] tjwatson merged pull request #4: Allow public access to ConnectContent via the AtomosContent interface

2020-03-03 Thread GitBox
tjwatson merged pull request #4: Allow public access to ConnectContent via the AtomosContent interface URL: https://github.com/apache/felix-atomos/pull/4 This is an automated message from the Apache Git Service. To respond t

[GitHub] [felix-atomos] stbischof commented on issue #1: WIP: FELIX-6228: Atomos maven plugin

2020-03-04 Thread GitBox
stbischof commented on issue #1: WIP: FELIX-6228: Atomos maven plugin URL: https://github.com/apache/felix-atomos/pull/1#issuecomment-594392627 Thank you. But I am not sure why Graal-NI could not handle this. https://github.com/oracle/graal/issues/1956

[GitHub] [felix-atomos] tjwatson commented on issue #1: WIP: FELIX-6228: Atomos maven plugin

2020-03-04 Thread GitBox
tjwatson commented on issue #1: WIP: FELIX-6228: Atomos maven plugin URL: https://github.com/apache/felix-atomos/pull/1#issuecomment-594529419 > Thank you. > But I am not sure why Graal-NI could not handle this. > [oracle/graal#1956](https://github.com/oracle/graal/issues/1956)

[GitHub] [felix-atomos] karlpauls commented on issue #1: WIP: FELIX-6228: Atomos maven plugin

2020-03-04 Thread GitBox
karlpauls commented on issue #1: WIP: FELIX-6228: Atomos maven plugin URL: https://github.com/apache/felix-atomos/pull/1#issuecomment-594530434 I think keeping the resources (at least by default) is a good idea. This is an aut

[GitHub] [felix-atomos] rotty3000 commented on issue #1: WIP: FELIX-6228: Atomos maven plugin

2020-03-04 Thread GitBox
rotty3000 commented on issue #1: WIP: FELIX-6228: Atomos maven plugin URL: https://github.com/apache/felix-atomos/pull/1#issuecomment-594596164 +1 On Wed, Mar 4, 2020, 08:43 Karl Pauls, wrote: > I think keeping the resources (at least by default) is a good idea. > > —

[GitHub] [felix-dev] DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-05 Thread GitBox
DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r388191268 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServ

[GitHub] [felix-dev] DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-05 Thread GitBox
DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r388191268 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServ

[GitHub] [felix-dev] cziegeler commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-05 Thread GitBox
cziegeler commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r388195649 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet

[GitHub] [felix-dev] DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-05 Thread GitBox
DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r388229007 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServ

[GitHub] [felix-dev] DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-05 Thread GitBox
DominikSuess commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1#discussion_r388229240 ## File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServ

[GitHub] [felix-atomos] tjwatson opened a new pull request #5: FELIX-6237

2020-03-05 Thread GitBox
tjwatson opened a new pull request #5: FELIX-6237 URL: https://github.com/apache/felix-atomos/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [felix-atomos] tjwatson merged pull request #5: FELIX-6237

2020-03-05 Thread GitBox
tjwatson merged pull request #5: FELIX-6237 URL: https://github.com/apache/felix-atomos/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [felix-atomos] tjwatson opened a new pull request #6: FELIX-6227 - Add configuration for path to Atomos index

2020-03-05 Thread GitBox
tjwatson opened a new pull request #6: FELIX-6227 - Add configuration for path to Atomos index URL: https://github.com/apache/felix-atomos/pull/6 Instead of using an atomos.load.index option with FIRST|IGNORE this change adds an option atomos.index.path that allows the specification o

[GitHub] [felix-atomos] tjwatson merged pull request #6: FELIX-6227 - Add configuration for path to Atomos index

2020-03-05 Thread GitBox
tjwatson merged pull request #6: FELIX-6227 - Add configuration for path to Atomos index URL: https://github.com/apache/felix-atomos/pull/6 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [felix-dev] cziegeler merged pull request #1: FELIX-6232 - adding option to install parallel version of bundle

2020-03-05 Thread GitBox
cziegeler merged pull request #1: FELIX-6232 - adding option to install parallel version of bundle URL: https://github.com/apache/felix-dev/pull/1 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [felix-atomos] tjwatson merged pull request #1: FELIX-6228: Atomos maven plugin

2020-03-06 Thread GitBox
tjwatson merged pull request #1: FELIX-6228: Atomos maven plugin URL: https://github.com/apache/felix-atomos/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [felix-atomos] rotty3000 opened a new pull request #7: fix build badge

2020-03-06 Thread GitBox
rotty3000 opened a new pull request #7: fix build badge URL: https://github.com/apache/felix-atomos/pull/7 Signed-off-by: Raymond Augé This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [felix-atomos] rotty3000 commented on issue #7: fix build badge

2020-03-06 Thread GitBox
rotty3000 commented on issue #7: fix build badge URL: https://github.com/apache/felix-atomos/pull/7#issuecomment-595943377 @tjwatson you can verify this by using the "View File" in the github diff view. The link should work.

[GitHub] [felix-atomos] tjwatson commented on issue #7: fix build badge

2020-03-06 Thread GitBox
tjwatson commented on issue #7: fix build badge URL: https://github.com/apache/felix-atomos/pull/7#issuecomment-595951313 Thanks Ray! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [felix-atomos] tjwatson merged pull request #7: fix build badge

2020-03-06 Thread GitBox
tjwatson merged pull request #7: fix build badge URL: https://github.com/apache/felix-atomos/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [felix-atomos] tjwatson opened a new pull request #8: Add gitpod config

2020-03-07 Thread GitBox
tjwatson opened a new pull request #8: Add gitpod config URL: https://github.com/apache/felix-atomos/pull/8 this commit adds support for Gitpod.io, a free automated dev environment that makes contributing and generally working on GitHub projects much easier. It allows anyone to start a

[GitHub] [felix-atomos] tjwatson merged pull request #8: Add gitpod config

2020-03-07 Thread GitBox
tjwatson merged pull request #8: Add gitpod config URL: https://github.com/apache/felix-atomos/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [felix-atomos] stbischof opened a new pull request #9: Improve main-class and module-version in module-info.class

2020-03-07 Thread GitBox
stbischof opened a new pull request #9: Improve main-class and module-version in module-info.class URL: https://github.com/apache/felix-atomos/pull/9 update bundle maven-jar-plugin (main-class) update bundle maven-compiler-plugin (version) remove ant plugin - Result: // Compi

[GitHub] [felix-atomos] tjwatson commented on issue #9: Improve main-class and module-version in module-info.class

2020-03-07 Thread GitBox
tjwatson commented on issue #9: Improve main-class and module-version in module-info.class URL: https://github.com/apache/felix-atomos/pull/9#issuecomment-596161532 Stefan, please try to merge this one to see if your commit rights are in order now. Thanks!

[GitHub] [felix-atomos] stbischof merged pull request #9: Improve main-class and module-version in module-info.class

2020-03-08 Thread GitBox
stbischof merged pull request #9: Improve main-class and module-version in module-info.class URL: https://github.com/apache/felix-atomos/pull/9 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [felix-atomos] rotty3000 opened a new pull request #10: another chat badge logo fix

2020-03-09 Thread GitBox
rotty3000 opened a new pull request #10: another chat badge logo fix URL: https://github.com/apache/felix-atomos/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [felix-atomos] rotty3000 opened a new pull request #11: better chat badge logo fix

2020-03-09 Thread GitBox
rotty3000 opened a new pull request #11: better chat badge logo fix URL: https://github.com/apache/felix-atomos/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [felix-atomos] rotty3000 closed pull request #10: another chat badge logo fix

2020-03-09 Thread GitBox
rotty3000 closed pull request #10: another chat badge logo fix URL: https://github.com/apache/felix-atomos/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [felix-atomos] rotty3000 merged pull request #11: better chat badge logo fix

2020-03-09 Thread GitBox
rotty3000 merged pull request #11: better chat badge logo fix URL: https://github.com/apache/felix-atomos/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [felix-atomos] rotty3000 opened a new pull request #12: more readme tweaks

2020-03-09 Thread GitBox
rotty3000 opened a new pull request #12: more readme tweaks URL: https://github.com/apache/felix-atomos/pull/12 Signed-off-by: Raymond Augé This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [felix-atomos] rotty3000 merged pull request #12: more readme tweaks

2020-03-09 Thread GitBox
rotty3000 merged pull request #12: more readme tweaks URL: https://github.com/apache/felix-atomos/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [felix-dev] stbischof opened a new pull request #9: Convert to Interface without methods - FELIX-6238

2020-03-09 Thread GitBox
stbischof opened a new pull request #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9 https://issues.apache.org/jira/browse/FELIX-6238 This is an automated message from the

[GitHub] [felix-dev] bosschaert commented on issue #9: Convert to Interface without methods - FELIX-6238

2020-03-11 Thread GitBox
bosschaert commented on issue #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9#issuecomment-597728436 LGTM @timothyjward WDYT? This is an automated message from the

[GitHub] [felix-atomos] tjwatson opened a new pull request #13: Add example using the Spring loader

2020-03-13 Thread GitBox
tjwatson opened a new pull request #13: Add example using the Spring loader URL: https://github.com/apache/felix-atomos/pull/13 This example creates an executable jar using the spring-boot-maven-plugin. The result is a single executable JAR with embedded bundle JARs. Atomos is abl

[GitHub] [felix-atomos] tjwatson merged pull request #13: Add example using the Spring loader

2020-03-13 Thread GitBox
tjwatson merged pull request #13: Add example using the Spring loader URL: https://github.com/apache/felix-atomos/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [felix-dev] timothyjward edited a comment on issue #9: Convert to Interface without methods - FELIX-6238

2020-03-13 Thread GitBox
timothyjward edited a comment on issue #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9#issuecomment-598859059 This method has always been a bit odd to read - it still seems odd to check that the methods returned by the interface are def

[GitHub] [felix-dev] timothyjward commented on issue #9: Convert to Interface without methods - FELIX-6238

2020-03-13 Thread GitBox
timothyjward commented on issue #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9#issuecomment-598859059 This method has always been a bit odd to read - it still seems odd to check that the methods returned by the interface are defined by

[GitHub] [felix-atomos] tjwatson opened a new pull request #14: Use AtomosLauncher if possible, instead of separate main classes

2020-03-13 Thread GitBox
tjwatson opened a new pull request #14: Use AtomosLauncher if possible, instead of separate main classes URL: https://github.com/apache/felix-atomos/pull/14 This is an automated message from the Apache Git Service. To respon

[GitHub] [felix-atomos] tjwatson commented on issue #14: Use AtomosLauncher if possible, instead of separate main classes

2020-03-13 Thread GitBox
tjwatson commented on issue #14: Use AtomosLauncher if possible, instead of separate main classes URL: https://github.com/apache/felix-atomos/pull/14#issuecomment-598881269 @stbischof please review 60312b0 This is an automate

[GitHub] [felix-dev] cziegeler merged pull request #2: FELIX-6234 - Updating Snakeyaml

2020-03-14 Thread GitBox
cziegeler merged pull request #2: FELIX-6234 - Updating Snakeyaml URL: https://github.com/apache/felix-dev/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [felix-dev] cziegeler merged pull request #7: Updating pax url in a few places

2020-03-15 Thread GitBox
cziegeler merged pull request #7: Updating pax url in a few places URL: https://github.com/apache/felix-dev/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [felix-dev] cziegeler commented on issue #7: Updating pax url in a few places

2020-03-15 Thread GitBox
cziegeler commented on issue #7: Updating pax url in a few places URL: https://github.com/apache/felix-dev/pull/7#issuecomment-599194206 Thanks for the PR This is an automated message from the Apache Git Service. To respond to

[GitHub] [felix-dev] cziegeler merged pull request #8: FELIX-6193 - Update maven-archiver + plexus-utils

2020-03-15 Thread GitBox
cziegeler merged pull request #8: FELIX-6193 - Update maven-archiver + plexus-utils URL: https://github.com/apache/felix-dev/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [felix-dev] cziegeler commented on issue #6: Updating Commons Compress, FileUpload and IO

2020-03-15 Thread GitBox
cziegeler commented on issue #6: Updating Commons Compress, FileUpload and IO URL: https://github.com/apache/felix-dev/pull/6#issuecomment-599194458 Thanks for the PR! This is an automated message from the Apache Git Service.

[GitHub] [felix-dev] cziegeler merged pull request #6: Updating Commons Compress, FileUpload and IO

2020-03-15 Thread GitBox
cziegeler merged pull request #6: Updating Commons Compress, FileUpload and IO URL: https://github.com/apache/felix-dev/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [felix-dev] bosschaert commented on issue #9: Convert to Interface without methods - FELIX-6238

2020-03-16 Thread GitBox
bosschaert commented on issue #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9#issuecomment-599493751 @stbischof would you have time to implement the change suggested by @timothyjward ? --

[GitHub] [felix-atomos] stbischof commented on issue #14: Use AtomosLauncher if possible, instead of separate main classes

2020-03-16 Thread GitBox
stbischof commented on issue #14: Use AtomosLauncher if possible, instead of separate main classes URL: https://github.com/apache/felix-atomos/pull/14#issuecomment-599542247 @tjwatson lgtm This is an automated message from t

[GitHub] [felix-atomos] tjwatson merged pull request #14: Use AtomosLauncher if possible, instead of separate main classes

2020-03-16 Thread GitBox
tjwatson merged pull request #14: Use AtomosLauncher if possible, instead of separate main classes URL: https://github.com/apache/felix-atomos/pull/14 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [felix-dev] stbischof commented on issue #9: Convert to Interface without methods - FELIX-6238

2020-03-16 Thread GitBox
stbischof commented on issue #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9#issuecomment-599768206 @bosschaert sure. tomorrow! This is an automated message from the Apach

[GitHub] [felix-atomos] stbischof opened a new pull request #15: more flexible substrate builder

2020-03-16 Thread GitBox
stbischof opened a new pull request #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [felix-dev] stbischof commented on issue #9: Convert to Interface without methods - FELIX-6238

2020-03-17 Thread GitBox
stbischof commented on issue #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9#issuecomment-600101737 @bosschaert here is the small change. Do you have any ideas ho to handle this?: https://issues.apache.org/jira/browse/FELIX-623

[GitHub] [felix-atomos] tjwatson opened a new pull request #16: Update to bnd-maven-plugin version 5.0

2020-03-17 Thread GitBox
tjwatson opened a new pull request #16: Update to bnd-maven-plugin version 5.0 URL: https://github.com/apache/felix-atomos/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [felix-atomos] tjwatson merged pull request #16: Update to bnd-maven-plugin version 5.0

2020-03-17 Thread GitBox
tjwatson merged pull request #16: Update to bnd-maven-plugin version 5.0 URL: https://github.com/apache/felix-atomos/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [felix-atomos] tjwatson commented on issue #15: more flexible substrate builder

2020-03-17 Thread GitBox
tjwatson commented on issue #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-600250645 Some superficial comments while you are in draft mode on this PR. In the end I think we will want a general plugin that will be able to do substrate

[GitHub] [felix-atomos] stbischof commented on issue #15: more flexible substrate builder

2020-03-17 Thread GitBox
stbischof commented on issue #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-600321247 Thank you for the comment. This i why I opend this draft pull request. You are addressing the right things. I tried to handle it more globally.

[GitHub] [felix-dev] bosschaert merged pull request #9: Convert to Interface without methods - FELIX-6238

2020-03-18 Thread GitBox
bosschaert merged pull request #9: Convert to Interface without methods - FELIX-6238 URL: https://github.com/apache/felix-dev/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [felix-dev] stbischof opened a new pull request #10: [converter] handle default methods - FELIX-6239

2020-03-18 Thread GitBox
stbischof opened a new pull request #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10 https://issues.apache.org/jira/browse/FELIX-6239 This is an automated message f

[GitHub] [felix-atomos] tjwatson opened a new pull request #17: Add ability to generate atomos index outside of native-image

2020-03-19 Thread GitBox
tjwatson opened a new pull request #17: Add ability to generate atomos index outside of native-image URL: https://github.com/apache/felix-atomos/pull/17 Added an example atomos.examples.index that uses the new mojo goal atomos-index along with the bnd-maven-plugin to create an executable

[GitHub] [felix-atomos] stbischof commented on issue #17: Add ability to generate atomos index outside of native-image

2020-03-19 Thread GitBox
stbischof commented on issue #17: Add ability to generate atomos index outside of native-image URL: https://github.com/apache/felix-atomos/pull/17#issuecomment-601551645 We may shoulst also use the example.webconsole.bom to replace the same dependencys in the other example pom files.

[GitHub] [felix-dev] amitjoy opened a new pull request #11: [FELIX-6246] Packaged External Library Packages inside the Bundles

2020-03-22 Thread GitBox
amitjoy opened a new pull request #11: [FELIX-6246] Packaged External Library Packages inside the Bundles URL: https://github.com/apache/felix-dev/pull/11 For small IoT devices, it would definitely matter if someone needs to introduce Apache Commons Lang (~500KB) to use Felix Health Checks

[GitHub] [felix-atomos] tjwatson commented on issue #17: Add ability to generate atomos index outside of native-image

2020-03-24 Thread GitBox
tjwatson commented on issue #17: Add ability to generate atomos index outside of native-image URL: https://github.com/apache/felix-atomos/pull/17#issuecomment-603408794 I've updated the PR a bit, it now uses the `maven-assembly-plugin` and the new `atomos-index` goal new places the index d

[GitHub] [felix-atomos] tjwatson merged pull request #17: Add ability to generate atomos index outside of native-image

2020-03-24 Thread GitBox
tjwatson merged pull request #17: Add ability to generate atomos index outside of native-image URL: https://github.com/apache/felix-atomos/pull/17 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [felix-dev] bosschaert commented on a change in pull request #10: [converter] handle default methods - FELIX-6239

2020-03-25 Thread GitBox
bosschaert commented on a change in pull request #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10#discussion_r397712849 ## File path: converter/converter/src/main/java/org/osgi/util/converter/ConvertingImpl.java ## @@ -

[GitHub] [felix-dev] bosschaert commented on issue #10: [converter] handle default methods - FELIX-6239

2020-03-25 Thread GitBox
bosschaert commented on issue #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10#issuecomment-603736594 The PR looks good to me, I just find it surprising that there seems to be special code for just Java 8... Can the Java 8 code not use t

[GitHub] [felix-dev] stbischof commented on a change in pull request #10: [converter] handle default methods - FELIX-6239

2020-03-26 Thread GitBox
stbischof commented on a change in pull request #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10#discussion_r398522828 ## File path: converter/converter/src/main/java/org/osgi/util/converter/ConvertingImpl.java ## @@ -8

[GitHub] [felix-dev] stbischof commented on issue #10: [converter] handle default methods - FELIX-6239

2020-03-26 Thread GitBox
stbischof commented on issue #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10#issuecomment-604400975 Each way works only with one. 8 oder 9+. The most information i found about this topic are there. https://stackoverflow.c

[GitHub] [felix-dev] stbischof edited a comment on issue #10: [converter] handle default methods - FELIX-6239

2020-03-26 Thread GitBox
stbischof edited a comment on issue #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10#issuecomment-604400975 Each way works only with one. 8 oder 9+. The most information i found about this topic are there. https://stackove

[GitHub] [felix-dev] bosschaert commented on issue #10: [converter] handle default methods - FELIX-6239

2020-03-26 Thread GitBox
bosschaert commented on issue #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10#issuecomment-604405005 Thanks @stbischof I've merged your change. This is an automated messa

[GitHub] [felix-dev] bosschaert merged pull request #10: [converter] handle default methods - FELIX-6239

2020-03-26 Thread GitBox
bosschaert merged pull request #10: [converter] handle default methods - FELIX-6239 URL: https://github.com/apache/felix-dev/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [felix-dev] ghenzler opened a new pull request #12: Feature/felix 6245 condition service interfaces felix 6250 healthcheck monitor

2020-03-27 Thread GitBox
ghenzler opened a new pull request #12: Feature/felix 6245 condition service interfaces felix 6250 healthcheck monitor URL: https://github.com/apache/felix-dev/pull/12 This is an automated message from the Apache Git Service

[GitHub] [felix-dev] ghenzler commented on a change in pull request #11: [FELIX-6246] Packaged External Library Packages inside referenced Health Check Bundles

2020-03-27 Thread GitBox
ghenzler commented on a change in pull request #11: [FELIX-6246] Packaged External Library Packages inside referenced Health Check Bundles URL: https://github.com/apache/felix-dev/pull/11#discussion_r399603168 ## File path: healthcheck/api/bnd.bnd ## @@ -1,12 +1,6 @@ -Bund

[GitHub] [felix-dev] ghenzler commented on a change in pull request #11: [FELIX-6246] Packaged External Library Packages inside referenced Health Check Bundles

2020-03-27 Thread GitBox
ghenzler commented on a change in pull request #11: [FELIX-6246] Packaged External Library Packages inside referenced Health Check Bundles URL: https://github.com/apache/felix-dev/pull/11#discussion_r399603986 ## File path: healthcheck/generalchecks/bnd.bnd ## @@ -1,15 +1,

  1   2   3   4   5   6   7   8   9   10   >