Re: [FlexJS] technical debt

2017-07-05 Thread Justin Mclean
Hi, > In the differential all 30 of the bugs are of the form: > > Make this class “Event" override "Event.clone()” function Which some are false positives as there’s a cloneEvent method. Note you can mark them as such in the interface. I had already fixed a couple of these a few weeks back.

4.16.0 Install issues

2017-07-05 Thread Nicholas Kwiatkowski
Is anybody actually addressing the issues people have been reporting about the installer and/or ANT script for Flex SDK 4.16.0? Right now I see two major issues that are preventing even people who are familiar with the SDK from doing installs : - In the installer, selecting AIR 25.0 gives users

Re: [FlexJS] Use of typeof

2017-07-05 Thread Alex Harui
I've noticed lots of advice on the internet to use feature detection instead of browser/runtime detection. Did you rule out doing that? Browsers may implement new features over time. But otherwise, I see some clever tests that check for "window" and a few other things. HTH, -Alex On 7/5/17,

RE: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

2017-07-05 Thread Allen YANG
Hi Yishay, After trying for quite a while, I found that we might be talking about two different things. I informed Piotr that was able to use Maven and VS Code to build and run Piotr's "Hello World" example successfully. But I was unable to successfully run demo_for_presentation using Flash

Re: [FlexJS] technical debt

2017-07-05 Thread Dave Fisher
Hi - In the differential all 30 of the bugs are of the form: Make this class “Event" override "Event.clone()” function All of the 133 vulnerabilities are of these forms: Make this "public static" field const Remove this use of the "trace" function. The singular code smell (Sonar says that

[FlexJS] technical debt

2017-07-05 Thread Justin Mclean
Hi, If you take a look at this [1] you see that technical debt increased a bit between the 0.8 and 0.9 releases. It would be good if we could reduce this. While Sonar cube isn’t perfect, probably needs some tuning, and there are a number of false positives in there it is trying to tell us

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-05 Thread Justin Mclean
Hi, > I was trying some time ago to do as you are doing and failed. - Not sure > whether it was same problem. After some time I gave up. > > The conclusion is that I end up with pom for Maven build and setup where the > intelisence is working. That mirrors my experience as well. I know Chris

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-05 Thread piotrz
Hi Josh, I was trying some time ago to do as you are doing and failed. - Not sure whether it was same problem. After some time I gave up. The conclusion is that I end up with pom for Maven build and setup where the intelisence is working. Piotr - Apache Flex PMC

[FlexJS] 0.8.0 not working in IntelliJ IDEA

2017-07-05 Thread Josh Tynjala
I'm trying to create a new FlexJS 0.8.0 project in IntelliJ IDEA, and I'm getting the following output when I try to build the project: Information:[HelloIDEA]: Starting Flex compiler: "/Applications/IntelliJ IDEA.app/Contents/jdk/Contents/Home/jre/bin/java"

Re: [FlexJS] Use of typeof

2017-07-05 Thread Harbs
No. I was trying to use process to check whether it’s running in a Node runtime (such as Node or Electron). window does not have process. I’m trying to add a class that lets the client know what environment it’s running in. Adding global sounds like a good idea. Between window and global, I

Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-05 Thread yishayw
My AIR_HOME goes to my nightly installation which has Adobe AIR 23.0 SDK. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Mobile-Depends-on-Flash-11-4-tp62811p62846.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Use of typeof

2017-07-05 Thread Alex Harui
Sure, I know it wouldn't work at runtime, but it sounded like Harbs couldn't even get the compiler to accept window["process"] which it should. So, it should be ok to write: if(typeof window !== "undefined") { theProcess = window["process"]; } else theProcess = global.process But is

Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-05 Thread Alex Harui
Interesting. What is your AIR_HOME set to? I think it is working for most folks because AIR_HOME is set to something newer than 3.7. -Alex On 7/5/17, 12:06 AM, "yishayw" wrote: >I was getting the error when doing ant clean all from flex-asjs. I updated >build.xml

Re: [FlexJS] Use of typeof

2017-07-05 Thread Josh Tynjala
Node.js doesn't have a window variable, so window["process"] won't work. They have a global variable instead. I remember reading that there is a proposal for ECMAScript to standardize a single variable that refers to window in the browser and global in Node.js, but that doesn't exist yet. - Josh

RE: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Camera API requires flash verion 11.4

2017-07-05 Thread Yishay Weiss
I’m not sure. See here [1] [1] http://apache-flex-development.247.n4.nabble.com/FlexJS-Mobile-Depends-on-Flash-11-4-td62811.html From: Piotr Zarzycki Sent: Wednesday, July 5, 2017 11:56 AM To: dev@flex.apache.org Subject: Re:

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Camera API requires flash verion 11.4

2017-07-05 Thread Piotr Zarzycki
Hi Yishay, Does Maven build require this changes also ? I will look into that later today, but maybe you can beat me :) Thanks, Piotr 2017-07-05 9:20 GMT+02:00 : > Repository: flex-asjs > Updated Branches: > refs/heads/develop 722e9eed7 -> 73c18eccf > > > Camera API

Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-05 Thread yishayw
I was getting the error when doing ant clean all from flex-asjs. I updated build.xml under Mobile to include the snippet you provided. Let me know if I misunderstood, in which case I'll revert. Not sure what, if at all, needs to change for the Maven build. Thanks. -- View this message in

Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-05 Thread Alex Harui
Yes but in examples/flexjs/CordovaCameraExample, it specifies 11.4 and swfversion 17. Anyone who wants to use a later API than our baseline can do that. -Alex On 7/4/17, 11:30 PM, "Harbs" wrote: >Where is that from? > >In build.properties I see this: > >#

Re: [FlexJS] Use of typeof

2017-07-05 Thread Alex Harui
What class in Core needs this dependency? I think one drawback is that users of that class will need to add node.swc to their project dependencies. But I don't think every consumer of Core will need node.swc. But first, why didn't window["process"] work? In theory Falcon will let you access

Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-05 Thread Harbs
Where is that from? In build.properties I see this: # flex-sdk-description values release.name = Apache Flex (FlexJS) # this is the version that appears in the flex-sdk-description tag # and on the package name. This is the publicly known version of FlexJS release.version = 0.9.0 #

Re: [FlexJS] Mobile Depends on Flash 11.4?

2017-07-05 Thread Alex Harui
Which build? The Ant build is set for -Alex On 7/4/17, 12:14 AM, "yishayw" wrote: >I was having a problem building the Mobile package. It was complaining >about >line 151 in Camera.as which does camera.copyToByteArray(). Looking at the >docs [1], it looks like