Re: [FlexJS]TileLayout

Already fixed. :-) > On Jul 25, 2017, at 12:47 AM, Alex Harui wrote: > > I thought the goal was to approximate what regular Flex TileLayout did. > The fact that TileLayout uses flexbox under the covers is an > implementation detail. IMO, Flex TileLayout behavior would

Re: PAYG

Josh, that was the general idea with the wiki docs: -One section for 'definitions' -And another section for examples/archetypes with advantages/disadvantages of each - as a form of 'guidance', emphasis on the practical, but not a proscriptive approach. I'm sorry I have not had time to come back

Re: [FlexJS]TileLayout

I thought the goal was to approximate what regular Flex TileLayout did. The fact that TileLayout uses flexbox under the covers is an implementation detail. IMO, Flex TileLayout behavior would be the default TileLayout to simplify migration and other options would have longer names. No matter

Re: PAYG

Okay, so PAYG can't have One True Definition. How you implement PAYG depends on context. I wonder if some kind of PAYG pattern cookbook would be helpful? I was thinking that our situations with PAYG remind me of software design patterns. Design patterns aren't really defined with an exact

Re: [FlexJS] Debugging package

I implemented a "debugger" statement in ActionScript that works similarly to the JavaScript debugger statement: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/debugger In JavaScript, it translates directly. In SWF, the compiler generates bytecode for a call to

Re: [FlexJS]TileLayout

I just left things as open as possible as I recall. Thanks Harbs. On 7/23/17, 6:06 AM, "Harbs" wrote: >Agreed, but I think the defaults should match Flash between and HTML. > >He did not set stretch. Nothing was set. ³stretch² is the default css. > >> On Jul 23, 2017, at

Re: [FlexJS] PAYG and dataGroups

Framework convention is generally to leave out the braces and indent the line like this: if (ir) ir.selected = true; > On Jul 24, 2017, at 2:54 PM, piotrz wrote: > > I meant this kind of lines somewhere inside method: > > ir =

Re: [FlexJS] PAYG and dataGroups

I meant this kind of lines somewhere inside method: ir = dataGroup.getItemRendererForIndex(listModel.selectedIndex) as ISelectableItemRenderer; if (ir != null) ir.selected = true; I would change it to: ir = dataGroup.getItemRendererForIndex(listModel.selectedIndex) as ISelectableItemRenderer;

Re: [FlexJS] PAYG and dataGroups

I’m not sure what you mean. If you mean braces for single-line statements, I actually use those in my personal projects, but I leave them out in Flex code because that’s alway been the convention in the Flex Framework. Thanks, Harbs > On Jul 24, 2017, at 2:32 PM, piotrz

Re: [FlexJS] PAYG and dataGroups

Thanks! I saw your changes and it look better. Btw: I really would like to see in your commits more curly brackets - especially when you are doing some changes down into the methods. - It's lot easier to catch eventually bugs. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View

Re: [FlexJS] PAYG and dataGroups

I spent quite a bit of time looking into this. I came to the conclusion that there likely needs to be beads with more interop for modifying data content, but I don’t think I need that for right now. After finding my way through the classes, I realized that dataGroup.getItemRendererForIndex()

Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

Good call. I noticed that I can simplify the code a bit as well. I added this to the other notifier classes too. > On Jul 24, 2017, at 1:37 PM, Piotr Zarzycki wrote: > > Hi Harbs, > > I think this line should be outside "if": > > var object:Object =

Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

Hi Harbs, I think this line should be outside "if": var object:Object = document[sourceID]; Please check additionally other beads related to ChangeNotifier. Thanks, Piotr 2017-07-24 12:29 GMT+02:00 : > Repository: flex-asjs > Updated Branches: > refs/heads/develop

Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

While researching the issue I had, I noticed this code. It appears to be removing the event handlers from the object and then adding them back to the same objects. I believe the change I wrote is necessary to add the event handlers to the new object, but I’d appreciate if we get some

Re: [FlexJS] stopImmediatePropagation

Good to know. I think the bubbles test also needs to test a custom event. I think there is code that listens to the element for certain event names and to the wrapper. Get Outlook for Android From: Harbs Sent:

Re: git commit: [flex-asjs] [refs/heads/feature/browser-event] - goog.Event assumes the getter can be called on the event. Default to the super getter if wrappedEvent is not set (yet).

Good thought, but it does not work. With the modified typedef, I get this which generates an RTE because “get__target” is not defined: return this.wrappedEvent ? org.apache.flex.events.getTargetWrapper(this.wrappedEvent.target) :

Re: [FlexJS] PAYG and dataGroups

Hi Harbs, In such cases where you preventing from RTE I'm thinking that having bead would be weird. PreventDataGroupFromRte? Cause you do not do anything more adding such just-in-case code. Maybe this case is one of those when we should have that code? Piotr - Apache Flex PMC

Re: [FlexJS] stopImmediatePropagation

Hi Harbs, I will check your changes later today or tomorrow evening. Thank you, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-stopImmediatePropagation-tp63418p63501.html Sent from the Apache